Skip to contentSkip to conversation

xhci: Use %zu for printing size_t type

PATCH In review Fabio Estevam 3 participants 3 messages May 22, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 xhci: Use %zu for printing size_t type

Commit 597c56e372da ("xhci: update bounce buffer with correct sg num") caused the following build warnings:

drivers/usb/host/xhci-ring.c:676:19: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=]

Use %zu for printing size_t type in order to fix the warnings.

Fixes 597c56e372da ("xhci: update bounce buffer with correct sg num")

---
Changes since v1:
- Fixed a typo when referencing the commit hci-->xhci

 drivers/usb/host/xhci-ring.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/host/xhci-ring.c +2 -2
index ef7c8698772e..d04023d396d8 100644
@@ -673,7 +673,7 @@ static void xhci_unmap_td_bounce_buffer(struct xhci_hcd *xhci,
 	len = sg_pcopy_from_buffer(urb->sg, urb->num_sgs, seg->bounce_buf,
 			     seg->bounce_len, seg->bounce_offs);
 	if (len != seg->bounce_len)
-		xhci_warn(xhci, "WARN Wrong bounce buffer read length: %ld != %d\n",
+		xhci_warn(xhci, "WARN Wrong bounce buffer read length: %zu != %d\n",
 				len, seg->bounce_len);
 	seg->bounce_len = 0;
 	seg->bounce_offs = 0;
@@ -3166,7 +3166,7 @@ static int xhci_align_td(struct xhci_hcd *xhci, struct urb *urb, u32 enqd_len,
 				   seg->bounce_buf, new_buff_len, enqd_len);
 		if (len != seg->bounce_len)
 			xhci_warn(xhci,
-				"WARN Wrong bounce buffer write length: %ld != %d\n",
+				"WARN Wrong bounce buffer write length: %zu != %d\n",
 				len, seg->bounce_len);
 		seg->bounce_dma = dma_map_single(dev, seg->bounce_buf,
 						 max_pkt, DMA_TO_DEVICE);
Signature · 1 line
2.17.1
Acked-by on v2 1/1
#1 lore raw
Quoted 11 lines · Fabio Estevam

Commit 597c56e372da ("xhci: update bounce buffer with correct sg num") caused the following build warnings:

drivers/usb/host/xhci-ring.c:676:19: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=]

Use %zu for printing size_t type in order to fix the warnings.

Fixes 597c56e372da ("xhci: update bounce buffer with correct sg num")

---

Thanks for writing this follow-up patch

maintainer
#2 lore raw
Quoted 8 lines · Mathias Nyman
Quoted 7 lines · Fabio Estevam

Commit 597c56e372da ("xhci: update bounce buffer with correct sg num") caused the following build warnings:

drivers/usb/host/xhci-ring.c:676:19: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=]

Use %zu for printing size_t type in order to fix the warnings.

Quoted 11 lines
Quoted 4 lines
Fixes 597c56e372da ("xhci: update bounce buffer with correct sg num")

---

Thanks for writing this follow-up patch

Thanks, now queued up.

greg k-h