arch/sparc: remove unused varible paddrbase in function leon_swprobe()
PATCH 1/1 arch/sparc: remove unused varible paddrbase in function leon_swprobe()
From: Alex Shi <[email protected]>
commit f22ed71cd602 ("sparc32,leon: SRMMU MMU Table probe fix") change return value from paddrbase to 'pte', but left the varible here. That causes a build warning for this varible, so we may remove it.
make --keep-going CROSS_COMPILE=/home/alexs/0day/gcc-14.1.0-nolibc/sparc-linux/bin/sparc-linux- --jobs=16 KCFLAGS= -Wtautological-compare -Wno-error=return-type -Wreturn-type -Wcast-function-type -funsigned-char -Wundef -fstrict-flex-arrays=3 -Wformat-overflow -Wformat-truncation -Wrestrict -Wenum-conversion W=1 O=sparc ARCH=sparc defconfig SHELL=/bin/bash arch/sparc/mm/ mm/ -s <stdin>:1519:2: warning: #warning syscall clone3 not implemented [-Wcpp]../arch/sparc/mm/leon_mm.c: In function 'leon_swprobe':../arch/sparc/mm/leon_mm.c:42:32: warning: variable 'paddrbase' set but not used [-Wunused-but-set-variable]
42 | unsigned int lvl, pte, paddrbase;
| ^~~~~~~~~
To: [email protected]
To: [email protected]
To: Christian Brauner <[email protected]>
To: Andreas Larsson <[email protected]>
To: David S. Miller <[email protected]>
--- arch/sparc/mm/leon_mm.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
arch/sparc/mm/leon_mm.c +1 -7
@@ -39,12 +39,10 @@ unsigned long leon_swprobe(unsigned long vaddr, unsigned long *paddr)unsigned int ctxtbl;unsigned int pgd, pmd, ped;unsigned int ptr; -unsigned int lvl, pte, paddrbase; +unsigned int lvl, pte;unsigned int ctx;unsigned int paddr_calc; - paddrbase =0 ; -if (srmmu_swprobe_trace)printk (KERN_INFO "swprobe: trace on\n" );
@@ -73,7 +71,6 @@ unsigned long leon_swprobe(unsigned long vaddr, unsigned long *paddr)printk (KERN_INFO "swprobe: pgd is entry level 3\n" ); lvl =3 ; pte = pgd; - paddrbase = pgd & _SRMMU_PTE_PMASK_LEON; goto ready; }if (((pgd &SRMMU_ET_MASK ) !=SRMMU_ET_PTD )) {
@@ -96,7 +93,6 @@ unsigned long leon_swprobe(unsigned long vaddr, unsigned long *paddr)printk (KERN_INFO "swprobe: pmd is entry level 2\n" ); lvl =2 ; pte = pmd; - paddrbase = pmd & _SRMMU_PTE_PMASK_LEON; goto ready; }if (((pmd &SRMMU_ET_MASK ) !=SRMMU_ET_PTD )) {
@@ -124,7 +120,6 @@ unsigned long leon_swprobe(unsigned long vaddr, unsigned long *paddr)printk (KERN_INFO "swprobe: ped is entry level 1\n" ); lvl =1 ; pte = ped; - paddrbase = ped & _SRMMU_PTE_PMASK_LEON; goto ready; }if (((ped &SRMMU_ET_MASK ) !=SRMMU_ET_PTD )) {
@@ -147,7 +142,6 @@ unsigned long leon_swprobe(unsigned long vaddr, unsigned long *paddr)printk (KERN_INFO "swprobe: ptr is entry level 0\n" ); lvl =0 ; pte = ptr; - paddrbase = ptr & _SRMMU_PTE_PMASK_LEON; goto ready; }if (srmmu_swprobe_trace)
Signature · 1 line
2.43.0
Ping.
Quoted 14 lines · On 2024-07-29 08:49, [email protected] wrote:
From: Alex Shi <[email protected]>
commit
f22ed71cd602("sparc32,leon: SRMMU MMU Table probe fix") change return value from paddrbase to 'pte', but left the varible here. That causes a build warning for this varible, so we may remove it.make --keep-going CROSS_COMPILE=/home/alexs/0day/gcc-14.1.0-nolibc/sparc-linux/bin/sparc-linux- --jobs=16 KCFLAGS= -Wtautological-compare -Wno-error=return-type -Wreturn-type -Wcast-function-type -funsigned-char -Wundef -fstrict-flex-arrays=3 -Wformat-overflow -Wformat-truncation -Wrestrict -Wenum-conversion W=1 O=sparc ARCH=sparc defconfig SHELL=/bin/bash
arch/sparc/mm/mm/-s <stdin>:1519:2: warning: #warning syscall clone3 not implemented [-Wcpp]../arch/sparc/mm/leon_mm.c: In function 'leon_swprobe':../arch/sparc/mm/leon_mm.c:42:32: warning: variable 'paddrbase' set but not used [-Wunused-but-set-variable]
42 | unsigned int lvl, pte, paddrbase;
| ^~~~~~~~~Signed-off-by Alex Shi <[email protected]>
Quoted 8 lines
To: [email protected]
To: [email protected]
To: Christian Brauner <[email protected]>
To: Andreas Larsson <[email protected]>
To: David S. Miller <[email protected]>--- arch/sparc/mm/leon_mm.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
Picking this up to my for-next.
Thanks,
Andreas