Skip to contentSkip to conversation

arm64: dts: mt8173: elm: Fix nor_flash node property

PATCH Applied Hsin-Yi Wang 3 participants 4 messages Jul 27, 2020 – Sep 21, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: mt8173: elm: Fix nor_flash node property

bus-width and non-removable is not used by the driver. max-frequency should be spi-max-frequency for flash node.

Fixes 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
---
 arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +2 -3
index a5a12b2599a4..01522dd10603 100644
@@ -431,12 +431,11 @@ &nor_flash {
 	status = "okay";
 	pinctrl-names = "default";
 	pinctrl-0 = <&nor_gpio1_pins>;
-	bus-width = <8>;
-	max-frequency = <50000000>;
-	non-removable;
+
 	flash@0 {
 		compatible = "jedec,spi-nor";
 		reg = <0>;
+		spi-max-frequency = <50000000>;
 	};
 };
 
Signature · 1 line
2.28.0.rc0.142.g3c755180ce-goog
Reviewed-by on v1 1/1
#1 lore raw

Hi Hsin-Yi,

Thank you for your patch.

Quoted 6 lines · Hsin-Yi Wang

bus-width and non-removable is not used by the driver. max-frequency should be spi-max-frequency for flash node.

Fixes 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
Quoted 24 lines
---
 arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +2 -3
index a5a12b2599a4..01522dd10603 100644
@@ -431,12 +431,11 @@ &nor_flash {
 	status = "okay";
 	pinctrl-names = "default";
 	pinctrl-0 = <&nor_gpio1_pins>;
-	bus-width = <8>;
-	max-frequency = <50000000>;
-	non-removable;
+
 	flash@0 {
 		compatible = "jedec,spi-nor";
 		reg = <0>;
+		spi-max-frequency = <50000000>;
 	};
 };
 
#2 lore raw
Quoted 6 lines · Enric Balletbo i Serra

Hi Hsin-Yi,

Thank you for your patch.

On 27/7/20 9:41, Hsin-Yi Wang wrote:

Quoted 9 lines
Quoted 6 lines

bus-width and non-removable is not used by the driver. max-frequency should be spi-max-frequency for flash node.

Fixes 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")

Gentle ping.

maintainer Applied
#3 lore raw
In reply to Hsin-Yi Wang
Quoted 6 lines · Hsin-Yi Wang

bus-width and non-removable is not used by the driver. max-frequency should be spi-max-frequency for flash node.

Fixes 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")

Applied to v5.9-next/dts64

Thanks!

Quoted 24 lines
---
  arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +2 -3
index a5a12b2599a4..01522dd10603 100644
@@ -431,12 +431,11 @@ &nor_flash {
  	status = "okay";
  	pinctrl-names = "default";
  	pinctrl-0 = <&nor_gpio1_pins>;
-	bus-width = <8>;
-	max-frequency = <50000000>;
-	non-removable;
+
  	flash@0 {
  		compatible = "jedec,spi-nor";
  		reg = <0>;
+		spi-max-frequency = <50000000>;
  	};
  };