Skip to contentSkip to conversation

hw/arm/smmuv3: Set the restoration priority of the vSMMUv3 explicitly

RFC PATCH Applied Zenghui Yu 3 participants 3 messages Oct 19, 2020 – Oct 26, 2020

lore
Share & tools
lore

Zenghui Yu

author
#0 lore raw

RFC PATCH 1/1 hw/arm/smmuv3: Set the restoration priority of the vSMMUv3 explicitly

Ensure the vSMMUv3 will be restored before all PCIe devices so that DMA translation can work properly during migration.

---

not sure if anything would actually go wrong...

 hw/arm/smmuv3.c | 1 +
 1 file changed, 1 insertion(+)
hw/arm/smmuv3.c +1 -0
index 0122700e72..2017ba7a5a 100644
@@ -1440,6 +1440,7 @@ static const VMStateDescription vmstate_smmuv3 = {
     .name = "smmuv3",
     .version_id = 1,
     .minimum_version_id = 1,
+    .priority = MIG_PRI_IOMMU,
     .fields = (VMStateField[]) {
         VMSTATE_UINT32(features, SMMUv3State),
         VMSTATE_UINT8(sid_size, SMMUv3State),
Signature · 1 line
2.19.1
Acked-by on v1 1/1
#1 lore raw

Hi Zenghui,

Quoted 2 lines · Zenghui Yu

Ensure the vSMMUv3 will be restored before all PCIe devices so that DMA translation can work properly during migration.

Sorry I missed this patch. good catch!

Thanks

Eric

Quoted 22 lines

---

not sure if anything would actually go wrong...

 hw/arm/smmuv3.c | 1 +
 1 file changed, 1 insertion(+)
hw/arm/smmuv3.c +1 -0
index 0122700e72..2017ba7a5a 100644
@@ -1440,6 +1440,7 @@ static const VMStateDescription vmstate_smmuv3 = {
     .name = "smmuv3",
     .version_id = 1,
     .minimum_version_id = 1,
+    .priority = MIG_PRI_IOMMU,
     .fields = (VMStateField[]) {
         VMSTATE_UINT32(features, SMMUv3State),
         VMSTATE_UINT8(sid_size, SMMUv3State),
#2 lore raw
Quoted 10 lines · Auger Eric

Hi Zenghui,

Quoted 2 lines · Zenghui Yu

Ensure the vSMMUv3 will be restored before all PCIe devices so that DMA translation can work properly during migration.

Sorry I missed this patch. good catch!

Applied to target-arm.next, thanks.

-- PMM