ehci-mx6: Update EHCI driver to support OTG0 on i.MX7ULP
Subsystems (2)
PATCH 1/1 ehci-mx6: Update EHCI driver to support OTG0 on i.MX7ULP
From: Ye Li <[email protected]>
The ULP has two USB controllers. These two controllers have similar NC registers layout as i.MX7D. But OTG0 uses UTMI PHY simliar as i.MX6, not the integrated PHY on i.MX7D. The OTG1 needs off-chip HSIC PHY or ULPI PHY to work.
This patch only supports OTG0 with UTMI PHY.
--- drivers/usb/host/Kconfig | 4 +-- drivers/usb/host/ehci-mx6.c | 53 ++++++++++++++++++++++++++++--------- 2 files changed, 42 insertions(+), 15 deletions(-)
drivers/usb/host/Kconfig +2 -2
@@ -142,7 +142,7 @@ config USB_EHCI_MX5 config USB_EHCI_MX6 bool "Support for i.MX6 on-chip EHCI USB controller" - depends on ARCH_MX6 + depends on ARCH_MX6 || ARCH_MX7ULP default y ---help--- Enables support for the on-chip EHCI controller on i.MX6 SoCs.
@@ -169,7 +169,7 @@ config USB_EHCI_VF help Enables support for the on-chip EHCI controller on Vybrid SoCs. -if USB_EHCI_MX7 +if USB_EHCI_MX7 || USB_EHCI_MX6 config MXC_USB_OTG_HACTIVE bool "USB Power pin high active"
drivers/usb/host/ehci-mx6.c +40 -13
128 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH 1/1 ehci-mx6: Update EHCI driver to support OTG0 on i.MX7ULP
On 10/21/19 3:52 PM, Fabio Estevam wrote:
[...]
drivers/usb/host/Kconfig config USB_EHCI_MX5 · line 144
Quoted 8 lines
drivers/usb/host/Kconfig +0
-0@@ -142,7 +142,7 @@ config USB_EHCI_MX5 config USB_EHCI_MX6 bool "Support for i.MX6 on-chip EHCI USB controller"
Can you also update the description ?
drivers/usb/host/Kconfig config USB_EHCI_MX5 · line 145
Quoted 2 lines
drivers/usb/host/Kconfig +1
-1- depends on ARCH_MX6 + depends on ARCH_MX6 || ARCH_MX7ULP
Should this also depend on ARCH_MX7 here ?
drivers/usb/host/Kconfig config USB_EHCI_VF · line 172
Quoted 9 lines
drivers/usb/host/Kconfig +1
-1default y ---help--- Enables support for the on-chip EHCI controller on i.MX6 SoCs.@@ -169,7 +169,7 @@ config USB_EHCI_VF help Enables support for the on-chip EHCI controller on Vybrid SoCs. -if USB_EHCI_MX7 +if USB_EHCI_MX7 || USB_EHCI_MX6
Please swap the MX6 and MX7 to keep the list sorted.
[...]
Signature · 2 lines
Best regards, Marek Vasut
PATCH 1/1 ehci-mx6: Update EHCI driver to support OTG0 on i.MX7ULP
Hi Marek,
Quoted 4 lines · Marek Vasut
Quoted 2 lines
config
USB_EHCI_MX6
bool "Support for i.MX6 on-chip EHCI USB controller"Can you also update the description ?
Sure, done in v2.
Quoted 5 lines
drivers/usb/host/Kconfig config USB_EHCI_MX5 · line 145
Quoted 3 lines
drivers/usb/host/Kconfig +1
-1- depends on ARCH_MX6 + depends on ARCH_MX6 || ARCH_MX7ULPShould this also depend on
ARCH_MX7here ?
No, it is USB_EHCI_MX7 that depends on ARCH_MX7:
config USB_EHCI_MX7
bool "Support for i.MX7 on-chip EHCI USB controller" depends on ARCH_MX7
Quoted 11 lines
drivers/usb/host/Kconfig config USB_EHCI_VF · line 172
Quoted 9 lines
default y
---help---
Enables support for the on-chip EHCI controller on i.MX6 SoCs.drivers/usb/host/Kconfig +1
-1@@ -169,7 +169,7 @@ config USB_EHCI_VF help Enables support for the on-chip EHCI controller on Vybrid SoCs. -if USB_EHCI_MX7 +if USB_EHCI_MX7 || USB_EHCI_MX6Please swap the MX6 and MX7 to keep the list sorted.
Done in v2.
Thanks