Skip to contentSkip to conversation

mmc: davinci: Make SDIO irq truly optional

PATCH In review Julien Delbergue 3 participants 3 messages Jul 13, 2023 – Jul 14, 2023 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: davinci: Make SDIO irq truly optional

The following error is printed on Logic PD's DA850 EVM:
davinci_mmc 1c40000.mmc: error -ENXIO: IRQ index 1 not found

Depending on the board, the SDIO interrupt may not be present, so use the correct function to reflect that and prevent logging an error.

---
 drivers/mmc/host/davinci_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/davinci_mmc.c +1 -1
index 7138dfa065bf..fb686c0d171c 100644
@@ -1257,7 +1257,7 @@ static int davinci_mmcsd_probe(struct platform_device *pdev)
 
 	host->use_dma = use_dma;
 	host->mmc_irq = irq;
-	host->sdio_irq = platform_get_irq(pdev, 1);
+	host->sdio_irq = platform_get_irq_optional(pdev, 1);
 
 	if (host->use_dma) {
 		ret = davinci_acquire_dma_channels(host);
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 26 lines · Julien Delbergue

The following error is printed on Logic PD's DA850 EVM:
davinci_mmc 1c40000.mmc: error -ENXIO: IRQ index 1 not found

Depending on the board, the SDIO interrupt may not be present, so use the correct function to reflect that and prevent logging an error.

---
 drivers/mmc/host/davinci_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/davinci_mmc.c +1 -2
index 7138dfa065bf..fb686c0d171c 100644
@@ -1257,7 +1257,7 @@ static int davinci_mmcsd_probe(struct platform_device *pdev)
 
        host->use_dma = use_dma;
        host->mmc_irq = irq;
-       host->sdio_irq = platform_get_irq(pdev, 1);
+       host->sdio_irq = platform_get_irq_optional(pdev, 1);
 
        if (host->use_dma) {
                ret = davinci_acquire_dma_channels(host);
--
Quoted 1 line

2.34.1

#2 lore raw
In reply to Julien Delbergue
Quoted 8 lines · Julien Delbergue

The following error is printed on Logic PD's DA850 EVM:
davinci_mmc 1c40000.mmc: error -ENXIO: IRQ index 1 not found

Depending on the board, the SDIO interrupt may not be present, so use the correct function to reflect that and prevent logging an error.

Applied for next, thanks!

Kind regards
Uffe

Quoted 19 lines
---
 drivers/mmc/host/davinci_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/davinci_mmc.c +1 -2
index 7138dfa065bf..fb686c0d171c 100644
@@ -1257,7 +1257,7 @@ static int davinci_mmcsd_probe(struct platform_device *pdev)
 
        host->use_dma = use_dma;
        host->mmc_irq = irq;
-       host->sdio_irq = platform_get_irq(pdev, 1);
+       host->sdio_irq = platform_get_irq_optional(pdev, 1);
 
        if (host->use_dma) {
                ret = davinci_acquire_dma_channels(host);
--

2.34.1