Skip to contentSkip to conversation

nfc: pn544: make array rset_cmd static const

PATCH Applied Colin Ian King 3 participants 3 messages Jan 9, 2022 – Jan 12, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfc: pn544: make array rset_cmd static const

Don't populate the read-only array rset_cmd on the stack but instead it static const. Also makes the object code a little smaller.

---
 drivers/nfc/pn544/i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nfc/pn544/i2c.c +1 -1
index 37d26f01986b..62a0f1a010cb 100644
@@ -188,7 +188,7 @@ do {								\
 static void pn544_hci_i2c_platform_init(struct pn544_i2c_phy *phy)
 {
 	int polarity, retry, ret;
-	char rset_cmd[] = { 0x05, 0xF9, 0x04, 0x00, 0xC3, 0xE5 };
+	static const char rset_cmd[] = { 0x05, 0xF9, 0x04, 0x00, 0xC3, 0xE5 };
 	int count = sizeof(rset_cmd);
 
 	nfc_info(&phy->i2c_dev->dev, "Detecting nfc_en polarity\n");
Signature · 1 line
2.32.0
#2 lore raw
In reply to Colin Ian King
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 7 lines · On Sun, 9 Jan 2022 20:24:18 +0000 you wrote:

Don't populate the read-only array rset_cmd on the stack but instead it static const. Also makes the object code a little smaller.

---
 drivers/nfc/pn544/i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- nfc: pn544: make array rset_cmd static const

    https://git.kernel.org/netdev/net/c/e110978d6e06

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html