Skip to contentSkip to conversation

Add initial support for slimport anx7625

PATCH In review Xin Ji 3 participants 8 messages Sep 19, 2019 – Sep 21, 2019

Subsystems (4)
lore
Share & tools
lore

Xin Ji

author
#0 lore raw

cover Add initial support for slimport anx7625

Hi all,

The following series add initial support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device.

This is the first version upload, any mistakes, please let me know, I will fix it in the next series.

Thanks,
Xin

Xin Ji (2):
dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding drm/bridge: anx7625: Add anx7625 MIPI to DP bridge driver

 .../devicetree/bindings/display/bridge/anx7625.txt |   42 +
 drivers/gpu/drm/bridge/Makefile                    |    2 +-
 drivers/gpu/drm/bridge/analogix/Kconfig            |    6 +
 drivers/gpu/drm/bridge/analogix/Makefile           |    1 +
 drivers/gpu/drm/bridge/analogix/anx7625.c          | 2086 ++++++++++++++++++++
 drivers/gpu/drm/bridge/analogix/anx7625.h          |  397 ++++
 6 files changed, 2533 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.txt
 create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.c
 create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.h
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 1/2 dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K.

You can add support to your board with binding.

Example:

	anx_bridge: anx7625@58 {
		compatible = "analogix,anx7625";
		reg = <0x58>;
		anx,low_power_mode = <1>;
		anx,dsi_supported = <1>;
		anx,dsi_channel = <1>;
		anx,dsi_lanes = <4>;
		anx,internal_pannel = <1>;
		anx,p-on-gpio = <&gpio0 45 GPIO_ACTIVE_LOW>;
		anx,reset-gpio = <&gpio0 73 GPIO_ACTIVE_LOW>;
		status = "okay";
		port {
			anx7625_1_in: endpoint {
				remote-endpoint = <&mipi_dsi_bridge_1>;
			};
		};
	};
---
 .../devicetree/bindings/display/bridge/anx7625.txt | 42 ++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.txt
Documentation/devicetree/bindings/display/bridge/anx7625.txt new file +42 -0
new file mode 100644
index 0000000..f2a1c2a
@@ -0,0 +1,42 @@
+Analogix ANX7625 SlimPort (4K Mobile HD Transmitter)
+-----------------------------------------------
+
+The ANX7625 is an ultra-low power 4K Mobile HD Transmitter
+designed for portable devices.
+
+Required properties:
+
+ - compatible		: "analogix,anx7625"
+ - reg			: I2C address of the device
+ - anx,low_power_mode	: Low power mode support feature
+ - anx,dsi_supported	: DSI or DPI
+ - anx,dsi_channel	: DSI channel index
+ - anx,dsi_lanes	: DSI lane count
+ - anx,intr-hpd-gpio	: Which GPIO to use for interrupt
+
+Optional properties:
+
+ - anx,extcon_supported
+	external connector interface support flag
+ - anx,internal_pannel
+	Which indicate internal pannel
+ - anx,p-on-gpio
+	Which GPIO to use for Power On chip
+ - anx,reset-gpio
+	Which GPIO to use for RESET
+ - port
+	SoC specific port nodes with endpoint definitions as defined in
+	Documentation/devicetree/bindings/media/video-interfaces.txt,
+
+Example:
+
+	anx_bridge: anx7625@58 {
+		compatible = "analogix,anx7625";
+		reg = <0x58>;
+		anx,low_power_mode = <0>;
+		anx,dsi_supported = <1>;
+		anx,dsi_channel = <1>;
+		anx,dsi_lanes = <4>;
+		anx,intr-hpd-gpio = <&gpio1 19 IRQ_TYPE_LEVEL_LOW>;
+		status = "okay";
+	};
Signature · 1 line
2.7.4
#2 lore raw

Re: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

Hi,

Quoted 36 lines · Xin Ji

The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K.

You can add support to your board with binding.

Example:

	anx_bridge: anx7625@58 {
		compatible = "analogix,anx7625";
		reg = <0x58>;
		anx,low_power_mode = <1>;
		anx,dsi_supported = <1>;
		anx,dsi_channel = <1>;
		anx,dsi_lanes = <4>;
		anx,internal_pannel = <1>;
		anx,p-on-gpio = <&gpio0 45 GPIO_ACTIVE_LOW>;
		anx,reset-gpio = <&gpio0 73 GPIO_ACTIVE_LOW>;
		status = "okay";
		port {
			anx7625_1_in: endpoint {
				remote-endpoint = <&mipi_dsi_bridge_1>;
			};
		};
	};
---
 .../devicetree/bindings/display/bridge/anx7625.txt | 42 ++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.txt
Documentation/devicetree/bindings/display/bridge/anx7625.txt new file +0 -0
new file mode 100644
index 0000000..f2a1c2a

Documentation/devicetree/bindings/display/bridge/anx7625.txt line 2

Quoted 2 lines
Documentation/devicetree/bindings/display/bridge/anx7625.txt new file +2 -0
@@ -0,0 +1,42 @@
+Analogix ANX7625 SlimPort (4K Mobile HD Transmitter)
+-----------------------------------------------

New bindings should use yaml format:
https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/example-schema.yaml

Neil

Quoted 41 lines
Documentation/devicetree/bindings/display/bridge/anx7625.txt new file +40 -0
+
+The ANX7625 is an ultra-low power 4K Mobile HD Transmitter
+designed for portable devices.
+
+Required properties:
+
+ - compatible		: "analogix,anx7625"
+ - reg			: I2C address of the device
+ - anx,low_power_mode	: Low power mode support feature
+ - anx,dsi_supported	: DSI or DPI
+ - anx,dsi_channel	: DSI channel index
+ - anx,dsi_lanes	: DSI lane count
+ - anx,intr-hpd-gpio	: Which GPIO to use for interrupt
+
+Optional properties:
+
+ - anx,extcon_supported
+	external connector interface support flag
+ - anx,internal_pannel
+	Which indicate internal pannel
+ - anx,p-on-gpio
+	Which GPIO to use for Power On chip
+ - anx,reset-gpio
+	Which GPIO to use for RESET
+ - port
+	SoC specific port nodes with endpoint definitions as defined in
+	Documentation/devicetree/bindings/media/video-interfaces.txt,
+
+Example:
+
+	anx_bridge: anx7625@58 {
+		compatible = "analogix,anx7625";
+		reg = <0x58>;
+		anx,low_power_mode = <0>;
+		anx,dsi_supported = <1>;
+		anx,dsi_channel = <1>;
+		anx,dsi_lanes = <4>;
+		anx,intr-hpd-gpio = <&gpio1 19 IRQ_TYPE_LEVEL_LOW>;
+		status = "okay";
+	};
author
#3 lore raw

Re: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

Quoted 45 lines · Neil Armstrong

Hi,

Quoted 36 lines · Xin Ji

The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K.

You can add support to your board with binding.

Example:

	anx_bridge: anx7625@58 {
		compatible = "analogix,anx7625";
		reg = <0x58>;
		anx,low_power_mode = <1>;
		anx,dsi_supported = <1>;
		anx,dsi_channel = <1>;
		anx,dsi_lanes = <4>;
		anx,internal_pannel = <1>;
		anx,p-on-gpio = <&gpio0 45 GPIO_ACTIVE_LOW>;
		anx,reset-gpio = <&gpio0 73 GPIO_ACTIVE_LOW>;
		status = "okay";
		port {
			anx7625_1_in: endpoint {
				remote-endpoint = <&mipi_dsi_bridge_1>;
			};
		};
	};
---
 .../devicetree/bindings/display/bridge/anx7625.txt | 42 ++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.txt
Documentation/devicetree/bindings/display/bridge/anx7625.txt new file +0 -0
new file mode 100644
index 0000000..f2a1c2a

Documentation/devicetree/bindings/display/bridge/anx7625.txt line 2

Quoted 2 lines
Documentation/devicetree/bindings/display/bridge/anx7625.txt new file +2 -0
@@ -0,0 +1,42 @@
+Analogix ANX7625 SlimPort (4K Mobile HD Transmitter)
+-----------------------------------------------

New bindings should use yaml format:
https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/example-schema.yaml

Quoted 1 line

Neil

OK, I'll follow the yaml format in the next version. Thanks,
Xin

Quoted 42 lines
Quoted 42 lines
Documentation/devicetree/bindings/display/bridge/anx7625.txt new file +40 -0
+
+The ANX7625 is an ultra-low power 4K Mobile HD Transmitter
+designed for portable devices.
+
+Required properties:
+
+ - compatible		: "analogix,anx7625"
+ - reg			: I2C address of the device
+ - anx,low_power_mode	: Low power mode support feature
+ - anx,dsi_supported	: DSI or DPI
+ - anx,dsi_channel	: DSI channel index
+ - anx,dsi_lanes	: DSI lane count
+ - anx,intr-hpd-gpio	: Which GPIO to use for interrupt
+
+Optional properties:
+
+ - anx,extcon_supported
+	external connector interface support flag
+ - anx,internal_pannel
+	Which indicate internal pannel
+ - anx,p-on-gpio
+	Which GPIO to use for Power On chip
+ - anx,reset-gpio
+	Which GPIO to use for RESET
+ - port
+	SoC specific port nodes with endpoint definitions as defined in
+	Documentation/devicetree/bindings/media/video-interfaces.txt,
+
+Example:
+
+	anx_bridge: anx7625@58 {
+		compatible = "analogix,anx7625";
+		reg = <0x58>;
+		anx,low_power_mode = <0>;
+		anx,dsi_supported = <1>;
+		anx,dsi_channel = <1>;
+		anx,dsi_lanes = <4>;
+		anx,intr-hpd-gpio = <&gpio1 19 IRQ_TYPE_LEVEL_LOW>;
+		status = "okay";
+	};
#4 lore raw
In reply to Xin Ji

Hi,

Please Cc [email protected]

Thanks,
Neil

Quoted 27 lines · Xin Ji

Hi all,

The following series add initial support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device.

This is the first version upload, any mistakes, please let me know, I will fix it in the next series.

Thanks,
Xin

Xin Ji (2):
dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding drm/bridge: anx7625: Add anx7625 MIPI to DP bridge driver

 .../devicetree/bindings/display/bridge/anx7625.txt |   42 +
 drivers/gpu/drm/bridge/Makefile                    |    2 +-
 drivers/gpu/drm/bridge/analogix/Kconfig            |    6 +
 drivers/gpu/drm/bridge/analogix/Makefile           |    1 +
 drivers/gpu/drm/bridge/analogix/anx7625.c          | 2086 ++++++++++++++++++++
 drivers/gpu/drm/bridge/analogix/anx7625.h          |  397 ++++
 6 files changed, 2533 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.txt
 create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.c
 create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.h
author
#5 lore raw
Quoted 6 lines · Neil Armstrong

Hi,

Please Cc [email protected]

Thanks,
Neil

OK, thanks.
Xin

Quoted 29 lines · Xin Ji
Quoted 27 lines

Hi all,

The following series add initial support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device.

This is the first version upload, any mistakes, please let me know, I will fix it in the next series.

Thanks,
Xin

Xin Ji (2):
dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding drm/bridge: anx7625: Add anx7625 MIPI to DP bridge driver

 .../devicetree/bindings/display/bridge/anx7625.txt |   42 +
 drivers/gpu/drm/bridge/Makefile                    |    2 +-
 drivers/gpu/drm/bridge/analogix/Kconfig            |    6 +
 drivers/gpu/drm/bridge/analogix/Makefile           |    1 +
 drivers/gpu/drm/bridge/analogix/anx7625.c          | 2086 ++++++++++++++++++++
 drivers/gpu/drm/bridge/analogix/anx7625.h          |  397 ++++
 6 files changed, 2533 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.txt
 create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.c
 create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.h
author
#6 lore raw

PATCH 2/2 drm/bridge: anx7625: Add anx7625 MIPI to DP bridge driver

In reply to Xin Ji

The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K.

---
 drivers/gpu/drm/bridge/Makefile           |    2 +-
 drivers/gpu/drm/bridge/analogix/Kconfig   |    6 +
 drivers/gpu/drm/bridge/analogix/Makefile  |    1 +
 drivers/gpu/drm/bridge/analogix/anx7625.c | 2086 +++++++++++++++++++++++++++++
 drivers/gpu/drm/bridge/analogix/anx7625.h |  397 ++++++
 5 files changed, 2491 insertions(+), 1 deletion(-)
 create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.c
 create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.h
drivers/gpu/drm/bridge/Makefile +1 -1
index 4934fcf..bcd388a 100644
@@ -12,8 +12,8 @@ obj-$(CONFIG_DRM_SII9234) += sii9234.o
 obj-$(CONFIG_DRM_THINE_THC63LVD1024) += thc63lvd1024.o
 obj-$(CONFIG_DRM_TOSHIBA_TC358764) += tc358764.o
 obj-$(CONFIG_DRM_TOSHIBA_TC358767) += tc358767.o
-obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix/
 obj-$(CONFIG_DRM_I2C_ADV7511) += adv7511/
 obj-$(CONFIG_DRM_TI_SN65DSI86) += ti-sn65dsi86.o
 obj-$(CONFIG_DRM_TI_TFP410) += ti-tfp410.o
+obj-y += analogix/
 obj-y += synopsys/
drivers/gpu/drm/bridge/analogix/Kconfig +6 -0
index e930ff9..b2f127e 100644
@@ -2,3 +2,9 @@
 config DRM_ANALOGIX_DP
 	tristate
 	depends on DRM
+
+config ANALOGIX_ANX7625
+	tristate "Analogix MIPI to DP interface support"
+	help
+		ANX7625 is an ultra-low power 4K mobile HD transmitter designed
+		for portable devices. It converts MIPI/DPI to DisplayPort1.3 4K.
drivers/gpu/drm/bridge/analogix/Makefile +1 -0
index fdbf3fd..8a52867 100644
@@ -1,3 +1,4 @@
 # SPDX-License-Identifier: GPL-2.0-only
+obj-$(CONFIG_ANALOGIX_ANX7625) += anx7625.o
 analogix_dp-objs := analogix_dp_core.o analogix_dp_reg.o
 obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix_dp.o
drivers/gpu/drm/bridge/analogix/anx7625.c new file +2086 -0

2,086 lines not on this page · raw message

drivers/gpu/drm/bridge/analogix/anx7625.h new file +397 -0

397 lines not on this page · raw message

Signature · 1 line
2.7.4
#7 lore raw

Re: [PATCH v1 2/2] drm/bridge: anx7625: Add anx7625 MIPI to DP bridge driver

Thank you for the patch! Perhaps something to improve:

Hi Xin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[cannot apply to v5.3 next-20190918]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Xin-Ji/Add-initial-support-for-slimport-anx7625/20190919-150647
:::::: branch date: 73 minutes ago
:::::: commit date: 73 minutes ago

If you fix the issue, kindly add following tag

>> drivers/gpu/drm/bridge/analogix/anx7625.c:2070:3-8: No need to set .owner here. The core will do it.

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation