Skip to contentSkip to conversation

add some Blackfin specific checks to checkpatch.pl

PATCH In review Mike Frysinger 3 participants 4 messages Aug 21, 2007 – Sep 13, 2007 Checkpatch

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add some Blackfin specific checks to checkpatch.pl

Check for a few common errors in Blackfin-specific code wrt MMR loading in assembly and doing core/system syncs.

CC Bryan Wu <[email protected]>
CC Andy Whitcroft <[email protected]>
---
 scripts/checkpatch.pl |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)
scripts/checkpatch.pl +20 -0
index dae7d30..ead9675 100755
@@ -486,9 +486,29 @@ sub process {
 			WARN("line over 80 characters\n" . $herecurr);
 		}
 
+# Blackfin: use hi/lo macros
+		if ($line =~ /\.[lL][[:space:]]*=.*&[[:space:]]*0x[fF][fF][fF][fF]/) {
+			my $herevet = "$here\n" . cat_vet($line) . "\n";
+			ERROR("use the LO() macro, not (... & 0xFFFF)\n" . $herevet);
+		}
+		if ($line =~ /\.[hH][[:space:]]*=.*>>[[:space:]]*16/) {
+			my $herevet = "$here\n" . cat_vet($line) . "\n";
+			ERROR("use the HI() macro, not (... >> 16)\n" . $herevet);
+		}
+
 # check we are in a valid source file *.[hc] if not then ignore this hunk
 		next if ($realfile !~ /\.[hc]$/);
 
+# Blackfin: don't use __builtin_bfin_[cs]sync
+		if ($line =~ /__builtin_bfin_csync/) {
+			my $herevet = "$here\n" . cat_vet($line) . "\n";
+			ERROR("use the CSYNC() macro in asm/blackfin.h\n" . $herevet);
+		}
+		if ($line =~ /__builtin_bfin_ssync/) {
+			my $herevet = "$here\n" . cat_vet($line) . "\n";
+			ERROR("use the SSYNC() macro in asm/blackfin.h\n" . $herevet);
+		}
+
 # at the beginning of a line any tabs must come first and anything
 # more than 8 must use tabs.
 		if ($line=~/^\+\s* \t\s*\S/ or $line=~/^\+\s*        \s*/) {
Signature · 1 line
1.5.3.rc5
#1 lore raw

Check for a few common errors in Blackfin-specific code wrt MMR loading in assembly and doing core/system syncs. Restrict the Blackfin MMR checks to actual Blackfin assembly files as pointed out by Joe Perches.

CC Bryan Wu <[email protected]>
CC Andy Whitcroft <[email protected]>
---
 scripts/checkpatch.pl |   22 ++++++++++++++++++++
 1 files changed, 22 insertions(+), 0 deletions(-)
scripts/checkpatch.pl +22 -0
index dae7d30..ead9675 100755
@@ -486,9 +486,31 @@ sub process {
 			WARN("line over 80 characters\n" . $herecurr);
 		}
 
+# Blackfin: use hi/lo macros
+		if ($realfile =~ s@arch/blackfin/.*\.S$@) {
+			if ($line =~ /\.[lL][[:space:]]*=.*&[[:space:]]*0x[fF][fF][fF][fF]/) {
+				my $herevet = "$here\n" . cat_vet($line) . "\n";
+				ERROR("use the LO() macro, not (... & 0xFFFF)\n" . $herevet);
+			}
+			if ($line =~ /\.[hH][[:space:]]*=.*>>[[:space:]]*16/) {
+				my $herevet = "$here\n" . cat_vet($line) . "\n";
+				ERROR("use the HI() macro, not (... >> 16)\n" . $herevet);
+			}
+		}
+
 # check we are in a valid source file *.[hc] if not then ignore this hunk
 		next if ($realfile !~ /\.[hc]$/);
 
+# Blackfin: don't use __builtin_bfin_[cs]sync
+		if ($line =~ /__builtin_bfin_csync/) {
+			my $herevet = "$here\n" . cat_vet($line) . "\n";
+			ERROR("use the CSYNC() macro in asm/blackfin.h\n" . $herevet);
+		}
+		if ($line =~ /__builtin_bfin_ssync/) {
+			my $herevet = "$here\n" . cat_vet($line) . "\n";
+			ERROR("use the SSYNC() macro in asm/blackfin.h\n" . $herevet);
+		}
+
 # at the beginning of a line any tabs must come first and anything
 # more than 8 must use tabs.
 		if ($line=~/^\+\s* \t\s*\S/ or $line=~/^\+\s*        \s*/) {
Signature · 1 line
1.5.3.rc5
#2 lore raw
In reply to Mike Frysinger
Quoted 2 lines · Mike Frysinger

Check for a few common errors in Blackfin-specific code wrt MMR loading in assembly and doing core/system syncs.

If we are going to pull arch specific things into checkpatch I think we need to make sure we are pretty specific about where we apply them. I am assuming these checks only make sense againt some files in the arch tree?

-apw

#3 lore raw
Quoted 8 lines · Andy Whitcroft
Quoted 2 lines · Mike Frysinger

Check for a few common errors in Blackfin-specific code wrt MMR loading in assembly and doing core/system syncs.

If we are going to pull arch specific things into checkpatch I think we need to make sure we are pretty specific about where we apply them. I am assuming these checks only make sense againt some files in the arch tree?

ive restricted the .S check to arch/blackfin/, but the other check should be run on all .c files since Blackfin drivers may live anywhere in the tree, not just in arch/ ... i really doubt that'd be a problem unless another architecture starts implementing functions with "__builtin_bfin_ssync" in its name ...

side note, Joe pointed out that arch/blackfin regex should be m@...@, not s@...@ -mike