Redefine interconnect provider DT nodes for SDM845
cover Redefine interconnect provider DT nodes for SDM845
Redefine the SDM845 interconnect device nodes as the previous definitions of using a single child node under the apps_rsc device did not accurately capture the description of the hardware. The Network-On-Chip (NoC) interconnect devices should be represented in a manner akin to QCS404 platforms[1] where there is a separation of NoC devices and its RPM/RPMh counterparts.
The bcm-voter devices are representing the RPMh devices that the interconnect providers need to communicate with and there can be more than one instance of the Bus Clock Manager (BCM) which can live under different instances of Resource State Coordinators (RSC). There are display use cases where consumers may need to target a different bcm-voter (Some display specific RSC) than the default, and there needs to be a way to represent this connection in devicetree.
[1]: https://lkml.org/lkml/2019/6/13/143
David Dai (2):
dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings
arm64: dts: sdm845: Redefine interconnect provider DT nodes
.../bindings/interconnect/qcom,bcm-voter.txt | 32 ++++++++++++ .../bindings/interconnect/qcom,sdm845.txt | 40 ++++++++++---- arch/arm64/boot/dts/qcom/sdm845.dtsi | 61 ++++++++++++++++++++-- 3 files changed, 121 insertions(+), 12 deletions(-) create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH 1/2 dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings
Redefine the Network-on-Chip devices to more accurately describe the interconnect topology on Qualcomm's SDM845 platform. Each interconnect device can communicate with different instances of the RPMh hardware which are described as RSCs(Resource State Coordinators).
--- .../bindings/interconnect/qcom,bcm-voter.txt | 32 +++++++++++++++++ .../bindings/interconnect/qcom,sdm845.txt | 40 +++++++++++++++++----- 2 files changed, 63 insertions(+), 9 deletions(-) create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt new file +32 -0
@@ -0,0 +1,32 @@ +Qualcomm BCM-Voter interconnect driver binding +----------------------------------------------------------- + +The Bus Clock Manager (BCM) is a dedicated hardware accelerator +that manages shared system resources by aggregating requests +from multiple Resource State Coordinators (RSC). Interconnect +providers are able to vote for aggregated thresholds values from +consumers by communicating through their respective RSCs. + +Required properties : +- compatible : shall contain only one of the following: + "qcom,sdm845-bcm-voter", + +Examples: + +apps_rsc: rsc@179c0000 { + label = "apps_rsc"; + compatible = "qcom,rpmh-rsc"; + + apps_bcm_voter: bcm_voter { + compatible = "qcom,sdm845-bcm-voter"; + }; +} + +disp_rsc: rsc@179d0000 { + label = "disp_rsc"; + compatible = "qcom,rpmh-rsc"; + + disp_bcm_voter: bcm_voter { + compatible = "qcom,sdm845-bcm-voter"; + }; +}
Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt +31 -9
@@ -4,21 +4,43 @@ Qualcomm SDM845 Network-On-Chip interconnect driver binding SDM845 interconnect providers support system bandwidth requirements through RPMh hardware accelerators known as Bus Clock Manager (BCM). The provider is able to communicate with the BCM through the Resource State Coordinator (RSC) -associated with each execution environment. Provider nodes must reside within -an RPMh device node pertaining to their RSC and each provider maps to a single -RPMh resource. +associated with each execution environment. Provider nodes must point to at +least one RPMh device child node pertaining to their RSC and each provider +can map to multiple RPMh resources. Required properties : - compatible : shall contain only one of the following: - "qcom,sdm845-rsc-hlos" + "qcom,sdm845-aggre1_noc", + "qcom,sdm845-aggre2_noc", + "qcom,sdm845-config_noc", + "qcom,sdm845-dc_noc", + "qcom,sdm845-gladiator_noc", + "qcom,sdm845-mem_noc", + "qcom,sdm845-mmss_noc", + "qcom,sdm845-system_noc", - #interconnect-cells : should contain 1 +- reg : shall contain base register location and length +- qcom,bcm-voter : shall contain phandles to bcm voters Examples: -apps_rsc: rsc { - rsc_hlos: interconnect { - compatible = "qcom,sdm845-rsc-hlos"; - #interconnect-cells = <1>; - }; +aggre1_noc: interconnect@16e0000 { + compatible = "qcom,sdm845-aggre1_noc"; + reg = <0x16e0000 0xd080>; + interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; }; +mmss_noc: interconnect@1740000 { + compatible = "qcom,sdm845-mmss_noc"; + reg = <0x1740000 0x1c1000>; + interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>, <&disp_bcm_voter>; +}; + +mem_noc: interconnect@1380000 { + compatible = "qcom,sdm845-mem_noc"; + reg = <0 0x1380000 0 0x27200>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>, <&disp_bcm_voter>; +};
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH 1/2] dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings
Quoted 6 lines · David Dai
Redefine the Network-on-Chip devices to more accurately describe the interconnect topology on Qualcomm's SDM845 platform. Each interconnect device can communicate with different instances of the RPMh hardware which are described as RSCs(Resource State Coordinators).
Signed-off-by David Dai <[email protected]>
I like this and we don't have any consumers in DT yet, so I think this is good.
But we need a patch to the implementation as well, to have the provider(s) registered with the new compatibles.
Regards,
Bjorn
Quoted 105 lines
--- .../bindings/interconnect/qcom,bcm-voter.txt | 32 +++++++++++++++++ .../bindings/interconnect/qcom,sdm845.txt | 40 +++++++++++++++++----- 2 files changed, 63 insertions(+), 9 deletions(-) create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txtDocumentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt new file +32
-0@@ -0,0 +1,32 @@ +Qualcomm BCM-Voter interconnect driver binding +----------------------------------------------------------- + +The Bus Clock Manager (BCM) is a dedicated hardware accelerator +that manages shared system resources by aggregating requests +from multiple Resource State Coordinators (RSC). Interconnect +providers are able to vote for aggregated thresholds values from +consumers by communicating through their respective RSCs. + +Required properties : +- compatible : shall contain only one of the following: + "qcom,sdm845-bcm-voter", + +Examples: + +apps_rsc: rsc@179c0000 { + label = "apps_rsc"; + compatible = "qcom,rpmh-rsc"; + + apps_bcm_voter: bcm_voter { + compatible = "qcom,sdm845-bcm-voter"; + }; +} + +disp_rsc: rsc@179d0000 { + label = "disp_rsc"; + compatible = "qcom,rpmh-rsc"; + + disp_bcm_voter: bcm_voter { + compatible = "qcom,sdm845-bcm-voter"; + }; +}Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt +31
-9@@ -4,21 +4,43 @@ Qualcomm SDM845 Network-On-Chip interconnect driver binding SDM845 interconnect providers support system bandwidth requirements through RPMh hardware accelerators known as Bus Clock Manager (BCM). The provider is able to communicate with the BCM through the Resource State Coordinator (RSC) -associated with each execution environment. Provider nodes must reside within -an RPMh device node pertaining to their RSC and each provider maps to a single -RPMh resource. +associated with each execution environment. Provider nodes must point to at +least one RPMh device child node pertaining to their RSC and each provider +can map to multiple RPMh resources. Required properties : - compatible : shall contain only one of the following: - "qcom,sdm845-rsc-hlos" + "qcom,sdm845-aggre1_noc", + "qcom,sdm845-aggre2_noc", + "qcom,sdm845-config_noc", + "qcom,sdm845-dc_noc", + "qcom,sdm845-gladiator_noc", + "qcom,sdm845-mem_noc", + "qcom,sdm845-mmss_noc", + "qcom,sdm845-system_noc", - #interconnect-cells : should contain 1 +- reg : shall contain base register location and length +- qcom,bcm-voter : shall contain phandles to bcm voters Examples: -apps_rsc: rsc { - rsc_hlos: interconnect { - compatible = "qcom,sdm845-rsc-hlos"; - #interconnect-cells = <1>; - }; +aggre1_noc: interconnect@16e0000 { + compatible = "qcom,sdm845-aggre1_noc"; + reg = <0x16e0000 0xd080>; + interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; }; +mmss_noc: interconnect@1740000 { + compatible = "qcom,sdm845-mmss_noc"; + reg = <0x1740000 0x1c1000>; + interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>, <&disp_bcm_voter>; +}; + +mem_noc: interconnect@1380000 { + compatible = "qcom,sdm845-mem_noc"; + reg = <0 0x1380000 0 0x27200>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>, <&disp_bcm_voter>; +};Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH 1/2] dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings
In reply to David DaiQuoting David Dai (2019-07-19 13:32:23)
Quoted 19 lines
Redefine the Network-on-Chip devices to more accurately describe the interconnect topology on Qualcomm's SDM845 platform. Each interconnect device can communicate with different instances of the RPMh hardware which are described as RSCs(Resource State Coordinators).
Signed-off-by David Dai <[email protected]>---
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt new file +6
-0@@ -0,0 +1,32 @@ +Qualcomm BCM-Voter interconnect driver binding +----------------------------------------------------------- + +The Bus Clock Manager (BCM) is a dedicated hardware accelerator +that manages shared system resources by aggregating requests +from multiple Resource State Coordinators (RSC). Interconnect
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt line 16
Quoted 10 lines
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt new file +10
-0+providers are able to vote for aggregated thresholds values from +consumers by communicating through their respective RSCs. + +Required properties : +- compatible : shall contain only one of the following: + "qcom,sdm845-bcm-voter", + +Examples: + +apps_rsc: rsc@179c0000 {
But there isn't a reg property.
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt line 17
Quoted 1 line
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt new file +1
-0+ label = "apps_rsc";
Is label required?
Quoted 62 lines
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt new file +15
-0+ compatible = "qcom,rpmh-rsc"; + + apps_bcm_voter: bcm_voter { + compatible = "qcom,sdm845-bcm-voter"; + }; +} + +disp_rsc: rsc@179d0000 { + label = "disp_rsc"; + compatible = "qcom,rpmh-rsc"; + + disp_bcm_voter: bcm_voter { + compatible = "qcom,sdm845-bcm-voter"; + }; +}Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt +21
-9@@ -4,21 +4,43 @@ Qualcomm SDM845 Network-On-Chip interconnect driver binding SDM845 interconnect providers support system bandwidth requirements through RPMh hardware accelerators known as Bus Clock Manager (BCM). The provider is able to communicate with the BCM through the Resource State Coordinator (RSC) -associated with each execution environment. Provider nodes must reside within -an RPMh device node pertaining to their RSC and each provider maps to a single -RPMh resource. +associated with each execution environment. Provider nodes must point to at +least one RPMh device child node pertaining to their RSC and each provider +can map to multiple RPMh resources. Required properties : - compatible : shall contain only one of the following: - "qcom,sdm845-rsc-hlos" + "qcom,sdm845-aggre1_noc", + "qcom,sdm845-aggre2_noc", + "qcom,sdm845-config_noc", + "qcom,sdm845-dc_noc", + "qcom,sdm845-gladiator_noc", + "qcom,sdm845-mem_noc", + "qcom,sdm845-mmss_noc", + "qcom,sdm845-system_noc", - #interconnect-cells : should contain 1 +- reg : shall contain base register location and length +- qcom,bcm-voter : shall contain phandles to bcm voters Examples: -apps_rsc: rsc { - rsc_hlos: interconnect { - compatible = "qcom,sdm845-rsc-hlos"; - #interconnect-cells = <1>; - }; +aggre1_noc: interconnect@16e0000 { + compatible = "qcom,sdm845-aggre1_noc"; + reg = <0x16e0000 0xd080>; + interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; }; +mmss_noc: interconnect@1740000 { + compatible = "qcom,sdm845-mmss_noc"; + reg = <0x1740000 0x1c1000>;
Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt Qualcomm SDM845 Network-On-Chip interconnect driver binding · line 46
Quoted 10 lines
Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt +10
-0+ interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>, <&disp_bcm_voter>; +}; + +mem_noc: interconnect@1380000 { + compatible = "qcom,sdm845-mem_noc"; + reg = <0 0x1380000 0 0x27200>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>, <&disp_bcm_voter>; +};
How does a consumer target a particular RSC? For example, how can display decide to use the disp_bcm_voter node from mem_noc here? Maybe you can add that consumer to the example?
Re: [PATCH 1/2] dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings
Thanks for the feedback Stephen, much appreciated!
Quoted 23 lines · Stephen Boyd
Quoting David Dai (2019-07-19 13:32:23)
Quoted 22 lines
Redefine the Network-on-Chip devices to more accurately describe the interconnect topology on Qualcomm's SDM845 platform. Each interconnect device can communicate with different instances of the RPMh hardware which are described as RSCs(Resource State Coordinators).
Signed-off-by David Dai <[email protected]>---
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt new file +9
-0@@ -0,0 +1,32 @@ +Qualcomm BCM-Voter interconnect driver binding +----------------------------------------------------------- + +The Bus Clock Manager (BCM) is a dedicated hardware accelerator +that manages shared system resources by aggregating requests +from multiple Resource State Coordinators (RSC). Interconnect +providers are able to vote for aggregated thresholds values from +consumers by communicating through their respective RSCs. +
Quoted 8 lines
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt line 16
Quoted 7 lines
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt new file +7
-0+Required properties : +- compatible : shall contain only one of the following: + "qcom,sdm845-bcm-voter", + +Examples: + +apps_rsc: rsc@179c0000 {But there isn't a reg property.
I'll change this to the generic example with just apps_rsc: rsc {
Quoted 63 lines
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt line 17
Quoted 2 lines
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt new file +1
-0+ label = "apps_rsc";Is label required?
Quoted 59 lines
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt new file +15
-0+ compatible = "qcom,rpmh-rsc"; + + apps_bcm_voter: bcm_voter { + compatible = "qcom,sdm845-bcm-voter"; + }; +} + +disp_rsc: rsc@179d0000 { + label = "disp_rsc"; + compatible = "qcom,rpmh-rsc"; + + disp_bcm_voter: bcm_voter { + compatible = "qcom,sdm845-bcm-voter"; + }; +}Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt +18
-9@@ -4,21 +4,43 @@ Qualcomm SDM845 Network-On-Chip interconnect driver binding SDM845 interconnect providers support system bandwidth requirements through RPMh hardware accelerators known as Bus Clock Manager (BCM). The provider is able to communicate with the BCM through the Resource State Coordinator (RSC) -associated with each execution environment. Provider nodes must reside within -an RPMh device node pertaining to their RSC and each provider maps to a single -RPMh resource. +associated with each execution environment. Provider nodes must point to at +least one RPMh device child node pertaining to their RSC and each provider +can map to multiple RPMh resources. Required properties : - compatible : shall contain only one of the following: - "qcom,sdm845-rsc-hlos" + "qcom,sdm845-aggre1_noc", + "qcom,sdm845-aggre2_noc", + "qcom,sdm845-config_noc", + "qcom,sdm845-dc_noc", + "qcom,sdm845-gladiator_noc", + "qcom,sdm845-mem_noc", + "qcom,sdm845-mmss_noc", + "qcom,sdm845-system_noc", - #interconnect-cells : should contain 1 +- reg : shall contain base register location and length +- qcom,bcm-voter : shall contain phandles to bcm voters Examples: -apps_rsc: rsc { - rsc_hlos: interconnect { - compatible = "qcom,sdm845-rsc-hlos"; - #interconnect-cells = <1>; - }; +aggre1_noc: interconnect@16e0000 { + compatible = "qcom,sdm845-aggre1_noc"; + reg = <0x16e0000 0xd080>; + interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; };
Quoted 16 lines
Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt Qualcomm SDM845 Network-On-Chip interconnect driver binding · line 46
Quoted 13 lines
Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt +13
-0+mmss_noc: interconnect@1740000 { + compatible = "qcom,sdm845-mmss_noc"; + reg = <0x1740000 0x1c1000>; + interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>, <&disp_bcm_voter>; +}; + +mem_noc: interconnect@1380000 { + compatible = "qcom,sdm845-mem_noc"; + reg = <0 0x1380000 0 0x27200>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>, <&disp_bcm_voter>; +};How does a consumer target a particular RSC? For example, how can display decide to use the
disp_bcm_voternode frommem_nochere? Maybe you can add that consumer to the example?
I was thinking that the association between the bcm voters and the icc nodes would be handled by the interconnect provider, and that there would be a set of display specific icc nodes with their own unique IDs that the consumers could reference. I will mention this as part of the description and provide an example.
Ex: interconnects = <&mmss_noc MASTER_MDP0_DISP &mem_noc SLAVE_EBI_DISP>;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH 1/2] dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings
Quoting David Dai (2019-07-23 14:48:42)
Quoted 13 lines · Stephen Boyd
Quoted 8 lines
Quoting David Dai (2019-07-19 13:32:23)
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt line 16
Quoted 6 lines
+- compatible : shall contain only one of the following:
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt new file +5
-0+ "qcom,sdm845-bcm-voter", + +Examples: + +apps_rsc: rsc@179c0000 {But there isn't a reg property.
I'll change this to the generic example with just
apps_rsc: rsc {Quoted 3 lines
Quoted 2 lines
+ label = "
apps_rsc";Is label required?
Any answer?
Quoted 20 lines
Quoted 20 lines
Quoted 20 lines
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt new file +15
-0+ compatible = "qcom,rpmh-rsc"; + + apps_bcm_voter: bcm_voter { + compatible = "qcom,sdm845-bcm-voter"; + }; +} + +disp_rsc: rsc@179d0000 { + label = "disp_rsc"; + compatible = "qcom,rpmh-rsc"; + + disp_bcm_voter: bcm_voter { + compatible = "qcom,sdm845-bcm-voter"; + }; +}Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt +0
-0
[...]
Quoted 11 lines
Quoted 10 lines
Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt Qualcomm SDM845 Network-On-Chip interconnect driver binding · line 46
Quoted 7 lines
Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt +7
-0+ +mem_noc: interconnect@1380000 { + compatible = "qcom,sdm845-mem_noc"; + reg = <0 0x1380000 0 0x27200>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>, <&disp_bcm_voter>; +};How does a consumer target a particular RSC? For example, how can display decide to use the
disp_bcm_voternode frommem_nochere? Maybe you can add that consumer to the example?
Quoted 8 lines
I was thinking that the association between the bcm voters and the icc nodes would be handled by the interconnect provider, and that there would be a set of display specific icc nodes with their own unique IDs that the consumers could reference. I will mention this as part of the description and provide an example.
Ex: interconnects = <
&mmss_nocMASTER_MDP0_DISP&mem_nocSLAVE_EBI_DISP>;
It looks backwards to me. Don't the consumers want to consume a particular RSC, i.e. apps or display RSC, so they can choose where to put the bcm vote and then those RSCs want to find MMIO registers for mmss_noc or mem_noc that they have to write to tune something else like QoS? If the MMIO space is the provider then I'm lost how it can differentiate between the RSCs that may be targetting the particular NoC.
Maybe I've just completely missed something and this is all decided already. If so, sorry, I'm just trying to understand.
Re: [PATCH 1/2] dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings
Quoted 10 lines · Stephen Boyd
Quoting David Dai (2019-07-23 14:48:42)
Quoted 9 lines · Stephen Boyd
Quoted 8 lines
Quoting David Dai (2019-07-19 13:32:23)
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt line 16
Quoted 6 lines
+- compatible : shall contain only one of the following:
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt new file +5
-0+ "qcom,sdm845-bcm-voter", + +Examples: + +apps_rsc: rsc@179c0000 {But there isn't a reg property.
Quoted 4 lines
Quoted 3 lines
I'll change this to the generic example with just
apps_rsc: rsc {Quoted 2 lines
Quoted 1 line
+ label = "
apps_rsc";Is label required?
Any answer?
Not required.
Quoted 38 lines
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.txt new file +15
-0+ compatible = "qcom,rpmh-rsc"; + + apps_bcm_voter: bcm_voter { + compatible = "qcom,sdm845-bcm-voter"; + }; +} + +disp_rsc: rsc@179d0000 { + label = "disp_rsc"; + compatible = "qcom,rpmh-rsc"; + + disp_bcm_voter: bcm_voter { + compatible = "qcom,sdm845-bcm-voter"; + }; +}Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt +0
-0[...]
Quoted 10 lines
Quoted 10 lines
Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt Qualcomm SDM845 Network-On-Chip interconnect driver binding · line 46
Quoted 7 lines
Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt +7
-0+ +mem_noc: interconnect@1380000 { + compatible = "qcom,sdm845-mem_noc"; + reg = <0 0x1380000 0 0x27200>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>, <&disp_bcm_voter>; +};How does a consumer target a particular RSC? For example, how can display decide to use the
disp_bcm_voternode frommem_nochere? Maybe you can add that consumer to the example?Quoted 8 lines
I was thinking that the association between the bcm voters and the icc nodes would be handled by the interconnect provider, and that there would be a set of display specific icc nodes with their own unique IDs that the consumers could reference. I will mention this as part of the description and provide an example.
Ex: interconnects = <
&mmss_nocMASTER_MDP0_DISP&mem_nocSLAVE_EBI_DISP>;
Quoted 7 lines
It looks backwards to me. Don't the consumers want to consume a particular RSC, i.e. apps or display RSC, so they can choose where to put the bcm vote and then those RSCs want to find MMIO registers for
mmss_nocormem_nocthat they have to write to tune something else like QoS? If the MMIO space is the provider then I'm lost how it can differentiate between the RSCs that may be targetting the particular NoC.
The way that I view this is that the consumers consume both bandwidth and QoS from these physical NoC devices by getting some path between two endpoints on these different NoCs and applying some constraints. The NoC providers can accomplish that either by writing to MMIO spaces or by talking to some remote processor/hardware to tune its clock speed. The consumer doesn't interact with the RSCs directly, but can select a different bcm voter based on the endpoints that are associated with a particular bcm(apps or disp rsc). Each node(endpoints) will have its own BCM designation and an unique bcm voter.
Quoted 2 lines
Maybe I've just completely missed something and this is all decided already. If so, sorry, I'm just trying to understand.
No problem, this just means I need to do a better job of explaining.
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH 1/2] dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings
Quoting David Dai (2019-07-24 10:22:57)
Quoted 10 lines
The way that I view this is that the consumers consume both bandwidth and QoS from these physical NoC devices by getting some path between two endpoints on these different NoCs and applying some constraints. The NoC providers can accomplish that either by writing to MMIO spaces or by talking to some remote processor/hardware to tune its clock speed. The consumer doesn't interact with the RSCs directly, but can select a different bcm voter based on the endpoints that are associated with a particular bcm(apps or disp rsc). Each node(endpoints) will have its own BCM designation and an unique bcm voter.
Ok. I get it now. The MMIO nodes will be interconnect providers and they'll know what RSCs they can use by exposing the same RSC "resource" multiple times for each RSC that can be targeted? This is what the postfix is with _DISP on your examples? Presumably there's an _APPS version of the same prefixed endpoint in case the consumer wants to use the APPS RSC instead of the DISP one, or maybe there's just no postfix in this case because APPS is the "default".
Re: [PATCH 1/2] dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings
Quoted 10 lines · Stephen Boyd
Quoting David Dai (2019-07-24 10:22:57)
Quoted 9 lines
The way that I view this is that the consumers consume both bandwidth and QoS from these physical NoC devices by getting some path between two endpoints on these different NoCs and applying some constraints. The NoC providers can accomplish that either by writing to MMIO spaces or by talking to some remote processor/hardware to tune its clock speed. The consumer doesn't interact with the RSCs directly, but can select a different bcm voter based on the endpoints that are associated with a particular bcm(apps or disp rsc). Each node(endpoints) will have its own BCM designation and an unique bcm voter.
Quoted 7 lines
Ok. I get it now. The MMIO nodes will be interconnect providers and they'll know what RSCs they can use by exposing the same RSC "resource" multiple times for each RSC that can be targeted? This is what the postfix is with
_DISPon your examples? Presumably there's an_APPSversion of the same prefixed endpoint in case the consumer wants to use the APPS RSC instead of the DISP one, or maybe there's just no postfix in this case because APPS is the "default".
Right, the suffixes will denote the RSC association and will default to APPS otherwise.
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH 2/2 arm64: dts: sdm845: Redefine interconnect provider DT nodes
In reply to David DaiAdd the DT nodes for each of the Network-On-Chip interconnect buses found on SDM845 based platform and redefine the rsc_hlos child node as a bcm-voter device to better represent the hardware.
--- arch/arm64/boot/dts/qcom/sdm845.dtsi | 61 ++++++++++++++++++++++++++++++++++-- 1 file changed, 58 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/qcom/sdm845.dtsi +58 -3
@@ -610,6 +610,62 @@ #power-domain-cells = <1>; }; + aggre1_noc: interconnect@16e0000 { + compatible = "qcom,sdm845-aggre1_noc"; + reg = <0 0x16e0000 0 0xd080>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + aggre2_noc: interconnect@1700000 { + compatible = "qcom,sdm845-aggre2_noc"; + reg = <0 0x1700000 0 0x3b100>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + config_noc: interconnect@1500000 { + compatible = "qcom,sdm845-config_noc"; + reg = <0 0x1500000 0 0x5080>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + dc_noc: interconnect@14e0000 { + compatible = "qcom,sdm845-dc_noc"; + reg = <0 0x14e0000 0 0x400>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + gladiator_noc: interconnect@17900000 { + compatible = "qcom,sdm845-gladiator_noc"; + reg = <0 0x17900000 0 0xd080>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + mem_noc: interconnect@1380000 { + compatible = "qcom,sdm845-mem_noc"; + reg = <0 0x1380000 0 0x27200>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + mmss_noc: interconnect@1740000 { + compatible = "qcom,sdm845-mmss_noc"; + reg = <0 0x1740000 0 0x1c1000>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + system_noc: interconnect@1620000 { + compatible = "qcom,sdm845-system_noc"; + reg = <0 0x1620000 0 0x18080>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + qfprom@784000 { compatible = "qcom,qfprom"; reg = <0 0x00784000 0 0x8ff>;
@@ -2801,9 +2857,8 @@ }; }; - rsc_hlos: interconnect { - compatible = "qcom,sdm845-rsc-hlos"; - #interconnect-cells = <1>; + apps_bcm_voter: bcm_voter { + compatible = "qcom,sdm845-bcm-voter"; }; };
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH 2/2] arm64: dts: sdm845: Redefine interconnect provider DT nodes
Quoted 14 lines · David Dai
Add the DT nodes for each of the Network-On-Chip interconnect buses found on SDM845 based platform and redefine the
rsc_hloschild node as a bcm-voter device to better represent the hardware.Signed-off-by David Dai <[email protected]>--- arch/arm64/boot/dts/qcom/sdm845.dtsi | 61 ++++++++++++++++++++++++++++++++++-- 1 file changed, 58 insertions(+), 3 deletions(-)arch/arm64/boot/dts/qcom/sdm845.dtsi +0
-0
arch/arm64/boot/dts/qcom/sdm845.dtsi line 615
Quoted 6 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi +3
-0@@ -610,6 +610,62 @@ #power-domain-cells = <1>; }; + aggre1_noc: interconnect@16e0000 { + compatible = "qcom,sdm845-aggre1_noc"; + reg = <0 0x16e0000 0 0xd080>;
Please pad the address to 8 digits and keep nodes sorted by address.
Quoted 17 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi +17
-0+ #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + aggre2_noc: interconnect@1700000 { + compatible = "qcom,sdm845-aggre2_noc"; + reg = <0 0x1700000 0 0x3b100>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + config_noc: interconnect@1500000 { + compatible = "qcom,sdm845-config_noc"; + reg = <0 0x1500000 0 0x5080>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + };
[..]
arch/arm64/boot/dts/qcom/sdm845.dtsi line 2860
Quoted 11 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi +1
-3qfprom@784000 { compatible = "qcom,qfprom"; reg = <0 0x00784000 0 0x8ff>;@@ -2801,9 +2857,8 @@ }; }; - rsc_hlos: interconnect { - compatible = "qcom,sdm845-rsc-hlos"; - #interconnect-cells = <1>; + apps_bcm_voter: bcm_voter {
No '_' in node names, so bcm-voter.
Apart from this nits this looks good.
Regards,
Bjorn
Quoted 8 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi +1
-0+ compatible = "qcom,sdm845-bcm-voter"; }; };Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH 2/2] arm64: dts: sdm845: Redefine interconnect provider DT nodes
Thanks for looking over this, Bjorn.
Quoted 19 lines · Bjorn Andersson
Quoted 17 lines · David Dai
Add the DT nodes for each of the Network-On-Chip interconnect buses found on SDM845 based platform and redefine the
rsc_hloschild node as a bcm-voter device to better represent the hardware.Signed-off-by David Dai <[email protected]>--- arch/arm64/boot/dts/qcom/sdm845.dtsi | 61 ++++++++++++++++++++++++++++++++++-- 1 file changed, 58 insertions(+), 3 deletions(-)arch/arm64/boot/dts/qcom/sdm845.dtsi +0
-0@@ -610,6 +610,62 @@ #power-domain-cells = <1>; };
Quoted 4 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi line 615
Quoted 3 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi +3
-0+ aggre1_noc: interconnect@16e0000 { + compatible = "qcom,sdm845-aggre1_noc"; + reg = <0 0x16e0000 0 0xd080>;Please pad the address to 8 digits and keep nodes sorted by address.
Will fix.
Quoted 25 lines
Quoted 17 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi +17
-0+ #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + aggre2_noc: interconnect@1700000 { + compatible = "qcom,sdm845-aggre2_noc"; + reg = <0 0x1700000 0 0x3b100>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + config_noc: interconnect@1500000 { + compatible = "qcom,sdm845-config_noc"; + reg = <0 0x1500000 0 0x5080>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + };[..]
Quoted 7 lines
qfprom@784000 { compatible = "qcom,qfprom"; reg = <0 0x00784000 0 0x8ff>;arch/arm64/boot/dts/qcom/sdm845.dtsi +0
-0@@ -2801,9 +2857,8 @@ }; };
Quoted 5 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi line 2860
Quoted 4 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi +1
-3- rsc_hlos: interconnect { - compatible = "qcom,sdm845-rsc-hlos"; - #interconnect-cells = <1>; + apps_bcm_voter: bcm_voter {No '_' in node names, so bcm-voter.
Ok.
Quoted 14 lines
Apart from this nits this looks good.
Regards,
BjornQuoted 8 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi +1
-0+ compatible = "qcom,sdm845-bcm-voter"; }; };Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH 2/2] arm64: dts: sdm845: Redefine interconnect provider DT nodes
Quoted 15 lines · David Dai
Thanks for looking over this, Bjorn.
Quoted 11 lines · Bjorn Andersson
Quoted 9 lines · David Dai
Add the DT nodes for each of the Network-On-Chip interconnect buses found on SDM845 based platform and redefine the
rsc_hloschild node as a bcm-voter device to better represent the hardware.Signed-off-by David Dai <[email protected]>--- arch/arm64/boot/dts/qcom/sdm845.dtsi | 61 ++++++++++++++++++++++++++++++++++-- 1 file changed, 58 insertions(+), 3 deletions(-)
What happened to this series? Is it abandoned?
-Evan