clk: fractional-divider: Use bit operations consistently
PATCH 1/1 clk: fractional-divider: Use bit operations consistently
Use BIT() where makes sense. This alings usage of bit operations in the same pieces of code. Moreover, strictly speaking by the letter of the C standard, left shift of 1 by 31 bits is UB (undefined behaviour), switching to BIT() addresses that as well.
--- drivers/clk/clk-fractional-divider.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/clk/clk-fractional-divider.c +4 -4
@@ -140,8 +140,8 @@ void clk_fractional_divider_general_approximation(struct clk_hw *hw, }if (fd->flags &CLK_FRAC_DIVIDER_ZERO_BASED ) { - max_m =1 << fd->mwidth; - max_n =1 << fd->nwidth; + max_m =BIT (fd->mwidth); + max_n =BIT (fd->nwidth); }else { max_m =GENMASK (fd->mwidth -1 ,0 ); max_n =GENMASK (fd->nwidth -1 ,0 );
@@ -182,8 +182,8 @@ static int clk_fd_set_rate(struct clk_hw *hw, unsigned long rate,u32 val;if (fd->flags &CLK_FRAC_DIVIDER_ZERO_BASED ) { - max_m =1 << fd->mwidth; - max_n =1 << fd->nwidth; + max_m =BIT (fd->mwidth); + max_n =BIT (fd->nwidth); }else { max_m =GENMASK (fd->mwidth -1 ,0 ); max_n =GENMASK (fd->nwidth -1 ,0 );
Signature · 1 line
2.44.0
Quoted 7 lines · Andy Shevchenko
Use
BIT()where makes sense. This alings usage of bit operations in the same pieces of code. Moreover, strictly speaking by the letter of the C standard, left shift of 1 by 31 bits is UB (undefined behaviour), switching toBIT()addresses that as well.Signed-off-by Andy Shevchenko <[email protected]>
Quoting Andy Shevchenko (2024-03-03 04:07:32)
Quoted 7 lines
Use
BIT()where makes sense. This alings usage of bit operations in the same pieces of code. Moreover, strictly speaking by the letter of the C standard, left shift of 1 by 31 bits is UB (undefined behaviour), switching toBIT()addresses that as well.Signed-off-by Andy Shevchenko <[email protected]>---
Applied to clk-next