Skip to contentSkip to conversation

buildtools/map_to_def.py: drop python2 support

PATCH Superseded Bruce Richardson 2 participants 5 messages May 13, 2020 – Aug 28, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 buildtools/map_to_def.py: drop python2 support

The build scripts called from meson all use python3 as meson itself depends upon python3. Therefore there is no need for python2 compatibility in these script files.

---
 buildtools/map_to_def.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
buildtools/map_to_def.py +1 -2
index 6775b54a9..9edde7a67 100644
@@ -1,8 +1,7 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2019 Intel Corporation
 
-from __future__ import print_function
 import sys
 from os.path import dirname, basename, join, exists
 
Signature · 1 line
2.20.1
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Bruce Richardson

The build scripts called from meson all use python3 as meson itself depends upon python3. Therefore there is no need for python2 compatibility in these script files.

---

I think there was a reimplementation of check_output there that isn't necessary any more either. (and hasn't been for some time...)

Otherwise,

Signature · 2 lines
Thanks,
Anatoly
#2 lore raw
Quoted 11 lines · Anatoly
Quoted 6 lines · Bruce Richardson

The build scripts called from meson all use python3 as meson itself depends upon python3. Therefore there is no need for python2 compatibility in these script files.

---

I think there was a reimplementation of check_output there that isn't necessary any more either. (and hasn't been for some time...)

Not sure what you are referring to here. Perhaps a different script file?

#3 lore raw
Quoted 6 lines · Bruce Richardson
Quoted 5 lines · Anatoly
Quoted 4 lines · Bruce Richardson

The build scripts called from meson all use python3 as meson itself depends upon python3. Therefore there is no need for python2 compatibility in these script files.

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

---

I think there was a reimplementation of check_output there that isn't necessary any more either. (and hasn't been for some time...)

Not sure what you are referring to here. Perhaps a different script file?

Oh, sorry, yes. I slightly misread the patch description :)

Signature · 2 lines
Thanks,
Anatoly
#4 lore raw

PATCH v2 1/1 buildtools/map_to_win.py: drop python2 support

In reply to Bruce Richardson

The build scripts called from meson all use python3 as meson itself depends upon python3. Therefore there is no need for python2 compatibility in these script files, as well as which python2 support is being dropped generally from DPDK.

---
V2: rebased for 20.11, since this script is not covered by set

    http://patches.dpdk.org/project/dpdk/list/?series=11739
---
 buildtools/map_to_win.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
buildtools/map_to_win.py +1 -2
index 2990b58634..2a6cb88605 100644
@@ -1,8 +1,7 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2019 Intel Corporation
 
-from __future__ import print_function
 import sys
 from os.path import dirname, basename, join, exists
 
Signature · 1 line
2.25.1