Skip to contentSkip to conversation

drm/nouveau/nvkm: do not use assignment in if condition

PATCH In review [email protected] 2 participants 3 messages Jul 10, 2023 – Jul 13, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drm/nouveau/nvkm: do not use assignment in if condition

Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning:

ERROR: do not use assignment in if condition

---
 drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c +2 -1
index 976539de4220..054fa42f1d04 100644
@@ -286,7 +286,8 @@ nvkm_i2c_new_(const struct nvkm_i2c_func *func, struct nvkm_device *device,
 
         if (ccbE.share != DCB_I2C_UNUSED) {
             const int id = NVKM_I2C_PAD_HYBRID(ccbE.share);
-            if (!(pad = nvkm_i2c_pad_find(i2c, id)))
+            pad = nvkm_i2c_pad_find(i2c, id);
+            if (!pad)
                 ret = func->pad_s_new(i2c, id, &pad);
             else
                 ret = 0;
Reviewed-by on v1 1/1
#2 lore raw
Quoted 26 lines · On Mon, Jul 10, 2023 at 9:23 AM <[email protected]> wrote:

Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning:

ERROR: do not use assignment in if condition

---
  drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c +2 -1
index 976539de4220..054fa42f1d04 100644
@@ -286,7 +286,8 @@ nvkm_i2c_new_(const struct nvkm_i2c_func *func,
 struct nvkm_device *device,
 
          if (ccbE.share != DCB_I2C_UNUSED) {
              const int id = NVKM_I2C_PAD_HYBRID(ccbE.share);
-            if (!(pad = nvkm_i2c_pad_find(i2c, id)))
+            pad = nvkm_i2c_pad_find(i2c, id);
+            if (!pad)
                  ret = func->pad_s_new(i2c, id, &pad);
              else
Quoted 2 lines
                  ret = 0;
#3 lore raw

PATCH 1/1 drm/nouveau/nvkm: do not use assignment in if condition

In reply to a message not in the archive

Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning:

ERROR: do not use assignment in if condition

---
 drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c +2 -1
index 976539de4220..054fa42f1d04 100644
@@ -286,7 +286,8 @@ nvkm_i2c_new_(const struct nvkm_i2c_func *func, struct nvkm_device *device,
 
         if (ccbE.share != DCB_I2C_UNUSED) {
             const int id = NVKM_I2C_PAD_HYBRID(ccbE.share);
-            if (!(pad = nvkm_i2c_pad_find(i2c, id)))
+            pad = nvkm_i2c_pad_find(i2c, id);
+            if (!pad)
                 ret = func->pad_s_new(i2c, id, &pad);
             else
                 ret = 0;