Skip to contentSkip to conversation

libldb: add pam to REQUIRED_DISTRO_FEATURES

PATCH In review Martin Jansa 5 participants 8 messages Sep 27, 2018 – Oct 10, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libldb: add pam to REQUIRED_DISTRO_FEATURES

* dependency on samba was added recently in:
libldb: Add samba to rdeps for pyldb
so now we need to match samba restriction to prevent:

ERROR: Nothing RPROVIDES 'samba' (but meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb RDEPENDS on or otherwise requires it) samba was skipped: missing required distro feature 'pam' (not in DISTRO_FEATURES)
NOTE: Runtime target 'samba' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['samba']
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'libldb', 'samba']

---
 meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-networking/recipes-support/libldb/libldb_1.4.1.bb +2 -1
index 99e62f66bb..3c7e5455e9 100644
@@ -35,7 +35,8 @@ LIC_FILES_CHKSUM = "file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada
 SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
 SRC_URI[sha256sum] = "2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"
 
-inherit waf-samba
+inherit waf-samba distro_features_check
+REQUIRED_DISTRO_FEATURES = "pam"
 
 S = "${WORKDIR}/ldb-${PV}"
 
Signature · 1 line
2.17.1
#1 lore raw

Could you explain commit 0db9697dc6b8c a little bit, where libpam became a distro requirement for samba itself? I'm not sure why pam is a hard requirement, rather than being PACKAGECONFIG option. I haven't tried the server ipk built with --without-pam but the client-side pieces are certainly useful. I've got a bbappend to override the pam forcing, and was just wondering if this change might be upstreamable.

Quoted 38 lines · Martin Jansa

* dependency on samba was added recently in:
libldb: Add samba to rdeps for pyldb
so now we need to match samba restriction to prevent:

ERROR: Nothing RPROVIDES 'samba' (but meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb RDEPENDS on or otherwise requires it) samba was skipped: missing required distro feature 'pam' (not in DISTRO_FEATURES)
NOTE: Runtime target 'samba' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['samba']
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'libldb', 'samba']

---
 meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-networking/recipes-support/libldb/libldb_1.4.1.bb +2 -1
index 99e62f66bb..3c7e5455e9 100644
@@ -35,7 +35,8 @@ LIC_FILES_CHKSUM = "file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada
 SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
 SRC_URI[sha256sum] = "2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"
 
-inherit waf-samba
+inherit waf-samba distro_features_check
+REQUIRED_DISTRO_FEATURES = "pam"
 
 S = "${WORKDIR}/ldb-${PV}"
 
Signature · 7 lines
2.17.1

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
#2 lore raw
Quoted 7 lines · S. Lockwood-Childs

Could you explain commit 0db9697dc6b8c a little bit, where libpam became a distro requirement for samba itself? I'm not sure why pam is a hard requirement, rather than being PACKAGECONFIG option. I haven't tried the server ipk built with --without-pam but the client-side pieces are certainly useful. I've got a bbappend to override the pam forcing, and was just wondering if this change might be upstreamable.

its lack of fine grained packaging that this was needed. If you can sort this out then I am all ears

Quoted 45 lines · Martin Jansa
Quoted 33 lines

* dependency on samba was added recently in:
libldb: Add samba to rdeps for pyldb
so now we need to match samba restriction to prevent:

ERROR: Nothing RPROVIDES 'samba' (but meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb RDEPENDS on or otherwise requires it) samba was skipped: missing required distro feature 'pam' (not in DISTRO_FEATURES)
NOTE: Runtime target 'samba' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['samba']
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'libldb', 'samba']

---
 meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-networking/recipes-support/libldb/libldb_1.4.1.bb +2 -2
index 99e62f66bb..3c7e5455e9 100644
@@ -35,7 +35,8 @@ LIC_FILES_CHKSUM = "file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada
 SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
 SRC_URI[sha256sum] = "2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"
 
-inherit waf-samba
+inherit waf-samba distro_features_check
+REQUIRED_DISTRO_FEATURES = "pam"
 
 S = "${WORKDIR}/ldb-${PV}"
 
--

2.17.1

Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#3 lore raw
Quoted 11 lines · Khem Raj
Quoted 7 lines · S. Lockwood-Childs

Could you explain commit 0db9697dc6b8c a little bit, where libpam became a distro requirement for samba itself? I'm not sure why pam is a hard requirement, rather than being PACKAGECONFIG option. I haven't tried the server ipk built with --without-pam but the client-side pieces are certainly useful. I've got a bbappend to override the pam forcing, and was just wondering if this change might be upstreamable.

its lack of fine grained packaging that this was needed. If you can sort this out then I am all ears

What are the packaging problems to be solved when pam support is disabled?

Like I said we're only running the client-side stuff so far, so I'm guessing the problems came up in server-side packages. There were no build errors from --without-pam at least.

Quoted 46 lines
Quoted 46 lines · Martin Jansa
Quoted 33 lines

* dependency on samba was added recently in:
libldb: Add samba to rdeps for pyldb
so now we need to match samba restriction to prevent:

ERROR: Nothing RPROVIDES 'samba' (but meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb RDEPENDS on or otherwise requires it) samba was skipped: missing required distro feature 'pam' (not in DISTRO_FEATURES)
NOTE: Runtime target 'samba' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['samba']
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'libldb', 'samba']

---
 meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-networking/recipes-support/libldb/libldb_1.4.1.bb +2 -2
index 99e62f66bb..3c7e5455e9 100644
@@ -35,7 +35,8 @@ LIC_FILES_CHKSUM = "file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada
 SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
 SRC_URI[sha256sum] = "2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"
 
-inherit waf-samba
+inherit waf-samba distro_features_check
+REQUIRED_DISTRO_FEATURES = "pam"
 
 S = "${WORKDIR}/ldb-${PV}"
 
--

2.17.1

Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#4 lore raw

It depends on pam DISTRO_FEATURES, because it depends on libpam since:
commit a95726df4bb1c898da7e4d4dbf9e2846914061e4

Author: Andreas Müller <[email protected]>
Date:   Sat Sep 17 12:04:42 2016 +0200

samba: replace pam packageconfig by hard dependency

samba links against libpam even if pam is not in packageconfig and
libpam was
built before. This patch avoid this floating dependency - other
solution could
not be found. For those who want packageconfig back, see discussion iat
[1] for

    further inspiration.

    [1]

http://lists.openembedded.org/pipermail/openembedded-devel/2016-September/109143.html

Quoted 81 lines · S. Lockwood-Childs
Quoted 1 line · Khem Raj

On Fri, Sep 28, 2018 at 1:19 PM S. Lockwood-Childs <[email protected]>

Quoted 2 lines · wrote:
Quoted 2 lines

Could you explain commit 0db9697dc6b8c a little bit, where libpam

became a

Quoted 2 lines
Quoted 2 lines

distro requirement for samba itself? I'm not sure why pam is a hard requirement, rather than being PACKAGECONFIG option. I haven't tried

the server

Quoted 1 line
Quoted 1 line

ipk built with --without-pam but the client-side pieces are certainly

useful.

Quoted 1 line
Quoted 1 line

I've got a bbappend to override the pam forcing, and was just

wondering if

Quoted 4 lines
Quoted 1 line

this change might be upstreamable.

its lack of fine grained packaging that this was needed. If you can sort this out then I am all ears

What are the packaging problems to be solved when pam support is disabled?

Like I said we're only running the client-side stuff so far, so I'm guessing
the problems came up in server-side packages. There were no build errors from
--without-pam at least.

Quoted 8 lines
Quoted 8 lines · Martin Jansa
Quoted 5 lines

* dependency on samba was added recently in:
libldb: Add samba to rdeps for pyldb
so now we need to match samba restriction to prevent:

ERROR: Nothing RPROVIDES 'samba' (but

meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb RDEPENDS on or otherwise requires it)

Quoted 1 line
Quoted 1 line
Quoted 1 line

samba was skipped: missing required distro feature 'pam' (not in

DISTRO_FEATURES)

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

NOTE: Runtime target 'samba' is unbuildable, removing... Missing or unbuildable dependency chain was: ['samba']
ERROR: Required build target 'meta-world-pkgdata' has no buildable

providers.

Quoted 1 line
Quoted 1 line
Quoted 1 line

Missing or unbuildable dependency chain was: ['meta-world-pkgdata',

'libldb', 'samba']

Quoted 7 lines
Quoted 7 lines

Review

Quoted 7 lines
---
 meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb

Quoted 4 lines
Quoted 4 lines

meta-networking/recipes-support/libldb/libldb_1.4.1.bb LIC_FILES_CHKSUM =

Quoted 4 lines

index 99e62f66bb..3c7e5455e9 100644

meta-networking/recipes-support/libldb/libldb_1.4.1.bb +0 -0
@@ -35,7 +35,8 @@ LIC_FILES_CHKSUM =

"file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada

Quoted 2 lines
Quoted 2 lines

meta-networking/recipes-support/libldb/libldb_1.4.1.bb LIC_FILES_CHKSUM = · line 36

Quoted 2 lines
meta-networking/recipes-support/libldb/libldb_1.4.1.bb +0 -0
 SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
 SRC_URI[sha256sum] =

"2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"

Quoted 20 lines
Quoted 20 lines
Quoted 10 lines
meta-networking/recipes-support/libldb/libldb_1.4.1.bb +2 -2
-inherit waf-samba
+inherit waf-samba distro_features_check
+REQUIRED_DISTRO_FEATURES = "pam"
 
 S = "${WORKDIR}/ldb-${PV}"
 
--

2.17.1

Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#5 lore raw

Ok, so after reading the thread mentioned below, the actual problem seems to be that if libpam has been built (e.g., because pam is included in DISTRO_FEATURES), then samba will link with it even if --without-pam is specified? This seems like something that can be fixed. Because when building without pam in DISTRO_FEATURES (as we do), then it does not seem to be a problem to build samba with --without-pam and having it work as expected. In our case, the REQUIRED_DISTRO_FEATURES = "pam" in the samba recipe is more of a problem...

//Peter

Quoted 136 lines

-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Martin Jansa
Sent: den 29 september 2018 09:45
To: S. Lockwood-Childs <[email protected]>; Khem Raj <[email protected]>; openembedded-devel <openembedded- [email protected]>
Subject: Re: [oe] [meta-networking][PATCH] libldb: add pam to REQUIRED_DISTRO_FEATURES

It depends on pam DISTRO_FEATURES, because it depends on libpam since:
commit a95726df4bb1c898da7e4d4dbf9e2846914061e4

Author: Andreas Müller <[email protected]>
Date:   Sat Sep 17 12:04:42 2016 +0200

samba: replace pam packageconfig by hard dependency

samba links against libpam even if pam is not in packageconfig and
libpam was
built before. This patch avoid this floating dependency - other
solution could
not be found. For those who want packageconfig back, see discussion
iat
[1] for

    further inspiration.

    [1]

http://lists.openembedded.org/pipermail/openembedded-devel/2016-
September/109143.html

Quoted 2 lines · S. Lockwood-Childs
Quoted 1 line · Khem Raj

On Fri, Sep 28, 2018 at 1:19 PM S. Lockwood-Childs

<[email protected]>

Quoted 5 lines
Quoted 2 lines · wrote:
Quoted 2 lines

Could you explain commit 0db9697dc6b8c a little bit, where libpam

became a

Quoted 1 line
Quoted 1 line

distro requirement for samba itself? I'm not sure why pam is a

hard

Quoted 1 line
Quoted 1 line
Quoted 1 line

requirement, rather than being PACKAGECONFIG option. I haven't

tried

Quoted 2 lines

the server

Quoted 1 line
Quoted 1 line

ipk built with --without-pam but the client-side pieces are

certainly

Quoted 9 lines

useful.

Quoted 1 line
Quoted 1 line

I've got a bbappend to override the pam forcing, and was just

wondering if

Quoted 4 lines
Quoted 1 line

this change might be upstreamable.

its lack of fine grained packaging that this was needed. If you can sort this out then I am all ears

What are the packaging problems to be solved when pam support is

disabled?

Quoted 4 lines

Like I said we're only running the client-side stuff so far, so I'm guessing
the problems came up in server-side packages. There were no build

errors

Quoted 5 lines

from
--without-pam at least.

Quoted 2 lines
Quoted 2 lines
Quoted 7 lines
Quoted 6 lines
Quoted 6 lines · Martin Jansa
Quoted 5 lines

* dependency on samba was added recently in:
libldb: Add samba to rdeps for pyldb
so now we need to match samba restriction to prevent:

ERROR: Nothing RPROVIDES 'samba' (but

meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb

RDEPENDS

Quoted 2 lines

on or otherwise requires it)

Quoted 1 line
Quoted 1 line
Quoted 1 line

samba was skipped: missing required distro feature 'pam' (not

in

Quoted 4 lines

DISTRO_FEATURES)

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

NOTE: Runtime target 'samba' is unbuildable, removing... Missing or unbuildable dependency chain was: ['samba']
ERROR: Required build target 'meta-world-pkgdata' has no

buildable

Quoted 2 lines

providers.

Quoted 1 line
Quoted 1 line
Quoted 1 line

Missing or unbuildable dependency chain was: ['meta-world-

pkgdata',

Quoted 8 lines

'libldb', 'samba']

Quoted 7 lines
Quoted 7 lines

Review

Quoted 7 lines
---
 meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

support/libldb/libldb_1.4.1.bb

Quoted 16 lines

b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb

Quoted 4 lines
Quoted 4 lines

meta-networking/recipes-support/libldb/libldb_1.4.1.bb LIC_FILES_CHKSUM =

Quoted 4 lines

index 99e62f66bb..3c7e5455e9 100644

meta-networking/recipes-support/libldb/libldb_1.4.1.bb +0 -0
@@ -35,7 +35,8 @@ LIC_FILES_CHKSUM =

"file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada

Quoted 2 lines
Quoted 2 lines

meta-networking/recipes-support/libldb/libldb_1.4.1.bb LIC_FILES_CHKSUM = · line 36

Quoted 2 lines
meta-networking/recipes-support/libldb/libldb_1.4.1.bb +0 -0
 SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
 SRC_URI[sha256sum] =

"2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
meta-networking/recipes-support/libldb/libldb_1.4.1.bb +2 -1
-inherit waf-samba
+inherit waf-samba distro_features_check
+REQUIRED_DISTRO_FEATURES = "pam"
 
 S = "${WORKDIR}/ldb-${PV}"
 
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta-networking/recipes-support/libldb/libldb_1.4.1.bb +0 -1
--

2.17.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-

devel

Quoted 6 lines
Quoted 5 lines
Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#6 lore raw
Quoted 5 lines · Peter Kjellerstedt

Ok, so after reading the thread mentioned below, the actual problem seems to be that if libpam has been built (e.g., because pam is included in DISTRO_FEATURES), then samba will link with it even if --without-pam is specified? This seems like something that can be fixed.

Patches are surely welcome for that. There are at least 2 WIP patches trying to do that, but neither worked.

Before oe-core c9e7a276859d38aaa03845ee09428f62760ad147 it was even worse, because libpam could be built even without pam in DISTRO_FEATUREs.

Quoted 144 lines

Because when building without pam in DISTRO_FEATURES (as we do), then it does not seem to be a problem to build samba with --without-pam and having it work as expected. In our case, the REQUIRED_DISTRO_FEATURES = "pam" in the samba recipe is more of a problem...

//Peter

Quoted 136 lines

-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Martin Jansa
Sent: den 29 september 2018 09:45
To: S. Lockwood-Childs <[email protected]>; Khem Raj <[email protected]>; openembedded-devel <openembedded- [email protected]>
Subject: Re: [oe] [meta-networking][PATCH] libldb: add pam to REQUIRED_DISTRO_FEATURES

It depends on pam DISTRO_FEATURES, because it depends on libpam since:
commit a95726df4bb1c898da7e4d4dbf9e2846914061e4

Author: Andreas Müller <[email protected]>
Date:   Sat Sep 17 12:04:42 2016 +0200

samba: replace pam packageconfig by hard dependency

samba links against libpam even if pam is not in packageconfig and
libpam was
built before. This patch avoid this floating dependency - other
solution could
not be found. For those who want packageconfig back, see discussion
iat
[1] for

    further inspiration.

    [1]

http://lists.openembedded.org/pipermail/openembedded-devel/2016-
September/109143.html

Quoted 2 lines · S. Lockwood-Childs
Quoted 1 line · Khem Raj

On Fri, Sep 28, 2018 at 1:19 PM S. Lockwood-Childs

<[email protected]>

Quoted 5 lines
Quoted 2 lines · wrote:
Quoted 2 lines

Could you explain commit 0db9697dc6b8c a little bit, where libpam

became a

Quoted 1 line
Quoted 1 line

distro requirement for samba itself? I'm not sure why pam is a

hard

Quoted 1 line
Quoted 1 line
Quoted 1 line

requirement, rather than being PACKAGECONFIG option. I haven't

tried

Quoted 2 lines

the server

Quoted 1 line
Quoted 1 line

ipk built with --without-pam but the client-side pieces are

certainly

Quoted 9 lines

useful.

Quoted 1 line
Quoted 1 line

I've got a bbappend to override the pam forcing, and was just

wondering if

Quoted 4 lines
Quoted 1 line

this change might be upstreamable.

its lack of fine grained packaging that this was needed. If you can sort this out then I am all ears

What are the packaging problems to be solved when pam support is

disabled?

Quoted 4 lines

Like I said we're only running the client-side stuff so far, so I'm guessing
the problems came up in server-side packages. There were no build

errors

Quoted 5 lines

from
--without-pam at least.

Quoted 2 lines
Quoted 2 lines
Quoted 7 lines
Quoted 6 lines
Quoted 6 lines · Martin Jansa
Quoted 5 lines

* dependency on samba was added recently in:
libldb: Add samba to rdeps for pyldb
so now we need to match samba restriction to prevent:

ERROR: Nothing RPROVIDES 'samba' (but

meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb

RDEPENDS

Quoted 2 lines

on or otherwise requires it)

Quoted 1 line
Quoted 1 line
Quoted 1 line

samba was skipped: missing required distro feature 'pam' (not

in

Quoted 4 lines

DISTRO_FEATURES)

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

NOTE: Runtime target 'samba' is unbuildable, removing... Missing or unbuildable dependency chain was: ['samba']
ERROR: Required build target 'meta-world-pkgdata' has no

buildable

Quoted 2 lines

providers.

Quoted 1 line
Quoted 1 line
Quoted 1 line

Missing or unbuildable dependency chain was: ['meta-world-

pkgdata',

Quoted 8 lines

'libldb', 'samba']

Quoted 7 lines
Quoted 7 lines

Review

Quoted 7 lines
---
 meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

support/libldb/libldb_1.4.1.bb

Quoted 16 lines

b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb

Quoted 4 lines
Quoted 4 lines

meta-networking/recipes-support/libldb/libldb_1.4.1.bb LIC_FILES_CHKSUM =

Quoted 4 lines

index 99e62f66bb..3c7e5455e9 100644

meta-networking/recipes-support/libldb/libldb_1.4.1.bb +0 -0
@@ -35,7 +35,8 @@ LIC_FILES_CHKSUM =

"file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada

Quoted 2 lines
Quoted 2 lines

meta-networking/recipes-support/libldb/libldb_1.4.1.bb LIC_FILES_CHKSUM = · line 36

Quoted 2 lines
meta-networking/recipes-support/libldb/libldb_1.4.1.bb +0 -0
 SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
 SRC_URI[sha256sum] =

"2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
meta-networking/recipes-support/libldb/libldb_1.4.1.bb +2 -1
-inherit waf-samba
+inherit waf-samba distro_features_check
+REQUIRED_DISTRO_FEATURES = "pam"
 
 S = "${WORKDIR}/ldb-${PV}"
 
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta-networking/recipes-support/libldb/libldb_1.4.1.bb +0 -1
--

2.17.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-

devel

Quoted 6 lines
Quoted 5 lines
Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#7 lore raw
In reply to Martin Jansa

Hi Martin,

Quoted 7 lines · Martin Jansa

It depends on pam DISTRO_FEATURES, because it depends on libpam since:
commit a95726df4bb1c898da7e4d4dbf9e2846914061e4

Author: Andreas Müller <[email protected]>
Date:   Sat Sep 17 12:04:42 2016 +0200

samba: replace pam packageconfig by hard dependency

Quoted 7 lines

samba links against libpam even if pam is not in packageconfig and
libpam was
built before. This patch avoid this floating dependency - other
solution could
not be found. For those who want packageconfig back, see discussion iat
[1] for
further inspiration.

Hasn't this fix (from 2016) been obsoleted by recipe-specific-sysroots?

// Martin

Quoted 91 lines
     [1]

http://lists.openembedded.org/pipermail/openembedded-devel/2016-September/109143.html

Quoted 81 lines · S. Lockwood-Childs
Quoted 1 line · Khem Raj

On Fri, Sep 28, 2018 at 1:19 PM S. Lockwood-Childs <[email protected]>

Quoted 2 lines · wrote:
Quoted 2 lines

Could you explain commit 0db9697dc6b8c a little bit, where libpam

became a

Quoted 2 lines
Quoted 2 lines

distro requirement for samba itself? I'm not sure why pam is a hard requirement, rather than being PACKAGECONFIG option. I haven't tried

the server

Quoted 1 line
Quoted 1 line

ipk built with --without-pam but the client-side pieces are certainly

useful.

Quoted 1 line
Quoted 1 line

I've got a bbappend to override the pam forcing, and was just

wondering if

Quoted 4 lines
Quoted 1 line

this change might be upstreamable.

its lack of fine grained packaging that this was needed. If you can sort this out then I am all ears

What are the packaging problems to be solved when pam support is disabled?

Like I said we're only running the client-side stuff so far, so I'm guessing
the problems came up in server-side packages. There were no build errors from
--without-pam at least.

Quoted 8 lines
Quoted 8 lines · Martin Jansa
Quoted 5 lines

* dependency on samba was added recently in:
libldb: Add samba to rdeps for pyldb
so now we need to match samba restriction to prevent:

ERROR: Nothing RPROVIDES 'samba' (but

meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb RDEPENDS on or otherwise requires it)

Quoted 1 line
Quoted 1 line
Quoted 1 line

samba was skipped: missing required distro feature 'pam' (not in

DISTRO_FEATURES)

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

NOTE: Runtime target 'samba' is unbuildable, removing... Missing or unbuildable dependency chain was: ['samba']
ERROR: Required build target 'meta-world-pkgdata' has no buildable

providers.

Quoted 1 line
Quoted 1 line
Quoted 1 line

Missing or unbuildable dependency chain was: ['meta-world-pkgdata',

'libldb', 'samba']

Quoted 7 lines
Quoted 7 lines

Review

Quoted 7 lines
---
  meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb

Quoted 4 lines
Quoted 4 lines

meta-networking/recipes-support/libldb/libldb_1.4.1.bb LIC_FILES_CHKSUM =

Quoted 4 lines

index 99e62f66bb..3c7e5455e9 100644

meta-networking/recipes-support/libldb/libldb_1.4.1.bb +0 -0
@@ -35,7 +35,8 @@ LIC_FILES_CHKSUM =

"file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada

Quoted 2 lines
Quoted 2 lines

meta-networking/recipes-support/libldb/libldb_1.4.1.bb LIC_FILES_CHKSUM = · line 36

Quoted 2 lines
meta-networking/recipes-support/libldb/libldb_1.4.1.bb +0 -0
  SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
  SRC_URI[sha256sum] =

"2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"

Quoted 20 lines
Quoted 20 lines
Quoted 10 lines
meta-networking/recipes-support/libldb/libldb_1.4.1.bb +2 -2
-inherit waf-samba
+inherit waf-samba distro_features_check
+REQUIRED_DISTRO_FEATURES = "pam"
 
  S = "${WORKDIR}/ldb-${PV}"
 
--

2.17.1

Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 10 lines
Kind regards,
Martin Hundebøll
Embedded Linux Consultant

+45 61 65 54 61
[email protected]

Geanix IVS
https://geanix.com
DK39600706