Skip to contentSkip to conversation

net: smc911x: Drop the standalone EEPROM example

RFC PATCH New Marek Vasut 4 participants 15 messages Mar 14, 2020 – Jun 12, 2020 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 net: smc911x: Drop the standalone EEPROM example

Drop the example, for two reasons. First, it is tapping directly into the IO accessors of the SMC911x, while it should instead go through the net device API. Second, this makes conversion of the SMC911x driver to DM real hard.

Cc Joe Hershberger <[email protected]>
Cc Tom Rini <[email protected]>
---
 examples/standalone/Makefile         |   1 -
 examples/standalone/smc911x_eeprom.c | 379 ---------------------------
 2 files changed, 380 deletions(-)
 delete mode 100644 examples/standalone/smc911x_eeprom.c
examples/standalone/Makefile +0 -1
index 0b17a91804..5c8d56c92c 100644
@@ -5,7 +5,6 @@
 
 extra-y        := hello_world
 extra-$(CONFIG_SMC91111)           += smc91111_eeprom
-extra-$(CONFIG_SMC911X)            += smc911x_eeprom
 extra-$(CONFIG_SPI_FLASH_ATMEL)    += atmel_df_pow2
 extra-$(CONFIG_PPC)                += sched
 
examples/standalone/smc911x_eeprom.c deleted +0 -379

379 lines not on this page · raw message

Signature · 1 line
2.25.0
#1 lore raw

RFC PATCH 1/1 net: smc911x: Drop the standalone EEPROM example

Quoted 9 lines · Marek Vasut

Drop the example, for two reasons. First, it is tapping directly into the IO accessors of the SMC911x, while it should instead go through the net device API. Second, this makes conversion of the SMC911x driver to DM real hard.

Cc Joe Hershberger <[email protected]>
Cc Tom Rini <[email protected]>
#2 lore raw

RFC PATCH 1/1 net: smc911x: Drop the standalone EEPROM example

In reply to Marek Vasut
Quoted 6 lines · Marek Vasut

Drop the example, for two reasons. First, it is tapping directly into the IO accessors of the SMC911x, while it should instead go through the net device API. Second, this makes conversion of the SMC911x driver to DM real hard.

Quoted 8 lines
Cc Joe Hershberger <[email protected]>
Cc Tom Rini <[email protected]>
---
 examples/standalone/Makefile         |   1 -
 examples/standalone/smc911x_eeprom.c | 379 ---------------------------
 2 files changed, 380 deletions(-)
 delete mode 100644 examples/standalone/smc911x_eeprom.c

Yeah, I was disturbed by this example code.

I agree we should drop it.

Signature · 2 lines
Best Regards
Masahiro Yamada
#3 lore raw

RFC PATCH 1/1 net: smc911x: Drop the standalone EEPROM example

Quoted 17 lines · Masahiro Yamada
Quoted 6 lines · Marek Vasut

Drop the example, for two reasons. First, it is tapping directly into the IO accessors of the SMC911x, while it should instead go through the net device API. Second, this makes conversion of the SMC911x driver to DM real hard.

Quoted 8 lines
Cc Joe Hershberger <[email protected]>
Cc Tom Rini <[email protected]>
---
 examples/standalone/Makefile         |   1 -
 examples/standalone/smc911x_eeprom.c | 379 ---------------------------
 2 files changed, 380 deletions(-)
 delete mode 100644 examples/standalone/smc911x_eeprom.c
Quoted 5 lines

Yeah, I was disturbed by this example code.

I agree we should drop it.

Well I dunno. Can this be rewritten on top of DM somehow ? Do we even have U-Boot application API to access DM EEPROM ?

Signature · 2 lines
Best regards,
Marek Vasut
#4 lore raw

RFC PATCH 1/1 net: smc911x: Drop the standalone EEPROM example

Quoted 18 lines · Marek Vasut
Quoted 17 lines · Masahiro Yamada
Quoted 14 lines · Marek Vasut

Drop the example, for two reasons. First, it is tapping directly into the IO accessors of the SMC911x, while it should instead go through the net device API. Second, this makes conversion of the SMC911x driver to DM real hard.

Cc Joe Hershberger <[email protected]>
Cc Tom Rini <[email protected]>
---
 examples/standalone/Makefile         |   1 -
 examples/standalone/smc911x_eeprom.c | 379 ---------------------------
 2 files changed, 380 deletions(-)
 delete mode 100644 examples/standalone/smc911x_eeprom.c
Quoted 8 lines
Quoted 5 lines

Yeah, I was disturbed by this example code.

I agree we should drop it.

Well I dunno. Can this be rewritten on top of DM somehow ? Do we even have U-Boot application API to access DM EEPROM ?

We should just drop it I think. The biggest surface we have today for external application is EFI application now, not U-Boot specific API. We can't drop the API but we don't expand it without very good reason.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200317/2017e638/attachment.sig>
#5 lore raw

RFC PATCH 1/1 net: smc911x: Drop the standalone EEPROM example

Quoted 23 lines · Tom Rini
Quoted 22 lines · Marek Vasut
Quoted 21 lines · Masahiro Yamada
Quoted 6 lines · Marek Vasut

Drop the example, for two reasons. First, it is tapping directly into the IO accessors of the SMC911x, while it should instead go through the net device API. Second, this makes conversion of the SMC911x driver to DM real hard.

Quoted 8 lines
Cc Joe Hershberger <[email protected]>
Cc Tom Rini <[email protected]>
---
 examples/standalone/Makefile         |   1 -
 examples/standalone/smc911x_eeprom.c | 379 ---------------------------
 2 files changed, 380 deletions(-)
 delete mode 100644 examples/standalone/smc911x_eeprom.c

Yeah, I was disturbed by this example code.

I agree we should drop it.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Well I dunno. Can this be rewritten on top of DM somehow ? Do we even have U-Boot application API to access DM EEPROM ?

We should just drop it I think. The biggest surface we have today for external application is EFI application now, not U-Boot specific API. We can't drop the API but we don't expand it without very good reason.

But this drops the ability to access the SMC911x EEPROM too. So maybe we need some DM EEPROM implementation in the SMC911x driver ? Does anyone have SMC911x with an external EEPROM ?

Signature · 2 lines
Best regards,
Marek Vasut
#6 lore raw

RFC PATCH 1/1 net: smc911x: Drop the standalone EEPROM example

Quoted 29 lines · Marek Vasut
Quoted 28 lines · Tom Rini
Quoted 26 lines · Marek Vasut
Quoted 17 lines · Masahiro Yamada
Quoted 6 lines · Marek Vasut

Drop the example, for two reasons. First, it is tapping directly into the IO accessors of the SMC911x, while it should instead go through the net device API. Second, this makes conversion of the SMC911x driver to DM real hard.

Quoted 8 lines
Cc Joe Hershberger <[email protected]>
Cc Tom Rini <[email protected]>
---
 examples/standalone/Makefile         |   1 -
 examples/standalone/smc911x_eeprom.c | 379 ---------------------------
 2 files changed, 380 deletions(-)
 delete mode 100644 examples/standalone/smc911x_eeprom.c
Quoted 5 lines

Yeah, I was disturbed by this example code.

I agree we should drop it.

Well I dunno. Can this be rewritten on top of DM somehow ? Do we even have U-Boot application API to access DM EEPROM ?

Quoted 7 lines
Quoted 3 lines

We should just drop it I think. The biggest surface we have today for external application is EFI application now, not U-Boot specific API. We can't drop the API but we don't expand it without very good reason.

But this drops the ability to access the SMC911x EEPROM too. So maybe we need some DM EEPROM implementation in the SMC911x driver ? Does anyone have SMC911x with an external EEPROM ?

All this does is drop an example. I don't see anything removing API code itself.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200317/762ecec8/attachment.sig>
#7 lore raw

RFC PATCH 1/1 net: smc911x: Drop the standalone EEPROM example

Quoted 34 lines · Tom Rini
Quoted 33 lines · Marek Vasut
Quoted 31 lines · Tom Rini
Quoted 18 lines · Marek Vasut
Quoted 17 lines · Masahiro Yamada
Quoted 14 lines · Marek Vasut

Drop the example, for two reasons. First, it is tapping directly into the IO accessors of the SMC911x, while it should instead go through the net device API. Second, this makes conversion of the SMC911x driver to DM real hard.

Cc Joe Hershberger <[email protected]>
Cc Tom Rini <[email protected]>
---
 examples/standalone/Makefile         |   1 -
 examples/standalone/smc911x_eeprom.c | 379 ---------------------------
 2 files changed, 380 deletions(-)
 delete mode 100644 examples/standalone/smc911x_eeprom.c
Quoted 8 lines
Quoted 5 lines

Yeah, I was disturbed by this example code.

I agree we should drop it.

Well I dunno. Can this be rewritten on top of DM somehow ? Do we even have U-Boot application API to access DM EEPROM ?

We should just drop it I think. The biggest surface we have today for external application is EFI application now, not U-Boot specific API. We can't drop the API but we don't expand it without very good reason.

Quoted 6 lines
Quoted 3 lines

But this drops the ability to access the SMC911x EEPROM too. So maybe we need some DM EEPROM implementation in the SMC911x driver ? Does anyone have SMC911x with an external EEPROM ?

All this does is drop an example. I don't see anything removing API code itself.

Where did I say anything about API code ?

Signature · 2 lines
Best regards,
Marek Vasut
#8 lore raw

RFC PATCH 1/1 net: smc911x: Drop the standalone EEPROM example

Quoted 35 lines · Marek Vasut
Quoted 34 lines · Tom Rini
Quoted 33 lines · Marek Vasut
Quoted 31 lines · Tom Rini
Quoted 18 lines · Marek Vasut
Quoted 17 lines · Masahiro Yamada
Quoted 14 lines · Marek Vasut

Drop the example, for two reasons. First, it is tapping directly into the IO accessors of the SMC911x, while it should instead go through the net device API. Second, this makes conversion of the SMC911x driver to DM real hard.

Cc Joe Hershberger <[email protected]>
Cc Tom Rini <[email protected]>
---
 examples/standalone/Makefile         |   1 -
 examples/standalone/smc911x_eeprom.c | 379 ---------------------------
 2 files changed, 380 deletions(-)
 delete mode 100644 examples/standalone/smc911x_eeprom.c
Quoted 8 lines
Quoted 5 lines

Yeah, I was disturbed by this example code.

I agree we should drop it.

Well I dunno. Can this be rewritten on top of DM somehow ? Do we even have U-Boot application API to access DM EEPROM ?

We should just drop it I think. The biggest surface we have today for external application is EFI application now, not U-Boot specific API. We can't drop the API but we don't expand it without very good reason.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

But this drops the ability to access the SMC911x EEPROM too. So maybe we need some DM EEPROM implementation in the SMC911x driver ? Does anyone have SMC911x with an external EEPROM ?

All this does is drop an example. I don't see anything removing API code itself.

Where did I say anything about API code ?

Nowhere, which is my point. You're just dropping an example, not the ability to do $X.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200317/7fe41baa/attachment.sig>
#9 lore raw

RFC PATCH 1/1 net: smc911x: Drop the standalone EEPROM example

Quoted 40 lines · Tom Rini
Quoted 39 lines · Marek Vasut
Quoted 38 lines · Tom Rini
Quoted 36 lines · Marek Vasut
Quoted 23 lines · Tom Rini
Quoted 22 lines · Marek Vasut
Quoted 21 lines · Masahiro Yamada
Quoted 6 lines · Marek Vasut

Drop the example, for two reasons. First, it is tapping directly into the IO accessors of the SMC911x, while it should instead go through the net device API. Second, this makes conversion of the SMC911x driver to DM real hard.

Quoted 8 lines
Cc Joe Hershberger <[email protected]>
Cc Tom Rini <[email protected]>
---
 examples/standalone/Makefile         |   1 -
 examples/standalone/smc911x_eeprom.c | 379 ---------------------------
 2 files changed, 380 deletions(-)
 delete mode 100644 examples/standalone/smc911x_eeprom.c

Yeah, I was disturbed by this example code.

I agree we should drop it.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Well I dunno. Can this be rewritten on top of DM somehow ? Do we even have U-Boot application API to access DM EEPROM ?

We should just drop it I think. The biggest surface we have today for external application is EFI application now, not U-Boot specific API. We can't drop the API but we don't expand it without very good reason.

But this drops the ability to access the SMC911x EEPROM too. So maybe we need some DM EEPROM implementation in the SMC911x driver ? Does anyone have SMC911x with an external EEPROM ?

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

All this does is drop an example. I don't see anything removing API code itself.

Where did I say anything about API code ?

Nowhere, which is my point. You're just dropping an example, not the ability to do $X.

If $X is ability to access the EEPROM, then I am dropping $X here.

Signature · 2 lines
Best regards,
Marek Vasut
#10 lore raw

RFC PATCH 1/1 net: smc911x: Drop the standalone EEPROM example

Quoted 44 lines · Marek Vasut
Quoted 43 lines · Tom Rini
Quoted 42 lines · Marek Vasut
Quoted 40 lines · Tom Rini
Quoted 29 lines · Marek Vasut
Quoted 28 lines · Tom Rini
Quoted 26 lines · Marek Vasut
Quoted 17 lines · Masahiro Yamada
Quoted 6 lines · Marek Vasut

Drop the example, for two reasons. First, it is tapping directly into the IO accessors of the SMC911x, while it should instead go through the net device API. Second, this makes conversion of the SMC911x driver to DM real hard.

Quoted 8 lines
Cc Joe Hershberger <[email protected]>
Cc Tom Rini <[email protected]>
---
 examples/standalone/Makefile         |   1 -
 examples/standalone/smc911x_eeprom.c | 379 ---------------------------
 2 files changed, 380 deletions(-)
 delete mode 100644 examples/standalone/smc911x_eeprom.c
Quoted 5 lines

Yeah, I was disturbed by this example code.

I agree we should drop it.

Well I dunno. Can this be rewritten on top of DM somehow ? Do we even have U-Boot application API to access DM EEPROM ?

Quoted 7 lines
Quoted 3 lines

We should just drop it I think. The biggest surface we have today for external application is EFI application now, not U-Boot specific API. We can't drop the API but we don't expand it without very good reason.

But this drops the ability to access the SMC911x EEPROM too. So maybe we need some DM EEPROM implementation in the SMC911x driver ? Does anyone have SMC911x with an external EEPROM ?

All this does is drop an example. I don't see anything removing API code itself.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Where did I say anything about API code ?

Nowhere, which is my point. You're just dropping an example, not the ability to do $X.

If $X is ability to access the EEPROM, then I am dropping $X here.

No, you're dropping an example of doing $X.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200317/aad80773/attachment.sig>

A message that is not in the archive (sent off-list or not yet received): CANr=Z=bAAoVsFJcqDYe-9qLrqLu9X0h5e_jqeDKv5bSAP5bGnw@mail.gmail.com

#12 lore raw

RFC PATCH 1/1 net: smc911x: Drop the standalone EEPROM example

Quoted 52 lines · Joe Hershberger
Quoted 51 lines · Tom Rini
Quoted 49 lines · Marek Vasut
Quoted 47 lines · Tom Rini
Quoted 35 lines · Marek Vasut
Quoted 34 lines · Tom Rini
Quoted 33 lines · Marek Vasut
Quoted 31 lines · Tom Rini
Quoted 18 lines · Marek Vasut
Quoted 17 lines · Masahiro Yamada
Quoted 14 lines · Marek Vasut

Drop the example, for two reasons. First, it is tapping directly into the IO accessors of the SMC911x, while it should instead go through the net device API. Second, this makes conversion of the SMC911x driver to DM real hard.

Cc Joe Hershberger <[email protected]>
Cc Tom Rini <[email protected]>
---
 examples/standalone/Makefile         |   1 -
 examples/standalone/smc911x_eeprom.c | 379 ---------------------------
 2 files changed, 380 deletions(-)
 delete mode 100644 examples/standalone/smc911x_eeprom.c
Quoted 8 lines
Quoted 5 lines

Yeah, I was disturbed by this example code.

I agree we should drop it.

Well I dunno. Can this be rewritten on top of DM somehow ? Do we even have U-Boot application API to access DM EEPROM ?

We should just drop it I think. The biggest surface we have today for external application is EFI application now, not U-Boot specific API. We can't drop the API but we don't expand it without very good reason.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

But this drops the ability to access the SMC911x EEPROM too. So maybe we need some DM EEPROM implementation in the SMC911x driver ? Does anyone have SMC911x with an external EEPROM ?

All this does is drop an example. I don't see anything removing API code itself.

Where did I say anything about API code ?

Nowhere, which is my point. You're just dropping an example, not the ability to do $X.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

If $X is ability to access the EEPROM, then I am dropping $X here.

No, you're dropping an example of doing $X.

Correct. But the move to DM in the driver will drop the functions this example was using, no?

If it was using something that's not in <_exports.h> I don't see that as a problem. A standalone app could do whatever it likes with the hardware and needs to restore the hardware before passing control back to U-Boot (if it's doing that).

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200317/47bd5fed/attachment.sig>
#13 lore raw

RFC PATCH 1/1 net: smc911x: Drop the standalone EEPROM example

Hi Tom,

Quoted 58 lines · Tom Rini
Quoted 56 lines · Joe Hershberger
Quoted 54 lines · Tom Rini
Quoted 44 lines · Marek Vasut
Quoted 43 lines · Tom Rini
Quoted 42 lines · Marek Vasut
Quoted 40 lines · Tom Rini
Quoted 29 lines · Marek Vasut
Quoted 28 lines · Tom Rini
Quoted 26 lines · Marek Vasut
Quoted 17 lines · Masahiro Yamada
Quoted 6 lines · Marek Vasut

Drop the example, for two reasons. First, it is tapping directly into the IO accessors of the SMC911x, while it should instead go through the net device API. Second, this makes conversion of the SMC911x driver to DM real hard.

Quoted 8 lines
Cc Joe Hershberger <[email protected]>
Cc Tom Rini <[email protected]>
---
 examples/standalone/Makefile         |   1 -
 examples/standalone/smc911x_eeprom.c | 379 ---------------------------
 2 files changed, 380 deletions(-)
 delete mode 100644 examples/standalone/smc911x_eeprom.c
Quoted 5 lines

Yeah, I was disturbed by this example code.

I agree we should drop it.

Well I dunno. Can this be rewritten on top of DM somehow ? Do we even have U-Boot application API to access DM EEPROM ?

Quoted 7 lines
Quoted 3 lines

We should just drop it I think. The biggest surface we have today for external application is EFI application now, not U-Boot specific API. We can't drop the API but we don't expand it without very good reason.

But this drops the ability to access the SMC911x EEPROM too. So maybe we need some DM EEPROM implementation in the SMC911x driver ? Does anyone have SMC911x with an external EEPROM ?

All this does is drop an example. I don't see anything removing API code itself.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Where did I say anything about API code ?

Nowhere, which is my point. You're just dropping an example, not the ability to do $X.

If $X is ability to access the EEPROM, then I am dropping $X here.

No, you're dropping an example of doing $X.

Quoted 7 lines
Quoted 2 lines

Correct. But the move to DM in the driver will drop the functions this example was using, no?

If it was using something that's not in <_exports.h> I don't see that as a problem. A standalone app could do whatever it likes with the hardware and needs to restore the hardware before passing control back to U-Boot (if it's doing that).

My understanding (correct me if I'm wrong) is that the SCM911x driver in question used to expose its eeprom through the external API, but not as though there was a special API directly implemented in that driver.

I think the behavior change that Marek was concerned about was that this particular device would not be accessible via the external eeprom api any longer.

-Joe

#14 lore raw

RFC PATCH 1/1 net: smc911x: Drop the standalone EEPROM example

Quoted 69 lines · Joe Hershberger

Hi Tom,

Quoted 58 lines · Tom Rini
Quoted 56 lines · Joe Hershberger
Quoted 54 lines · Tom Rini
Quoted 44 lines · Marek Vasut
Quoted 43 lines · Tom Rini
Quoted 42 lines · Marek Vasut
Quoted 40 lines · Tom Rini
Quoted 29 lines · Marek Vasut
Quoted 28 lines · Tom Rini
Quoted 26 lines · Marek Vasut
Quoted 17 lines · Masahiro Yamada
Quoted 14 lines · Marek Vasut

Drop the example, for two reasons. First, it is tapping directly into
the IO accessors of the SMC911x, while it should instead go through
the net device API. Second, this makes conversion of the SMC911x driver
to DM real hard.

Signed-off-by: Marek Vasut <[email protected]>
Cc: Joe Hershberger <[email protected]>
Cc: Tom Rini <[email protected]>
---
examples/standalone/Makefile | 1 -
examples/standalone/smc911x_eeprom.c | 379 ---------------------------
2 files changed, 380 deletions(-)
delete mode 100644 examples/standalone/smc911x_eeprom.c

Quoted 5 lines

Yeah, I was disturbed by this example code.

I agree we should drop it.

Well I dunno. Can this be rewritten on top of DM somehow ? Do we even have U-Boot application API to access DM EEPROM ?

Quoted 7 lines
Quoted 3 lines

We should just drop it I think. The biggest surface we have today for external application is EFI application now, not U-Boot specific API. We can't drop the API but we don't expand it without very good reason.

But this drops the ability to access the SMC911x EEPROM too. So maybe we need some DM EEPROM implementation in the SMC911x driver ? Does anyone have SMC911x with an external EEPROM ?

All this does is drop an example. I don't see anything removing API code itself.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Where did I say anything about API code ?

Nowhere, which is my point. You're just dropping an example, not the ability to do $X.

If $X is ability to access the EEPROM, then I am dropping $X here.

No, you're dropping an example of doing $X.

Quoted 7 lines
Quoted 2 lines

Correct. But the move to DM in the driver will drop the functions this example was using, no?

If it was using something that's not in <_exports.h> I don't see that as a problem. A standalone app could do whatever it likes with the hardware and needs to restore the hardware before passing control back to U-Boot (if it's doing that).

Quoted 8 lines

My understanding (correct me if I'm wrong) is that the SCM911x driver in question used to expose its eeprom through the external API, but not as though there was a special API directly implemented in that driver.

I think the behavior change that Marek was concerned about was that this particular device would not be accessible via the external eeprom api any longer.

One can have the driver expose some EEPROM interface, but not via the U-Boot application example. But then, the U-Boot application was poking registers directly anyway, which is awful.

Signature · 2 lines
Best regards,
Marek Vasut
#15 lore raw

RFC PATCH 1/1 net: smc911x: Drop the standalone EEPROM example

In reply to Marek Vasut
Quoted 9 lines · Marek Vasut

Drop the example, for two reasons. First, it is tapping directly into the IO accessors of the SMC911x, while it should instead go through the net device API. Second, this makes conversion of the SMC911x driver to DM real hard.

Applied to u-boot/next, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200612/8ad2c0bf/attachment.sig>