Skip to contentSkip to conversation

iommu/amd: Remove redundant check

PATCH In review Vasant Hegde via iommu 2 participants 3 messages Mar 14, 2022 – Apr 28, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iommu/amd: Remove redundant check

smatch static checker warning:
drivers/iommu/amd/init.c:1989 amd_iommu_init_pci()
warn: duplicate check 'ret' (previous on line 1978)

Fixes 06687a03805e ("iommu/amd: Improve error handling for amd_iommu_init_pci")
---
 drivers/iommu/amd/init.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iommu/amd/init.c +1 -2
index 2586e589e54e..8ed1f86fe93d 100644
@@ -2137,8 +2137,7 @@ static int __init amd_iommu_init_pci(void)
 	for_each_iommu(iommu)
 		iommu_flush_all_caches(iommu);
 
-	if (!ret)
-		print_iommu_info();
+	print_iommu_info();
 
 out:
 	return ret;
Signature · 6 lines
2.27.0

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
#1 lore raw

Joerg,

Ping.

-Vasant

Quoted 16 lines · Vasant Hegde via iommu

smatch static checker warning:
drivers/iommu/amd/init.c:1989 amd_iommu_init_pci()
warn: duplicate check 'ret' (previous on line 1978)

Fixes 06687a03805e ("iommu/amd: Improve error handling for amd_iommu_init_pci")
---
 drivers/iommu/amd/init.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iommu/amd/init.c +0 -0
index 2586e589e54e..8ed1f86fe93d 100644

drivers/iommu/amd/init.c static int __init amd_iommu_init_pci(void) · line 2143

Quoted 9 lines
drivers/iommu/amd/init.c +1 -2
@@ -2137,8 +2137,7 @@ static int __init amd_iommu_init_pci(void)
 	for_each_iommu(iommu)
 		iommu_flush_all_caches(iommu);
 
-	if (!ret)
-		print_iommu_info();
+	print_iommu_info();
 
 out:
 	return ret;

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

maintainer
#2 lore raw
In reply to Vasant Hegde via iommu
Quoted 7 lines · Vasant Hegde

smatch static checker warning:
drivers/iommu/amd/init.c:1989 amd_iommu_init_pci()
warn: duplicate check 'ret' (previous on line 1978)

Fixes 06687a03805e ("iommu/amd: Improve error handling for amd_iommu_init_pci")

Applied, thanks.
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu