realtime/m4: Re-add define for robust mutexattr APIs
PATCH 1/1 realtime/m4: Re-add define for robust mutexattr APIs
From: Mathias Fiedler <[email protected]>
This define is required by sbrk_mutex.c and testpi-6.c. This define was dropped in
commit 3f6e7fe1e7d6afffb1db593e0dc14ca88a01cf66:
realtime: Fix pthread_mutexattr_{g,s}etrobust_np detection
--- testcases/realtime/m4/check.m4 | 1 + 1 file changed, 1 insertion(+)
testcases/realtime/m4/check.m4 +1 -0
@@ -17,6 +17,7 @@ AC_DEFUN([REALTIME_CHECK_ROBUST_APIS],[ AC_CHECK_DECLS([pthread_mutexattr_getrobust, pthread_mutexattr_setrobust],[],[has_robust="no"],[[#include <pthread.h>]]) AC_MSG_CHECKING([for pthread_mutexattr_*robust* APIs]) if test "x$has_robust" != "xno"; then + AC_DEFINE(HAS_PTHREAD_MUTEXTATTR_ROBUST_APIS,1,[Define to 1 if you have pthread_mutexattr_*robust* APIs]) AC_MSG_RESULT(yes) else AC_MSG_RESULT(no)
Signature · 1 line
2.25.1
PATCH 1/1 realtime/m4: Re-add define for robust mutexattr APIs
Hi!
The code switched to the POSIX variants later on so I wonder if we even need this configure check or if we can remove the ifdefs from the testcases completely.
Signature · 2 lines
Cyril Hrubis [email protected]
PATCH 1/1 realtime/m4: Re-add define for robust mutexattr APIs
Hi,
Quoted 4 lines · Cyril Hrubis
Hi!
The code switched to the POSIX variants later on so I wonder if we even need this configure check or if we can remove the ifdefs from the testcases completely.
either that or this patch. At least at the moment these tests are completely broken.
I am not sure how long pthread_mutexattr_*roboust* api is part of posix and if ltp is supposed to be supported on platforms, that may not implement it.
But should accepting this patch wouldn't do any harm for now, but would fix the tests. In the future it can still be removed completely.
J?rg
PS: @Cyril Sorry for the resending this, forgot to include the mail list
PATCH 1/1 realtime/m4: Re-add define for robust mutexattr APIs
Hi!
Quoted 8 lines
Quoted 3 lines
The code switched to the POSIX variants later on so I wonder if we even need this configure check or if we can remove the ifdefs from the testcases completely.
either that or this patch. At least at the moment these tests are completely broken.
I am not sure how long pthread_mutexattr_*roboust* api is part of posix and if ltp is supposed to be supported on platforms, that may not implement it.
As for LTP the only part that is supposed to be used on anything else than Linux is the open posix testsuite. The rest, including the relatime tests, is strictly Linux only.
Looking at the glibc the pthread_mutexattr_*robust* calls were implemented in 2010 which is 10 years from now, which means that it's old enough to just remove the checks.
Will you send a patch or should I do so?
Signature · 2 lines
Cyril Hrubis [email protected]