Skip to contentSkip to conversation

drm/amd/pm: Clean up errors in smu11_driver_if_sienna_cichlid.h

PATCH In review [email protected] 2 participants 4 messages Jul 24, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drm/amd/pm: Clean up errors in smu11_driver_if_sienna_cichlid.h

Fix the following errors reported by checkpatch:

ERROR: trailing whitespace

---
 drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_1_pmfw.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_1_pmfw.h +2 -2
index c5e26d619bf0..8ec588248aac 100644
@@ -30,7 +30,7 @@
 
 #define ENABLE_DEBUG_FEATURES
 
-// Firmware features
+// Firmware features
 // Feature Control Defines
 #define FEATURE_CCLK_DPM_BIT                 0
 #define FEATURE_FAN_CONTROLLER_BIT           1
@@ -92,7 +92,7 @@
 #define FEATURE_ZSTATES_ECO_BIT             57
 #define FEATURE_CC6_BIT                     58
 #define FEATURE_DS_UMCCLK_BIT               59
-#define FEATURE_DS_HSPCLK_BIT               60
+#define FEATURE_DS_HSPCLK_BIT               60
 #define NUM_FEATURES                        61
 
 typedef struct {
#2 lore raw

This doesn't apply cleanly.

Alex

Quoted 33 lines · On Mon, Jul 24, 2023 at 4:34 AM <[email protected]> wrote:

Fix the following errors reported by checkpatch:

ERROR: trailing whitespace

---
  drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_1_pmfw.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_1_pmfw.h +2 -2
index c5e26d619bf0..8ec588248aac 100644
@@ -30,7 +30,7 @@
 
  #define ENABLE_DEBUG_FEATURES
 
-// Firmware features
+// Firmware features
  // Feature Control Defines
  #define FEATURE_CCLK_DPM_BIT                 0
  #define FEATURE_FAN_CONTROLLER_BIT           1
@@ -92,7 +92,7 @@
  #define FEATURE_ZSTATES_ECO_BIT             57
  #define FEATURE_CC6_BIT                     58
  #define FEATURE_DS_UMCCLK_BIT               59
-#define FEATURE_DS_HSPCLK_BIT               60
+#define FEATURE_DS_HSPCLK_BIT               60
  #define NUM_FEATURES                        61
 
  typedef struct {
#3 lore raw

PATCH 1/1 drm/amd/pm: Clean up errors in smu_v13_0_1_pmfw.h

In reply to a message not in the archive

Fix the following errors reported by checkpatch:

ERROR: trailing whitespace

---
 drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_1_pmfw.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_1_pmfw.h +2 -2
index c5e26d619bf0..8ec588248aac 100644
@@ -30,7 +30,7 @@
 
 #define ENABLE_DEBUG_FEATURES
 
-// Firmware features
+// Firmware features
 // Feature Control Defines
 #define FEATURE_CCLK_DPM_BIT                 0
 #define FEATURE_FAN_CONTROLLER_BIT           1
@@ -92,7 +92,7 @@
 #define FEATURE_ZSTATES_ECO_BIT             57
 #define FEATURE_CC6_BIT                     58
 #define FEATURE_DS_UMCCLK_BIT               59
-#define FEATURE_DS_HSPCLK_BIT               60
+#define FEATURE_DS_HSPCLK_BIT               60
 #define NUM_FEATURES                        61
 
 typedef struct {
#4 lore raw

Re: [PATCH] drm/amd/pm: Clean up errors in smu_v13_0_1_pmfw.h

This doesn't apply cleanly.

Alex

Quoted 33 lines · On Mon, Jul 24, 2023 at 4:57 AM <[email protected]> wrote:

Fix the following errors reported by checkpatch:

ERROR: trailing whitespace

---
  drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_1_pmfw.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_1_pmfw.h +2 -2
index c5e26d619bf0..8ec588248aac 100644
@@ -30,7 +30,7 @@
 
  #define ENABLE_DEBUG_FEATURES
 
-// Firmware features
+// Firmware features
  // Feature Control Defines
  #define FEATURE_CCLK_DPM_BIT                 0
  #define FEATURE_FAN_CONTROLLER_BIT           1
@@ -92,7 +92,7 @@
  #define FEATURE_ZSTATES_ECO_BIT             57
  #define FEATURE_CC6_BIT                     58
  #define FEATURE_DS_UMCCLK_BIT               59
-#define FEATURE_DS_HSPCLK_BIT               60
+#define FEATURE_DS_HSPCLK_BIT               60
  #define NUM_FEATURES                        61
 
  typedef struct {