Skip to contentSkip to conversation

ti-ipc: Fix "buildpaths" QA error

PATCH Superseded Ryan Eatmon 2 participants 4 messages Jul 16, 2024 – Jul 17, 2024 1 message not in the archive

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ti-ipc: Fix "buildpaths" QA error

Referring to the TI specific kernel header file via -I${UNPACKDIR} causes a "buildpaths" QA error. Solution is to copy the file from UNPACKDIR into the S dir at the start of each compile, and then fix the patch to make sure the #include is correct for this new location.

---
 ...1-MmRpc-Stop-looking-for-rpmsg_rpc.h-in-the-kernel.patch | 2 +-
 meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb                    | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)
meta-ti-bsp/recipes-ti/ipc/ti-ipc/0001-MmRpc-Stop-looking-for-rpmsg_rpc.h-in-the-kernel.patch +1 -1
index 522ad5e4..6d84cfb4 100644
@@ -26,7 +26,7 @@ index 2df7420..10f496b 100644
  #endif
 
 -#include linux_include(KERNEL_INSTALL_DIR,rpmsg_rpc)
-+#include "linux/rpmsg_rpc.h"
++#include "rpmsg_rpc.h"
 
  #ifdef _linux_
  #define linux _linux
meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb +4 -2
index 11be09ea..e12ce273 100644
@@ -18,8 +18,6 @@ SRC_URI += "file://tiipclad-daemon.sh \
             file://0001-MmRpc-Stop-looking-for-rpmsg_rpc.h-in-the-kernel.patch \
            "
 
-CFLAGS += "-I${UNPACKDIR}"
-
 DAEMON = "UNKNOWN"
 DAEMON:dra7xx = "lad_dra7xx"
 DAEMON:omapl138 = "lad_omapl138"
@@ -40,6 +38,10 @@ do_configure() {
     oe_runconf
 }
 
+do_compile:prepend() {
+    cp ${UNPACKDIR}/linux/rpmsg_rpc.h ${S}/packages/ti/ipc/mm/rpmsg_rpc.h
+}
+
 do_install:append() {
     install -d ${D}${sysconfdir}/init.d/
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 30 lines · Ryan Eatmon via lists.yoctoproject.org

Referring to the TI specific kernel header file via -I${UNPACKDIR} causes a "buildpaths" QA error. Solution is to copy the file from UNPACKDIR into the S dir at the start of each compile, and then fix the patch to make sure the #include is correct for this new location.

---
 ...1-MmRpc-Stop-looking-for-rpmsg_rpc.h-in-the-kernel.patch | 2 +-
 meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb                    | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)
meta-ti-bsp/recipes-ti/ipc/ti-ipc/0001-MmRpc-Stop-looking-for-rpmsg_rpc.h-in-the-kernel.patch +1 -1
index 522ad5e4..6d84cfb4 100644
@@ -26,7 +26,7 @@ index 2df7420..10f496b 100644
  #endif
 
 -#include linux_include(KERNEL_INSTALL_DIR,rpmsg_rpc)
-+#include "linux/rpmsg_rpc.h"
++#include "rpmsg_rpc.h"
 
  #ifdef _linux_
  #define linux _linux
meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb +0 -0
index 11be09ea..e12ce273 100644

meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb SRC_URI += "file://tiipclad-daemon.sh \ · line 22

Quoted 5 lines
meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb +0 -2
@@ -18,8 +18,6 @@ SRC_URI += "file://tiipclad-daemon.sh \
             file://0001-MmRpc-Stop-looking-for-rpmsg_rpc.h-in-the-kernel.patch \
            "
 
-CFLAGS += "-I${UNPACKDIR}="
-

Perhaps adding -fdebug-prefix-map=${UNPACKDIR}=${TARGET_DBGSRC_DIR} in CFLAGS is all you need.

Quoted 26 lines
meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb +4 -1
 DAEMON = "UNKNOWN"
 DAEMON:dra7xx = "lad_dra7xx"
 DAEMON:omapl138 = "lad_omapl138"
@@ -40,6 +38,10 @@ do_configure() {
     oe_runconf
 }
 
+do_compile:prepend() {
+    cp ${UNPACKDIR}/linux/rpmsg_rpc.h ${S}/packages/ti/ipc/mm/rpmsg_rpc.h
+}
+
 do_install:append() {
     install -d ${D}${sysconfdir}/init.d/
 
--

2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17868): https://lists.yoctoproject.org/g/meta-ti/message/17868
Mute This Topic: https://lists.yoctoproject.org/mt/107259201/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw
Quoted 35 lines · Khem Raj
Quoted 33 lines · Ryan Eatmon via lists.yoctoproject.org

Referring to the TI specific kernel header file via -I${UNPACKDIR} causes a "buildpaths" QA error. Solution is to copy the file from UNPACKDIR into the S dir at the start of each compile, and then fix the patch to make sure the #include is correct for this new location.

---
  ...1-MmRpc-Stop-looking-for-rpmsg_rpc.h-in-the-kernel.patch | 2 +-
  meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb                    | 6 ++++--
  2 files changed, 5 insertions(+), 3 deletions(-)
meta-ti-bsp/recipes-ti/ipc/ti-ipc/0001-MmRpc-Stop-looking-for-rpmsg_rpc.h-in-the-kernel.patch +1 -1
index 522ad5e4..6d84cfb4 100644
@@ -26,7 +26,7 @@ index 2df7420..10f496b 100644
   #endif
 
  -#include linux_include(KERNEL_INSTALL_DIR,rpmsg_rpc)
-+#include "linux/rpmsg_rpc.h"
++#include "rpmsg_rpc.h"
 
   #ifdef _linux_
   #define linux _linux
meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb +0 -0
index 11be09ea..e12ce273 100644
@@ -18,8 +18,6 @@ SRC_URI += "file://tiipclad-daemon.sh \
              file://0001-MmRpc-Stop-looking-for-rpmsg_rpc.h-in-the-kernel.patch \
             "
 
Quoted 5 lines

meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb SRC_URI += "file://tiipclad-daemon.sh \ · line 22

Quoted 2 lines
meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb +0 -2
-CFLAGS += "-I${UNPACKDIR}="
-

Perhaps adding -fdebug-prefix-map=${UNPACKDIR}=${TARGET_DBGSRC_DIR} in CFLAGS is all you need.

I'll try it. Thanks.

Quoted 26 lines
Quoted 26 lines
meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb +4 -1
  DAEMON = "UNKNOWN"
  DAEMON:dra7xx = "lad_dra7xx"
  DAEMON:omapl138 = "lad_omapl138"
@@ -40,6 +38,10 @@ do_configure() {
      oe_runconf
  }
 
+do_compile:prepend() {
+    cp ${UNPACKDIR}/linux/rpmsg_rpc.h ${S}/packages/ti/ipc/mm/rpmsg_rpc.h
+}
+
  do_install:append() {
      install -d ${D}${sysconfdir}/init.d/
 
--

2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17868): https://lists.yoctoproject.org/g/meta-ti/message/17868
Mute This Topic: https://lists.yoctoproject.org/mt/107259201/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 41 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 38 lines · Khem Raj
Quoted 36 lines · Ryan Eatmon via lists.yoctoproject.org

Referring to the TI specific kernel header file via -I${UNPACKDIR} causes a "buildpaths" QA error.  Solution is to copy the file from UNPACKDIR into the S dir at the start of each compile, and then fix the patch to make sure the #include is correct for this new location.

---
  ...1-MmRpc-Stop-looking-for-rpmsg_rpc.h-in-the-kernel.patch | 2 +- meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb                    | 6 ++++--

  2 files changed, 5 insertions(+), 3 deletions(-)
meta-ti-bsp/recipes-ti/ipc/ti-ipc/0001-MmRpc-Stop-looking-for-rpmsg_rpc.h-in-the-kernel.patch +0 -1
index 522ad5e4..6d84cfb4 100644
--- 

a/meta-ti-bsp/recipes-ti/ipc/ti-ipc/0001-MmRpc-Stop-looking-for-rpmsg_rpc.h-in-the-kernel.patch
+++
b/meta-ti-bsp/recipes-ti/ipc/ti-ipc/0001-MmRpc-Stop-looking-for-rpmsg_rpc.h-in-the-kernel.patch

meta-ti-bsp/recipes-ti/ipc/ti-ipc/0001-MmRpc-Stop-looking-for-rpmsg_rpc.h-in-the-kernel.patch +1 -1
@@ -26,7 +26,7 @@ index 2df7420..10f496b 100644
    #endif
 
   -#include linux_include(KERNEL_INSTALL_DIR,rpmsg_rpc)
-+#include "linux/rpmsg_rpc.h"
++#include "rpmsg_rpc.h"
 
    #ifdef _linux_
    #define linux _linux
meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb +0 -0
index 11be09ea..e12ce273 100644
@@ -18,8 +18,6 @@ SRC_URI += "file://tiipclad-daemon.sh \
 
 file://0001-MmRpc-Stop-looking-for-rpmsg_rpc.h-in-the-kernel.patch \

             "

Quoted 8 lines
Quoted 5 lines

meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb

Quoted 2 lines
meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb +0 -2
-CFLAGS += "-I${UNPACKDIR}="
-

Perhaps adding  -fdebug-prefix-map=${UNPACKDIR}=${TARGET_DBGSRC_DIR} in CFLAGS is all you need.

I'll try it.  Thanks.

Looks like that works. v2 incoming.

Quoted 33 lines
Quoted 16 lines
Quoted 16 lines

  DAEMON = "UNKNOWN"
  DAEMON:dra7xx = "lad_dra7xx"
  DAEMON:omapl138 = "lad_omapl138"

meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb +0 -0
@@ -40,6 +38,10 @@ do_configure() {

      oe_runconf
  }

+do_compile:prepend() {
+    cp ${UNPACKDIR}/linux/rpmsg_rpc.h
${S}/packages/ti/ipc/mm/rpmsg_rpc.h

meta-ti-bsp/recipes-ti/ipc/ti-ipc_git.bb +2 -0
+}
+

  do_install:append() {
      install -d ${D}${sysconfdir}/init.d/

Quoted 6 lines
Quoted 6 lines
Signature · 1 line
2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17870): https://lists.yoctoproject.org/g/meta-ti/message/17870
Mute This Topic: https://lists.yoctoproject.org/mt/107259201/6551054
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS