dm: add support for DM_TARGET_NOWAIT for various targets
Subsystems (3)
PATCH 1/1 dm: add support for DM_TARGET_NOWAIT for various targets
This is one prep patch for supporting iopoll for dm device.
The direct IO routine will set REQ_NOWAIT flag for REQ_HIPRI IO (that is, IO will do iopoll) in bio_set_polled(). Then in the IO submission routine, the ability of handling REQ_NOWAIT of the block device will be checked for REQ_HIPRI IO in submit_bio_checks(). -EOPNOTSUPP will be returned if the block device doesn't support REQ_NOWAIT.
DM lacks support for REQ_NOWAIT until commit 6abc49468eea ("dm: add support for REQ_NOWAIT and enable it for linear target"). Since then, dm targets that support REQ_NOWAIT should advertise DM_TARGET_NOWAIT feature.
This patch adds support for DM_TARGET_NOWAIT for those dm targets, the .map() algorithm of which just involves sector recalculation.
---
Hi Mike,
I could split these boilerplate code that each dm target have one seperate patch if you think that would be better.
--- drivers/md/dm-stripe.c | 2 +- drivers/md/dm-switch.c | 1 + drivers/md/dm-unstripe.c | 1 + drivers/md/dm-zero.c | 1 + 4 files changed, 4 insertions(+), 1 deletion(-)
drivers/md/dm-stripe.c +1 -1
@@ -496,7 +496,7 @@ static void stripe_io_hints(struct dm_target *ti,static struct target_type stripe_target = { .name ="striped" , .version = {1 ,6 ,0 }, - .features =DM_TARGET_PASSES_INTEGRITY , + .features =DM_TARGET_PASSES_INTEGRITY |DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = stripe_ctr, .dtr = stripe_dtr,
drivers/md/dm-switch.c +1 -0
@@ -550,6 +550,7 @@ static int switch_iterate_devices(struct dm_target *ti,static struct target_type switch_target = { .name ="switch" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = switch_ctr, .dtr = switch_dtr,
drivers/md/dm-unstripe.c +1 -0
@@ -178,6 +178,7 @@ static void unstripe_io_hints(struct dm_target *ti,static struct target_type unstripe_target = { .name ="unstriped" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = unstripe_ctr, .dtr = unstripe_dtr,
drivers/md/dm-zero.c +1 -0
@@ -59,6 +59,7 @@ static int zero_map(struct dm_target *ti, struct bio *bio)static struct target_type zero_target = { .name ="zero" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = zero_ctr, .map = zero_map,
Signature · 6 lines
2.27.0 -- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
Quoted 7 lines · Jeffle Xu
This is one prep patch for supporting iopoll for dm device.
The direct IO routine will set
REQ_NOWAITflag forREQ_HIPRIIO (that is, IO will do iopoll) inbio_set_polled(). Then in the IO submission routine, the ability of handlingREQ_NOWAITof the block device will be checked forREQ_HIPRIIO insubmit_bio_checks().-EOPNOTSUPPwill be returned if the block device doesn't supportREQ_NOWAIT.
submit_bio_checks() verifies the request_queue has QUEUE_FLAG_NOWAIT set if the bio has REQ_NOWAIT.
Quoted 4 lines
DM lacks support for
REQ_NOWAITuntil commit6abc49468eea("dm: add support forREQ_NOWAITand enable it for linear target"). Since then, dm targets that supportREQ_NOWAITshould advertiseDM_TARGET_NOWAITfeature.
I'm not seeing why DM_TARGET_NOWAIT is needed (since you didn't add any code that consumes the flag).
dm-table.c:dm_table_set_restrictions() has:
if (dm_table_supports_nowait(t))
blk_queue_flag_set(QUEUE_FLAG_NOWAIT, q);
else
blk_queue_flag_clear(QUEUE_FLAG_NOWAIT, q);Quoted 2 lines
This patch adds support for
DM_TARGET_NOWAITfor those dm targets, the .map() algorithm of which just involves sector recalculation.
So you're looking to constrain which targets will properly support REQ_NOWAIT, based on whether they do a simple remapping?
Quoted 6 lines
Signed-off-by Jeffle Xu <[email protected]>---
Hi Mike,I could split these boilerplate code that each dm target have one seperate patch if you think that would be better.
One patch for all these is fine. But it should include the code that I assume you'll be adding to dm_table_supports_nowait() to further verify that the targets in the table are all DM_TARGET_NOWAIT.
And why isn't dm-linear setting DM_TARGET_NOWAIT?
Also, other targets _could_ be made to support REQ_NOWAIT by conditionally returning bio_wouldblock_error() if appropriate (e.g. bio-based dm-multipath's case of queue_if_no_path).
Mike
Quoted 59 lines
--- drivers/md/dm-stripe.c | 2 +- drivers/md/dm-switch.c | 1 + drivers/md/dm-unstripe.c | 1 + drivers/md/dm-zero.c | 1 + 4 files changed, 4 insertions(+), 1 deletion(-)drivers/md/dm-stripe.c +1
-1@@ -496,7 +496,7 @@ static void stripe_io_hints(struct dm_target *ti,static struct target_type stripe_target = { .name ="striped" , .version = {1 ,6 ,0 }, - .features =DM_TARGET_PASSES_INTEGRITY , + .features =DM_TARGET_PASSES_INTEGRITY |DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = stripe_ctr, .dtr = stripe_dtr,drivers/md/dm-switch.c +1
-0@@ -550,6 +550,7 @@ static int switch_iterate_devices(struct dm_target *ti,static struct target_type switch_target = { .name ="switch" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = switch_ctr, .dtr = switch_dtr,drivers/md/dm-unstripe.c +1
-0@@ -178,6 +178,7 @@ static void unstripe_io_hints(struct dm_target *ti,static struct target_type unstripe_target = { .name ="unstriped" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = unstripe_ctr, .dtr = unstripe_dtr,drivers/md/dm-zero.c +1
-0@@ -59,6 +59,7 @@ static int zero_map(struct dm_target *ti, struct bio *bio)static struct target_type zero_target = { .name ="zero" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = zero_ctr, .map = zero_map,Signature · 1 line
2.27.0
--
dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel
Hi Jens and guys in block/io_uring mailing list, this mail contains some discussion abount
RWF_NOWAIT, please see the following contents.
Quoted 5 lines · Mike Snitzer
Quoted 2 lines · Jeffle Xu
This is one prep patch for supporting iopoll for dm device.
Quoted 7 lines
Quoted 5 lines
The direct IO routine will set
REQ_NOWAITflag forREQ_HIPRIIO (that is, IO will do iopoll) inbio_set_polled(). Then in the IO submission routine, the ability of handlingREQ_NOWAITof the block device will be checked forREQ_HIPRIIO insubmit_bio_checks().-EOPNOTSUPPwill be returned if the block device doesn't supportREQ_NOWAIT.
submit_bio_checks()verifies therequest_queuehasQUEUE_FLAG_NOWAITset if the bio hasREQ_NOWAIT.
Yes that's the case.
Quoted 7 lines
Quoted 5 lines
DM lacks support for
REQ_NOWAITuntil commit6abc49468eea("dm: add support forREQ_NOWAITand enable it for linear target"). Since then, dm targets that supportREQ_NOWAITshould advertiseDM_TARGET_NOWAITfeature.I'm not seeing why
DM_TARGET_NOWAITis needed (since you didn't add any code that consumes the flag).
As I said, it's needed if we support iopoll for dm device. Only if a block device is capable of
handling NOWAIT, then it can support iopoll.
IO submitted for iopoll (marked with IOCB_HIPRI) is usually also marked with REQ_NOWAIT.
There are two scenario when it could happen.
1. io_uring will set REQ_NOWAIT
The IO submission of io_uring can be divided into two phase. First, IO will be submitted
synchronously in user process context (when sqthread feature disabled), or sqthread
context (when sqthread feature enabled).
```sh - current process context when sqthread disabled, or sqthread when it's enabled io_uring_enter io_submit_sqes io_submit_sqe io_queue_sqe __io_queue_sqe io_issue_sqe // with @force_nonblock is true io_read/io_write ```
In this case, IO should be handled in a NOWAIT way, since the user process or sqthread
can not be blocked for performance.
``` io_read/io_write /* Ensure we clear previously set non-block flag */ if (!force_nonblock) kiocb->ki_flags &= ~IOCB_NOWAIT; else kiocb->ki_flags |= IOCB_NOWAIT; ```
2. The direct IO routine will set REQ_NOWAIT for polling IO
Both fs/block_dev.c: __blkdev_direct_IO and fs/iomap/direct-io.c: iomap_dio_submit_bio will
call bio_set_polled(), in which will set REQ_NOWAIT for polling IO.
```sh __blkdev_direct_IO / iomap_dio_submit_bio: if (dio->iocb->ki_flags & IOCB_HIPRI) bio_set_polled bio->bi_opf |= REQ_NOWAIT ```
Thus to support iopoll for dm device, the dm target should be capable of handling NOWAIT,
or submit_bio_checks() will fail with -EOPNOTSUPP when submitting bio to dm device.
Quoted 8 lines
dm-table.c:dm_table_set_restrictions() has:
if (dm_table_supports_nowait(t)) blk_queue_flag_set(QUEUE_FLAG_NOWAIT, q); else blk_queue_flag_clear(QUEUE_FLAG_NOWAIT, q);
Quoted 4 lines
Quoted 2 lines
This patch adds support for
DM_TARGET_NOWAITfor those dm targets, the .map() algorithm of which just involves sector recalculation.So you're looking to constrain which targets will properly support
REQ_NOWAIT, based on whether they do a simple remapping?
To be honest, I'm a little confused about the semantics of REQ_NOWAIT. Jens may had ever
explained it in block or io_uring mailing list, but I can't find the specific mail.
The man page explains FMODE_NOWAIT as 'File is capable of returning -EAGAIN if I/O will
block'.
And RWF_NOWAIT as
``` RWF_NOWAIT (since Linux 4.14) Don't wait if the I/O will block for operations such as file block allocations, dirty page flush, mutex locks, or a congested block device inside the kernel. If any of these conditions are met, the control block is re‐ turned immediately with a return value of -EAGAIN in the res field of the io_event structure (see io_getevents(2)). ```
commit 6abc49468eea ("dm: add support for REQ_NOWAIT and enable it for linear
target") handles NOWAIT for DM core as
```
@@ -1802,7 +1802,9 @@ static blk_qc_t dm_submit_bio(struct bio *bio)
if (unlikely(test_bit(DMF_BLOCK_IO_FOR_SUSPEND, &md->flags))) {
+ if (bio->bi_opf & REQ_NOWAIT)
+ bio_wouldblock_error(bio);
+ else if (!(bio->bi_opf & REQ_RAHEAD))
queue_io(md, bio);
```Theoretically the block device could advertise QUEUE_FLAG_NOWAIT as long as it could
'return -EAGAIN if I/O will block' as the man page said. However, considering when the
dm device detected as suspending, the submitted bios are deferred to workqueue in
drivers/dm/dm.c: dm_submit_bio. In this case, IO gets **deferred** while the user process
will not be **blocked**. Can we say IO gets **blocked** in this case?
Actually several dm targets handle submitted bio in this deferred way, such as dm-crypt/
dm-delay/dm-era/dm-ebs. Can we say these targets are not capable of handling NOWAIT?
Also when system is short of memory, bio allocation in bio_alloc_bioset() may trigger memory
direct reclaim, as the gfp_mask is usually GFP_NOIO. While in memory direct reclaim, the
process may be scheduled out, but I have never seen the proper handling for NOWAIT in this
situation. Maybe the block or io_uring guys have more insights?
So there's just too many possibilities that may get blocked, not to say mutex locks.
Quoted 6 lines
Quoted 6 lines
Signed-off-by Jeffle Xu <[email protected]>---
Hi Mike,
Quoted 7 lines
Quoted 2 lines
I could split these boilerplate code that each dm target have one seperate patch if you think that would be better.
One patch for all these is fine. But it should include the code that I assume you'll be adding to
dm_table_supports_nowait()to further verify that the targets in the table are allDM_TARGET_NOWAIT.And why isn't dm-linear setting
DM_TARGET_NOWAIT?
These are all done in commit 6abc49468eea ("dm: add support for REQ_NOWAIT and enable it for linear target").
Quoted 4 lines
Also, other targets _could_ be made to support
REQ_NOWAITby conditionally returningbio_wouldblock_error()if appropriate (e.g. bio-based dm-multipath's case ofqueue_if_no_path).
Signature · 2 lines
Thanks, Jeffle
Quoted 8 lines · JeffleXu
Quoted 8 lines
dm-table.c:dm_table_set_restrictions() has:
if (
dm_table_supports_nowait(t))blk_queue_flag_set(QUEUE_FLAG_NOWAIT, q); elseblk_queue_flag_clear(QUEUE_FLAG_NOWAIT, q);
Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
This patch adds support for
DM_TARGET_NOWAITfor those dm targets, the .map() algorithm of which just involves sector recalculation.So you're looking to constrain which targets will properly support
REQ_NOWAIT, based on whether they do a simple remapping?To be honest, I'm a little confused about the semantics of
REQ_NOWAIT. Jens may had everexplained it in block or
io_uringmailing list, but I can't find the specific mail.
I find it here https://lore.kernel.org/linux-block/[email protected]/
So if the IO is offloaded to workqueue and the current process context will not get blocked,
then is this device capable of handling REQ_NOWAIT or not?
Signature · 2 lines
Thanks, Jeffle
Quoted 213 lines · JeffleXu
Hi Jens and guys in
block/io_uringmailing list, this mail contains some discussion abount
RWF_NOWAIT, please see the following contents.Quoted 5 lines · Mike Snitzer
Quoted 2 lines · Jeffle Xu
This is one prep patch for supporting iopoll for dm device.
Quoted 7 lines
Quoted 5 lines
The direct IO routine will set
REQ_NOWAITflag forREQ_HIPRIIO (that is, IO will do iopoll) inbio_set_polled(). Then in the IO submission routine, the ability of handlingREQ_NOWAITof the block device will be checked forREQ_HIPRIIO insubmit_bio_checks().-EOPNOTSUPPwill be returned if the block device doesn't supportREQ_NOWAIT.
submit_bio_checks()verifies therequest_queuehasQUEUE_FLAG_NOWAITset if the bio hasREQ_NOWAIT.Yes that's the case.
Quoted 7 lines
Quoted 5 lines
DM lacks support for
REQ_NOWAITuntil commit6abc49468eea("dm: add support forREQ_NOWAITand enable it for linear target"). Since then, dm targets that supportREQ_NOWAITshould advertiseDM_TARGET_NOWAITfeature.I'm not seeing why
DM_TARGET_NOWAITis needed (since you didn't add any code that consumes the flag).As I said, it's needed if we support iopoll for dm device. Only if a block device is capable of
handling NOWAIT, then it can support iopoll.
IO submitted for iopoll (marked with
IOCB_HIPRI) is usually also marked withREQ_NOWAIT.There are two scenario when it could happen.
1.
io_uringwill setREQ_NOWAITThe IO submission of
io_uringcan be divided into two phase. First, IO will be submittedsynchronously in user process context (when sqthread feature disabled), or sqthread
context (when sqthread feature enabled).
```sh - current process context when sqthread disabled, or sqthread when it's enabled io_uring_enter io_submit_sqes io_submit_sqe io_queue_sqe __io_queue_sqe io_issue_sqe // with @force_nonblock is true io_read/io_write ```In this case, IO should be handled in a NOWAIT way, since the user process or sqthread
can not be blocked for performance.
``` io_read/io_write /* Ensure we clear previously set non-block flag */ if (!force_nonblock) kiocb->ki_flags &= ~IOCB_NOWAIT; else kiocb->ki_flags |= IOCB_NOWAIT; ```2. The direct IO routine will set
REQ_NOWAITfor polling IOBoth
fs/block_dev.c:__blkdev_direct_IOandfs/iomap/direct-io.c:iomap_dio_submit_biowillcall
bio_set_polled(), in which will setREQ_NOWAITfor polling IO.```sh __blkdev_direct_IO / iomap_dio_submit_bio: if (dio->iocb->ki_flags & IOCB_HIPRI) bio_set_polled bio->bi_opf |= REQ_NOWAIT ```Thus to support iopoll for dm device, the dm target should be capable of handling NOWAIT,
or
submit_bio_checks()will fail with-EOPNOTSUPPwhen submitting bio to dm device.Quoted 8 lines
dm-table.c:dm_table_set_restrictions() has:
if (dm_table_supports_nowait(t)) blk_queue_flag_set(QUEUE_FLAG_NOWAIT, q); else blk_queue_flag_clear(QUEUE_FLAG_NOWAIT, q);Quoted 4 lines
Quoted 2 lines
This patch adds support for
DM_TARGET_NOWAITfor those dm targets, the .map() algorithm of which just involves sector recalculation.So you're looking to constrain which targets will properly support
REQ_NOWAIT, based on whether they do a simple remapping?To be honest, I'm a little confused about the semantics of
REQ_NOWAIT. Jens may had everexplained it in block or
io_uringmailing list, but I can't find the specific mail.The man page explains
FMODE_NOWAITas 'File is capable of returning-EAGAINif I/O willblock'.
And
RWF_NOWAITas``` RWF_NOWAIT (since Linux 4.14) Don't wait if the I/O will block for operations such as file block allocations, dirty page flush, mutex locks, or a congested block device inside the kernel. If any of these conditions are met, the control block is re‐ turned immediately with a return value of -EAGAIN in the res field of the io_event structure (see io_getevents(2)). ```commit
6abc49468eea("dm: add support forREQ_NOWAITand enable it for lineartarget") handles NOWAIT for DM core as
```
(quoted diff) +3
-0@@ -1802,7 +1802,9 @@ static blk_qc_t dm_submit_bio(struct bio *bio) if (unlikely(test_bit(DMF_BLOCK_IO_FOR_SUSPEND, &md->flags))) { + if (bio->bi_opf & REQ_NOWAIT) + bio_wouldblock_error(bio); + else if (!(bio->bi_opf & REQ_RAHEAD)) queue_io(md, bio);```
Theoretically the block device could advertise
QUEUE_FLAG_NOWAITas long as it could'return
-EAGAINif I/O will block' as the man page said. However, considering when thedm device detected as suspending, the submitted bios are deferred to workqueue in
drivers/dm/dm.c:dm_submit_bio. In this case, IO gets **deferred** while the user processwill not be **blocked**. Can we say IO gets **blocked** in this case?
Actually several dm targets handle submitted bio in this deferred way, such as dm-crypt/
dm-delay/dm-era/dm-ebs. Can we say these targets are not capable of handling NOWAIT?
Also when system is short of memory, bio allocation in
bio_alloc_bioset()may trigger memorydirect reclaim, as the
gfp_maskis usuallyGFP_NOIO. While in memory direct reclaim, theprocess may be scheduled out, but I have never seen the proper handling for NOWAIT in this
situation. Maybe the block or
io_uringguys have more insights?So there's just too many possibilities that may get blocked, not to say mutex locks.
Quoted 8 lines
Quoted 8 lines
Signed-off-by Jeffle Xu <[email protected]>---
Hi Mike,I could split these boilerplate code that each dm target have one seperate patch if you think that would be better.
Quoted 8 lines
Quoted 5 lines
One patch for all these is fine. But it should include the code that I assume you'll be adding to
dm_table_supports_nowait()to further verify that the targets in the table are allDM_TARGET_NOWAIT.And why isn't dm-linear setting
DM_TARGET_NOWAIT?These are all done in commit
6abc49468eea("dm: add support forREQ_NOWAITand enable it for
linear target").
Ha, oops. You'd think I'd have remembered adding DM_TARGET_NOWAIT to dm-linear and dm_target_supports_nowait, etc.
Thanks for clarifying. So your patch was just about extending the capability to other targets where you think it applicable.
We'll be able to make that clearer by tweaking the header a bit.
Mike
PATCH v2 1/1 dm: add support for DM_TARGET_NOWAIT for various targets
In reply to Jeffle Xucommit 021a24460dc2 ("block: add QUEUE_FLAG_NOWAIT") adds a new queue flag QUEUE_FLAG_NOWAIT to advertise if the bdev supports handling of REQ_NOWAIT or not. DM core supports this in commit 6abc49468eea ("dm:
add support for REQ_NOWAIT and enable it for linear target"), in which only dm-linear is enabled.
This patch also enables several dm-linear likely dm targets, the mapping algorithm of which is just simple remapping.
--- drivers/md/dm-stripe.c | 2 +- drivers/md/dm-switch.c | 1 + drivers/md/dm-unstripe.c | 1 + drivers/md/dm-zero.c | 1 + 4 files changed, 4 insertions(+), 1 deletion(-)
drivers/md/dm-stripe.c +1 -1
@@ -496,7 +496,7 @@ static void stripe_io_hints(struct dm_target *ti,static struct target_type stripe_target = { .name ="striped" , .version = {1 ,6 ,0 }, - .features =DM_TARGET_PASSES_INTEGRITY , + .features =DM_TARGET_PASSES_INTEGRITY |DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = stripe_ctr, .dtr = stripe_dtr,
drivers/md/dm-switch.c +1 -0
@@ -550,6 +550,7 @@ static int switch_iterate_devices(struct dm_target *ti,static struct target_type switch_target = { .name ="switch" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = switch_ctr, .dtr = switch_dtr,
drivers/md/dm-unstripe.c +1 -0
@@ -178,6 +178,7 @@ static void unstripe_io_hints(struct dm_target *ti,static struct target_type unstripe_target = { .name ="unstriped" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = unstripe_ctr, .dtr = unstripe_dtr,
drivers/md/dm-zero.c +1 -0
@@ -59,6 +59,7 @@ static int zero_map(struct dm_target *ti, struct bio *bio)static struct target_type zero_target = { .name ="zero" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = zero_ctr, .map = zero_map,
Signature · 6 lines
2.27.0 -- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
Hi Mike,
I just tweaks the commit message in this v2 patch to make the purpose clearer,
while keep the code unstained.
Thanks,
Jeffle
Quoted 66 lines · Jeffle Xu
commit
021a24460dc2("block: addQUEUE_FLAG_NOWAIT") adds a new queue flagQUEUE_FLAG_NOWAITto advertise if the bdev supports handling ofREQ_NOWAITor not. DM core supports this in commit6abc49468eea("dm:
add support forREQ_NOWAITand enable it for linear target"), in which only dm-linear is enabled.This patch also enables several dm-linear likely dm targets, the mapping algorithm of which is just simple remapping.
Signed-off-by Jeffle Xu <[email protected]>--- drivers/md/dm-stripe.c | 2 +- drivers/md/dm-switch.c | 1 + drivers/md/dm-unstripe.c | 1 + drivers/md/dm-zero.c | 1 + 4 files changed, 4 insertions(+), 1 deletion(-)drivers/md/dm-stripe.c +1
-1@@ -496,7 +496,7 @@ static void stripe_io_hints(struct dm_target *ti,static struct target_type stripe_target = { .name ="striped" , .version = {1 ,6 ,0 }, - .features =DM_TARGET_PASSES_INTEGRITY , + .features =DM_TARGET_PASSES_INTEGRITY |DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = stripe_ctr, .dtr = stripe_dtr,drivers/md/dm-switch.c +1
-0@@ -550,6 +550,7 @@ static int switch_iterate_devices(struct dm_target *ti,static struct target_type switch_target = { .name ="switch" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = switch_ctr, .dtr = switch_dtr,drivers/md/dm-unstripe.c +1
-0@@ -178,6 +178,7 @@ static void unstripe_io_hints(struct dm_target *ti,static struct target_type unstripe_target = { .name ="unstriped" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = unstripe_ctr, .dtr = unstripe_dtr,drivers/md/dm-zero.c +1
-0@@ -59,6 +59,7 @@ static int zero_map(struct dm_target *ti, struct bio *bio)static struct target_type zero_target = { .name ="zero" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = zero_ctr, .map = zero_map,
Signature · 7 lines
Thanks, Jeffle -- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
Hi Mike,
How about this patch? I just tweaks the commit message in this v2 patch to make
the purpose clearer, while keep the code unstained.
Thanks,
Jeffle
Quoted 66 lines · Jeffle Xu
commit
021a24460dc2("block: addQUEUE_FLAG_NOWAIT") adds a new queue flagQUEUE_FLAG_NOWAITto advertise if the bdev supports handling ofREQ_NOWAITor not. DM core supports this in commit6abc49468eea("dm:
add support forREQ_NOWAITand enable it for linear target"), in which only dm-linear is enabled.This patch also enables several dm-linear likely dm targets, the mapping algorithm of which is just simple remapping.
Signed-off-by Jeffle Xu <[email protected]>--- drivers/md/dm-stripe.c | 2 +- drivers/md/dm-switch.c | 1 + drivers/md/dm-unstripe.c | 1 + drivers/md/dm-zero.c | 1 + 4 files changed, 4 insertions(+), 1 deletion(-)drivers/md/dm-stripe.c +1
-1@@ -496,7 +496,7 @@ static void stripe_io_hints(struct dm_target *ti,static struct target_type stripe_target = { .name ="striped" , .version = {1 ,6 ,0 }, - .features =DM_TARGET_PASSES_INTEGRITY , + .features =DM_TARGET_PASSES_INTEGRITY |DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = stripe_ctr, .dtr = stripe_dtr,drivers/md/dm-switch.c +1
-0@@ -550,6 +550,7 @@ static int switch_iterate_devices(struct dm_target *ti,static struct target_type switch_target = { .name ="switch" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = switch_ctr, .dtr = switch_dtr,drivers/md/dm-unstripe.c +1
-0@@ -178,6 +178,7 @@ static void unstripe_io_hints(struct dm_target *ti,static struct target_type unstripe_target = { .name ="unstriped" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = unstripe_ctr, .dtr = unstripe_dtr,drivers/md/dm-zero.c +1
-0@@ -59,6 +59,7 @@ static int zero_map(struct dm_target *ti, struct bio *bio)static struct target_type zero_target = { .name ="zero" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = zero_ctr, .map = zero_map,
Signature · 7 lines
Thanks, Jeffle -- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
I just staged this for 5.11, see:
https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.11&id=373ce365b756bf6fec237461a0bbe65f33f201f6
I tweaked your patch header just a bit.
Thanks,
Mike
Quoted 72 lines · JeffleXu
Hi Mike,
How about this patch? I just tweaks the commit message in this v2 patch to make
the purpose clearer, while keep the code unstained.
Thanks,
Jeffle
Quoted 58 lines · Jeffle Xu
commit
021a24460dc2("block: addQUEUE_FLAG_NOWAIT") adds a new queue flagQUEUE_FLAG_NOWAITto advertise if the bdev supports handling ofREQ_NOWAITor not. DM core supports this in commit6abc49468eea("dm:
add support forREQ_NOWAITand enable it for linear target"), in which only dm-linear is enabled.This patch also enables several dm-linear likely dm targets, the mapping algorithm of which is just simple remapping.
Signed-off-by Jeffle Xu <[email protected]>--- drivers/md/dm-stripe.c | 2 +- drivers/md/dm-switch.c | 1 + drivers/md/dm-unstripe.c | 1 + drivers/md/dm-zero.c | 1 + 4 files changed, 4 insertions(+), 1 deletion(-)drivers/md/dm-stripe.c +1
-1@@ -496,7 +496,7 @@ static void stripe_io_hints(struct dm_target *ti,static struct target_type stripe_target = { .name ="striped" , .version = {1 ,6 ,0 }, - .features =DM_TARGET_PASSES_INTEGRITY , + .features =DM_TARGET_PASSES_INTEGRITY |DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = stripe_ctr, .dtr = stripe_dtr,drivers/md/dm-switch.c +1
-0@@ -550,6 +550,7 @@ static int switch_iterate_devices(struct dm_target *ti,static struct target_type switch_target = { .name ="switch" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = switch_ctr, .dtr = switch_dtr,drivers/md/dm-unstripe.c +1
-0@@ -178,6 +178,7 @@ static void unstripe_io_hints(struct dm_target *ti,static struct target_type unstripe_target = { .name ="unstriped" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = unstripe_ctr, .dtr = unstripe_dtr,drivers/md/dm-zero.c +0
-0
Quoted 13 lines
Quoted 8 lines
drivers/md/dm-zero.c +1
-0@@ -59,6 +59,7 @@ static int zero_map(struct dm_target *ti, struct bio *bio)static struct target_type zero_target = { .name ="zero" , .version = {1 ,1 ,0 }, + .features =DM_TARGET_NOWAIT , .module =THIS_MODULE , .ctr = zero_ctr, .map = zero_map,Signature · 2 lines
Thanks, Jeffle
--
dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel