Skip to contentSkip to conversation

drm/amd/display: Report non-DP display as disconnected without EDID

PATCH In review Harry Wentland 3 participants 4 messages Aug 1, 2018 – Aug 2, 2018 2 messages not in the archive

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/amd/display: Report non-DP display as disconnected without EDID

[Why]
Some boards seem to have a problem where HPD is high on HDMI even though no display is connected. We don't want to report these as connected. DP spec still requires us to report DP displays as connected when HPD is high but we can't read the EDID in order to go to fail-safe mode.

[How]
If connector_signal is not DP abort detection if we can't retrieve the EDID.

Bugzilla: https://bugs.freedesktop.org/107390
Bugzilla: https://bugs.freedesktop.org/106846

v2: Add Bugzilla and stable

---
 drivers/gpu/drm/amd/display/dc/core/dc_link.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/gpu/drm/amd/display/dc/core/dc_link.c +11 -0
index b180197a41e2..84f0fd15be4c 100644
@@ -744,6 +744,17 @@ bool dc_link_detect(struct dc_link *link, enum dc_detect_reason reason)
 			break;
 		case EDID_NO_RESPONSE:
 			DC_LOG_ERROR("No EDID read.\n");
+
+			/*
+			 * Abort detection for non-DP connectors if we have
+			 * no EDID
+			 *
+			 * DP needs to report as connected if HDP is high
+			 * even if we have no EDID in order to go to
+			 * fail-safe mode
+			 */
+			if (!dc_is_dp_signal(link->connector_signal))
+				return false;
 		default:
 			break;
 		}
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by on v2 1/1
#1 lore raw
Quoted 34 lines · Harry Wentland

[Why]
Some boards seem to have a problem where HPD is high on HDMI even though no display is connected. We don't want to report these as connected. DP spec still requires us to report DP displays as connected when HPD is high but we can't read the EDID in order to go to fail-safe mode.

[How]
If connector_signal is not DP abort detection if we can't retrieve the EDID.

Bugzilla: https://bugs.freedesktop.org/107390
Bugzilla: https://bugs.freedesktop.org/106846

v2: Add Bugzilla and stable

---
  drivers/gpu/drm/amd/display/dc/core/dc_link.c | 11 +++++++++++
  1 file changed, 11 insertions(+)
drivers/gpu/drm/amd/display/dc/core/dc_link.c +4 -0
index b180197a41e2..84f0fd15be4c 100644
@@ -744,6 +744,17 @@ bool dc_link_detect(struct dc_link *link, enum dc_detect_reason reason)
  			break;
  		case EDID_NO_RESPONSE:
  			DC_LOG_ERROR("No EDID read.\n");
+
+			/*
+			 * Abort detection for non-DP connectors if we have
+			 * no EDID

drivers/gpu/drm/amd/display/dc/core/dc_link.c bool dc_link_detect(struct dc_link *link, enum dc_detect_reason reason) · line 760

Quoted 10 lines
drivers/gpu/drm/amd/display/dc/core/dc_link.c +7 -0
+			 *
+			 * DP needs to report as connected if HDP is high
+			 * even if we have no EDID in order to go to
+			 * fail-safe mode
+			 */
+			if (!dc_is_dp_signal(link->connector_signal))
+				return false;
  		default:
  			break;
  		}

A message that is not in the archive (sent off-list or not yet received): 20180801195106.10971-1-harry.wentland-5C7GfCeVMHo@public.gmane.org

#3 lore raw
Quoted 34 lines · Harry Wentland

[Why]
Some boards seem to have a problem where HPD is high on HDMI even though no display is connected. We don't want to report these as connected. DP spec still requires us to report DP displays as connected when HPD is high but we can't read the EDID in order to go to fail-safe mode.

[How]
If connector_signal is not DP abort detection if we can't retrieve the EDID.

Bugzilla: https://bugs.freedesktop.org/107390
Bugzilla: https://bugs.freedesktop.org/106846

v2: Add Bugzilla and stable

---
 drivers/gpu/drm/amd/display/dc/core/dc_link.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/gpu/drm/amd/display/dc/core/dc_link.c +4 -0
index b180197a41e2..84f0fd15be4c 100644
@@ -744,6 +744,17 @@ bool dc_link_detect(struct dc_link *link, enum dc_detect_reason reason)
 			break;
 		case EDID_NO_RESPONSE:
 			DC_LOG_ERROR("No EDID read.\n");
+
+			/*
+			 * Abort detection for non-DP connectors if we have
+			 * no EDID

drivers/gpu/drm/amd/display/dc/core/dc_link.c bool dc_link_detect(struct dc_link *link, enum dc_detect_reason reason) · line 760

Quoted 10 lines
drivers/gpu/drm/amd/display/dc/core/dc_link.c +7 -0
+			 *
+			 * DP needs to report as connected if HDP is high
+			 * even if we have no EDID in order to go to
+			 * fail-safe mode
+			 */
+			if (!dc_is_dp_signal(link->connector_signal))
+				return false;
 		default:
 			break;
 		}

Could this be problematic with VGA connectors? AFAIR e.g. KVM switches can cause trouble with retrieving EDID, or it could just be an old CRT with no EDID in the first place.

Might it make sense to limit this to HDMI & DVI?

Signature · 6 lines
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 5eb3dba3-82cd-e1c6-1828-93b05a33934c-otUistvHUpPR7s880joybQ@public.gmane.org

#5 lore raw
Quoted 41 lines · Michel Dänzer
Quoted 40 lines · Harry Wentland

[Why]
Some boards seem to have a problem where HPD is high on HDMI even though no display is connected. We don't want to report these as connected. DP spec still requires us to report DP displays as connected when HPD is high but we can't read the EDID in order to go to fail-safe mode.

[How]
If connector_signal is not DP abort detection if we can't retrieve the EDID.

Bugzilla: https://bugs.freedesktop.org/107390
Bugzilla: https://bugs.freedesktop.org/106846

v2: Add Bugzilla and stable

---
 drivers/gpu/drm/amd/display/dc/core/dc_link.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/gpu/drm/amd/display/dc/core/dc_link.c +11 -0
index b180197a41e2..84f0fd15be4c 100644
@@ -744,6 +744,17 @@ bool dc_link_detect(struct dc_link *link, enum dc_detect_reason reason)
 			break;
 		case EDID_NO_RESPONSE:
 			DC_LOG_ERROR("No EDID read.\n");
+
+			/*
+			 * Abort detection for non-DP connectors if we have
+			 * no EDID
+			 *
+			 * DP needs to report as connected if HDP is high
+			 * even if we have no EDID in order to go to
+			 * fail-safe mode
+			 */
+			if (!dc_is_dp_signal(link->connector_signal))
+				return false;
Quoted 9 lines

drivers/gpu/drm/amd/display/dc/core/dc_link.c bool dc_link_detect(struct dc_link *link, enum dc_detect_reason reason) · line 760

Quoted 4 lines
drivers/gpu/drm/amd/display/dc/core/dc_link.c +0 -0
 		default:
 			break;
 		}

Could this be problematic with VGA connectors? AFAIR e.g. KVM switches can cause trouble with retrieving EDID, or it could just be an old CRT with no EDID in the first place.

Good point, although DC doesn't currently support VGA. I'll send another patch anyways in case anyone enables VGA in the future as this would be easily missed.

Harry

Quoted 3 lines

Might it make sense to limit this to HDMI & DVI?

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx