vfio/nvlink: Remove exec permission to avoid SELinux AVCs
PATCH RESEND 1/1 vfio/nvlink: Remove exec permission to avoid SELinux AVCs
If SELinux is setup without 'execmem' permission for qemu, all mmap with (PROT_WRITE | PROT_EXEC) will fail and print a warning in SELinux log.
If "nvlink2-mr" memory allocation fails (fist diff), it will cause guest NUMA nodes to not be correctly configured (V100 memory will not be visible for guest, nor its NUMA nodes).
Not having 'execmem' permission is intesting for virtual machines to avoid buffer-overflow based attacks, and it's adopted in distros like RHEL.
So, removing the PROT_EXEC flag seems the right thing to do.
Browsing some other code that mmaps memory for usage with memory_region_init_ram_device_ptr, I could notice it's usual to not have PROT_EXEC (only PROT_READ | PROT_WRITE), so it should be no problem around this.
---
- Alexey's review is here: https://lists.nongnu.org/archive/html/qemu-devel/2020-05/msg00006.html
hw/vfio/pci-quirks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
hw/vfio/pci-quirks.c +2 -2
@@ -1620,7 +1620,7 @@ int vfio_pci_nvidia_v100_ram_init(VFIOPCIDevice *vdev, Error **errp) } cap = (void *) hdr; - p =mmap (NULL , nv2reg->size,PROT_READ |PROT_WRITE |PROT_EXEC , + p =mmap (NULL , nv2reg->size,PROT_READ |PROT_WRITE ,MAP_SHARED , vdev->vbasedev.fd, nv2reg->offset);if (p ==MAP_FAILED ) { ret = -errno;
@@ -1680,7 +1680,7 @@ int vfio_pci_nvlink2_init(VFIOPCIDevice *vdev, Error **errp)/* Some NVLink bridges may not have assigned ATSD */ if (atsdreg->size) { - p =mmap (NULL , atsdreg->size,PROT_READ |PROT_WRITE |PROT_EXEC , + p =mmap (NULL , atsdreg->size,PROT_READ |PROT_WRITE ,MAP_SHARED , vdev->vbasedev.fd, atsdreg->offset);if (p ==MAP_FAILED ) { ret = -errno;
Quoted 19 lines · On Mon, 18 May 2020 12:05:24 -0300 Leonardo Bras <[email protected]> wrote:
If SELinux is setup without 'execmem' permission for qemu, all mmap with (
PROT_WRITE|PROT_EXEC) will fail and print a warning in SELinux log.If "nvlink2-mr" memory allocation fails (fist diff), it will cause guest NUMA nodes to not be correctly configured (V100 memory will not be visible for guest, nor its NUMA nodes).
Not having 'execmem' permission is intesting for virtual machines to avoid buffer-overflow based attacks, and it's adopted in distros like RHEL.
So, removing the
PROT_EXECflag seems the right thing to do.Browsing some other code that mmaps memory for usage with
memory_region_init_ram_device_ptr, I could notice it's usual to not havePROT_EXEC(onlyPROT_READ|PROT_WRITE), so it should be no problem around this.
Quoted 4 lines
Signed-off-by Leonardo Bras <[email protected]>Reviewed-by Alexey Kardashevskiy <[email protected]>---
Seems David Gibson might be in a position to send a pull request including this before I can, so:
Quoted 28 lines
- Alexey's review is here: https://lists.nongnu.org/archive/html/qemu-devel/2020-05/msg00006.html
hw/vfio/pci-quirks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)hw/vfio/pci-quirks.c +2
-2@@ -1620,7 +1620,7 @@ int vfio_pci_nvidia_v100_ram_init(VFIOPCIDevice *vdev, Error **errp) } cap = (void *) hdr; - p =mmap (NULL , nv2reg->size,PROT_READ |PROT_WRITE |PROT_EXEC , + p =mmap (NULL , nv2reg->size,PROT_READ |PROT_WRITE ,MAP_SHARED , vdev->vbasedev.fd, nv2reg->offset);if (p ==MAP_FAILED ) { ret = -errno;@@ -1680,7 +1680,7 @@ int vfio_pci_nvlink2_init(VFIOPCIDevice *vdev, Error **errp)/* Some NVLink bridges may not have assigned ATSD */ if (atsdreg->size) { - p =mmap (NULL , atsdreg->size,PROT_READ |PROT_WRITE |PROT_EXEC , + p =mmap (NULL , atsdreg->size,PROT_READ |PROT_WRITE ,MAP_SHARED , vdev->vbasedev.fd, atsdreg->offset);if (p ==MAP_FAILED ) { ret = -errno;
David Gibson
AppliedQuoted 22 lines · Alex Williamson
Quoted 19 lines · On Mon, 18 May 2020 12:05:24 -0300 Leonardo Bras <[email protected]> wrote:
If SELinux is setup without 'execmem' permission for qemu, all mmap with (
PROT_WRITE|PROT_EXEC) will fail and print a warning in SELinux log.If "nvlink2-mr" memory allocation fails (fist diff), it will cause guest NUMA nodes to not be correctly configured (V100 memory will not be visible for guest, nor its NUMA nodes).
Not having 'execmem' permission is intesting for virtual machines to avoid buffer-overflow based attacks, and it's adopted in distros like RHEL.
So, removing the
PROT_EXECflag seems the right thing to do.Browsing some other code that mmaps memory for usage with
memory_region_init_ram_device_ptr, I could notice it's usual to not havePROT_EXEC(onlyPROT_READ|PROT_WRITE), so it should be no problem around this.
Quoted 7 lines
Quoted 4 lines
Signed-off-by Leonardo Bras <[email protected]>Reviewed-by Alexey Kardashevskiy <[email protected]>---
Seems David Gibson might be in a position to send a pull request including this before I can, so:
Merged to ppc-for-5.1, thanks.
Quoted 34 lines
Acked-by Alex Williamson <[email protected]>Quoted 28 lines
- Alexey's review is here: https://lists.nongnu.org/archive/html/qemu-devel/2020-05/msg00006.html
hw/vfio/pci-quirks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)hw/vfio/pci-quirks.c +2
-2@@ -1620,7 +1620,7 @@ int vfio_pci_nvidia_v100_ram_init(VFIOPCIDevice *vdev, Error **errp) } cap = (void *) hdr; - p =mmap (NULL , nv2reg->size,PROT_READ |PROT_WRITE |PROT_EXEC , + p =mmap (NULL , nv2reg->size,PROT_READ |PROT_WRITE ,MAP_SHARED , vdev->vbasedev.fd, nv2reg->offset);if (p ==MAP_FAILED ) { ret = -errno;@@ -1680,7 +1680,7 @@ int vfio_pci_nvlink2_init(VFIOPCIDevice *vdev, Error **errp)/* Some NVLink bridges may not have assigned ATSD */ if (atsdreg->size) { - p =mmap (NULL , atsdreg->size,PROT_READ |PROT_WRITE |PROT_EXEC , + p =mmap (NULL , atsdreg->size,PROT_READ |PROT_WRITE ,MAP_SHARED , vdev->vbasedev.fd, atsdreg->offset);if (p ==MAP_FAILED ) { ret = -errno;
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson