efs: Delete unnecessary checks before brelse()
PATCH 1/1 efs: Delete unnecessary checks before brelse()
From: Markus Elfring <[email protected]>
Date: Tue, 3 Sep 2019 14:24:38 +0200
The brelse() function tests whether its argument is NULL and then returns immediately.
Thus the tests around the shown calls are not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by Markus Elfring <[email protected]>
--- fs/efs/inode.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
fs/efs/inode.c +5 -6
@@ -262,7 +262,7 @@ efs_block_t efs_map_block(struct inode *inode, efs_block_t block) {/* should never happen */ pr_err ("couldn't find direct extent for indirect extent %d (block %u)\n" , cur, block); -if (bh)brelse (bh); +brelse (bh);return 0 ; }
@@ -274,8 +274,7 @@ efs_block_t efs_map_block(struct inode *inode, efs_block_t block) { (EFS_BLOCKSIZE /sizeof (efs_extent));if (first || lastblock != iblock) { -if (bh)brelse (bh); - +brelse (bh); bh =sb_bread (inode->i_sb, iblock);if (!bh) { pr_err("%s() failed at block %d\n",
@@ -295,17 +294,17 @@ efs_block_t efs_map_block(struct inode *inode, efs_block_t block) {if (ext.cooked.ex_magic !=0 ) {pr_err ("extent %d has bad magic number in block %d\n" , cur, iblock); -if (bh)brelse (bh); +brelse (bh);return 0 ; }if ((result =efs_extent_check (&ext, block, sb))) { -if (bh)brelse (bh); +brelse (bh); in->lastextent = cur;return result; } } -if (bh)brelse (bh); +brelse (bh);pr_err ("%s() failed to map block %u (indir)\n" , __func__, block);return 0 ; }
--
2.23.0