Skip to contentSkip to conversation

configure: default to PIE disabled on Windows platforms

PATCH Applied Daniel P. Berrangé 4 participants 4 messages Aug 24, 2020 – Aug 25, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: default to PIE disabled on Windows platforms

If Windows EXE files are built with -pie/-fpie they will fail to launch. Historically QEMU defaulted to disabling PIE for Windows, but this setting was accidentally lost when the configure summary text was removed in

commit f9332757898a764d85e19d339ec421236e885b68
Author: Paolo Bonzini <[email protected]>
Date: Mon Feb 3 13:28:38 2020 +0100

meson: move summary to meson.build

Fixes f9332757898a764d85e19d339ec421236e885b68
---
 configure | 1 +
 1 file changed, 1 insertion(+)
configure +1 -0
index 67832e3bab..b6f3b6e191 100755
@@ -857,6 +857,7 @@ MINGW32*)
     audio_drv_list=""
   fi
   supported_os="yes"
+  pie="no"
 ;;
 GNU/kFreeBSD)
   bsd="yes"
Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#1 lore raw

Hi

Quoted 9 lines · Daniel P. Berrangé

If Windows EXE files are built with -pie/-fpie they will fail to launch. Historically QEMU defaulted to disabling PIE for Windows, but this setting was accidentally lost when the configure summary text was removed in

commit f9332757898a764d85e19d339ec421236e885b68
Author: Paolo Bonzini <[email protected]>
Date: Mon Feb 3 13:28:38 2020 +0100

Quoted 7 lines

meson: move summary to meson.build

Fixes f9332757898a764d85e19d339ec421236e885b68

(one of those innocent looking commits)

---

Quoted 20 lines
 configure | 1 +
 1 file changed, 1 insertion(+)
configure +1 -1
index 67832e3bab..b6f3b6e191 100755
@@ -857,6 +857,7 @@ MINGW32*)
     audio_drv_list=""
   fi
   supported_os="yes"
+  pie="no"
 ;;
 GNU/kFreeBSD)
   bsd="yes"
--

2.26.2

Signature · 1 line
Marc-André Lureau
Reviewed-by on v1 1/1
#2 lore raw
In reply to Daniel P. Berrangé
Quoted 25 lines · Daniel P. Berrangé

If Windows EXE files are built with -pie/-fpie they will fail to launch. Historically QEMU defaulted to disabling PIE for Windows, but this setting was accidentally lost when the configure summary text was removed in

commit f9332757898a764d85e19d339ec421236e885b68
Author: Paolo Bonzini <[email protected]>
Date: Mon Feb 3 13:28:38 2020 +0100

meson: move summary to meson.build

Fixes f9332757898a764d85e19d339ec421236e885b68
---
  configure | 1 +
  1 file changed, 1 insertion(+)
configure +0 -0
index 67832e3bab..b6f3b6e191 100755

configure MINGW32*) · line 863

Quoted 7 lines
configure +1 -0
@@ -857,6 +857,7 @@ MINGW32*)
      audio_drv_list=""
    fi
    supported_os="yes"
+  pie="no"
  ;;
  GNU/kFreeBSD)
    bsd="yes"
#3 lore raw
In reply to Daniel P. Berrangé

Queued, thanks.

Paolo

Il lun 24 ago 2020, 18:31 Daniel P. Berrangé <[email protected]> ha scritto:

Quoted 35 lines

If Windows EXE files are built with -pie/-fpie they will fail to launch. Historically QEMU defaulted to disabling PIE for Windows, but this setting was accidentally lost when the configure summary text was removed in

commit f9332757898a764d85e19d339ec421236e885b68
Author: Paolo Bonzini <[email protected]>
Date: Mon Feb 3 13:28:38 2020 +0100

meson: move summary to meson.build

Fixes f9332757898a764d85e19d339ec421236e885b68
---
 configure | 1 +
 1 file changed, 1 insertion(+)
configure +1 -1
index 67832e3bab..b6f3b6e191 100755
@@ -857,6 +857,7 @@ MINGW32*)
     audio_drv_list=""
   fi
   supported_os="yes"
+  pie="no"
 ;;
 GNU/kFreeBSD)
   bsd="yes"
--

2.26.2