Skip to contentSkip to conversation

ice: disable stripping in default VSI ctx

PATCH New Marcin Szycik 3 participants 7 messages May 27, 2022 – May 30, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ice: disable stripping in default VSI ctx

From: Michal Swiatkowski <[email protected]>

In case when driver is in eswitch mode, having VLAN stripping enabled causes failure in communication. All VLAN configuration commands are blocked, because of that VF driver can't disable VLAN stripping at initialization. It leads to the situation when VLAN stripping on VF VSI is on, but in kernel it is off.

To prevent this, set VLAN stripping to disabled in VSI initialization. It doesn't break other usecases, because it is set according to kernel settings.

Fixes f09901aa554a ("ice: remove VLAN representor specific ops")
---
 drivers/net/ethernet/intel/ice/ice_lib.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/ethernet/intel/ice/ice_lib.c +3 -0
index 70961c0343e7..b28fb8eacffb 100644
@@ -887,6 +887,9 @@ static void ice_set_dflt_vsi_ctx(struct ice_hw *hw, struct ice_vsi_ctx *ctxt)
 			(ICE_AQ_VSI_OUTER_TAG_VLAN_8100 <<
 			 ICE_AQ_VSI_OUTER_TAG_TYPE_S) &
 			ICE_AQ_VSI_OUTER_TAG_TYPE_M;
+		ctxt->info.outer_vlan_flags |=
+			FIELD_PREP(ICE_AQ_VSI_OUTER_VLAN_EMODE_M,
+				   ICE_AQ_VSI_OUTER_VLAN_EMODE_NOTHING);
 	}
 	/* Have 1:1 UP mapping for both ingress/egress tables */
 	table |= ICE_UP_TABLE_TRANSLATE(0, 0);
Signature · 1 line
2.35.1
#1 lore raw

PATCH 1/1 ice: disable stripping in default VSI ctx

Dear Marcin, dear Michal,

Am 27.05.22 um 13:51 schrieb Marcin Szycik:

Quoted 5 lines

From: Michal Swiatkowski <[email protected]>

In case when driver is in eswitch mode, having VLAN stripping enabled causes failure in communication. All VLAN configuration commands are blocked, because of that VF driver can't disable VLAN stripping at

s/blocked, because/blocked. Because/

Quoted 4 lines

initialization. It leads to the situation when VLAN stripping on VF VSI is on, but in kernel it is off.

To prevent this, set VLAN stripping to disabled in VSI initialization.

Maybe: ?, disable VLAN stripping in VSI initialization.

Quoted 2 lines

It doesn't break other usecases, because it is set according to kernel settings.

Please document your test setup.

Kind regards,

Paul

Quoted 21 lines
Fixes f09901aa554a ("ice: remove VLAN representor specific ops")
---
  drivers/net/ethernet/intel/ice/ice_lib.c | 3 +++
  1 file changed, 3 insertions(+)
drivers/net/ethernet/intel/ice/ice_lib.c +3 -0
index 70961c0343e7..b28fb8eacffb 100644
@@ -887,6 +887,9 @@ static void ice_set_dflt_vsi_ctx(struct ice_hw *hw, struct ice_vsi_ctx *ctxt)
  			(ICE_AQ_VSI_OUTER_TAG_VLAN_8100 <<
  			 ICE_AQ_VSI_OUTER_TAG_TYPE_S) &
  			ICE_AQ_VSI_OUTER_TAG_TYPE_M;
+		ctxt->info.outer_vlan_flags |=
+			FIELD_PREP(ICE_AQ_VSI_OUTER_VLAN_EMODE_M,
+				   ICE_AQ_VSI_OUTER_VLAN_EMODE_NOTHING);
  	}
  	/* Have 1:1 UP mapping for both ingress/egress tables */
  	table |= ICE_UP_TABLE_TRANSLATE(0, 0);
#2 lore raw

PATCH 1/1 ice: disable stripping in default VSI ctx

Hi Paul,

Quoted 11 lines · Paul Menzel

Dear Marcin, dear Michal,

Am 27.05.22 um 13:51 schrieb Marcin Szycik:

Quoted 5 lines

From: Michal Swiatkowski <[email protected]>

In case when driver is in eswitch mode, having VLAN stripping enabled causes failure in communication. All VLAN configuration commands are blocked, because of that VF driver can't disable VLAN stripping at

s/blocked, because/blocked. Because/

Sorry, but I don't understand what to change here. Could you explain more clearly?

Quoted 7 lines
Quoted 5 lines

initialization. It leads to the situation when VLAN stripping on VF VSI is on, but in kernel it is off.

To prevent this, set VLAN stripping to disabled in VSI initialization.

Maybe: ?, disable VLAN stripping in VSI initialization.

Sounds good.

Quoted 5 lines
Quoted 3 lines

It doesn't break other usecases, because it is set according to kernel settings.

Please document your test setup.

Will reproduction steps be enough?

Thanks for the review!

Marcin

Quoted 28 lines

Kind regards,

Paul

Quoted 21 lines
Fixes f09901aa554a ("ice: remove VLAN representor specific ops")

---
? drivers/net/ethernet/intel/ice/ice_lib.c | 3 +++ ? 1 file changed, 3 insertions(+)

drivers/net/ethernet/intel/ice/ice_lib.c +0 -0
index 70961c0343e7..b28fb8eacffb 100644
@@ -887,6 +887,9 @@ static void ice_set_dflt_vsi_ctx(struct ice_hw *hw, struct ice_vsi_ctx *ctxt)

????????????? (ICE_AQ_VSI_OUTER_TAG_VLAN_8100 << ?????????????? ICE_AQ_VSI_OUTER_TAG_TYPE_S) & ????????????? ICE_AQ_VSI_OUTER_TAG_TYPE_M;
+??????? ctxt->info.outer_vlan_flags |=
+??????????? FIELD_PREP(ICE_AQ_VSI_OUTER_VLAN_EMODE_M, +?????????????????? ICE_AQ_VSI_OUTER_VLAN_EMODE_NOTHING); ????? }
????? /* Have 1:1 UP mapping for both ingress/egress tables */ ????? table |= ICE_UP_TABLE_TRANSLATE(0, 0)

#3 lore raw

PATCH 1/1 ice: disable stripping in default VSI ctx

Dear Marcin.

Am 27.05.22 um 15:01 schrieb Marcin Szycik:

Quoted 5 lines · Paul Menzel
Quoted 4 lines

Am 27.05.22 um 13:51 schrieb Marcin Szycik:

Quoted 2 lines

From: Michal Swiatkowski <[email protected]>

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

In case when driver is in eswitch mode, having VLAN stripping enabled causes failure in communication. All VLAN configuration commands are blocked, because of that VF driver can't disable VLAN stripping at

s/blocked, because/blocked. Because/

Sorry, but I don't understand what to change here. Could you explain more clearly?

I am sorry for being unclear. I think it should be two sentences.

Quoted 7 lines
Quoted 6 lines
Quoted 4 lines

initialization. It leads to the situation when VLAN stripping on VF VSI is on, but in kernel it is off.

To prevent this, set VLAN stripping to disabled in VSI initialization.

Maybe: ?, disable VLAN stripping in VSI initialization.

Quoted 8 lines

Sounds good.

Quoted 4 lines
Quoted 2 lines

It doesn't break other usecases, because it is set according to kernel settings.

Please document your test setup.

Will reproduction steps be enough?

Yes, that?d be great.

Kind regards,

Paul

Quoted 25 lines
Quoted 7 lines
Quoted 7 lines
Fixes f09901aa554a ("ice: remove VLAN representor specific ops")
---
 ? drivers/net/ethernet/intel/ice/ice_lib.c | 3 +++

? 1 file changed, 3 insertions(+)

Quoted 14 lines
Quoted 5 lines
drivers/net/ethernet/intel/ice/ice_lib.c +0 -0
index 70961c0343e7..b28fb8eacffb 100644

drivers/net/ethernet/intel/ice/ice_lib.c static void ice_set_dflt_vsi_ctx(struct ice_hw *hw, struct ice_vsi_ctx *ctxt) · line 895

Quoted 9 lines
drivers/net/ethernet/intel/ice/ice_lib.c +3 -0
@@ -887,6 +887,9 @@ static void ice_set_dflt_vsi_ctx(struct ice_hw *hw, struct ice_vsi_ctx *ctxt)
 ????????????? (ICE_AQ_VSI_OUTER_TAG_VLAN_8100 <<
 ?????????????? ICE_AQ_VSI_OUTER_TAG_TYPE_S) &
 ????????????? ICE_AQ_VSI_OUTER_TAG_TYPE_M;
+??????? ctxt->info.outer_vlan_flags |=
+??????????? FIELD_PREP(ICE_AQ_VSI_OUTER_VLAN_EMODE_M,
+?????????????????? ICE_AQ_VSI_OUTER_VLAN_EMODE_NOTHING);
 ????? }
 ????? /* Have 1:1 UP mapping for both ingress/egress tables */
 ????? table |= ICE_UP_TABLE_TRANSLATE(0, 0)

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan at osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

#4 lore raw

PATCH 1/1 ice: disable stripping in default VSI ctx

Quoted 14 lines · Paul Menzel

Dear Marcin.

Am 27.05.22 um 15:01 schrieb Marcin Szycik:

Quoted 9 lines · Paul Menzel
Quoted 8 lines

Am 27.05.22 um 13:51 schrieb Marcin Szycik:

Quoted 5 lines

From: Michal Swiatkowski <[email protected]>

In case when driver is in eswitch mode, having VLAN stripping enabled causes failure in communication. All VLAN configuration commands are blocked, because of that VF driver can't disable VLAN stripping at

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

s/blocked, because/blocked. Because/

Sorry, but I don't understand what to change here. Could you explain more clearly?

I am sorry for being unclear. I think it should be two sentences.

Ah, now I see it's a sed-style string replace. I will remember this for future discussions :)

Quoted 9 lines
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines

initialization. It leads to the situation when VLAN stripping on VF VSI is on, but in kernel it is off.

To prevent this, set VLAN stripping to disabled in VSI initialization.

Maybe: ?, disable VLAN stripping in VSI initialization.

Sounds good.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

It doesn't break other usecases, because it is set according to kernel settings.

Please document your test setup.

Will reproduction steps be enough?

Yes, that?d be great.

I'll send v2 probably on Monday. I'm sorry for delay, but I have a bit of a problem reproducing this issue, and I don't want to include a repro that doesn't actually work (Micha? originally worked on the fix, but he will be unavailable for some time).

Regards,
Marcin

Quoted 25 lines
Quoted 25 lines
Quoted 7 lines
Quoted 7 lines
Fixes f09901aa554a ("ice: remove VLAN representor specific ops")

---
?? drivers/net/ethernet/intel/ice/ice_lib.c | 3 +++ ?? 1 file changed, 3 insertions(+)

Quoted 14 lines
Quoted 6 lines
drivers/net/ethernet/intel/ice/ice_lib.c +0 -0
index 70961c0343e7..b28fb8eacffb 100644
@@ -887,6 +887,9 @@ static void ice_set_dflt_vsi_ctx(struct ice_hw *hw, struct ice_vsi_ctx *ctxt)

?????????????? (ICE_AQ_VSI_OUTER_TAG_VLAN_8100 <<

Quoted 8 lines

??????????????? ICE_AQ_VSI_OUTER_TAG_TYPE_S) & ?????????????? ICE_AQ_VSI_OUTER_TAG_TYPE_M;
+??????? ctxt->info.outer_vlan_flags |=
+??????????? FIELD_PREP(ICE_AQ_VSI_OUTER_VLAN_EMODE_M, +?????????????????? ICE_AQ_VSI_OUTER_VLAN_EMODE_NOTHING); ?????? }
?????? /* Have 1:1 UP mapping for both ingress/egress tables */ ?????? table |= ICE_UP_TABLE_TRANSLATE(0, 0)

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan at osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

maintainer
#5 lore raw

PATCH 1/1 ice: disable stripping in default VSI ctx

In reply to Marcin Szycik

On 5/27/2022 4:51 AM, Marcin Szycik wrote:

This fixes commit doesn't exist in net, so it shouldn't be targeting net. It looks like the patch this is fixing is still on Intel Wired LAN [1]. Perhaps it would be better to squash it with that patch as a v2?

Quoted 8 lines

From: Michal Swiatkowski <[email protected]>

In case when driver is in eswitch mode, having VLAN stripping enabled causes failure in communication. All VLAN configuration commands are blocked, because of that VF driver can't disable VLAN stripping at initialization. It leads to the situation when VLAN stripping on VF VSI is on, but in kernel it is off.

Quoted 7 lines

To prevent this, set VLAN stripping to disabled in VSI initialization. It doesn't break other usecases, because it is set according to kernel settings.

Fixes f09901aa554a ("ice: remove VLAN representor specific ops")

[1]
https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20220425062756.14987-3-michal.swiatkowski at linux.intel.com/

#6 lore raw

PATCH 1/1 ice: disable stripping in default VSI ctx

Quoted 5 lines · Tony Nguyen

On 5/27/2022 4:51 AM, Marcin Szycik wrote:

This fixes commit doesn't exist in net, so it shouldn't be targeting net. It looks like the patch this is fixing is still on Intel Wired LAN [1]. Perhaps it would be better to squash it with that patch as a v2?

You're right, sorry I didn't notice this. I will send next version with net-next tag and a squash note.

Quoted 17 lines
Quoted 8 lines

From: Michal Swiatkowski <[email protected]>

In case when driver is in eswitch mode, having VLAN stripping enabled causes failure in communication. All VLAN configuration commands are blocked, because of that VF driver can't disable VLAN stripping at initialization. It leads to the situation when VLAN stripping on VF VSI is on, but in kernel it is off.

Quoted 7 lines

To prevent this, set VLAN stripping to disabled in VSI initialization. It doesn't break other usecases, because it is set according to kernel settings.

Fixes f09901aa554a ("ice: remove VLAN representor specific ops")

[1] https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20220425062756.14987-3-michal.swiatkowski at linux.intel.com/