libcroco: CVE-2020-12825 Security Advisory
PATCH 1/1 libcroco: CVE-2020-12825 Security Advisory
References
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-12825
--- .../libcroco/libcroco/CVE-2020-12825.patch | 170 ++++++++++++++++++ .../libcroco/libcroco_0.6.13.bb | 2 + 2 files changed, 172 insertions(+) create mode 100644 meta/recipes-support/libcroco/libcroco/CVE-2020-12825.patch
meta/recipes-support/libcroco/libcroco/CVE-2020-12825.patch new file +170 -0
@@ -0,0 +1,170 @@ +Subject: [PATCH] libcroco: Limit recursion in block and any productions + +Signed-off-by:Michael Catanzaro @mcatanzaro +--- + src/cr-parser.c | 42 +++++++++++++++++++++++++++--------------- + 1 file changed, 27 insertions(+), 15 deletions(-) + +diff --git a/src/cr-parser.c b/src/cr-parser.c +index 18c9a01..4e5b424 100644 +--- a/src/cr-parser.c ++++ b/src/cr-parser.c +@@ -136,6 +136,8 @@ struct _CRParserPriv { + + #define CHARS_TAB_SIZE 12 + ++#define RECURSIVE_CALLERS_LIMIT 100 ++ + /** + * IS_NUM: + *@a_char: the char to test. +@@ -344,9 +346,11 @@ static enum CRStatus cr_parser_parse_selector_core (CRParser * a_this); + + static enum CRStatus cr_parser_parse_declaration_core (CRParser * a_this); + +-static enum CRStatus cr_parser_parse_any_core (CRParser * a_this); ++static enum CRStatus cr_parser_parse_any_core (CRParser * a_this, ++ guint n_calls); + +-static enum CRStatus cr_parser_parse_block_core (CRParser * a_this); ++static enum CRStatus cr_parser_parse_block_core (CRParser * a_this, ++ guint n_calls); + + static enum CRStatus cr_parser_parse_value_core (CRParser * a_this); + +@@ -784,7 +788,7 @@ cr_parser_parse_atrule_core (CRParser * a_this) + cr_parser_try_to_skip_spaces_and_comments (a_this); + + do { +- status = cr_parser_parse_any_core (a_this); ++ status = cr_parser_parse_any_core (a_this, 0); + } while (status == CR_OK); + + status = cr_tknzr_get_next_token (PRIVATE (a_this)->tknzr, +@@ -795,7 +799,7 @@ cr_parser_parse_atrule_core (CRParser * a_this) + cr_tknzr_unget_token (PRIVATE (a_this)->tknzr, + token); + token = NULL; +- status = cr_parser_parse_block_core (a_this); ++ status = cr_parser_parse_block_core (a_this, 0); + CHECK_PARSING_STATUS (status, + FALSE); + goto done; +@@ -930,11 +934,11 @@ cr_parser_parse_selector_core (CRParser * a_this) + + RECORD_INITIAL_POS (a_this, &init_pos); + +- status = cr_parser_parse_any_core (a_this); ++ status = cr_parser_parse_any_core (a_this, 0); + CHECK_PARSING_STATUS (status, FALSE); + + do { +- status = cr_parser_parse_any_core (a_this); ++ status = cr_parser_parse_any_core (a_this, 0); + + } while (status == CR_OK); + +@@ -959,7 +963,8 @@ cr_parser_parse_selector_core (CRParser * a_this) + *FIXME: code this function. + */ + static enum CRStatus +-cr_parser_parse_block_core (CRParser * a_this) ++cr_parser_parse_block_core (CRParser * a_this, ++ guint n_calls) + { + CRToken *token = NULL; + CRInputPos init_pos; +@@ -967,6 +972,9 @@ cr_parser_parse_block_core (CRParser * a_this) + + g_return_val_if_fail (a_this && PRIVATE (a_this), CR_BAD_PARAM_ERROR); + ++ if (n_calls > RECURSIVE_CALLERS_LIMIT) ++ return CR_ERROR; ++ + RECORD_INITIAL_POS (a_this, &init_pos); + + status = cr_tknzr_get_next_token (PRIVATE (a_this)->tknzr, &token); +@@ -996,13 +1004,13 @@ cr_parser_parse_block_core (CRParser * a_this) + } else if (token->type == CBO_TK) { + cr_tknzr_unget_token (PRIVATE (a_this)->tknzr, token); + token = NULL; +- status = cr_parser_parse_block_core (a_this); ++ status = cr_parser_parse_block_core (a_this, n_calls + 1); + CHECK_PARSING_STATUS (status, FALSE); + goto parse_block_content; + } else { + cr_tknzr_unget_token (PRIVATE (a_this)->tknzr, token); + token = NULL; +- status = cr_parser_parse_any_core (a_this); ++ status = cr_parser_parse_any_core (a_this, n_calls + 1); + CHECK_PARSING_STATUS (status, FALSE); + goto parse_block_content; + } +@@ -1109,7 +1117,7 @@ cr_parser_parse_value_core (CRParser * a_this) + status = cr_tknzr_unget_token (PRIVATE (a_this)->tknzr, + token); + token = NULL; +- status = cr_parser_parse_block_core (a_this); ++ status = cr_parser_parse_block_core (a_this, 0); + CHECK_PARSING_STATUS (status, FALSE); + ref++; + goto continue_parsing; +@@ -1123,7 +1131,7 @@ cr_parser_parse_value_core (CRParser * a_this) + status = cr_tknzr_unget_token (PRIVATE (a_this)->tknzr, + token); + token = NULL; +- status = cr_parser_parse_any_core (a_this); ++ status = cr_parser_parse_any_core (a_this, 0); + if (status == CR_OK) { + ref++; + goto continue_parsing; +@@ -1165,7 +1173,8 @@ cr_parser_parse_value_core (CRParser * a_this) + *@return CR_OK upon successfull completion, an error code otherwise. + */ + static enum CRStatus +-cr_parser_parse_any_core (CRParser * a_this) ++cr_parser_parse_any_core (CRParser * a_this, ++ guint n_calls) + { + CRToken *token1 = NULL, + *token2 = NULL; +@@ -1174,6 +1183,9 @@ cr_parser_parse_any_core (CRParser * a_this) + + g_return_val_if_fail (a_this, CR_BAD_PARAM_ERROR); + ++ if (n_calls > RECURSIVE_CALLERS_LIMIT) ++ return CR_ERROR; ++ + RECORD_INITIAL_POS (a_this, &init_pos); + + status = cr_tknzr_get_next_token (PRIVATE (a_this)->tknzr, &token1); +@@ -1212,7 +1224,7 @@ cr_parser_parse_any_core (CRParser * a_this) + *We consider parameter as being an "any*" production. + */ + do { +- status = cr_parser_parse_any_core (a_this); ++ status = cr_parser_parse_any_core (a_this, n_calls + 1); + } while (status == CR_OK); + + ENSURE_PARSING_COND (status == CR_PARSING_ERROR); +@@ -1237,7 +1249,7 @@ cr_parser_parse_any_core (CRParser * a_this) + } + + do { +- status = cr_parser_parse_any_core (a_this); ++ status = cr_parser_parse_any_core (a_this, n_calls + 1); + } while (status == CR_OK); + + ENSURE_PARSING_COND (status == CR_PARSING_ERROR); +@@ -1265,7 +1277,7 @@ cr_parser_parse_any_core (CRParser * a_this) + } + + do { +- status = cr_parser_parse_any_core (a_this); ++ status = cr_parser_parse_any_core (a_this, n_calls + 1); + } while (status == CR_OK); + + ENSURE_PARSING_COND (status == CR_PARSING_ERROR); +-- +2.25.1 +
meta/recipes-support/libcroco/libcroco_0.6.13.bb +2 -0
@@ -7,6 +7,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=55ca817ccb7d5b5b66355690e9abc605 \ file://src/cr-rgb.c;endline=22;md5=31d5f0944d556c8589d04ea6055fcc66 \ file://tests/cr-test-utils.c;endline=21;md5=2382c27934cae1d3792fcb17a6142c4e" +SRC_URI += "file://CVE-2020-12825.patch" + SECTION = "x11/utils" DEPENDS = "glib-2.0 libxml2 zlib" BBCLASSEXTEND = "native nativesdk"
Signature · 1 line
2.25.1
Quoted 16 lines · Wang Mingyu
References
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-12825Signed-off-by Wang Mingyu <[email protected]>---
.../libcroco/libcroco/CVE-2020-12825.patch | 170 ++++++++++++++++++
.../libcroco/libcroco_0.6.13.bb | 2 +2 files changed, 172 insertions(+)create mode 100644
meta/recipes-support/libcroco/libcroco/CVE-2020-12825.patchmeta/recipes-support/libcroco/libcroco/CVE-2020-12825.patch new file +0
-0
meta/recipes-support/libcroco/libcroco/CVE-2020-12825.patch line 3
Quoted 3 lines
meta/recipes-support/libcroco/libcroco/CVE-2020-12825.patch new file +3
-0@@ -0,0 +1,170 @@ +Subject: [PATCH] libcroco: Limit recursion in block and any productions + +Signed-off-by:Michael Catanzaro @mcatanzaro
Thanks for this, the patch has no Upstream-Status set though? Could you resend with one please?
Cheers,
Richard
And a CVE: CVE-2020-12825 tag alongside that too would be good.
Ross
Quoted 32 lines · Richard Purdie
Quoted 16 lines · Wang Mingyu
References
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-12825Signed-off-by Wang Mingyu <[email protected]>--- .../libcroco/libcroco/CVE-2020-12825.patch | 170 ++++++++++++++++++ .../libcroco/libcroco_0.6.13.bb | 2 + 2 files changed, 172 insertions(+) create mode 100644 meta/recipes-support/libcroco/libcroco/CVE-2020-12825.patchmeta/recipes-support/libcroco/libcroco/CVE-2020-12825.patch new file +0
-0meta/recipes-support/libcroco/libcroco/CVE-2020-12825.patch line 3
Quoted 3 lines
meta/recipes-support/libcroco/libcroco/CVE-2020-12825.patch new file +3
-0@@ -0,0 +1,170 @@ +Subject: [PATCH] libcroco: Limit recursion in block and any productions + +Signed-off-by:Michael Catanzaro @mcatanzaroThanks for this, the patch has no Upstream-Status set though? Could you resend with one please?
Cheers,
Richard
I am also seeing
ERROR: libcroco-native-0.6.13-r0 do_patch: Fuzz detected:
Applying patch CVE-2020-12825.patch
patching file src/cr-parser.c
Hunk #4 succeeded at 799 with fuzz 1.
The context lines in the patches can be updated with devtool:
devtool modify libcroco-native
devtool finish --force-patch-refresh libcroco-native <layer_path>
Quoted 42 lines · Ross Burton
And a CVE: CVE-2020-12825 tag alongside that too would be good.
Ross
Quoted 32 lines · Richard Purdie
Quoted 16 lines · Wang Mingyu
References
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-12825Signed-off-by Wang Mingyu <[email protected]>--- .../libcroco/libcroco/CVE-2020-12825.patch | 170 ++++++++++++++++++ .../libcroco/libcroco_0.6.13.bb | 2 + 2 files changed, 172 insertions(+) create mode 100644 meta/recipes-support/libcroco/libcroco/CVE-2020-12825.patchmeta/recipes-support/libcroco/libcroco/CVE-2020-12825.patch new file +0
-0meta/recipes-support/libcroco/libcroco/CVE-2020-12825.patch line 3
Quoted 3 lines
meta/recipes-support/libcroco/libcroco/CVE-2020-12825.patch new file +3
-0@@ -0,0 +1,170 @@ +Subject: [PATCH] libcroco: Limit recursion in block and any productions + +Signed-off-by:Michael Catanzaro @mcatanzaroThanks for this, the patch has no Upstream-Status set though? Could you resend with one please?
Cheers,
Richard
Quoted 9 lines · Khem Raj
I am also seeing
ERROR: libcroco-native-0.6.13-r0
do_patch: Fuzz detected:Applying patch CVE-2020-12825.patch
patching filesrc/cr-parser.c
Hunk #4 succeeded at 799 with fuzz 1.
Quoted 4 lines
The context lines in the patches can be updated with devtool:
devtool modify libcroco-native
devtool finish --force-patch-refresh libcroco-native <layer_path>
There was a more recently submitted version of this. I've refreshed it, in master-next it looks like it was whitespace damaged somehow.
Cheers,
Richard