Skip to contentSkip to conversation

common-license: add fdk-aac license file

PATCH In review Scott Branden 4 participants 8 messages Feb 25, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 common-license: add fdk-aac license file

From: Mircea Carausu <[email protected]>

Add Fraunhofer FDK AAC Codec Library license.

Signed-offby: Mircea Carausu <[email protected]>

---
 ...aunhofer_FDK_AAC_Codec_Library_for_Android | 92 +++++++++++++++++++
 1 file changed, 92 insertions(+)
 create mode 100644 meta/files/common-licenses/Fraunhofer_FDK_AAC_Codec_Library_for_Android
meta/files/common-licenses/Fraunhofer_FDK_AAC_Codec_Library_for_Android new file +92 -0
new file mode 100644
index 0000000000..05b32bdeaf
@@ -0,0 +1,92 @@
+Software License for The Fraunhofer FDK AAC Codec Library for Android
+
+© Copyright  1995 - 2018 Fraunhofer-Gesellschaft zur Förderung der angewandten
+Forschung e.V. All rights reserved.
+
+ 1.    INTRODUCTION
+The Fraunhofer FDK AAC Codec Library for Android ("FDK AAC Codec") is software
+that implements the MPEG Advanced Audio Coding ("AAC") encoding and decoding
+scheme for digital audio. This FDK AAC Codec software is intended to be used on
+a wide variety of Android devices.
+
+AAC's HE-AAC and HE-AAC v2 versions are regarded as today's most efficient
+general perceptual audio codecs. AAC-ELD is considered the best-performing
+full-bandwidth communications codec by independent studies and is widely
+deployed. AAC has been standardized by ISO and IEC as part of the MPEG
+specifications.
+
+Patent licenses for necessary patent claims for the FDK AAC Codec (including
+those of Fraunhofer) may be obtained through Via Licensing
+(www.vialicensing.com) or through the respective patent owners individually for
+the purpose of encoding or decoding bit streams in products that are compliant
+with the ISO/IEC MPEG audio standards. Please note that most manufacturers of
+Android devices already license these patent claims through Via Licensing or
+directly from the patent owners, and therefore FDK AAC Codec software may
+already be covered under those patent licenses when it is used for those
+licensed purposes only.
+
+Commercially-licensed AAC software libraries, including floating-point versions
+with enhanced sound quality, are also available from Fraunhofer. Users are
+encouraged to check the Fraunhofer website for additional applications
+information and documentation.
+
+2.    COPYRIGHT LICENSE
+
+Redistribution and use in source and binary forms, with or without modification,
+are permitted without payment of copyright license fees provided that you
+satisfy the following conditions:
+
+You must retain the complete text of this software license in redistributions of
+the FDK AAC Codec or your modifications thereto in source code form.
+
+You must retain the complete text of this software license in the documentation
+and/or other materials provided with redistributions of the FDK AAC Codec or
+your modifications thereto in binary form. You must make available free of
+charge copies of the complete source code of the FDK AAC Codec and your
+modifications thereto to recipients of copies in binary form.
+
+The name of Fraunhofer may not be used to endorse or promote products derived
+from this library without prior written permission.
+
+You may not charge copyright license fees for anyone to use, copy or distribute
+the FDK AAC Codec software or your modifications thereto.
+
+Your modified versions of the FDK AAC Codec must carry prominent notices stating
+that you changed the software and the date of any change. For modified versions
+of the FDK AAC Codec, the term "Fraunhofer FDK AAC Codec Library for Android"
+must be replaced by the term "Third-Party Modified Version of the Fraunhofer FDK
+AAC Codec Library for Android."
+
+3.    NO PATENT LICENSE
+
+NO EXPRESS OR IMPLIED LICENSES TO ANY PATENT CLAIMS, including without
+limitation the patents of Fraunhofer, ARE GRANTED BY THIS SOFTWARE LICENSE.
+Fraunhofer provides no warranty of patent non-infringement with respect to this
+software.
+
+You may use this FDK AAC Codec software or modifications thereto only for
+purposes that are authorized by appropriate patent licenses.
+
+4.    DISCLAIMER
+
+This FDK AAC Codec software is provided by Fraunhofer on behalf of the copyright
+holders and contributors "AS IS" and WITHOUT ANY EXPRESS OR IMPLIED WARRANTIES,
+including but not limited to the implied warranties of merchantability and
+fitness for a particular purpose. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
+CONTRIBUTORS BE LIABLE for any direct, indirect, incidental, special, exemplary,
+or consequential damages, including but not limited to procurement of substitute
+goods or services; loss of use, data, or profits, or business interruption,
+however caused and on any theory of liability, whether in contract, strict
+liability, or tort (including negligence), arising in any way out of the use of
+this software, even if advised of the possibility of such damage.
+
+5.    CONTACT INFORMATION
+
+Fraunhofer Institute for Integrated Circuits IIS
+Attention: Audio and Multimedia Departments - FDK AAC LL
+Am Wolfsmantel 33
+91058 Erlangen, Germany
+
+www.iis.fraunhofer.de/amm
[email protected]
+
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/2 ffmpeg: add PACKAGECONFIG support for fdk-aac

Add PACKAGECONFIG support for fdk-aac in ffmpeg.

---
 meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.2.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.2.bb +1 -0
index 20a8249b02..d7b0641054 100644
@@ -59,6 +59,7 @@ PACKAGECONFIG[avresample] = "--enable-avresample,--disable-avresample"
 # features to support
 PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
 PACKAGECONFIG[bzlib] = "--enable-bzlib,--disable-bzlib,bzip2"
+PACKAGECONFIG[fdk-aac] = "--enable-libfdk-aac --enable-nonfree,--disable-libfdk-aac,fdk-aac"
 PACKAGECONFIG[gpl] = "--enable-gpl,--disable-gpl"
 PACKAGECONFIG[gsm] = "--enable-libgsm,--disable-libgsm,libgsm"
 PACKAGECONFIG[jack] = "--enable-indev=jack,--disable-indev=jack,jack"
Signature · 1 line
2.17.1
#2 lore raw
In reply to Scott Branden
Quoted 6 lines · Scott Branden via Openembedded-core

From: Mircea Carausu <[email protected]>

Add Fraunhofer FDK AAC Codec Library license.

Signed-offby: Mircea Carausu <[email protected]>

I'm not sure this belongs in Core? Is it a commonly used license? This recipe isn't in OE-Core? Does the license have an SPDX identifier (I couldn't see it on https://spdx.org/licenses/)?

Cheers,

Richard

#3 lore raw

Hi Richard,

Quoted 11 lines · Richard Purdie
Quoted 6 lines · Scott Branden via Openembedded-core

From: Mircea Carausu <[email protected]>

Add Fraunhofer FDK AAC Codec Library license.

Signed-offby: Mircea Carausu <[email protected]>

I'm not sure this belongs in Core? Is it a commonly used license? This recipe isn't in OE-Core? Does the license have an SPDX identifier (I couldn't see it on https://spdx.org/licenses/)?

If we do not add this license the following WARNING is emitted:

WARNING: fdk-aac-2.0.1-r0 do_populate_lic: fdk-aac: No generic license file exists for: Fraunhofer_FDK_AAC_Codec_Library_for_Android in any provider

We have submitted the fdk-aac recipe to meta-openembedded/meta-multimedia here:
https://patchwork.openembedded.org/patch/170495/

Please suggest the appropriate place to submit this license.
It is an open source license but does not have and SPDX indentifier and is only used for fdk-aac at this time.

Quoted 4 lines

Cheers,

Richard

Thanks,
 Scott

#4 lore raw
Quoted 16 lines · Scott Branden via Openembedded-core

Hi Richard,

Quoted 11 lines · Richard Purdie
Quoted 6 lines · Scott Branden via Openembedded-core

From: Mircea Carausu <[email protected]>

Add Fraunhofer FDK AAC Codec Library license.

Signed-offby: Mircea Carausu <[email protected]>

I'm not sure this belongs in Core? Is it a commonly used license? This recipe isn't in OE-Core? Does the license have an SPDX identifier (I couldn't see it on https://spdx.org/licenses/)?

If we do not add this license the following WARNING is emitted:

Quoted 8 lines

WARNING: fdk-aac-2.0.1-r0 do_populate_lic: fdk-aac: No generic license file exists for: Fraunhofer_FDK_AAC_Codec_Library_for_Android in any provider

We have submitted the fdk-aac recipe to meta-openembedded/meta-multimedia here:
https://patchwork.openembedded.org/patch/170495/

Please suggest the appropriate place to submit this license.

licenses directory in meta-multimedia

Quoted 14 lines

It is an open source license but does not have and SPDX indentifier and is only used for fdk-aac at this time.

Quoted 4 lines

Cheers,

Richard

Thanks,
 Scott

Signature · 4 lines
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
#5 lore raw
In reply to Scott Branden
Quoted 20 lines · Scott Branden via Openembedded-core

Hi Richard,

Quoted 11 lines · Richard Purdie
Quoted 6 lines · Scott Branden via Openembedded-core

From: Mircea Carausu <[email protected]>

Add Fraunhofer FDK AAC Codec Library license.

Signed-offby: Mircea Carausu <[email protected]>

I'm not sure this belongs in Core? Is it a commonly used license? This recipe isn't in OE-Core? Does the license have an SPDX identifier (I couldn't see it on https://spdx.org/licenses/)?

If we do not add this license the following WARNING is emitted:

WARNING: fdk-aac-2.0.1-r0 do_populate_lic: fdk-aac: No generic license file exists for: Fraunhofer_FDK_AAC_Codec_Library_for_Android in any provider

Quoted 7 lines

We have submitted the fdk-aac recipe to
meta-openembedded/meta-multimedia here:
https://patchwork.openembedded.org/patch/170495/

Please suggest the appropriate place to submit this license. It is an open source license but does not have and SPDX indentifier and is only used for fdk-aac at this time.

you can propose it for meta-multimedia

Quoted 7 lines
Quoted 5 lines

Cheers,

Richard

Thanks,
 Scott

#6 lore raw
Quoted 22 lines · Khem Raj
Quoted 20 lines · Scott Branden via Openembedded-core

Hi Richard,

Quoted 11 lines · Richard Purdie
Quoted 6 lines · Scott Branden via Openembedded-core

From: Mircea Carausu <[email protected]>

Add Fraunhofer FDK AAC Codec Library license.

Signed-offby: Mircea Carausu <[email protected]>

I'm not sure this belongs in Core? Is it a commonly used license? This recipe isn't in OE-Core? Does the license have an SPDX identifier (I couldn't see it on https://spdx.org/licenses/)?

If we do not add this license the following WARNING is emitted:

WARNING: fdk-aac-2.0.1-r0 do_populate_lic: fdk-aac: No generic license file exists for: Fraunhofer_FDK_AAC_Codec_Library_for_Android in any provider

Quoted 8 lines
Quoted 7 lines

We have submitted the fdk-aac recipe to
meta-openembedded/meta-multimedia here:
https://patchwork.openembedded.org/patch/170495/

Please suggest the appropriate place to submit this license. It is an open source license but does not have and SPDX indentifier and is only used for fdk-aac at this time.

you can propose it for meta-multimedia

That makes more sense.  We missed seeing a licenses directory in meta-multimedia.

Quoted 6 lines
Quoted 6 lines
Quoted 4 lines

Cheers,

Richard

Thanks,
 Scott

#7 lore raw
In reply to Scott Branden

Richard,

Please drop this patch.  fdk-aac license file submitted to meta-multimedia.

Quoted 30 lines · Scott Branden

Hi Richard,

Quoted 11 lines · Richard Purdie
Quoted 6 lines · Scott Branden via Openembedded-core

From: Mircea Carausu <[email protected]>

Add Fraunhofer FDK AAC Codec Library license.

Signed-offby: Mircea Carausu <[email protected]>

I'm not sure this belongs in Core? Is it a commonly used license? This recipe isn't in OE-Core? Does the license have an SPDX identifier (I couldn't see it on https://spdx.org/licenses/)?

If we do not add this license the following WARNING is emitted:

WARNING: fdk-aac-2.0.1-r0 do_populate_lic: fdk-aac: No generic license file exists for: Fraunhofer_FDK_AAC_Codec_Library_for_Android in any provider

We have submitted the fdk-aac recipe to meta-openembedded/meta-multimedia here:
https://patchwork.openembedded.org/patch/170495/

Please suggest the appropriate place to submit this license.
It is an open source license but does not have and SPDX indentifier and is only used for fdk-aac at this time.

Quoted 4 lines

Cheers,

Richard

Thanks,
 Scott