usb: typec: rt1719: Fix build error without CONFIG_POWER_SUPPLY
Subsystems (2)
PATCH 1/1 usb: typec: rt1719: Fix build error without CONFIG_POWER_SUPPLY
Building without CONFIG_POWER_SUPPLY will fail:
drivers/usb/typec/rt1719.o: In function `rt1719_psy_set_property':
rt1719.c:(.text+0x10a): undefined reference to power_supply_get_drvdata' drivers/usb/typec/rt1719.o: In function rt1719_psy_get_property':
rt1719.c:(.text+0x2c8): undefined reference to power_supply_get_drvdata' drivers/usb/typec/rt1719.o: In function devm_rt1719_psy_register':
rt1719.c:(.text+0x3e9): undefined reference to devm_power_supply_register' drivers/usb/typec/rt1719.o: In function rt1719_irq_handler':
rt1719.c:(.text+0xf9f): undefined reference to power_supply_changed' drivers/usb/typec/rt1719.o: In function rt1719_update_pwr_opmode.part.9':
rt1719.c:(.text+0x657): undefined reference to power_supply_changed' drivers/usb/typec/rt1719.o: In function rt1719_attach':
rt1719.c:(.text+0x83e): undefined reference to `power_supply_changed'
Add POWER_SUPPLY dependency to Kconfig.
--- drivers/usb/typec/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/usb/typec/Kconfig +1 -0
@@ -56,6 +56,7 @@ config TYPEC_RT1719 tristate "Richtek RT1719 Sink Only Type-C controller driver" depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH depends on I2C + depends on POWER_SUPPLY select REGMAP_I2C help Say Y or M here if your system has Richtek RT1719 sink only
Signature · 1 line
2.17.1
Mon, Apr 18, 2022 at 04:24:25PM +0800, Ren Zhijie kirjoitti:
Quoted 15 lines
Building without
CONFIG_POWER_SUPPLYwill fail:
drivers/usb/typec/rt1719.o: In function `rt1719_psy_set_property':
rt1719.c:(.text+0x10a): undefined reference topower_supply_get_drvdata' drivers/usb/typec/rt1719.o: In functionrt1719_psy_get_property':
rt1719.c:(.text+0x2c8): undefined reference topower_supply_get_drvdata' drivers/usb/typec/rt1719.o: In functiondevm_rt1719_psy_register':
rt1719.c:(.text+0x3e9): undefined reference todevm_power_supply_register' drivers/usb/typec/rt1719.o: In functionrt1719_irq_handler':
rt1719.c:(.text+0xf9f): undefined reference topower_supply_changed' drivers/usb/typec/rt1719.o: In functionrt1719_update_pwr_opmode.part.9':
rt1719.c:(.text+0x657): undefined reference topower_supply_changed' drivers/usb/typec/rt1719.o: In functionrt1719_attach':
rt1719.c:(.text+0x83e): undefined reference to `power_supply_changed'
Quoted 5 lines
Add
POWER_SUPPLYdependency toKconfig.Reported-by Hulk Robot <[email protected]>Fixes 25d29b980912 ("usb: typec: rt1719: Add support for Richtek RT1719")Signed-off-by Ren Zhijie <[email protected]>
Quoted 18 lines
--- drivers/usb/typec/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/usb/typec/Kconfig +1
-0@@ -56,6 +56,7 @@ config TYPEC_RT1719 tristate "Richtek RT1719 Sink Only Type-C controller driver" depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH depends on I2C + depends on POWER_SUPPLY select REGMAP_I2C help Say Y or M here if your system has Richtek RT1719 sink onlySignature · 1 line
2.17.1
Signature · 1 line
heikki
cy_huang(黃啟原)
Reviewed-by於 三,2022-04-20 於 12:06 +0300,Heikki Krogerus 提到:
Quoted 18 lines
Mon, Apr 18, 2022 at 04:24:25PM +0800, Ren Zhijie kirjoitti:
Quoted 17 lines
Building without
CONFIG_POWER_SUPPLYwill fail:
drivers/usb/typec/rt1719.o: In function `rt1719_psy_set_property':
rt1719.c:(.text+0x10a): undefined reference topower_supply_get_drvdata' drivers/usb/typec/rt1719.o: In functionrt1719_psy_get_property':
rt1719.c:(.text+0x2c8): undefined reference topower_supply_get_drvdata' drivers/usb/typec/rt1719.o: In functiondevm_rt1719_psy_register':
rt1719.c:(.text+0x3e9): undefined reference todevm_power_supply_register' drivers/usb/typec/rt1719.o: In functionrt1719_irq_handler':
rt1719.c:(.text+0xf9f): undefined reference topower_supply_changed' drivers/usb/typec/rt1719.o: In functionrt1719_update_pwr_opmode.part.9':
rt1719.c:(.text+0x657): undefined reference topower_supply_changed' drivers/usb/typec/rt1719.o: In functionrt1719_attach':
rt1719.c:(.text+0x83e): undefined reference to `power_supply_changed'Add
POWER_SUPPLYdependency toKconfig.
Thanks.
Quoted 5 lines
Quoted 4 lines
Reported-by Hulk Robot <[email protected]>Fixes 25d29b980912 ("usb: typec: rt1719: Add support for Richtek RT1719")Signed-off-by Ren Zhijie <[email protected]>Reviewed-by Heikki Krogerus <[email protected]>
--- drivers/usb/typec/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/usb/typec/Kconfig +1 -0
@@ -56,6 +56,7 @@ config TYPEC_RT1719 tristate "Richtek RT1719 Sink Only Type-C controller driver" depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH depends on I2C +depends on POWER_SUPPLY select REGMAP_I2C help Say Y or M here if your system has Richtek RT1719 sink only
--
2.17.1
************* Email Confidentiality Notice ********************
The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!
ChiYuan Huang
Reviewed-byQuoted 18 lines · Heikki Krogerus
Mon, Apr 18, 2022 at 04:24:25PM +0800, Ren Zhijie kirjoitti:
Quoted 17 lines
Building without
CONFIG_POWER_SUPPLYwill fail:
drivers/usb/typec/rt1719.o: In function `rt1719_psy_set_property':
rt1719.c:(.text+0x10a): undefined reference topower_supply_get_drvdata' drivers/usb/typec/rt1719.o: In functionrt1719_psy_get_property':
rt1719.c:(.text+0x2c8): undefined reference topower_supply_get_drvdata' drivers/usb/typec/rt1719.o: In functiondevm_rt1719_psy_register':
rt1719.c:(.text+0x3e9): undefined reference todevm_power_supply_register' drivers/usb/typec/rt1719.o: In functionrt1719_irq_handler':
rt1719.c:(.text+0xf9f): undefined reference topower_supply_changed' drivers/usb/typec/rt1719.o: In functionrt1719_update_pwr_opmode.part.9':
rt1719.c:(.text+0x657): undefined reference topower_supply_changed' drivers/usb/typec/rt1719.o: In functionrt1719_attach':
rt1719.c:(.text+0x83e): undefined reference to `power_supply_changed'Add
POWER_SUPPLYdependency toKconfig.
Thanks.
Quoted 6 lines
Quoted 3 lines
Reported-by Hulk Robot <[email protected]>Fixes 25d29b980912 ("usb: typec: rt1719: Add support for Richtek RT1719")Signed-off-by Ren Zhijie <[email protected]>Reviewed-by Heikki Krogerus <[email protected]>
Quoted 21 lines
Quoted 18 lines
--- drivers/usb/typec/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/usb/typec/Kconfig +1
-0@@ -56,6 +56,7 @@ config TYPEC_RT1719 tristate "Richtek RT1719 Sink Only Type-C controller driver" depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH depends on I2C + depends on POWER_SUPPLY select REGMAP_I2C help Say Y or M here if your system has Richtek RT1719 sink onlySignature · 1 line
2.17.1Signature · 1 line
heikki
ping...
Quoted 36 lines · Ren Zhijie
Building without
CONFIG_POWER_SUPPLYwill fail:
drivers/usb/typec/rt1719.o: In function `rt1719_psy_set_property':
rt1719.c:(.text+0x10a): undefined reference topower_supply_get_drvdata' drivers/usb/typec/rt1719.o: In functionrt1719_psy_get_property':
rt1719.c:(.text+0x2c8): undefined reference topower_supply_get_drvdata' drivers/usb/typec/rt1719.o: In functiondevm_rt1719_psy_register':
rt1719.c:(.text+0x3e9): undefined reference todevm_power_supply_register' drivers/usb/typec/rt1719.o: In functionrt1719_irq_handler':
rt1719.c:(.text+0xf9f): undefined reference topower_supply_changed' drivers/usb/typec/rt1719.o: In functionrt1719_update_pwr_opmode.part.9':
rt1719.c:(.text+0x657): undefined reference topower_supply_changed' drivers/usb/typec/rt1719.o: In functionrt1719_attach':
rt1719.c:(.text+0x83e): undefined reference to `power_supply_changed'Add
POWER_SUPPLYdependency toKconfig.Reported-by Hulk Robot <[email protected]>Fixes 25d29b980912 ("usb: typec: rt1719: Add support for Richtek RT1719")Signed-off-by Ren Zhijie <[email protected]>--- drivers/usb/typec/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/usb/typec/Kconfig +1
-0@@ -56,6 +56,7 @@ config TYPEC_RT1719 tristate "Richtek RT1719 Sink Only Type-C controller driver" depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH depends on I2C + depends on POWER_SUPPLY select REGMAP_I2C help Say Y or M here if your system has Richtek RT1719 sink only
Greg KH
maintainerQuoted 3 lines · Ren Zhijie
ping...
在 2022/4/18 16:24, Ren Zhijie 写道:
It was posted 3 days prior, relax please.
If you are eager to see patches reviewed faster, please help out and review them on the lists, we can always use the help.
thanks,
greg k-h