Skip to contentSkip to conversation

usb: dwc3: trace: log ep commands in hex

PATCH New Laurent Pinchart 1 participant 1 message Aug 20, 2018 USB

lore
Share & tools
lore
#0 lore raw

PATCH 3/4 usb: dwc3: trace: log ep commands in hex

Hi Andy,

Quoted 7 lines · On Monday, 20 August 2018 15:06:31 EEST Andy Shevchenko wrote:
Quoted 4 lines · Laurent Pinchart

Review

Quoted 2 lines
(quoted diff) +1 -1
-     TP_printk("%s: cmd '%s' [%d] params %08x %08x %08x --> status: %s",
+     TP_printk("%s: cmd '%s' [%x] params %08x %08x %08x --> status: %s",

How about 0x%x ?

Side note: # is one character less for the same.

Doesn't that print 0 instead of 0x0 ? There's no ambiguity with 0, but I find that always printing the 0x is more consistent. I'll leave that up to Felipe, I'm OK with both options.