Skip to contentSkip to conversation

build: remove non-x86 file from non-x86 net/avf builds

PATCH In review Luca Boccassi 2 participants 3 messages Sep 26, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build: remove non-x86 file from non-x86 net/avf builds

The sse file was added both conditionally on building for x86 and unconditionally, which breaks the build on non-x86.

Fixes bd29fd07ba64 ("build: add Meson files for avf PMD")
---
 drivers/net/avf/meson.build | 1 -
 1 file changed, 1 deletion(-)
drivers/net/avf/meson.build +0 -1
index b5ad9cc673..9a05ebbf4e 100644
@@ -9,7 +9,6 @@ objs = [base_objs]
 sources = files(
 	'avf_ethdev.c',
 	'avf_rxtx.c',
-	'avf_rxtx_vec_sse.c',
 	'avf_vchnl.c',
 )
 
Signature · 1 line
2.18.0
#1 lore raw
Quoted 15 lines · Luca Boccassi

The sse file was added both conditionally on building for x86 and unconditionally, which breaks the build on non-x86.

Fixes bd29fd07ba64 ("build: add Meson files for avf PMD")
---
 drivers/net/avf/meson.build | 1 -
 1 file changed, 1 deletion(-)
drivers/net/avf/meson.build +0 -0
index b5ad9cc673..9a05ebbf4e 100644

drivers/net/avf/meson.build objs = [base_objs] · line 12

Quoted 4 lines
drivers/net/avf/meson.build +0 -1
@@ -9,7 +9,6 @@ objs = [base_objs]
 sources = files(
 	'avf_ethdev.c',
 	'avf_rxtx.c',
-	'avf_rxtx_vec_sse.c',

The patch merged [1] already don't have this.

[1]
https://patches.dpdk.org/patch/44908/

#2 lore raw
Quoted 24 lines · Ferruh Yigit
Quoted 19 lines · Luca Boccassi

The sse file was added both conditionally on building for x86 and unconditionally, which breaks the build on non-x86.

Fixes bd29fd07ba64 ("build: add Meson files for avf PMD")

---
 drivers/net/avf/meson.build | 1 -

 1 file changed, 1 deletion(-)
drivers/net/avf/meson.build +0 -0
index b5ad9cc673..9a05ebbf4e 100644
@@ -9,7 +9,6 @@ objs = [base_objs]

 sources = files(
  'avf_ethdev.c',
  'avf_rxtx.c',

drivers/net/avf/meson.build objs = [base_objs] · line 12

Quoted 1 line
drivers/net/avf/meson.build +0 -1
-	'avf_rxtx_vec_sse.c',

The patch merged [1] already don't have this.

Quoted 2 lines

[1]
https://patches.dpdk.org/patch/44908/

Lol, I used an old git branch to check Bruce's patch, thanks, changed status on patchwork

Signature · 2 lines
Kind regards,
Luca Boccassi