Skip to contentSkip to conversation

Make missing checksums an error

PATCH In review Joshua Lock 4 participants 8 messages Dec 2, 2011 – Dec 6, 2011

lore
Share & tools
lore

Joshua Lock

author
#0 lore raw

cover Make missing checksums an error

NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly, otherwise you'll see a Python backtrace and the build fail...

Per some discussion on the list recently this patch sets BB_STRICT_CHECKSUM in the default-distrovars.inc so that missing checksums in recipes raises an error.

Cheers,
Joshua

1. lists.linuxtogo.org/pipermail/bitbake-devel/2011-December/thread.html

The following changes since commit 044324465bd54d53ae768f3c1e7468ae0e0c6200:

dpkg-native: Fix perl path (2011-12-02 15:31:03 +0000)

are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib josh/checksums
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=josh/checksums

Joshua Lock (1):
default-distrovars: missing checksums should raise an error

 meta/conf/distro/include/default-distrovars.inc |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.7.3
author
#1 lore raw

PATCH 1/1 default-distrovars: missing checksums should raise an error

Set BB_STRICT_CHECKSUM in default-distrovars so that an error is raised if no checksum is set.

Signed-off-by Joshua Lock <[email protected]>
---
 meta/conf/distro/include/default-distrovars.inc |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
meta/conf/distro/include/default-distrovars.inc +3 -0
index 6f5f1c0..e1594f3 100644
@@ -48,3 +48,6 @@ NO32LIBS ??= "1"
 BBINCLUDELOGS ??= "yes"
 SDK_VERSION ??= "oe-core.0"
 DISTRO_VERSION ??= "oe-core.0"
+
+# Missing checksums should raise an error
+BB_STRICT_CHECKSUM = "1"
Signature · 1 line
1.7.7.3
author
#2 lore raw
In reply to Joshua Lock
Quoted 2 lines · Joshua Lock

NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly, otherwise you'll see a Python backtrace and the build fail...

This patch has now been merged into BitBake master.

Cheers,
Joshua

Signature · 3 lines
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre
#3 lore raw
In reply to Joshua Lock
Quoted 9 lines · Joshua Lock

NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly, otherwise you'll see a Python backtrace and the build fail...

Per some discussion on the list recently this patch sets BB_STRICT_CHECKSUM in the default-distrovars.inc so that missing checksums in recipes raises an error.

Cheers,
Joshua

What's the state of master? If I merge this, how badly do things explode?

Cheers,

Richard

author
#4 lore raw
Quoted 8 lines · Richard Purdie
Quoted 7 lines · Joshua Lock

NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly, otherwise you'll see a Python backtrace and the build fail...

Per some discussion on the list recently this patch sets BB_STRICT_CHECKSUM in the default-distrovars.inc so that missing checksums in recipes raises an error.

Quoted 5 lines
Quoted 2 lines

Cheers,
Joshua

What's the state of master? If I merge this, how badly do things explode?

Let me run a universe fetchall and get back to you...

Joshua

Signature · 3 lines
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre
author
#5 lore raw
Quoted 9 lines · Joshua Lock
Quoted 8 lines · Richard Purdie
Quoted 7 lines · Joshua Lock

NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly, otherwise you'll see a Python backtrace and the build fail...

Per some discussion on the list recently this patch sets BB_STRICT_CHECKSUM in the default-distrovars.inc so that missing checksums in recipes raises an error.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Cheers,
Joshua

What's the state of master? If I merge this, how badly do things explode?

Let me run a universe fetchall and get back to you...

Two recipes in oe-core require checksums adding, puzzles and omap3-sgx-modules - a v2 of this request with those patches is incoming.

Joshua

Signature · 3 lines
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre
#6 lore raw

Op 6 dec. 2011, om 03:13 heeft Joshua Lock het volgende geschreven:

Quoted 15 lines · Joshua Lock
Quoted 12 lines · Richard Purdie
Quoted 11 lines · Joshua Lock
Quoted 9 lines

NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly, otherwise you'll see a Python backtrace and the build fail...

Per some discussion on the list recently this patch sets BB_STRICT_CHECKSUM in the default-distrovars.inc so that missing checksums in recipes raises an error.

Cheers,
Joshua

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

What's the state of master? If I merge this, how badly do things explode?

Let me run a universe fetchall and get back to you...

Two recipes in oe-core require checksums adding, puzzles and omap3-sgx-modules - a v2 of this request with those patches is incoming.

Omap3-sgx-modules has no place in OE-core, so it should get deleted.

regards,

KOen

#7 lore raw
Quoted 1 line · On Tuesday 06 December 2011 08:18:30 Koen Kooi wrote:

Omap3-sgx-modules has no place in OE-core, so it should get deleted.

Sounds good, would you mind sending a patch that does that?

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre