drm/xe: Add process name to devcoredump
Subsystems (2)
PATCH 1/1 drm/xe: Add process name to devcoredump
Process name help us track what application caused the gpug hang, this is crucial when running several applications at the same time.
Cc Rodrigo Vivi <[email protected]>
Signed-off-by José Roberto de Souza <[email protected]>
--- drivers/gpu/drm/xe/xe_devcoredump.c | 8 ++++++++ drivers/gpu/drm/xe/xe_devcoredump_types.h | 2 ++ 2 files changed, 10 insertions(+)
drivers/gpu/drm/xe/xe_devcoredump.c +8 -0
@@ -110,6 +110,7 @@ static ssize_t xe_devcoredump_read(char *buffer, loff_t offset,drm_printf (&p,"Snapshot time: %lld.%09ld\n" , ts.tv_sec, ts.tv_nsec); ts =ktime_to_timespec64 (ss->boot_time);drm_printf (&p,"Uptime: %lld.%09ld\n" , ts.tv_sec, ts.tv_nsec); +drm_printf (&p,"Process: %s\n" , ss->process_name);xe_device_snapshot_print (xe, &p);drm_printf (&p,"\n**** GuC CT ****\n" );
@@ -166,12 +167,19 @@ static void devcoredump_snapshot(struct xe_devcoredump *coredump,enum xe_hw_engine_id id;u32 adj_logical_mask = q->logical_mask;u32 width_mask = (0x1 << q->width) -1 ; +struct task_struct *task;int i;bool cookie; ss->snapshot_time =ktime_get_real (); ss->boot_time =ktime_get_boottime (); +rcu_read_lock (); + task =pid_task (q->vm->xef->drm->pid,PIDTYPE_PID ); +if (task) +strscpy (ss->process_name, task->comm,sizeof (ss->process_name)); +rcu_read_unlock (); + ss->gt = q->gt;INIT_WORK (&ss->work, xe_devcoredump_deferred_snap_work);
drivers/gpu/drm/xe/xe_devcoredump_types.h +2 -0
@@ -26,6 +26,8 @@ struct xe_devcoredump_snapshot {ktime_t snapshot_time;/** @boot_time: Relative boot time so the uptime can be calculated. */ ktime_t boot_time; +/** @process_name: Name of process that triggered this gpu hang */ +char process_name[TASK_COMM_LEN ];/** @gt: Affected GT, used by forcewake for delayed capture */ struct xe_gt *gt;
Signature · 1 line
2.45.1
Quoted 28 lines · José Roberto de Souza
Process name help us track what application caused the gpug hang, this is crucial when running several applications at the same time.
Cc Rodrigo Vivi <[email protected]>Signed-off-by José Roberto de Souza <[email protected]>--- drivers/gpu/drm/xe/xe_devcoredump.c | 8 ++++++++ drivers/gpu/drm/xe/xe_devcoredump_types.h | 2 ++ 2 files changed, 10 insertions(+)drivers/gpu/drm/xe/xe_devcoredump.c +2
-0@@ -110,6 +110,7 @@ static ssize_t xe_devcoredump_read(char *buffer, loff_t offset,drm_printf (&p,"Snapshot time: %lld.%09ld\n" , ts.tv_sec, ts.tv_nsec); ts =ktime_to_timespec64 (ss->boot_time);drm_printf (&p,"Uptime: %lld.%09ld\n" , ts.tv_sec, ts.tv_nsec); +drm_printf (&p,"Process: %s\n" , ss->process_name);xe_device_snapshot_print (xe, &p);drm_printf (&p,"\n**** GuC CT ****\n" );@@ -166,12 +167,19 @@ static void devcoredump_snapshot(struct xe_devcoredump *coredump,enum xe_hw_engine_id id;u32 adj_logical_mask = q->logical_mask;u32 width_mask = (0x1 << q->width) -1 ; +struct task_struct *task;int i;
drivers/gpu/drm/xe/xe_devcoredump.c static void devcoredump_snapshot(struct xe_devcoredump *coredump, · line 181
Quoted 10 lines
drivers/gpu/drm/xe/xe_devcoredump.c +5
-0bool cookie; ss->snapshot_time =ktime_get_real (); ss->boot_time =ktime_get_boottime (); +rcu_read_lock (); + task =pid_task (q->vm->xef->drm->pid,PIDTYPE_PID ); +if (task) +strscpy (ss->process_name, task->comm,sizeof (ss->process_name)); +rcu_read_unlock ();
Use get_pid_task() instead. Otherwise
Reviewed-by Nirmoy Das <[email protected]>
Quoted 17 lines
drivers/gpu/drm/xe/xe_devcoredump.c +1
-0+ ss->gt = q->gt;INIT_WORK (&ss->work, xe_devcoredump_deferred_snap_work);drivers/gpu/drm/xe/xe_devcoredump_types.h +2
-0@@ -26,6 +26,8 @@ struct xe_devcoredump_snapshot {ktime_t snapshot_time;/** @boot_time: Relative boot time so the uptime can be calculated. */ ktime_t boot_time; +/** @process_name: Name of process that triggered this gpu hang */ +char process_name[TASK_COMM_LEN ];/** @gt: Affected GT, used by forcewake for delayed capture */ struct xe_gt *gt;