Skip to contentSkip to conversation

Removal of checkboard from spl bootstrap build for SIMPC8313

PATCH Superseded Ron Madrid 2 participants 5 messages May 10, 2010 – May 17, 2010

lore
Share & tools
lore

Ron Madrid

author
#0 lore raw

PATCH v2 1/1 Removal of checkboard from spl bootstrap build for SIMPC8313

This patch removes the checkboard function from the build of the 4k bootstrap section for the SIMPC8313 as it is not needed in the spl build. This will allow > 100 bytes of extra room for other uses.

---
 board/sheldon/simpc8313/simpc8313.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
board/sheldon/simpc8313/simpc8313.c +1 -1
index 0235545..cb30b48 100644
@@ -33,13 +33,13 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
+#ifndef CONFIG_NAND_SPL
 int checkboard(void)
 {
 	puts("Board: Sheldon Instruments SIMPC8313\n");
 	return 0;
 }
 
-#ifndef CONFIG_NAND_SPL
 static struct pci_region pci_regions[] = {
 	{
 		bus_start: CONFIG_SYS_PCI1_MEM_BASE,
Signature · 1 line
1.5.5.1
#1 lore raw

PATCH v2 1/1 Removal of checkboard from spl bootstrap build for SIMPC8313

Quoted 6 lines · On Mon, 10 May 2010 15:23:20 -0700 Ron Madrid <[email protected]> wrote:

This patch removes the checkboard function from the build of the 4k bootstrap section for the SIMPC8313 as it is not needed in the spl build. This will allow > 100 bytes of extra room for other uses.

---

Hi Ron,

while this patch looks great, the 8315 nand build remains broken. I cooked up the following patch to fix both the simpc8313 and the 8315erdb. Let me know if you want me to still apply yours in addition to this, or any other concerns you may have.

Thanks,

Kim

author
#2 lore raw

PATCH v2 1/1 Removal of checkboard from spl bootstrap build for SIMPC8313

Quoted 20 lines · Kim Phillips

From: Kim Phillips <[email protected]>
Subject: Re: [U-Boot] [PATCH v2][mpc83xx] Removal of checkboard from spl bootstrap build for SIMPC8313
To: "Ron Madrid" <[email protected]>
Cc: u-boot at lists.denx.de
Date: Friday, May 14, 2010, 11:26 AM

Quoted 1 line · On Mon, 10 May 2010 15:23:20 -0700 Ron Madrid <[email protected]> wrote:

This patch removes the checkboard function from the

build of the 4k bootstrap

Quoted 1 line

section for the SIMPC8313 as it is not needed in the

spl build. This will

Quoted 4 lines

allow > 100 bytes of extra room for other uses.

---

Hi Ron,

Quoted 7 lines

while this patch looks great, the 8315 nand build remains broken. I
cooked up the following patch to fix both the simpc8313 and the
8315erdb. Let me know if you want me to still apply yours in addition
to this, or any other concerns you may have.

Yes, please still apply my patch. It will 'give back' a bunch of unnecessarily used space in the first 4k for my board. I was also going to look into a common fix but thought it prudent to first check my board specific files, which is how I came across the 'fix' for my board.

Thanks,

Ron

Applied
#3 lore raw

PATCH v2 1/1 Removal of checkboard from spl bootstrap build for SIMPC8313

In reply to Kim Phillips
Quoted 10 lines · On Fri, 14 May 2010 13:26:44 -0500 Kim Phillips <[email protected]>…

From 4cb5f50929688d90b68366116713ec735ec51a5f Mon Sep 17 00:00:00 2001
From: Kim Phillips <[email protected]>
Date: Fri, 14 May 2010 13:18:54 -0500
Subject: [PATCH] mpc83xx: fix NAND bootstrap too big error

commit 167cdad1372917bc11c636c359aad02625291fa9 "SERIAL: Enable port-mapped access" inadvertently broke 83xx nand boards by converting NS16550_init to use io accessors, which expanded the size of the generated code.

Quoted 7 lines

this patch fixes the problem by removing icache functions from the nand builds, which somewhat follows the icache implementation commit 1a2e203b31d33fb720f2cf1033b241ad36ab405a "mpc83xx: turn on icache in core initialization to improve u-boot boot time" took.

---

applied.

Thanks,

Kim

Applied
#4 lore raw

PATCH v2 1/1 Removal of checkboard from spl bootstrap build for SIMPC8313

In reply to Ron Madrid
Quoted 6 lines · On Mon, 10 May 2010 15:23:20 -0700 Ron Madrid <[email protected]> wrote:

This patch removes the checkboard function from the build of the 4k bootstrap section for the SIMPC8313 as it is not needed in the spl build. This will allow > 100 bytes of extra room for other uses.

---

applied.

Thanks,

Kim