ima: Use kmemdup rather than kmalloc+memcpy
Subsystems (4)
PATCH 1/1 ima: Use kmemdup rather than kmalloc+memcpy
Issue identified with Coccinelle.
Signed-off-by Alex Dewar <[email protected]>
--- security/integrity/ima/ima_policy.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
security/integrity/ima/ima_policy.c +4 -5
@@ -284,15 +284,14 @@ static struct ima_rule_entry *ima_lsm_copy_rule(struct ima_rule_entry *entry)struct ima_rule_entry *nentry;int i; - nentry =kmalloc (sizeof (*nentry),GFP_KERNEL ); -if (!nentry) -return NULL ; -/* * Immutable elements are copied over as pointers and data; only * lsm rules can change */ -memcpy (nentry, entry,sizeof (*nentry)); + nentry =kmemdup (entry,sizeof (*nentry),GFP_KERNEL ); +if (!nentry) +return NULL ; + memset(nentry->lsm, 0, sizeof_field(struct ima_rule_entry, lsm));for (i =0 ; i <MAX_LSM_RULES ; i++) {
Signature · 1 line
2.28.0
Mimi Zohar
maintainerQuoted 3 lines · Alex Dewar
Issue identified with Coccinelle.
Signed-off-by Alex Dewar <[email protected]>
Thank you.
Mimi