Add HP Stream 8 to bytcr_rt5640.c
Subsystems (3)
PATCH 1/1 Add HP Stream 8 to bytcr_rt5640.c
The HP Stream 8 tablet is identical to the HP Stream 7 in terms of the PCB, with the exception of the added SIM Card Slot.
Therefore, I'm submitting this patch which properly initializes the audio and enables the headphone jack to work, just like it does in the HP Stream 7.
--- sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
sound/soc/intel/boards/bytcr_rt5640.c +11 -0
@@ -796,6 +796,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {BYT_RT5640_SSP0_AIF1 | BYT_RT5640_MCLK_EN), }, + { /* HP Stream 8 */ + .matches = { +DMI_EXACT_MATCH (DMI_SYS_VENDOR ,"Hewlett-Packard" ), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "HP Stream 8 Tablet"), + }, + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS | +BYT_RT5640_MONO_SPEAKER | +BYT_RT5640_JD_NOT_INV | +BYT_RT5640_SSP0_AIF1 | + BYT_RT5640_MCLK_EN), + }, { /* I.T.Works TW891 */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
Signature · 1 line
2.37.2
Hello Moises,
Quoted 7 lines · Moises Cardona
The HP Stream 8 tablet is identical to the HP Stream 7 in terms of the PCB, with the exception of the added SIM Card Slot.
Therefore, I'm submitting this patch which properly initializes the audio and enables the headphone jack to work, just like it does in the HP Stream 7.Signed-off-by Moises Cardona <[email protected]>
Thank you for your patch.
According to this review:
http://techlife101.com/hp-stream-8-review/
The Stream 8 has 2 speakers, so you should drop the BYT_RT5640_MONO_SPEAKER part so that both speakers will be used.
Regards,
Hans
Quoted 26 lines
--- sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++ 1 file changed, 11 insertions(+)sound/soc/intel/boards/bytcr_rt5640.c +11
-0@@ -796,6 +796,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {BYT_RT5640_SSP0_AIF1 | BYT_RT5640_MCLK_EN), }, + { /* HP Stream 8 */ + .matches = { +DMI_EXACT_MATCH (DMI_SYS_VENDOR ,"Hewlett-Packard" ), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "HP Stream 8 Tablet"), + }, + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS | +BYT_RT5640_MONO_SPEAKER | +BYT_RT5640_JD_NOT_INV | +BYT_RT5640_SSP0_AIF1 | + BYT_RT5640_MCLK_EN), + }, { /* I.T.Works TW891 */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
Quoted 7 lines · Moises Cardona
The HP Stream 8 tablet is identical to the HP Stream 7 in terms of the PCB, with the exception of the added SIM Card Slot.
Therefore, I'm submitting this patch which properly initializes the audio and enables the headphone jack to work, just like it does in the HP Stream 7.Signed-off-by Moises Cardona <[email protected]>
Quoted 26 lines
--- sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++ 1 file changed, 11 insertions(+)sound/soc/intel/boards/bytcr_rt5640.c +11
-0@@ -796,6 +796,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {BYT_RT5640_SSP0_AIF1 | BYT_RT5640_MCLK_EN), }, + { /* HP Stream 8 */ + .matches = { +DMI_EXACT_MATCH (DMI_SYS_VENDOR ,"Hewlett-Packard" ), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "HP Stream 8 Tablet"), + }, + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS | +BYT_RT5640_MONO_SPEAKER | +BYT_RT5640_JD_NOT_INV | +BYT_RT5640_SSP0_AIF1 | + BYT_RT5640_MCLK_EN), + }, { /* I.T.Works TW891 */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
Hi,
Quoted 9 lines · Pierre-Louis Bossart
Quoted 6 lines · Moises Cardona
The HP Stream 8 tablet is identical to the HP Stream 7 in terms of the PCB, with the exception of the added SIM Card Slot.
Therefore, I'm submitting this patch which properly initializes the audio and enables the headphone jack to work, just like it does in the HP Stream 7.
Quoted 3 lines
Quoted 1 line
Signed-off-by Moises Cardona <[email protected]>
Note this is the old version which wrongly contains the BYT_RT5640_MONO_SPEAKER flag.
Mark, please merge the new version (which unfortunately was not marked as v2) which correctly drops the BYT_RT5640_MONO_SPEAKER flag.
(this tablet has 2 speakers so it should not have the mono flag)
Regards,
Hans
Quoted 28 lines
Quoted 27 lines
--- sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++ 1 file changed, 11 insertions(+)sound/soc/intel/boards/bytcr_rt5640.c +11
-0@@ -796,6 +796,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {BYT_RT5640_SSP0_AIF1 | BYT_RT5640_MCLK_EN), }, + { /* HP Stream 8 */ + .matches = { +DMI_EXACT_MATCH (DMI_SYS_VENDOR ,"Hewlett-Packard" ), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "HP Stream 8 Tablet"), + }, + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS | +BYT_RT5640_MONO_SPEAKER | +BYT_RT5640_JD_NOT_INV | +BYT_RT5640_SSP0_AIF1 | + BYT_RT5640_MCLK_EN), + }, { /* I.T.Works TW891 */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
Mark Brown
maintainerQuoted 3 lines · Hans de Goede
Mark, please merge the new version (which unfortunately was not marked as v2) which correctly drops the
BYT_RT5640_MONO_SPEAKERflag.
It's already going through my queue.