clk: samsung: allow building the clkout driver as module
Subsystems (3)
Krzysztof Kozlowski
maintainerPATCH 1/1 clk: samsung: allow building the clkout driver as module
The Exynos clock output driver can be built as module (it does not have to be part of core init process) for better customization. Adding a KConfig entry allows also compile testing for build coverage.
--- drivers/clk/samsung/Kconfig | 10 ++++++++++ drivers/clk/samsung/Makefile | 2 +- drivers/clk/samsung/clk-exynos-clkout.c | 1 + 3 files changed, 12 insertions(+), 1 deletion(-)
drivers/clk/samsung/Kconfig +10 -0
@@ -19,6 +19,16 @@ config EXYNOS_AUDSS_CLK_CON on some Exynos SoC variants. Choose M or Y here if you want to use audio devices such as I2S, PCM, etc. +config EXYNOS_CLK_OUT + tristate "Samsung Exynos clock output driver" + depends on COMMON_CLK_SAMSUNG + default y if ARCH_EXYNOS + help + Support for the clock output (XCLKOUT) driver present on some of + Exynos SoC variants. Usually the XCLKOUT is used to monitor the + status of the certains clocks from SoC, but it could also be tied to + other devices as an input clock. + # For S3C24XX platforms, select following symbols: config S3C2410_COMMON_CLK bool "Samsung S3C2410 clock controller support" if COMPILE_TEST
drivers/clk/samsung/Makefile +1 -1
@@ -15,7 +15,7 @@ obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5-subcmu.o obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos5433.o obj-$(CONFIG_EXYNOS_AUDSS_CLK_CON) += clk-exynos-audss.o -obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o +obj-$(CONFIG_EXYNOS_CLK_OUT) += clk-exynos-clkout.o obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos7.o obj-$(CONFIG_S3C2410_COMMON_CLK)+= clk-s3c2410.o obj-$(CONFIG_S3C2410_COMMON_DCLK)+= clk-s3c2410-dclk.o
drivers/clk/samsung/clk-exynos-clkout.c +1 -0
@@ -72,6 +72,7 @@ static const struct of_device_id exynos_clkout_ids[] = { .data = &exynos_clkout_exynos5, }, { } }; +MODULE_DEVICE_TABLE (of, exynos_clkout_ids);/* * Device will be instantiated as child of PMU device without its own
Signature · 1 line
2.25.1
Hi Krzysztof,
Quoted 51 lines · Krzysztof Kozlowski
The Exynos clock output driver can be built as module (it does not have to be part of core init process) for better customization. Adding a KConfig entry allows also compile testing for build coverage.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/clk/samsung/Kconfig | 10 ++++++++++ drivers/clk/samsung/Makefile | 2 +- drivers/clk/samsung/clk-exynos-clkout.c | 1 + 3 files changed, 12 insertions(+), 1 deletion(-)drivers/clk/samsung/Kconfig +10
-0@@ -19,6 +19,16 @@ config EXYNOS_AUDSS_CLK_CON on some Exynos SoC variants. Choose M or Y here if you want to use audio devices such as I2S, PCM, etc. +config EXYNOS_CLK_OUT + tristate "Samsung Exynos clock output driver" + depends on COMMON_CLK_SAMSUNG + default y if ARCH_EXYNOS + help + Support for the clock output (XCLKOUT) driver present on some of + Exynos SoC variants. Usually the XCLKOUT is used to monitor the + status of the certains clocks from SoC, but it could also be tied to + other devices as an input clock. + # For S3C24XX platforms, select following symbols: config S3C2410_COMMON_CLK bool "Samsung S3C2410 clock controller support" if COMPILE_TESTdrivers/clk/samsung/Makefile +1
-1@@ -15,7 +15,7 @@ obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5-subcmu.o obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos5433.o obj-$(CONFIG_EXYNOS_AUDSS_CLK_CON) += clk-exynos-audss.o -obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o +obj-$(CONFIG_EXYNOS_CLK_OUT) += clk-exynos-clkout.o obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos7.o obj-$(CONFIG_S3C2410_COMMON_CLK)+= clk-s3c2410.o obj-$(CONFIG_S3C2410_COMMON_DCLK)+= clk-s3c2410-dclk.odrivers/clk/samsung/clk-exynos-clkout.c +0
-0
drivers/clk/samsung/clk-exynos-clkout.c static const struct of_device_id exynos_clkout_ids[] = { · line 78
Quoted 7 lines
drivers/clk/samsung/clk-exynos-clkout.c +1
-0@@ -72,6 +72,7 @@ static const struct of_device_id exynos_clkout_ids[] = { .data = &exynos_clkout_exynos5, }, { } }; +MODULE_DEVICE_TABLE (of, exynos_clkout_ids);/* * Device will be instantiated as child of PMU device without its own
Signature · 3 lines
Best Regards, Chanwoo Choi Samsung Electronics
Quoted 5 lines · Krzysztof Kozlowski
The Exynos clock output driver can be built as module (it does not have to be part of core init process) for better customization. Adding a KConfig entry allows also compile testing for build coverage.
Signed-off-by Krzysztof Kozlowski <[email protected]>
This needs to go through your tree due to dependencies on your previous patches, so
Quoted 11 lines
--- drivers/clk/samsung/Kconfig | 10 ++++++++++ drivers/clk/samsung/Makefile | 2 +- drivers/clk/samsung/clk-exynos-clkout.c | 1 + 3 files changed, 12 insertions(+), 1 deletion(-)drivers/clk/samsung/Kconfig +0
-0
drivers/clk/samsung/Kconfig config EXYNOS_AUDSS_CLK_CON · line 22
Quoted 4 lines
drivers/clk/samsung/Kconfig +1
-0@@ -19,6 +19,16 @@ config EXYNOS_AUDSS_CLK_CON on some Exynos SoC variants. Choose M or Y here if you want to use audio devices such as I2S, PCM, etc. +config EXYNOS_CLK_OUT
Perhaps change it EXYNOS_CLKOUT for a better match with the SoC documentation?
Quoted 14 lines
drivers/clk/samsung/Kconfig +8
-0+ tristate "Samsung Exynos clock output driver" + depends on COMMON_CLK_SAMSUNG + default y if ARCH_EXYNOS + help + Support for the clock output (XCLKOUT) driver present on some of + Exynos SoC variants. Usually the XCLKOUT is used to monitor the + status of the certains clocks from SoC, but it could also be tied to + other devices as an input clock.drivers/clk/samsung/Makefile +0
-0
drivers/clk/samsung/Makefile obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o · line 18
Quoted 5 lines
drivers/clk/samsung/Makefile +1
-1@@ -15,7 +15,7 @@ obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5-subcmu.o obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos5433.o obj-$(CONFIG_EXYNOS_AUDSS_CLK_CON) += clk-exynos-audss.o -obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o +obj-$(CONFIG_EXYNOS_CLK_OUT) += clk-exynos-clkout.o
--
Regards,
Sylwester
Krzysztof Kozlowski
maintainerQuoted 11 lines · Sylwester Nawrocki
Quoted 5 lines · Krzysztof Kozlowski
The Exynos clock output driver can be built as module (it does not have to be part of core init process) for better customization. Adding a KConfig entry allows also compile testing for build coverage.
Signed-off-by Krzysztof Kozlowski <[email protected]>This needs to go through your tree due to dependencies on your previous patches, so
Yes, thanks.
Quoted 15 lines
Quoted 15 lines
--- drivers/clk/samsung/Kconfig | 10 ++++++++++ drivers/clk/samsung/Makefile | 2 +- drivers/clk/samsung/clk-exynos-clkout.c | 1 + 3 files changed, 12 insertions(+), 1 deletion(-)drivers/clk/samsung/Kconfig +0
-0@@ -19,6 +19,16 @@ config EXYNOS_AUDSS_CLK_CON on some Exynos SoC variants. Choose M or Y here if you want to use audio devices such as I2S, PCM, etc.
Quoted 3 lines
drivers/clk/samsung/Kconfig config EXYNOS_AUDSS_CLK_CON · line 22
Quoted 1 line
drivers/clk/samsung/Kconfig +1
-0+config EXYNOS_CLK_OUTPerhaps change it
EXYNOS_CLKOUTfor a better match with the SoC documentation?
Sure, I applied it with name fixup.
Best regards,
Krzysztof