intel-gpu-top: Support for client stats
PATCH 1/1 intel-gpu-top: Support for client stats
From: Tvrtko Ursulin <[email protected]>
Adds support for per-client engine busyness stats i915 exports in sysfs and produces output like the below:
===============================================================================
intel-gpu-top: Intel Skylake (Gen9) @ /dev/dri/card0 - 951/ 950 MHz;
0% RC6; 14.60/23.62 W; 1482 irqs/s
IMC reads: 1287 MiB/s
IMC writes: 115 MiB/s
ENGINES BUSY MI_SEMA MI_WAIT
Render/3D 95.48% |█████████████████████████████████ | 5% 0%
Blitter 15.98% |█████ | 10% 0%
Video 35.40% |████████████ | 26% 0%
VideoEnhance 0.00% | | 0% 0%
PID NAME Render/3D Blitter Video VideoEnhance
1053 gem_wsim |███ || ||███ || | 1054 gem_wsim |███████ ||█ || || |
===============================================================================
Apart from the existing physical engine utilization it now also shows utilization per client and per engine class.
v2:
* Version to match removal of global enable_stats toggle.
* Plus various fixes.
v3:
* Support brief backward jumps in client stats.
v4:
* Support device selection.
v5:
* Rebase for class aggregation.
* Optimise sysfs reads a tiny bit by openat(2) and caching client root.
--- tools/intel_gpu_top.c | 557 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 545 insertions(+), 12 deletions(-)
tools/intel_gpu_top.c +545 -12
@@ -1,5 +1,5 @@/* -* Copyright © 2007-2019 Intel Corporation +* Copyright © 2007-2021 Intel Corporation * * Permission is hereby granted, free of charge, to any person obtaining a * copy of this software and associated documentation files (the "Software"),
@@ -625,23 +625,356 @@ static void pmu_sample(struct engines *engines) } } +enum client_status { +FREE =0 ,/* mbz */ +ALIVE , +PROBE +}; + +struct clients ; + +struct client { +struct clients *clients; + +enum client_status status; +int sysfs_root; +unsigned int id; +unsigned int pid; +char name[128 ]; +unsigned int samples; +unsigned long total; +struct engines *engines; +unsigned long *val; +uint64_t *last; +}; + +struct clients { +unsigned int num_clients; + +unsigned int num_classes; +struct engine_class *class; + +char sysfs_root[64 ]; + +struct client *client; +}; + +#define for_each_client (clients, c, tmp) \ + for ((tmp) = (clients)->num_clients, c = (clients)->client; \ + (tmp > 0); (tmp)--, (c)++) + +static struct clients *init_clients (const char *drm_card) +{ +struct clients *clients =malloc (sizeof (*clients)); +const char *slash; +ssize_t ret; + +memset (clients,0 ,sizeof (*clients)); + +if (drm_card) { + slash =rindex (drm_card,'/' ); +assert (slash); + }else { + slash ="card0" ; + } + + ret =snprintf (clients->sysfs_root,sizeof (clients->sysfs_root), +"/sys/class/drm/%s/clients/" , slash); +assert (ret >0 && ret <sizeof (clients->sysfs_root)); + +return clients; +} + +static int __read_to_buf (int fd,char *buf,unsigned int bufsize) +{ +ssize_t ret; +int err; + + ret =read (fd, buf, bufsize -1 ); + err = errno; +if (ret <1 ) { + errno = ret <0 ? err :ENOMSG ; + +return -1 ; + } + +if (ret >1 && buf[ret -1 ] =='\n' ) + buf[ret -1 ] ='\0' ; +else + buf[ret] ='\0' ; + +return 0 ; +} + +static int +__read_client_field (int root,const char *field,char *buf,unsigned int bufsize) +{ +int fd, ret; + + fd =openat (root, field,O_RDONLY ); +if (fd <0 ) +return -1 ; + + ret =__read_to_buf (fd, buf, bufsize); + +close (fd); + +return ret; +} + +static uint64_t +read_client_busy (const struct client *client,unsigned int class) +{ +char buf[256 ], *b; +int ret; + +assert (client->sysfs_root >=0 ); +if (client->sysfs_root <0 ) +return 0 ; + + ret =snprintf (buf,sizeof (buf),"busy/%u" , class); +assert (ret >0 && ret <sizeof (buf)); +if (ret <=0 || ret ==sizeof (buf)) +return 0 ; + + ret =__read_client_field (client->sysfs_root, buf, buf,sizeof (buf)); +assert (ret ==0 ); +if (ret) +return 0 ; + +/* +* Handle both single integer and key=value formats by skipping +* leading non-digits. +*/ + b = buf; +while (*b && !isdigit (*b)) + b++; + +return strtoull (b,NULL ,10 ); +} + +static struct client * +find_client (struct clients *clients,enum client_status status,unsigned int id) +{ +struct client *c; +int tmp; + +for_each_client (clients, c, tmp) { +if ((status ==FREE && c->status ==FREE ) || + (status == c->status && c->id == id)) +return c; + } + +return NULL ; +} + +static void update_client (struct client *c,unsigned int pid,char *name) +{ +uint64_t val[c->clients->num_classes]; +unsigned int i; + +if (c->pid != pid) + c->pid = pid; + +if (strcmp (c->name, name)) +strncpy (c->name, name,sizeof (c->name) -1 ); + +for (i =0 ; i < c->clients->num_classes; i++) + val[i] =read_client_busy (c, c->clients->class[i].class); + + c->total =0 ; + +for (i =0 ; i < c->clients->num_classes; i++) { +if (val[i] < c->last[i]) +continue ;/* It will catch up soon. */ + + c->val[i] = val[i] - c->last[i]; + c->total += c->val[i]; + c->last[i] = val[i]; + } + + c->samples++; + c->status =ALIVE ; +} + +static void +add_client (struct clients *clients,unsigned int id,unsigned int pid, +char *name,int sysfs_root) +{ +struct client *c; + +if (find_client (clients,ALIVE , id)) +return ; + + c =find_client (clients,FREE ,0 ); +if (!c) { +unsigned int idx = clients->num_clients; + + clients->num_clients += (clients->num_clients +2 ) /2 ; + clients->client =realloc (clients->client, + clients->num_clients *sizeof (*c)); +assert (clients->client); + + c = &clients->client[idx]; +memset (c,0 , (clients->num_clients - idx) *sizeof (*c)); + } + + c->sysfs_root = sysfs_root; + c->id = id; + c->clients = clients; + c->val =calloc (clients->num_classes,sizeof (c->val)); + c->last =calloc (clients->num_classes,sizeof (c->last)); +assert (c->val && c->last); + +update_client (c, pid, name); +} + +static void free_client (struct client *c) +{ +if (c->sysfs_root >=0 ) +close (c->sysfs_root); +free (c->val); +free (c->last); +memset (c,0 ,sizeof (*c)); +} + +static int +read_client_sysfs (char *buf,int bufsize,const char *sysfs_root, +unsigned int id,const char *field,int *client_root) +{ +ssize_t ret; + +if (*client_root <0 ) { +char namebuf[256 ]; + + ret =snprintf (namebuf,sizeof (namebuf),"%s/%u" , + sysfs_root, id); +assert (ret >0 && ret <sizeof (namebuf)); +if (ret <=0 || ret ==sizeof (namebuf)) +return -1 ; + + *client_root =open (namebuf,O_RDONLY |O_DIRECTORY ); + } + +if (*client_root <0 ) +return -1 ; + +return __read_client_field (*client_root, field, buf, bufsize); +} + +static void scan_clients (struct clients *clients) +{ +struct dirent *dent; +struct client *c; +unsigned int id; +int tmp; +DIR *d; + +if (!clients) +return ; + +for_each_client (clients, c, tmp) { +if (c->status ==ALIVE ) + c->status =PROBE ; + } + + d =opendir (clients->sysfs_root); +if (!d) +return ; + +while ((dent =readdir (d)) !=NULL ) { +char name[256 ], pid[256 ]; +int ret, root =-1 , *pr; + +if (dent->d_type !=DT_DIR ) +continue ; +if (!isdigit (dent->d_name[0 ])) +continue ; + + id =atoi (dent->d_name); + + c =find_client (clients,PROBE , id); + +if (c) + pr = &c->sysfs_root; +else + pr = &root; + + ret =read_client_sysfs (name,sizeof (name), clients->sysfs_root, + id,"name" , pr); + ret |=read_client_sysfs (pid,sizeof (pid), clients->sysfs_root, + id,"pid" , pr); +if (!ret) { +if (!c) +add_client (clients, id,atoi (pid), name, root); +else +update_client (c,atoi (pid), name); + }else if (c) { + c->status =PROBE ;/* Will be deleted below. */ + } + } + +closedir (d); + +for_each_client (clients, c, tmp) { +if (c->status ==PROBE ) +free_client (c); + } +} + +static int cmp (const void *_a,const void *_b) +{ +const struct client *a = _a; +const struct client *b = _b; +long tot_a = a->total; +long tot_b = b->total; + + tot_a *= a->status ==ALIVE && a->samples >1 ; + tot_b *= b->status ==ALIVE && b->samples >1 ; + + tot_b -= tot_a; + +if (!tot_b) +return (int )b->id - a->id; + +while (tot_b >INT_MAX || tot_b <INT_MIN ) + tot_b /=2 ; + +return tot_b; +} +static const char *bars[] = {" " ,"▏" ,"▎" ,"▍" ,"▌" ,"▋" ,"▊" ,"▉" ,"█" }; +static void n_spaces (const unsigned int n) +{ +unsigned int i; + +for (i =0 ; i < n; i++) +putchar (' ' ); +} +static void print_percentage_bar (double percent,int max_len) { -int bar_len = percent * (8 * (max_len -2 )) /100.0 ; -int i; +int bar_len, i, len = max_len -2 ; +const int w =8 ; + +assert (max_len >0 ); + + bar_len = percent * len /100.0 ; +if (bar_len > len) + bar_len = len; + bar_len *= w;putchar ('|' ); -for (i = bar_len; i >=8 ; i -=8 ) -printf ("%s" , bars[8 ]); +for (i = bar_len; i >= w; i -= w) +printf ("%s" , bars[w]);if (i)printf ("%s" , bars[i]); -for (i =0 ; i < (max_len -2 - (bar_len +7 ) /8 ); i++) -putchar (' ' ); + len -= (bar_len + (w -1 )) / w; +n_spaces (len);putchar ('|' ); }
@@ -744,6 +1077,18 @@ json_close_struct(void)fflush (stdout); } +static void +__json_add_member (const char *key,const char *val) +{ +assert (json_indent_level <ARRAY_SIZE (json_indent)); + +fprintf (out,"%s%s\"%s\": \"%s\"" , + json_struct_members ?",\n" :"" , + json_indent[json_indent_level], key, val); + + json_struct_members++; +} +static unsigned int json_add_member (const struct cnt_group *parent,struct cnt_item *item,unsigned int headers)
@@ -1046,8 +1391,6 @@ print_header(const struct igt_device_card *card,memmove (&groups[0 ], &groups[1 ],sizeof (groups) -sizeof (groups[0 ])); - pops->open_struct (NULL ); - *consumed =print_groups (groups);if (output_mode ==INTERACTIVE ) {
@@ -1204,7 +1547,7 @@ print_engine(struct engines *engines, unsigned int i, double t, engine->display_name, engine_items[0].buf); val =pmu_calc (&engine->busy.val,1e9 , t,100 ); -print_percentage_bar (val, max_w - len); +print_percentage_bar (val, max_w > len ? max_w - len :0 );printf ("%s\n" , buf);
@@ -1219,7 +1562,6 @@ print_engines_footer(struct engines *engines, double t, int lines, int con_w, int con_h) { pops->close_struct(); - pops->close_struct ();if (output_mode ==INTERACTIVE ) {if (lines++ < con_h)
@@ -1243,6 +1585,9 @@ static void init_engine_classes(struct engines *engines)unsigned int i, num;int max =-1 ; +if (engines->num_classes) +return ; +for (i =0 ; i < engines->num_engines; i++) {struct engine *engine =engine_ptr (engines, i);
@@ -1404,6 +1749,148 @@ print_engines(struct engines *engines, double t, int lines, int w, int h)return lines; } +static int +print_clients_header (struct clients *clients,int lines, +int con_w,int con_h,int *class_w) +{ +if (output_mode ==INTERACTIVE ) { +const char *pidname =" PID NAME " ; +unsigned int num_active =0 ; +int len =strlen (pidname); + +if (lines++ >= con_h) +return lines; + +printf ("\033[7m" ); +printf ("%s" , pidname); + +if (lines++ >= con_h || len >= con_w) +return lines; + +if (clients->num_classes) { +unsigned int i; +int width; + +for (i =0 ; i < clients->num_classes; i++) { +if (clients->class[i].num_engines) + num_active++; + } + + *class_w = width = (con_w - len) / num_active; + +for (i =0 ; i < clients->num_classes; i++) { +const char *name = clients->class[i].name; +int name_len =strlen (name); +int pad = (width - name_len) /2 ; +int spaces = width - pad - name_len; + +if (!clients->class[i].num_engines) +continue ;/* Assert in the ideal world. */ + +if (pad <0 || spaces <0 ) +continue ; + +n_spaces (pad); +printf ("%s" , name); +n_spaces (spaces); + len += pad + name_len + spaces; + } + } + +n_spaces (con_w - len); +printf ("\033[0m\n" ); + }else { +if (clients->num_classes) + pops->open_struct ("clients" ); + } + +return lines; +} + +static int +print_client (struct client *c,struct engines *engines,double t,int lines, +int con_w,int con_h,unsigned int period_us,int *class_w) +{ +struct clients *clients = c->clients; +unsigned int i; + +if (output_mode ==INTERACTIVE ) { +printf ("%6u %17s " , c->pid, c->name); + +for (i =0 ; i < clients->num_classes; i++) { +double pct; + +if (!clients->class[i].num_engines) +continue ;/* Assert in the ideal world. */ + + pct = (double )c->val[i] / period_us /1e3 *100 / + clients->class[i].num_engines; + +/* +* Guard against possible time-drift between sampling +* client data and time we obtained our time-delta from +* PMU. +*/ +if (pct >100.0 ) + pct =100.0 ; + +print_percentage_bar (pct, *class_w); + + lines++; + } + +putchar ('\n' ); + }else if (output_mode ==JSON ) { +char buf[64 ]; + +snprintf (buf,sizeof (buf),"%u" , c->id); + pops->open_struct (buf); + +__json_add_member ("name" , c->name); + +snprintf (buf,sizeof (buf),"%u" , c->pid); +__json_add_member ("pid" , buf); + + pops->open_struct ("engine-classes" ); + +for (i =0 ; i < clients->num_classes; i++) { +double pct; + +snprintf (buf,sizeof (buf),"%s" , + clients->class[i].name); + pops->open_struct (buf); + + pct = (double )c->val[i] / period_us /1e3 *100 ; +snprintf (buf,sizeof (buf),"%f" , pct); +__json_add_member ("busy" , buf); + +__json_add_member ("unit" ,"%" ); + + pops->close_struct (); + } + + pops->close_struct (); + pops->close_struct (); + } + +return lines; +} + +static int +print_clients_footer (struct clients *clients,double t, +int lines,int con_w,int con_h) +{ +if (output_mode ==INTERACTIVE ) { +if (lines++ < con_h) +printf ("\n" ); + }else { +if (clients->num_classes) + pops->close_struct (); + } + +return lines; +} +static bool stop_top;static void sigint_handler (int sig)
@@ -1492,6 +1979,7 @@ static void process_stdin(unsigned int timeout_us)int main (int argc,char **argv) {unsigned int period_us =DEFAULT_PERIOD_MS *1000 ; +struct clients *clients =NULL ;int con_w =-1 , con_h =-1 ;char *output_path =NULL ;struct engines *engines;
@@ -1625,13 +2113,20 @@ int main(int argc, char **argv) ret =EXIT_SUCCESS ; + clients =init_clients (card.pci_slot_name[0 ] ? card.card :NULL ); +init_engine_classes (engines); + clients->num_classes = engines->num_classes; + clients->class = engines->class; +pmu_sample (engines); +scan_clients (clients); codename =igt_device_get_pretty_name (&card, false);while (!stop_top) {bool consumed = false; -int lines =0 ; +int j, lines =0 ;struct winsize ws; +struct client *c;double t;/* Update terminal size. */
@@ -1650,10 +2145,18 @@ int main(int argc, char **argv)pmu_sample (engines); t = (double )(engines->ts.cur - engines->ts.prev) /1e9 ; +scan_clients (clients); +if (clients) { +qsort (clients->client, clients->num_clients, +sizeof (*clients->client), cmp); + } +if (stop_top)break ;while (!consumed) { + pops->open_struct (NULL ); + lines =print_header (&card, codename, engines, t, lines, con_w, con_h, &consumed);
@@ -1661,6 +2164,36 @@ int main(int argc, char **argv) lines =print_imc (engines, t, lines, con_w, con_h); lines =print_engines (engines, t, lines, con_w, con_h); + +if (clients) { +int class_w; + + lines =print_clients_header (clients, lines, + con_w, con_h, + &class_w); + +for_each_client (clients, c, j) { +if (lines++ > con_h) +break ; + +assert (c->status !=PROBE ); +if (c->status !=ALIVE ) +break ; + +if (c->samples <2 ) +continue ; + + lines =print_client (c, engines, t, + lines, con_w, + con_h, period_us, + &class_w); + } + + lines =print_clients_footer (clients, t, lines, + con_w, con_h); + } + + pops->close_struct (); }if (stop_top)
Signature · 6 lines
2.27.0 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for intel-gpu-top: Support for client stats (rev2)
== Series Details ==
== Series Details ==
Series: intel-gpu-top: Support for client stats (rev2)
URL : https://patchwork.freedesktop.org/series/71182/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9663 -> IGTPW_5415
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_5415 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_5415, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5415/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5415:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@hangcheck:
- fi-byt-j1900: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9663/fi-byt-j1900/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5415/fi-byt-j1900/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in IGTPW_5415 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_flink_basic@flink-lifetime:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9663/fi-tgl-y/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5415/fi-tgl-y/igt@[email protected]
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- fi-snb-2600: NOTRUN -> [SKIP][5] ([fdo#109271]) +30 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5415/fi-snb-2600/igt@[email protected]
* igt@kms_chamelium@hdmi-crc-fast:
- fi-snb-2600: NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111827]) +8 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5415/fi-snb-2600/igt@[email protected]
* igt@runner@aborted:
- fi-bdw-5557u: NOTRUN -> [FAIL][7] ([i915#1602] / [i915#2029] / [i915#2369])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5415/fi-bdw-5557u/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-snb-2600: [DMESG-WARN][8] ([i915#2772]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9663/fi-snb-2600/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5415/fi-snb-2600/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- {fi-tgl-dsi}: [DMESG-FAIL][10] ([i915#2601]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9663/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5415/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [FAIL][12] ([i915#1161] / [i915#262]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9663/fi-kbl-7500u/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5415/fi-kbl-7500u/igt@[email protected]
* igt@prime_self_import@basic-with_two_bos:
- fi-tgl-y: [DMESG-WARN][14] ([i915#402]) -> [PASS][15] +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9663/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5415/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1161]: https://gitlab.freedesktop.org/drm/intel/issues/1161
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2601]: https://gitlab.freedesktop.org/drm/intel/issues/2601
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#2772]: https://gitlab.freedesktop.org/drm/intel/issues/2772
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (41 -> 36)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-dg1-1 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5962 -> IGTPW_5415
CI-20190529: 20190529
CI_DRM_9663: 36cc146429e2863ce99c4bb32d69d8c644859a39 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5415: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5415/index.html
IGT_5962: 22e3daaed82ab7890018a2f2aabf5082cd536023 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5415/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoting Tvrtko Ursulin (2021-01-21 18:10:05)
Quoted 8 lines
tools/intel_gpu_top.c +8
-0+static struct clients *init_clients (const char *drm_card) +{ +struct clients *clients =malloc (sizeof (*clients)); +const char *slash; +ssize_t ret; + +memset (clients,0 ,sizeof (*clients)); +
tools/intel_gpu_top.c static void pmu_sample(struct engines *engines) · line 683
Quoted 10 lines
tools/intel_gpu_top.c +10
-0+if (drm_card) { + slash =rindex (drm_card,'/' ); +assert (slash); + }else { + slash ="card0" ; + } + + ret =snprintf (clients->sysfs_root,sizeof (clients->sysfs_root), +"/sys/class/drm/%s/clients/" , slash); +assert (ret >0 && ret <sizeof (clients->sysfs_root));
Afaict, igt_device_card_match_pci et al are not guaranteed to fill in dev->drm_card and may leave it blank instead of finding the corresponding /dev/dri/cardN.
Quoted 4 lines
tools/intel_gpu_top.c +4
-0+ +return clients; +} +
tools/intel_gpu_top.c static void pmu_sample(struct engines *engines) · line 765
Quoted 10 lines
tools/intel_gpu_top.c +10
-0+static struct client * +find_client (struct clients *clients,enum client_status status,unsigned int id) +{ +struct client *c; +int tmp; + +for_each_client (clients, c, tmp) { +if ((status ==FREE && c->status ==FREE ) || + (status == c->status && c->id == id)) +return c;
if (status != c->status)
continue;
if (status == FREE || c->id == id)
return c;
Quoted 5 lines
tools/intel_gpu_top.c +5
-0+ } + +return NULL ; +} +
tools/intel_gpu_top.c static void pmu_sample(struct engines *engines) · line 780
Quoted 10 lines
tools/intel_gpu_top.c +10
-0+static void update_client (struct client *c,unsigned int pid,char *name) +{ +uint64_t val[c->clients->num_classes]; +unsigned int i; + +if (c->pid != pid) + c->pid = pid; + +if (strcmp (c->name, name)) +strncpy (c->name, name,sizeof (c->name) -1 );
That answers my question about what happens to clients that change their name after new contexts are created.
You don't trust that (pid, name) are tied together? Right, either may change during the read of the pair.
Quoted 29 lines
tools/intel_gpu_top.c +29
-0+ +for (i =0 ; i < c->clients->num_classes; i++) + val[i] =read_client_busy (c, c->clients->class[i].class); + + c->total =0 ; + +for (i =0 ; i < c->clients->num_classes; i++) { +if (val[i] < c->last[i]) +continue ;/* It will catch up soon. */ + + c->val[i] = val[i] - c->last[i]; + c->total += c->val[i]; + c->last[i] = val[i]; + } + + c->samples++; + c->status =ALIVE ; +} + +static void +add_client (struct clients *clients,unsigned int id,unsigned int pid, +char *name,int sysfs_root) +{ +struct client *c; + +if (find_client (clients,ALIVE , id)) +return ; + + c =find_client (clients,FREE ,0 );
tools/intel_gpu_top.c static void pmu_sample(struct engines *engines) · line 819
Quoted 10 lines
tools/intel_gpu_top.c +10
-0+if (!c) { +unsigned int idx = clients->num_clients; + + clients->num_clients += (clients->num_clients +2 ) /2 ; + clients->client =realloc (clients->client, + clients->num_clients *sizeof (*c)); +assert (clients->client); + + c = &clients->client[idx]; +memset (c,0 , (clients->num_clients - idx) *sizeof (*c));
Hence must be FREE==zero. And for_each_client() walks an [] not list.
Quoted 9 lines
tools/intel_gpu_top.c +9
-0+ } + + c->sysfs_root = sysfs_root; + c->id = id; + c->clients = clients; + c->val =calloc (clients->num_classes,sizeof (c->val)); + c->last =calloc (clients->num_classes,sizeof (c->last)); +assert (c->val && c->last); +
tools/intel_gpu_top.c static void pmu_sample(struct engines *engines) · line 838
Quoted 10 lines
tools/intel_gpu_top.c +10
-0+update_client (c, pid, name); +} + +static void free_client (struct client *c) +{ +if (c->sysfs_root >=0 ) +close (c->sysfs_root); +free (c->val); +free (c->last); +memset (c,0 ,sizeof (*c));
Worth compacting the array?
I expect the array will trend to become quite sparse rather than auto-defragment.
Quoted 90 lines
tools/intel_gpu_top.c +90
-0+} + +static int +read_client_sysfs (char *buf,int bufsize,const char *sysfs_root, +unsigned int id,const char *field,int *client_root) +{ +ssize_t ret; + +if (*client_root <0 ) { +char namebuf[256 ]; + + ret =snprintf (namebuf,sizeof (namebuf),"%s/%u" , + sysfs_root, id); +assert (ret >0 && ret <sizeof (namebuf)); +if (ret <=0 || ret ==sizeof (namebuf)) +return -1 ; + + *client_root =open (namebuf,O_RDONLY |O_DIRECTORY ); + } + +if (*client_root <0 ) +return -1 ; + +return __read_client_field (*client_root, field, buf, bufsize); +} + +static void scan_clients (struct clients *clients) +{ +struct dirent *dent; +struct client *c; +unsigned int id; +int tmp; +DIR *d; + +if (!clients) +return ; + +for_each_client (clients, c, tmp) { +if (c->status ==ALIVE ) + c->status =PROBE ; + } + + d =opendir (clients->sysfs_root); +if (!d) +return ; + +while ((dent =readdir (d)) !=NULL ) { +char name[256 ], pid[256 ]; +int ret, root =-1 , *pr; + +if (dent->d_type !=DT_DIR ) +continue ; +if (!isdigit (dent->d_name[0 ])) +continue ; + + id =atoi (dent->d_name); + + c =find_client (clients,PROBE , id); + +if (c) + pr = &c->sysfs_root; +else + pr = &root; + + ret =read_client_sysfs (name,sizeof (name), clients->sysfs_root, + id,"name" , pr); + ret |=read_client_sysfs (pid,sizeof (pid), clients->sysfs_root, + id,"pid" , pr); +if (!ret) { +if (!c) +add_client (clients, id,atoi (pid), name, root); +else +update_client (c,atoi (pid), name); + }else if (c) { + c->status =PROBE ;/* Will be deleted below. */ + } + } + +closedir (d); + +for_each_client (clients, c, tmp) { +if (c->status ==PROBE ) +free_client (c); + } +} + +static int cmp (const void *_a,const void *_b) +{ +const struct client *a = _a; +const struct client *b = _b;
tools/intel_gpu_top.c static void pmu_sample(struct engines *engines) · line 938
Quoted 10 lines
tools/intel_gpu_top.c +10
-0+long tot_a = a->total; +long tot_b = b->total; + + tot_a *= a->status ==ALIVE && a->samples >1 ; + tot_b *= b->status ==ALIVE && b->samples >1 ; + + tot_b -= tot_a; + +if (!tot_b) +return (int )b->id - a->id;
If both active and identical runtimes, sort in ascending id, which is the client/<id> (chronological order of creation)
return (int)(b->id - a->id);
tools/intel_gpu_top.c static void pmu_sample(struct engines *engines) · line 941
Quoted 3 lines
tools/intel_gpu_top.c +3
-0+ +while (tot_b >INT_MAX || tot_b <INT_MIN ) + tot_b /=2 ;
This is just
if (tot_b > 0) return 1; if (tot_b < 0) return -1; return 0;
Right? Sort in order of runtimes, if active. If inactive, age of creation.
Quoted 137 lines
tools/intel_gpu_top.c +74
-10+ +return tot_b; +} +static const char *bars[] = {" " ,"▏" ,"▎" ,"▍" ,"▌" ,"▋" ,"▊" ,"▉" ,"█" }; +static void n_spaces (const unsigned int n) +{ +unsigned int i; + +for (i =0 ; i < n; i++) +putchar (' ' ); +} +static void print_percentage_bar (double percent,int max_len) { -int bar_len = percent * (8 * (max_len -2 )) /100.0 ; -int i; +int bar_len, i, len = max_len -2 ; +const int w =8 ; + +assert (max_len >0 ); + + bar_len = percent * len /100.0 ; +if (bar_len > len) + bar_len = len; + bar_len *= w;putchar ('|' ); -for (i = bar_len; i >=8 ; i -=8 ) -printf ("%s" , bars[8 ]); +for (i = bar_len; i >= w; i -= w) +printf ("%s" , bars[w]);if (i)printf ("%s" , bars[i]); -for (i =0 ; i < (max_len -2 - (bar_len +7 ) /8 ); i++) -putchar (' ' ); + len -= (bar_len + (w -1 )) / w; +n_spaces (len);putchar ('|' ); }@@ -744,6 +1077,18 @@ json_close_struct(void)fflush (stdout); } +static void +__json_add_member (const char *key,const char *val) +{ +assert (json_indent_level <ARRAY_SIZE (json_indent)); + +fprintf (out,"%s%s\"%s\": \"%s\"" , + json_struct_members ?",\n" :"" , + json_indent[json_indent_level], key, val); + + json_struct_members++; +} +static unsigned int json_add_member (const struct cnt_group *parent,struct cnt_item *item,unsigned int headers)@@ -1046,8 +1391,6 @@ print_header(const struct igt_device_card *card,memmove (&groups[0 ], &groups[1 ],sizeof (groups) -sizeof (groups[0 ])); - pops->open_struct (NULL ); - *consumed =print_groups (groups);if (output_mode ==INTERACTIVE ) {@@ -1204,7 +1547,7 @@ print_engine(struct engines *engines, unsigned int i, double t, engine->display_name, engine_items[0].buf); val =pmu_calc (&engine->busy.val,1e9 , t,100 ); -print_percentage_bar (val, max_w - len); +print_percentage_bar (val, max_w > len ? max_w - len :0 );printf ("%s\n" , buf);@@ -1219,7 +1562,6 @@ print_engines_footer(struct engines *engines, double t, int lines, int con_w, int con_h) { pops->close_struct(); - pops->close_struct ();if (output_mode ==INTERACTIVE ) {if (lines++ < con_h)@@ -1243,6 +1585,9 @@ static void init_engine_classes(struct engines *engines)unsigned int i, num;int max =-1 ; +if (engines->num_classes) +return ; +for (i =0 ; i < engines->num_engines; i++) {struct engine *engine =engine_ptr (engines, i);@@ -1404,6 +1749,148 @@ print_engines(struct engines *engines, double t, int lines, int w, int h)return lines; } +static int +print_clients_header (struct clients *clients,int lines, +int con_w,int con_h,int *class_w) +{ +if (output_mode ==INTERACTIVE ) { +const char *pidname =" PID NAME " ; +unsigned int num_active =0 ; +int len =strlen (pidname); + +if (lines++ >= con_h) +return lines; + +printf ("\033[7m" ); +printf ("%s" , pidname); + +if (lines++ >= con_h || len >= con_w) +return lines; + +if (clients->num_classes) { +unsigned int i; +int width; + +for (i =0 ; i < clients->num_classes; i++) { +if (clients->class[i].num_engines) + num_active++; + } + + *class_w = width = (con_w - len) / num_active; + +for (i =0 ; i < clients->num_classes; i++) { +const char *name = clients->class[i].name; +int name_len =strlen (name); +int pad = (width - name_len) /2 ;
tools/intel_gpu_top.c print_engines(struct engines *engines, double t, int lines, int w, int h) · line 1794
Quoted 10 lines
tools/intel_gpu_top.c +10
-0+int spaces = width - pad - name_len; + +if (!clients->class[i].num_engines) +continue ;/* Assert in the ideal world. */ + +if (pad <0 || spaces <0 ) +continue ; + +n_spaces (pad); +printf ("%s" , name);
Should we sanitize the names and remove ansi control codes or only show printable char?
Quoted 195 lines
tools/intel_gpu_top.c +146
-1+n_spaces (spaces); + len += pad + name_len + spaces; + } + } + +n_spaces (con_w - len); +printf ("\033[0m\n" ); + }else { +if (clients->num_classes) + pops->open_struct ("clients" ); + } + +return lines; +} + +static int +print_client (struct client *c,struct engines *engines,double t,int lines, +int con_w,int con_h,unsigned int period_us,int *class_w) +{ +struct clients *clients = c->clients; +unsigned int i; + +if (output_mode ==INTERACTIVE ) { +printf ("%6u %17s " , c->pid, c->name); + +for (i =0 ; i < clients->num_classes; i++) { +double pct; + +if (!clients->class[i].num_engines) +continue ;/* Assert in the ideal world. */ + + pct = (double )c->val[i] / period_us /1e3 *100 / + clients->class[i].num_engines; + +/* +* Guard against possible time-drift between sampling +* client data and time we obtained our time-delta from +* PMU. +*/ +if (pct >100.0 ) + pct =100.0 ; + +print_percentage_bar (pct, *class_w); + + lines++; + } + +putchar ('\n' ); + }else if (output_mode ==JSON ) { +char buf[64 ]; + +snprintf (buf,sizeof (buf),"%u" , c->id); + pops->open_struct (buf); + +__json_add_member ("name" , c->name); + +snprintf (buf,sizeof (buf),"%u" , c->pid); +__json_add_member ("pid" , buf); + + pops->open_struct ("engine-classes" ); + +for (i =0 ; i < clients->num_classes; i++) { +double pct; + +snprintf (buf,sizeof (buf),"%s" , + clients->class[i].name); + pops->open_struct (buf); + + pct = (double )c->val[i] / period_us /1e3 *100 ; +snprintf (buf,sizeof (buf),"%f" , pct); +__json_add_member ("busy" , buf); + +__json_add_member ("unit" ,"%" ); + + pops->close_struct (); + } + + pops->close_struct (); + pops->close_struct (); + } + +return lines; +} + +static int +print_clients_footer (struct clients *clients,double t, +int lines,int con_w,int con_h) +{ +if (output_mode ==INTERACTIVE ) { +if (lines++ < con_h) +printf ("\n" ); + }else { +if (clients->num_classes) + pops->close_struct (); + } + +return lines; +} +static bool stop_top;static void sigint_handler (int sig)@@ -1492,6 +1979,7 @@ static void process_stdin(unsigned int timeout_us)int main (int argc,char **argv) {unsigned int period_us =DEFAULT_PERIOD_MS *1000 ; +struct clients *clients =NULL ;int con_w =-1 , con_h =-1 ;char *output_path =NULL ;struct engines *engines;@@ -1625,13 +2113,20 @@ int main(int argc, char **argv) ret =EXIT_SUCCESS ; + clients =init_clients (card.pci_slot_name[0 ] ? card.card :NULL ); +init_engine_classes (engines); + clients->num_classes = engines->num_classes; + clients->class = engines->class; +pmu_sample (engines); +scan_clients (clients); codename =igt_device_get_pretty_name (&card, false);while (!stop_top) {bool consumed = false; -int lines =0 ; +int j, lines =0 ;struct winsize ws; +struct client *c;double t;/* Update terminal size. */ @@ -1650,10 +2145,18 @@ int main(int argc, char **argv)pmu_sample (engines); t = (double )(engines->ts.cur - engines->ts.prev) /1e9 ; +scan_clients (clients); +if (clients) { +qsort (clients->client, clients->num_clients, +sizeof (*clients->client), cmp); + } +if (stop_top)break ;while (!consumed) { + pops->open_struct (NULL ); + lines =print_header (&card, codename, engines, t, lines, con_w, con_h, &consumed);@@ -1661,6 +2164,36 @@ int main(int argc, char **argv) lines =print_imc (engines, t, lines, con_w, con_h); lines =print_engines (engines, t, lines, con_w, con_h); + +if (clients) { +int class_w; + + lines =print_clients_header (clients, lines, + con_w, con_h, + &class_w); + +for_each_client (clients, c, j) { +if (lines++ > con_h) +break ; + +assert (c->status !=PROBE ); +if (c->status !=ALIVE ) +break ; + +if (c->samples <2 ) +continue ; + + lines =print_client (c, engines, t, + lines, con_w, + con_h, period_us, + &class_w); + } + + lines =print_clients_footer (clients, t, lines, + con_w, con_h); + } + + pops->close_struct (); }if (stop_top)Signature · 6 lines
2.27.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 15 lines · Chris Wilson
Quoting Tvrtko Ursulin (2021-01-21 18:10:05)
Quoted 14 lines
tools/intel_gpu_top.c +14
-0+static struct clients *init_clients (const char *drm_card) +{ +struct clients *clients =malloc (sizeof (*clients)); +const char *slash; +ssize_t ret; + +memset (clients,0 ,sizeof (*clients)); + +if (drm_card) { + slash =rindex (drm_card,'/' ); +assert (slash); + }else { + slash ="card0" ; + }
Quoted 8 lines
tools/intel_gpu_top.c static void pmu_sample(struct engines *engines) · line 683
Quoted 4 lines
tools/intel_gpu_top.c +4
-0+ + ret =snprintf (clients->sysfs_root,sizeof (clients->sysfs_root), +"/sys/class/drm/%s/clients/" , slash); +assert (ret >0 && ret <sizeof (clients->sysfs_root));Afaict,
igt_device_card_match_pciet al are not guaranteed to fill indev->drm_cardand may leave it blank instead of finding the corresponding/dev/dri/cardN.
I did the rest but this is giving me trouble - can't see locally that it doesn't populate it. Do you know how to trigger that?
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoting Tvrtko Ursulin (2021-01-22 11:36:48)
Quoted 26 lines · Chris Wilson
Quoted 15 lines
Quoting Tvrtko Ursulin (2021-01-21 18:10:05)
Quoted 14 lines
tools/intel_gpu_top.c +14
-0+static struct clients *init_clients (const char *drm_card) +{ +struct clients *clients =malloc (sizeof (*clients)); +const char *slash; +ssize_t ret; + +memset (clients,0 ,sizeof (*clients)); + +if (drm_card) { + slash =rindex (drm_card,'/' ); +assert (slash); + }else { + slash ="card0" ; + }Quoted 8 lines
tools/intel_gpu_top.c static void pmu_sample(struct engines *engines) · line 683
Quoted 4 lines
tools/intel_gpu_top.c +4
-0+ + ret =snprintf (clients->sysfs_root,sizeof (clients->sysfs_root), +"/sys/class/drm/%s/clients/" , slash); +assert (ret >0 && ret <sizeof (clients->sysfs_root));Afaict,
igt_device_card_match_pciet al are not guaranteed to fill indev->drm_cardand may leave it blank instead of finding the corresponding/dev/dri/cardN.
Quoted 2 lines
I did the rest but this is giving me trouble - can't see locally that it doesn't populate it. Do you know how to trigger that?
Maybe it doesn't, I was just looking at the udev population of the card struct and surmised that if I could tell it to open a render device, dev->drm_card will not be found.
This is all speculation on my part, I've just been burnt enough times trying to set engine properties on the render sysfs :( -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
PATCH v6 1/1 intel-gpu-top: Support for client stats
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Adds support for per-client engine busyness stats i915 exports in sysfs and produces output like the below:
===============================================================================
intel-gpu-top: Intel Skylake (Gen9) @ /dev/dri/card0 - 951/ 950 MHz;
0% RC6; 14.60/23.62 W; 1482 irqs/s
IMC reads: 1287 MiB/s
IMC writes: 115 MiB/s
ENGINES BUSY MI_SEMA MI_WAIT
Render/3D 95.48% |█████████████████████████████████ | 5% 0%
Blitter 15.98% |█████ | 10% 0%
Video 35.40% |████████████ | 26% 0%
VideoEnhance 0.00% | | 0% 0%
PID NAME Render/3D Blitter Video VideoEnhance
1053 gem_wsim |███ || ||███ || | 1054 gem_wsim |███████ ||█ || || |
===============================================================================
Apart from the existing physical engine utilization it now also shows utilization per client and per engine class.
v2:
* Version to match removal of global enable_stats toggle.
* Plus various fixes.
v3:
* Support brief backward jumps in client stats.
v4:
* Support device selection.
v5:
* Rebase for class aggregation.
* Optimise sysfs reads a tiny bit by openat(2) and caching client root.
v6:
* Show clients as soon as detected, just delay busyness data one period.
* Add option to show numeric busyness.
* Further optimize sysfs reads.
* Trim overgrown array. (Chris)
* Simplify client sort callback and find client loop. (Chris)
* Zap non-printable chars when displaying client names. (Chris)
--- tools/intel_gpu_top.c | 640 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 625 insertions(+), 15 deletions(-)
tools/intel_gpu_top.c +625 -15
@@ -1,5 +1,5 @@/* -* Copyright © 2007-2019 Intel Corporation +* Copyright © 2007-2021 Intel Corporation * * Permission is hereby granted, free of charge, to any person obtaining a * copy of this software and associated documentation files (the "Software"),
@@ -46,6 +46,8 @@#include "igt_perf.h" +#define ARRAY_SIZE (arr) (sizeof(arr)/sizeof(arr[0])) +struct pmu_pair {uint64_t cur;uint64_t prev;
@@ -625,25 +627,433 @@ static void pmu_sample(struct engines *engines) } } +enum client_status { +FREE =0 ,/* mbz */ +ALIVE , +PROBE +}; + +struct clients ; + +struct client { +struct clients *clients; + +enum client_status status; +int sysfs_root; +int busy_root; +unsigned int id; +unsigned int pid; +char name[24 ]; +char print_name[24 ]; +unsigned int samples; +unsigned long total; +struct engines *engines; +unsigned long *val; +uint64_t *last; +}; + +struct clients { +unsigned int num_clients; + +unsigned int num_classes; +struct engine_class *class; + +char sysfs_root[128 ]; + +struct client *client; +}; + +#define for_each_client (clients, c, tmp) \ + for ((tmp) = (clients)->num_clients, c = (clients)->client; \ + (tmp > 0); (tmp)--, (c)++) + +static struct clients *init_clients (const char *drm_card) +{ +struct clients *clients =malloc (sizeof (*clients)); +const char *slash; +ssize_t ret; + +memset (clients,0 ,sizeof (*clients)); + +if (drm_card) { + slash =rindex (drm_card,'/' ); +assert (slash); + }else { + slash ="card0" ; + } + + ret =snprintf (clients->sysfs_root,sizeof (clients->sysfs_root), +"/sys/class/drm/%s/clients/" , slash); +assert (ret >0 && ret <sizeof (clients->sysfs_root)); + +return clients; +} + +static int __read_to_buf (int fd,char *buf,unsigned int bufsize) +{ +ssize_t ret; +int err; + + ret =read (fd, buf, bufsize -1 ); + err = errno; +if (ret <1 ) { + errno = ret <0 ? err :ENOMSG ; + +return -1 ; + } + +if (ret >1 && buf[ret -1 ] =='\n' ) + buf[ret -1 ] ='\0' ; +else + buf[ret] ='\0' ; + +return 0 ; +} + +static int +__read_client_field (int root,const char *field,char *buf,unsigned int bufsize) +{ +int fd, ret; + + fd =openat (root, field,O_RDONLY ); +if (fd <0 ) +return -1 ; + + ret =__read_to_buf (fd, buf, bufsize); + +close (fd); + +return ret; +} + +static uint64_t +read_client_busy (struct client *client,unsigned int class) +{ +const char *class_str[] = {"0" ,"1" ,"2" ,"3" ,"4" ,"5" ,"6" ,"7" }; +char buf[256 ], *b; +int ret; + +assert (class <ARRAY_SIZE (class_str)); +if (class >=ARRAY_SIZE (class_str)) +return 0 ; + +assert (client->sysfs_root >=0 ); +if (client->sysfs_root <0 ) +return 0 ; + +if (client->busy_root <0 ) + client->busy_root =openat (client->sysfs_root,"busy" , +O_RDONLY |O_DIRECTORY ); + +assert (client->busy_root); +if (client->busy_root <0 ) +return 0 ; + + ret =__read_client_field (client->busy_root, class_str[class], buf, +sizeof (buf)); +assert (ret ==0 ); +if (ret) +return 0 ; + +/* +* Handle both single integer and key=value formats by skipping +* leading non-digits. +*/ + b = buf; +while (*b && !isdigit (*b)) + b++; + +return strtoull (b,NULL ,10 ); +} + +static struct client * +find_client (struct clients *clients,enum client_status status,unsigned int id) +{ +struct client *c; +int tmp; + +for_each_client (clients, c, tmp) { +if (status != c->status) +continue ; + +if (status ==FREE || c->id == id) +return c; + } + +return NULL ; +} + +static void update_client (struct client *c,unsigned int pid,char *name) +{ +uint64_t val[c->clients->num_classes]; +unsigned int i; + +if (c->pid != pid) + c->pid = pid; + +if (strcmp (c->name, name)) { +char *p; + +strncpy (c->name, name,sizeof (c->name) -1 ); +strncpy (c->print_name, name,sizeof (c->print_name) -1 ); + + p = c->print_name; +while (*p) { +if (!isprint (*p)) + *p ='*' ; + p++; + }; + } + +for (i =0 ; i < c->clients->num_classes; i++) + val[i] =read_client_busy (c, c->clients->class[i].class); + + c->total =0 ; + +for (i =0 ; i < c->clients->num_classes; i++) { +if (val[i] < c->last[i]) +continue ;/* It will catch up soon. */ + + c->val[i] = val[i] - c->last[i]; + c->total += c->val[i]; + c->last[i] = val[i]; + } + + c->samples++; + c->status =ALIVE ; +} + +static void +add_client (struct clients *clients,unsigned int id,unsigned int pid, +char *name,int sysfs_root) +{ +struct client *c; + +if (find_client (clients,ALIVE , id)) +return ; + + c =find_client (clients,FREE ,0 ); +if (!c) { +unsigned int idx = clients->num_clients; + + clients->num_clients += (clients->num_clients +2 ) /2 ; + clients->client =realloc (clients->client, + clients->num_clients *sizeof (*c)); +assert (clients->client); + + c = &clients->client[idx]; +memset (c,0 , (clients->num_clients - idx) *sizeof (*c)); + } + + c->sysfs_root = sysfs_root; + c->busy_root =-1 ; + c->id = id; + c->clients = clients; + c->val =calloc (clients->num_classes,sizeof (c->val)); + c->last =calloc (clients->num_classes,sizeof (c->last)); +assert (c->val && c->last); + +update_client (c, pid, name); +} + +static void free_client (struct client *c) +{ +if (c->sysfs_root >=0 ) +close (c->sysfs_root); +if (c->busy_root >=0 ) +close (c->busy_root); +free (c->val); +free (c->last); +memset (c,0 ,sizeof (*c)); +} + +static int +read_client_sysfs (char *buf,int bufsize,const char *sysfs_root, +unsigned int id,const char *field,int *client_root) +{ +ssize_t ret; + +if (*client_root <0 ) { +char namebuf[256 ]; + + ret =snprintf (namebuf,sizeof (namebuf),"%s/%u" , + sysfs_root, id); +assert (ret >0 && ret <sizeof (namebuf)); +if (ret <=0 || ret ==sizeof (namebuf)) +return -1 ; + + *client_root =open (namebuf,O_RDONLY |O_DIRECTORY ); + } + +if (*client_root <0 ) +return -1 ; + +return __read_client_field (*client_root, field, buf, bufsize); +} + +static void scan_clients (struct clients *clients) +{ +struct dirent *dent; +struct client *c; +unsigned int id; +int tmp; +DIR *d; + +if (!clients) +return ; + +for_each_client (clients, c, tmp) { +if (c->status ==ALIVE ) + c->status =PROBE ; + } + + d =opendir (clients->sysfs_root); +if (!d) +return ; + +while ((dent =readdir (d)) !=NULL ) { +char name[24 ], pid[24 ]; +int ret, root =-1 , *pr; + +if (dent->d_type !=DT_DIR ) +continue ; +if (!isdigit (dent->d_name[0 ])) +continue ; + + id =atoi (dent->d_name); + + c =find_client (clients,PROBE , id); + +if (c) + pr = &c->sysfs_root; +else + pr = &root; + + ret =read_client_sysfs (name,sizeof (name), clients->sysfs_root, + id,"name" , pr); + ret |=read_client_sysfs (pid,sizeof (pid), clients->sysfs_root, + id,"pid" , pr); +if (!ret) { +if (!c) +add_client (clients, id,atoi (pid), name, root); +else +update_client (c,atoi (pid), name); + }else if (c) { + c->status =PROBE ;/* Will be deleted below. */ + } + } + +closedir (d); + +for_each_client (clients, c, tmp) { +if (c->status ==PROBE ) +free_client (c); + } +} + +static int client_cmp (const void *_a,const void *_b) +{ +const struct client *a = _a; +const struct client *b = _b; +long tot_a, tot_b; + +/* +* Sort clients in descending order of runtime in the previous sampling +* period for active ones, followed by inactive. Tie-breaker is client +* id. +*/ + + tot_a = a->status ==ALIVE ? a->total :-1 ; + tot_b = b->status ==ALIVE ? b->total :-1 ; + + tot_b -= tot_a; +if (!tot_b) +return (int )b->id - a->id; + +if (tot_b >0 ) +return 1 ; +if (tot_b <0 ) +return -1 ; +return 0 ; +} + +static void sort_clients (struct clients *clients) +{ +unsigned int active, free; +struct client *c; +int tmp; + +if (!clients) +return ; + +qsort (clients->client, clients->num_clients,sizeof (*clients->client), + client_cmp); + +/* Trim excessive array space. */ + active =0 ; +for_each_client (clients, c, tmp) { +if (c->status !=ALIVE ) +break ;/* Active clients are first in the array. */ + active++; + } + + free = clients->num_clients - active; +if (free > clients->num_clients /2 ) { + active = clients->num_clients - free /2 ; +if (active != clients->num_clients) { + clients->num_clients = active; + clients->client =realloc (clients->client, + clients->num_clients * +sizeof (*c)); + } + } +} + +static const char *bars[] = {" " ,"▏" ,"▎" ,"▍" ,"▌" ,"▋" ,"▊" ,"▉" ,"█" }; +static void n_spaces (const unsigned int n) +{ +unsigned int i; + +for (i =0 ; i < n; i++) +putchar (' ' ); +} +static void -print_percentage_bar (double percent,int max_len) +print_percentage_bar (double percent,int max_len,bool numeric) { -int bar_len = percent * (8 * (max_len -2 )) /100.0 ; -int i; +int bar_len, i, len = max_len -2 ; +const int w =8 ; + +assert (max_len >0 ); + + bar_len = percent * len /100.0 ; +if (bar_len > len) + bar_len = len; + bar_len *= w;putchar ('|' ); -for (i = bar_len; i >=8 ; i -=8 ) -printf ("%s" , bars[8 ]); +for (i = bar_len; i >= w; i -= w) +printf ("%s" , bars[w]);if (i)printf ("%s" , bars[i]); -for (i =0 ; i < (max_len -2 - (bar_len +7 ) /8 ); i++) -putchar (' ' ); + len -= (bar_len + (w -1 )) / w; +n_spaces (len);putchar ('|' ); + +if (numeric) { +/* +* TODO: Finer grained reverse control to better preserve +* bar under numerical percentage. +*/ +printf ("\033[%uD\033[7m" , max_len -1 ); + i =printf ("%3.f%%" , percent); +printf ("\033[%uC\033[0m" , max_len - i -1 ); + } }#define DEFAULT_PERIOD_MS (1000)
@@ -705,8 +1115,6 @@ static const char *json_indent[] = { "\t\t\t\t\t", }; -#define ARRAY_SIZE (arr) (sizeof(arr)/sizeof(arr[0])) -static unsigned int json_prev_struct_members;static unsigned int json_struct_members;
@@ -744,6 +1152,18 @@ json_close_struct(void)fflush (stdout); } +static void +__json_add_member (const char *key,const char *val) +{ +assert (json_indent_level <ARRAY_SIZE (json_indent)); + +fprintf (out,"%s%s\"%s\": \"%s\"" , + json_struct_members ?",\n" :"" , + json_indent[json_indent_level], key, val); + + json_struct_members++; +} +static unsigned int json_add_member (const struct cnt_group *parent,struct cnt_item *item,unsigned int headers)
@@ -1046,8 +1466,6 @@ print_header(const struct igt_device_card *card,memmove (&groups[0 ], &groups[1 ],sizeof (groups) -sizeof (groups[0 ])); - pops->open_struct (NULL ); - *consumed =print_groups (groups);if (output_mode ==INTERACTIVE ) {
@@ -1204,7 +1622,7 @@ print_engine(struct engines *engines, unsigned int i, double t, engine->display_name, engine_items[0].buf); val =pmu_calc (&engine->busy.val,1e9 , t,100 ); -print_percentage_bar (val, max_w - len); +print_percentage_bar (val, max_w > len ? max_w - len :0 , false);printf ("%s\n" , buf);
@@ -1219,7 +1637,6 @@ print_engines_footer(struct engines *engines, double t, int lines, int con_w, int con_h) { pops->close_struct(); - pops->close_struct ();if (output_mode ==INTERACTIVE ) {if (lines++ < con_h)
@@ -1243,6 +1660,9 @@ static void init_engine_classes(struct engines *engines)unsigned int i, num;int max =-1 ; +if (engines->num_classes) +return ; +for (i =0 ; i < engines->num_engines; i++) {struct engine *engine =engine_ptr (engines, i);
@@ -1404,6 +1824,153 @@ print_engines(struct engines *engines, double t, int lines, int w, int h)return lines; } +static int +print_clients_header (struct clients *clients,int lines, +int con_w,int con_h,int *class_w) +{ +if (output_mode ==INTERACTIVE ) { +const char *pidname =" PID NAME " ; +unsigned int num_active =0 ; +int len =strlen (pidname); + +if (lines++ >= con_h) +return lines; + +printf ("\033[7m" ); +printf ("%s" , pidname); + +if (lines++ >= con_h || len >= con_w) +return lines; + +if (clients->num_classes) { +unsigned int i; +int width; + +for (i =0 ; i < clients->num_classes; i++) { +if (clients->class[i].num_engines) + num_active++; + } + + *class_w = width = (con_w - len) / num_active; + +for (i =0 ; i < clients->num_classes; i++) { +const char *name = clients->class[i].name; +int name_len =strlen (name); +int pad = (width - name_len) /2 ; +int spaces = width - pad - name_len; + +if (!clients->class[i].num_engines) +continue ;/* Assert in the ideal world. */ + +if (pad <0 || spaces <0 ) +continue ; + +n_spaces (pad); +printf ("%s" , name); +n_spaces (spaces); + len += pad + name_len + spaces; + } + } + +n_spaces (con_w - len); +printf ("\033[0m\n" ); + }else { +if (clients->num_classes) + pops->open_struct ("clients" ); + } + +return lines; +} + +static bool numeric_clients; + +static int +print_client (struct client *c,struct engines *engines,double t,int lines, +int con_w,int con_h,unsigned int period_us,int *class_w) +{ +struct clients *clients = c->clients; +unsigned int i; + +if (output_mode ==INTERACTIVE ) { +printf ("%6u %17s " , c->pid, c->print_name); + +for (i =0 ; c->samples >1 && i < clients->num_classes; i++) { +double pct; + +if (!clients->class[i].num_engines) +continue ;/* Assert in the ideal world. */ + + pct = (double )c->val[i] / period_us /1e3 *100 / + clients->class[i].num_engines; + +/* +* Guard against possible time-drift between sampling +* client data and time we obtained our time-delta from +* PMU. +*/ +if (pct >100.0 ) + pct =100.0 ; + +print_percentage_bar (pct, *class_w, numeric_clients); + + lines++; + } + +putchar ('\n' ); + }else if (output_mode ==JSON ) { +char buf[64 ]; + +snprintf (buf,sizeof (buf),"%u" , c->id); + pops->open_struct (buf); + +__json_add_member ("name" , c->print_name); + +snprintf (buf,sizeof (buf),"%u" , c->pid); +__json_add_member ("pid" , buf); + +if (c->samples >1 ) { + pops->open_struct ("engine-classes" ); + +for (i =0 ; i < clients->num_classes; i++) { +double pct; + +snprintf (buf,sizeof (buf),"%s" , + clients->class[i].name); + pops->open_struct (buf); + + pct = (double )c->val[i] / period_us /1e3 *100 ; +snprintf (buf,sizeof (buf),"%f" , pct); +__json_add_member ("busy" , buf); + +__json_add_member ("unit" ,"%" ); + + pops->close_struct (); + } + + pops->close_struct (); + } + + pops->close_struct (); + } + +return lines; +} + +static int +print_clients_footer (struct clients *clients,double t, +int lines,int con_w,int con_h) +{ +if (output_mode ==INTERACTIVE ) { +if (lines++ < con_h) +printf ("\n" ); + }else { +if (clients->num_classes) + pops->close_struct (); + } + +return lines; +} +static bool stop_top;static void sigint_handler (int sig)
@@ -1485,6 +2052,9 @@ static void process_stdin(unsigned int timeout_us)case '1' : class_view ^= true;break ; +case 'n' : + numeric_clients ^= true; +break ; }; } }
@@ -1492,6 +2062,7 @@ static void process_stdin(unsigned int timeout_us)int main (int argc,char **argv) {unsigned int period_us =DEFAULT_PERIOD_MS *1000 ; +struct clients *clients =NULL ;int con_w =-1 , con_h =-1 ;char *output_path =NULL ;struct engines *engines;
@@ -1625,13 +2196,20 @@ int main(int argc, char **argv) ret =EXIT_SUCCESS ; + clients =init_clients (card.pci_slot_name[0 ] ? card.card :NULL ); +init_engine_classes (engines); + clients->num_classes = engines->num_classes; + clients->class = engines->class; +pmu_sample (engines); +scan_clients (clients); codename =igt_device_get_pretty_name (&card, false);while (!stop_top) {bool consumed = false; -int lines =0 ; +int j, lines =0 ;struct winsize ws; +struct client *c;double t;/* Update terminal size. */
@@ -1650,10 +2228,15 @@ int main(int argc, char **argv)pmu_sample (engines); t = (double )(engines->ts.cur - engines->ts.prev) /1e9 ; +scan_clients (clients); +sort_clients (clients); +if (stop_top)break ;while (!consumed) { + pops->open_struct (NULL ); + lines =print_header (&card, codename, engines, t, lines, con_w, con_h, &consumed);
@@ -1661,6 +2244,33 @@ int main(int argc, char **argv) lines =print_imc (engines, t, lines, con_w, con_h); lines =print_engines (engines, t, lines, con_w, con_h); + +if (clients) { +int class_w; + + lines =print_clients_header (clients, lines, + con_w, con_h, + &class_w); + +for_each_client (clients, c, j) { +assert (c->status !=PROBE ); +if (c->status !=ALIVE ) +break ;/* Active clients are first in the array. */ + +if (lines++ > con_h) +break ; + + lines =print_client (c, engines, t, + lines, con_w, + con_h, period_us, + &class_w); + } + + lines =print_clients_footer (clients, t, lines, + con_w, con_h); + } + + pops->close_struct (); }if (stop_top)
Signature · 6 lines
2.27.0 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoting Tvrtko Ursulin (2021-01-22 11:55:24)
Quoted 14 lines
tools/intel_gpu_top.c +14
-0+static int client_cmp (const void *_a,const void *_b) +{ +const struct client *a = _a; +const struct client *b = _b; +long tot_a, tot_b; + +/* +* Sort clients in descending order of runtime in the previous sampling +* period for active ones, followed by inactive. Tie-breaker is client +* id. +*/ + + tot_a = a->status ==ALIVE ? a->total :-1 ; + tot_b = b->status ==ALIVE ? b->total :-1 ;
tools/intel_gpu_top.c static void pmu_sample(struct engines *engines) · line 977
Quoted 10 lines
tools/intel_gpu_top.c +10
-0+ + tot_b -= tot_a; +if (!tot_b) +return (int )b->id - a->id; + +if (tot_b >0 ) +return 1 ; +if (tot_b <0 ) +return -1 ; +return 0 ;
Nit, this is clearly now
if (tot_b > 0)
return 1;
if (tot_b < 0)
return -1;
return (int)b->id - a->id;And the decision flow now neatly matches the comment. -Chris
_______________________________________________
igt-dev mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 28 lines · Chris Wilson
Quoting Tvrtko Ursulin (2021-01-22 11:55:24)
Quoted 14 lines
tools/intel_gpu_top.c +14
-0+static int client_cmp (const void *_a,const void *_b) +{ +const struct client *a = _a; +const struct client *b = _b; +long tot_a, tot_b; + +/* +* Sort clients in descending order of runtime in the previous sampling +* period for active ones, followed by inactive. Tie-breaker is client +* id. +*/ + + tot_a = a->status ==ALIVE ? a->total :-1 ; + tot_b = b->status ==ALIVE ? b->total :-1 ;tools/intel_gpu_top.c static void pmu_sample(struct engines *engines) · line 977
Quoted 10 lines
tools/intel_gpu_top.c +10
-0+ + tot_b -= tot_a; +if (!tot_b) +return (int )b->id - a->id; + +if (tot_b >0 ) +return 1 ; +if (tot_b <0 ) +return -1 ; +return 0 ;Nit, this is clearly now
Quoted 8 lines
if (tot_b > 0) return 1; if (tot_b < 0) return -1; return (int)b->id - a->id;And the decision flow now neatly matches the comment.
Fair enough, I forgot some other bits I wanted to do anyway. :)
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoting Tvrtko Ursulin (2021-01-22 11:55:24)
Quoted 10 lines
tools/intel_gpu_top.c +10
-0+static void update_client (struct client *c,unsigned int pid,char *name) +{ +uint64_t val[c->clients->num_classes]; +unsigned int i; + +if (c->pid != pid) + c->pid = pid; + +if (strcmp (c->name, name)) { +char *p;
tools/intel_gpu_top.c static void pmu_sample(struct engines *engines) · line 805
Quoted 10 lines
tools/intel_gpu_top.c +10
-0+ +strncpy (c->name, name,sizeof (c->name) -1 ); +strncpy (c->print_name, name,sizeof (c->print_name) -1 ); + + p = c->print_name; +while (*p) { +if (!isprint (*p)) + *p ='*' ; + p++; + };
Stray ';'
Probably worth adding a TODO for utf8 validation. But for now this stops the terminal from being screwed with.
Nothing else jumped out at me so,
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
PATCH v7 1/1 intel-gpu-top: Support for client stats
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Adds support for per-client engine busyness stats i915 exports in sysfs and produces output like the below:
===============================================================================
intel-gpu-top: Intel Skylake (Gen9) @ /dev/dri/card0 - 951/ 950 MHz;
0% RC6; 14.60/23.62 W; 1482 irqs/s
IMC reads: 1287 MiB/s
IMC writes: 115 MiB/s
ENGINES BUSY MI_SEMA MI_WAIT
Render/3D 95.48% |█████████████████████████████████ | 5% 0%
Blitter 15.98% |█████ | 10% 0%
Video 35.40% |████████████ | 26% 0%
VideoEnhance 0.00% | | 0% 0%
PID NAME Render/3D Blitter Video VideoEnhance
1053 gem_wsim |███ || ||███ || | 1054 gem_wsim |███████ ||█ || || |
===============================================================================
Apart from the existing physical engine utilization it now also shows utilization per client and per engine class.
v2:
* Version to match removal of global enable_stats toggle.
* Plus various fixes.
v3:
* Support brief backward jumps in client stats.
v4:
* Support device selection.
v5:
* Rebase for class aggregation.
* Optimise sysfs reads a tiny bit by openat(2) and caching client root.
v6:
* Show clients as soon as detected, just delay busyness data one period.
* Add option to show numeric busyness ('n').
* Further optimize sysfs reads.
* Trim overgrown array. (Chris)
* Simplify client sort callback and find client loop. (Chris)
* Zap non-printable chars when displaying client names. (Chris)
v7:
* Fix terminal height vs lines printed handling.
* Optimise client searches by relying on sorting.
* Added some sorting modes cyclable via 's'.
* Stray semi-colon and furhter sort cleanup. (Chris)
--- tools/intel_gpu_top.c | 708 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 693 insertions(+), 15 deletions(-)
tools/intel_gpu_top.c +693 -15
@@ -1,5 +1,5 @@/* -* Copyright © 2007-2019 Intel Corporation +* Copyright © 2007-2021 Intel Corporation * * Permission is hereby granted, free of charge, to any person obtaining a * copy of this software and associated documentation files (the "Software"),
@@ -46,6 +46,8 @@#include "igt_perf.h" +#define ARRAY_SIZE (arr) (sizeof(arr)/sizeof(arr[0])) +struct pmu_pair {uint64_t cur;uint64_t prev;
@@ -625,25 +627,482 @@ static void pmu_sample(struct engines *engines) } } +enum client_status { +FREE =0 ,/* mbz */ +ALIVE , +PROBE +}; + +struct clients ; + +struct client { +struct clients *clients; + +enum client_status status; +int sysfs_root; +int busy_root; +unsigned int id; +unsigned int pid; +char name[24 ]; +char print_name[24 ]; +unsigned int samples; +unsigned long total_runtime; +unsigned long last_runtime; +struct engines *engines; +unsigned long *val; +uint64_t *last; +}; + +struct clients { +unsigned int num_clients; +unsigned int active_clients; + +unsigned int num_classes; +struct engine_class *class; + +char sysfs_root[128 ]; + +struct client *client; +}; + +#define for_each_client (clients, c, tmp) \ + for ((tmp) = (clients)->num_clients, c = (clients)->client; \ + (tmp > 0); (tmp)--, (c)++) + +static struct clients *init_clients (const char *drm_card) +{ +struct clients *clients =malloc (sizeof (*clients)); +const char *slash; +ssize_t ret; + +memset (clients,0 ,sizeof (*clients)); + +if (drm_card) { + slash =rindex (drm_card,'/' ); +assert (slash); + }else { + slash ="card0" ; + } + + ret =snprintf (clients->sysfs_root,sizeof (clients->sysfs_root), +"/sys/class/drm/%s/clients/" , slash); +assert (ret >0 && ret <sizeof (clients->sysfs_root)); + +return clients; +} + +static int __read_to_buf (int fd,char *buf,unsigned int bufsize) +{ +ssize_t ret; +int err; + + ret =read (fd, buf, bufsize -1 ); + err = errno; +if (ret <1 ) { + errno = ret <0 ? err :ENOMSG ; + +return -1 ; + } + +if (ret >1 && buf[ret -1 ] =='\n' ) + buf[ret -1 ] ='\0' ; +else + buf[ret] ='\0' ; + +return 0 ; +} + +static int +__read_client_field (int root,const char *field,char *buf,unsigned int bufsize) +{ +int fd, ret; + + fd =openat (root, field,O_RDONLY ); +if (fd <0 ) +return -1 ; + + ret =__read_to_buf (fd, buf, bufsize); + +close (fd); + +return ret; +} + +static uint64_t +read_client_busy (struct client *client,unsigned int class) +{ +const char *class_str[] = {"0" ,"1" ,"2" ,"3" ,"4" ,"5" ,"6" ,"7" }; +char buf[256 ], *b; +int ret; + +assert (class <ARRAY_SIZE (class_str)); +if (class >=ARRAY_SIZE (class_str)) +return 0 ; + +assert (client->sysfs_root >=0 ); +if (client->sysfs_root <0 ) +return 0 ; + +if (client->busy_root <0 ) + client->busy_root =openat (client->sysfs_root,"busy" , +O_RDONLY |O_DIRECTORY ); + +assert (client->busy_root); +if (client->busy_root <0 ) +return 0 ; + + ret =__read_client_field (client->busy_root, class_str[class], buf, +sizeof (buf)); +assert (ret ==0 ); +if (ret) +return 0 ; + +/* +* Handle both single integer and key=value formats by skipping +* leading non-digits. +*/ + b = buf; +while (*b && !isdigit (*b)) + b++; + +return strtoull (b,NULL ,10 ); +} + +static struct client * +find_client (struct clients *clients,enum client_status status,unsigned int id) +{ +unsigned int start, num; +struct client *c; + + start = status ==FREE ? clients->active_clients :0 ;/* Free block at the end. */ + num = clients->num_clients - start; + +for (c = &clients->client[start]; num; c++, num--) { +if (status != c->status) +continue ; + +if (status ==FREE || c->id == id) +return c; + } + +return NULL ; +} + +static void update_client (struct client *c,unsigned int pid,char *name) +{ +uint64_t val[c->clients->num_classes]; +unsigned int i; + +if (c->pid != pid) + c->pid = pid; + +if (strcmp (c->name, name)) { +char *p; + +strncpy (c->name, name,sizeof (c->name) -1 ); +strncpy (c->print_name, name,sizeof (c->print_name) -1 ); + + p = c->print_name; +while (*p) { +if (!isprint (*p)) + *p ='*' ; + p++; + } + } + +for (i =0 ; i < c->clients->num_classes; i++) + val[i] =read_client_busy (c, c->clients->class[i].class); + + c->last_runtime =0 ; + c->total_runtime =0 ; + +for (i =0 ; i < c->clients->num_classes; i++) { +if (val[i] < c->last[i]) +continue ;/* It will catch up soon. */ + + c->total_runtime += val[i]; + c->val[i] = val[i] - c->last[i]; + c->last_runtime += c->val[i]; + c->last[i] = val[i]; + } + + c->samples++; + c->status =ALIVE ; +} + +static void +add_client (struct clients *clients,unsigned int id,unsigned int pid, +char *name,int sysfs_root) +{ +struct client *c; + +assert (!find_client (clients,ALIVE , id)); + + c =find_client (clients,FREE ,0 ); +if (!c) { +unsigned int idx = clients->num_clients; + + clients->num_clients += (clients->num_clients +2 ) /2 ; + clients->client =realloc (clients->client, + clients->num_clients *sizeof (*c)); +assert (clients->client); + + c = &clients->client[idx]; +memset (c,0 , (clients->num_clients - idx) *sizeof (*c)); + } + + c->sysfs_root = sysfs_root; + c->busy_root =-1 ; + c->id = id; + c->clients = clients; + c->val =calloc (clients->num_classes,sizeof (c->val)); + c->last =calloc (clients->num_classes,sizeof (c->last)); +assert (c->val && c->last); + +update_client (c, pid, name); +} + +static void free_client (struct client *c) +{ +if (c->sysfs_root >=0 ) +close (c->sysfs_root); +if (c->busy_root >=0 ) +close (c->busy_root); +free (c->val); +free (c->last); +memset (c,0 ,sizeof (*c)); +} + +static int +read_client_sysfs (char *buf,int bufsize,const char *sysfs_root, +unsigned int id,const char *field,int *client_root) +{ +ssize_t ret; + +if (*client_root <0 ) { +char namebuf[256 ]; + + ret =snprintf (namebuf,sizeof (namebuf),"%s/%u" , + sysfs_root, id); +assert (ret >0 && ret <sizeof (namebuf)); +if (ret <=0 || ret ==sizeof (namebuf)) +return -1 ; + + *client_root =open (namebuf,O_RDONLY |O_DIRECTORY ); + } + +if (*client_root <0 ) +return -1 ; + +return __read_client_field (*client_root, field, buf, bufsize); +} + +static void scan_clients (struct clients *clients) +{ +struct dirent *dent; +struct client *c; +unsigned int id; +int tmp; +DIR *d; + +if (!clients) +return ; + +for_each_client (clients, c, tmp) { +assert (c->status !=PROBE ); +if (c->status ==ALIVE ) + c->status =PROBE ; +else +break ;/* Free block at the end of array. */ + } + + d =opendir (clients->sysfs_root); +if (!d) +return ; + +while ((dent =readdir (d)) !=NULL ) { +char name[24 ], pid[24 ]; +int ret, root =-1 , *pr; + +if (dent->d_type !=DT_DIR ) +continue ; +if (!isdigit (dent->d_name[0 ])) +continue ; + + id =atoi (dent->d_name); + + c =find_client (clients,PROBE , id); + +if (c) + pr = &c->sysfs_root; +else + pr = &root; + + ret =read_client_sysfs (name,sizeof (name), clients->sysfs_root, + id,"name" , pr); + ret |=read_client_sysfs (pid,sizeof (pid), clients->sysfs_root, + id,"pid" , pr); +if (!ret) { +if (!c) +add_client (clients, id,atoi (pid), name, root); +else +update_client (c,atoi (pid), name); + }else if (c) { + c->status =PROBE ;/* Will be deleted below. */ + } + } + +closedir (d); + +for_each_client (clients, c, tmp) { +if (c->status ==PROBE ) +free_client (c); +else if (c->status ==FREE ) +break ; + } +} + +static int client_last_cmp (const void *_a,const void *_b) +{ +const struct client *a = _a; +const struct client *b = _b; +long tot_a, tot_b; + +/* +* Sort clients in descending order of runtime in the previous sampling +* period for active ones, followed by inactive. Tie-breaker is client +* id. +*/ + + tot_a = a->status ==ALIVE ? a->last_runtime :-1 ; + tot_b = b->status ==ALIVE ? b->last_runtime :-1 ; + + tot_b -= tot_a; +if (tot_b >0 ) +return 1 ; +if (tot_b <0 ) +return -1 ; + +return (int )b->id - a->id; +} + +static int client_total_cmp (const void *_a,const void *_b) +{ +const struct client *a = _a; +const struct client *b = _b; +long tot_a, tot_b; + + tot_a = a->status ==ALIVE ? a->total_runtime :-1 ; + tot_b = b->status ==ALIVE ? b->total_runtime :-1 ; + + tot_b -= tot_a; +if (tot_b >0 ) +return 1 ; +if (tot_b <0 ) +return -1 ; + +return (int )b->id - a->id; +} + +static int client_id_cmp (const void *_a,const void *_b) +{ +const struct client *a = _a; +const struct client *b = _b; +int id_a, id_b; + + id_a = a->status ==ALIVE ? a->id :-1 ; + id_b = b->status ==ALIVE ? b->id :-1 ; + + id_b -= id_a; +if (id_b >0 ) +return 1 ; +if (id_b <0 ) +return -1 ; + +return (int )b->id - a->id; +} + +static int (*client_cmp)(const void *,const void *) = client_last_cmp; + +static void sort_clients (struct clients *clients) +{ +unsigned int active, free; +struct client *c; +int tmp; + +if (!clients) +return ; + +qsort (clients->client, clients->num_clients,sizeof (*clients->client), + client_cmp); + +/* Trim excessive array space. */ + active =0 ; +for_each_client (clients, c, tmp) { +if (c->status !=ALIVE ) +break ;/* Active clients are first in the array. */ + active++; + } + + clients->active_clients = active; + + free = clients->num_clients - active; +if (free > clients->num_clients /2 ) { + active = clients->num_clients - free /2 ; +if (active != clients->num_clients) { + clients->num_clients = active; + clients->client =realloc (clients->client, + clients->num_clients * +sizeof (*c)); + } + } +} + +static const char *bars[] = {" " ,"▏" ,"▎" ,"▍" ,"▌" ,"▋" ,"▊" ,"▉" ,"█" }; +static void n_spaces (const unsigned int n) +{ +unsigned int i; + +for (i =0 ; i < n; i++) +putchar (' ' ); +} +static void -print_percentage_bar (double percent,int max_len) +print_percentage_bar (double percent,int max_len,bool numeric) { -int bar_len = percent * (8 * (max_len -2 )) /100.0 ; -int i; +int bar_len, i, len = max_len -2 ; +const int w =8 ; + +assert (max_len >0 ); + + bar_len = percent * len /100.0 ; +if (bar_len > len) + bar_len = len; + bar_len *= w;putchar ('|' ); -for (i = bar_len; i >=8 ; i -=8 ) -printf ("%s" , bars[8 ]); +for (i = bar_len; i >= w; i -= w) +printf ("%s" , bars[w]);if (i)printf ("%s" , bars[i]); -for (i =0 ; i < (max_len -2 - (bar_len +7 ) /8 ); i++) -putchar (' ' ); + len -= (bar_len + (w -1 )) / w; +n_spaces (len);putchar ('|' ); + +if (numeric) { +/* +* TODO: Finer grained reverse control to better preserve +* bar under numerical percentage. +*/ +printf ("\033[%uD\033[7m" , max_len -1 ); + i =printf ("%3.f%%" , percent); +printf ("\033[%uC\033[0m" , max_len - i -1 ); + } }#define DEFAULT_PERIOD_MS (1000)
@@ -705,8 +1164,6 @@ static const char *json_indent[] = { "\t\t\t\t\t", }; -#define ARRAY_SIZE (arr) (sizeof(arr)/sizeof(arr[0])) -static unsigned int json_prev_struct_members;static unsigned int json_struct_members;
@@ -744,6 +1201,18 @@ json_close_struct(void)fflush (stdout); } +static void +__json_add_member (const char *key,const char *val) +{ +assert (json_indent_level <ARRAY_SIZE (json_indent)); + +fprintf (out,"%s%s\"%s\": \"%s\"" , + json_struct_members ?",\n" :"" , + json_indent[json_indent_level], key, val); + + json_struct_members++; +} +static unsigned int json_add_member (const struct cnt_group *parent,struct cnt_item *item,unsigned int headers)
@@ -1046,8 +1515,6 @@ print_header(const struct igt_device_card *card,memmove (&groups[0 ], &groups[1 ],sizeof (groups) -sizeof (groups[0 ])); - pops->open_struct (NULL ); - *consumed =print_groups (groups);if (output_mode ==INTERACTIVE ) {
@@ -1204,7 +1671,7 @@ print_engine(struct engines *engines, unsigned int i, double t, engine->display_name, engine_items[0].buf); val =pmu_calc (&engine->busy.val,1e9 , t,100 ); -print_percentage_bar (val, max_w - len); +print_percentage_bar (val, max_w > len ? max_w - len :0 , false);printf ("%s\n" , buf);
@@ -1219,7 +1686,6 @@ print_engines_footer(struct engines *engines, double t, int lines, int con_w, int con_h) { pops->close_struct(); - pops->close_struct ();if (output_mode ==INTERACTIVE ) {if (lines++ < con_h)
@@ -1243,6 +1709,9 @@ static void init_engine_classes(struct engines *engines)unsigned int i, num;int max =-1 ; +if (engines->num_classes) +return ; +for (i =0 ; i < engines->num_engines; i++) {struct engine *engine =engine_ptr (engines, i);
@@ -1404,6 +1873,153 @@ print_engines(struct engines *engines, double t, int lines, int w, int h)return lines; } +static int +print_clients_header (struct clients *clients,int lines, +int con_w,int con_h,int *class_w) +{ +if (output_mode ==INTERACTIVE ) { +const char *pidname =" PID NAME " ; +unsigned int num_active =0 ; +int len =strlen (pidname); + +if (lines++ >= con_h) +return lines; + +printf ("\033[7m" ); +printf ("%s" , pidname); + +if (lines++ >= con_h || len >= con_w) +return lines; + +if (clients->num_classes) { +unsigned int i; +int width; + +for (i =0 ; i < clients->num_classes; i++) { +if (clients->class[i].num_engines) + num_active++; + } + + *class_w = width = (con_w - len) / num_active; + +for (i =0 ; i < clients->num_classes; i++) { +const char *name = clients->class[i].name; +int name_len =strlen (name); +int pad = (width - name_len) /2 ; +int spaces = width - pad - name_len; + +if (!clients->class[i].num_engines) +continue ;/* Assert in the ideal world. */ + +if (pad <0 || spaces <0 ) +continue ; + +n_spaces (pad); +printf ("%s" , name); +n_spaces (spaces); + len += pad + name_len + spaces; + } + } + +n_spaces (con_w - len); +printf ("\033[0m\n" ); + }else { +if (clients->num_classes) + pops->open_struct ("clients" ); + } + +return lines; +} + +static bool numeric_clients; + +static int +print_client (struct client *c,struct engines *engines,double t,int lines, +int con_w,int con_h,unsigned int period_us,int *class_w) +{ +struct clients *clients = c->clients; +unsigned int i; + +if (output_mode ==INTERACTIVE ) { + lines++; + +printf ("%6u %17s " , c->pid, c->print_name); + +for (i =0 ; c->samples >1 && i < clients->num_classes; i++) { +double pct; + +if (!clients->class[i].num_engines) +continue ;/* Assert in the ideal world. */ + + pct = (double )c->val[i] / period_us /1e3 *100 / + clients->class[i].num_engines; + +/* +* Guard against possible time-drift between sampling +* client data and time we obtained our time-delta from +* PMU. +*/ +if (pct >100.0 ) + pct =100.0 ; + +print_percentage_bar (pct, *class_w, numeric_clients); + } + +putchar ('\n' ); + }else if (output_mode ==JSON ) { +char buf[64 ]; + +snprintf (buf,sizeof (buf),"%u" , c->id); + pops->open_struct (buf); + +__json_add_member ("name" , c->print_name); + +snprintf (buf,sizeof (buf),"%u" , c->pid); +__json_add_member ("pid" , buf); + +if (c->samples >1 ) { + pops->open_struct ("engine-classes" ); + +for (i =0 ; i < clients->num_classes; i++) { +double pct; + +snprintf (buf,sizeof (buf),"%s" , + clients->class[i].name); + pops->open_struct (buf); + + pct = (double )c->val[i] / period_us /1e3 *100 ; +snprintf (buf,sizeof (buf),"%f" , pct); +__json_add_member ("busy" , buf); + +__json_add_member ("unit" ,"%" ); + + pops->close_struct (); + } + + pops->close_struct (); + } + + pops->close_struct (); + } + +return lines; +} + +static int +print_clients_footer (struct clients *clients,double t, +int lines,int con_w,int con_h) +{ +if (output_mode ==INTERACTIVE ) { +if (lines++ < con_h) +printf ("\n" ); + }else { +if (clients->num_classes) + pops->close_struct (); + } + +return lines; +} +static bool stop_top;static void sigint_handler (int sig)
@@ -1459,6 +2075,22 @@ static void interactive_stdin(void)assert (ret ==0 ); } +static void select_client_sort (void ) +{ +static unsigned int client_sort; + +switch (++client_sort %3 ) { +case 0 : + client_cmp = client_last_cmp; +break ; +case 1 : + client_cmp = client_total_cmp; +break ; +case 2 : + client_cmp = client_id_cmp; + } +} +static void process_stdin (unsigned int timeout_us) {struct pollfd p = { .fd =0 , .events =POLLIN };
@@ -1485,6 +2117,12 @@ static void process_stdin(unsigned int timeout_us)case '1' : class_view ^= true;break ; +case 'n' : + numeric_clients ^= true; +break ; +case 's' : +select_client_sort (); +break ; }; } }
@@ -1492,6 +2130,7 @@ static void process_stdin(unsigned int timeout_us)int main (int argc,char **argv) {unsigned int period_us =DEFAULT_PERIOD_MS *1000 ; +struct clients *clients =NULL ;int con_w =-1 , con_h =-1 ;char *output_path =NULL ;struct engines *engines;
@@ -1625,13 +2264,20 @@ int main(int argc, char **argv) ret =EXIT_SUCCESS ; + clients =init_clients (card.pci_slot_name[0 ] ? card.card :NULL ); +init_engine_classes (engines); + clients->num_classes = engines->num_classes; + clients->class = engines->class; +pmu_sample (engines); +scan_clients (clients); codename =igt_device_get_pretty_name (&card, false);while (!stop_top) {bool consumed = false; -int lines =0 ; +int j, lines =0 ;struct winsize ws; +struct client *c;double t;/* Update terminal size. */
@@ -1650,10 +2296,15 @@ int main(int argc, char **argv)pmu_sample (engines); t = (double )(engines->ts.cur - engines->ts.prev) /1e9 ; +scan_clients (clients); +sort_clients (clients); +if (stop_top)break ;while (!consumed) { + pops->open_struct (NULL ); + lines =print_header (&card, codename, engines, t, lines, con_w, con_h, &consumed);
@@ -1661,6 +2312,33 @@ int main(int argc, char **argv) lines =print_imc (engines, t, lines, con_w, con_h); lines =print_engines (engines, t, lines, con_w, con_h); + +if (clients) { +int class_w; + + lines =print_clients_header (clients, lines, + con_w, con_h, + &class_w); + +for_each_client (clients, c, j) { +assert (c->status !=PROBE ); +if (c->status !=ALIVE ) +break ;/* Active clients are first in the array. */ + +if (lines > con_h) +break ; + + lines =print_client (c, engines, t, + lines, con_w, + con_h, period_us, + &class_w); + } + + lines =print_clients_footer (clients, t, lines, + con_w, con_h); + } + + pops->close_struct (); }if (stop_top)
Signature · 6 lines
2.27.0 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for intel-gpu-top: Support for client stats (rev4)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: intel-gpu-top: Support for client stats (rev4)
URL : https://patchwork.freedesktop.org/series/71182/
State : success
== Summary ==
CI Bug Log - changes from IGT_5964 -> IGTPW_5422
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5422:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@gem_exec_parallel@engines@fds:
- {fi-tgl-dsi}: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/fi-tgl-dsi/igt@gem_exec_parallel@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/fi-tgl-dsi/igt@gem_exec_parallel@[email protected]
Known issues
------------
Here are the changes found in IGTPW_5422 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][3] ([fdo#109271]) +22 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/fi-bdw-5557u/igt@amdgpu/[email protected]
* igt@amdgpu/amd_cs_nop@sync-compute0:
- fi-kbl-r: NOTRUN -> [SKIP][4] ([fdo#109271]) +20 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/fi-kbl-r/igt@amdgpu/[email protected]
* igt@amdgpu/amd_cs_nop@sync-gfx0:
- fi-bsw-n3050: NOTRUN -> [SKIP][5] ([fdo#109271]) +17 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/fi-bsw-n3050/igt@amdgpu/[email protected]
* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][6] ([i915#2283])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/fi-bdw-5557u/igt@[email protected]
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-y: [PASS][7] -> [DMESG-WARN][8] ([i915#2411] / [i915#402])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/fi-tgl-y/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/fi-tgl-y/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-kbl-r: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#2190])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/fi-kbl-r/igt@[email protected]
* igt@kms_chamelium@hdmi-edid-read:
- fi-kbl-r: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827]) +8 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/fi-kbl-r/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-r: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#533])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/fi-kbl-r/igt@[email protected]
* igt@prime_self_import@basic-with_two_bos:
- fi-tgl-y: [PASS][12] -> [DMESG-WARN][13] ([i915#402]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-kbl-soraka: [DMESG-WARN][14] ([i915#1982]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/fi-kbl-soraka/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/fi-kbl-soraka/igt@[email protected]
* igt@i915_selftest@live@execlists:
- fi-bsw-n3050: [INCOMPLETE][16] ([i915#2940]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/fi-bsw-n3050/igt@i915_selftest@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/fi-bsw-n3050/igt@i915_selftest@[email protected]
* igt@kms_chamelium@hdmi-crc-fast:
- fi-kbl-7500u: [DMESG-WARN][18] ([i915#2868]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/fi-kbl-7500u/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/fi-kbl-7500u/igt@[email protected]
* igt@vgem_basic@dmabuf-fence-before:
- fi-tgl-y: [DMESG-WARN][20] ([i915#402]) -> [PASS][21] +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/fi-tgl-y/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/fi-tgl-y/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1729]: https://gitlab.freedesktop.org/drm/intel/issues/1729
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2868]: https://gitlab.freedesktop.org/drm/intel/issues/2868
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Participating hosts (41 -> 35)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-bsw-cyan fi-dg1-1 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5964 -> IGTPW_5422
CI-20190529: 20190529
CI_DRM_9668: d386242bc14582829f8ccb3845880c5bf1ada76b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5422: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/index.html
IGT_5964: 0949766cb9846d7d55fac9cdf31d3d8e8ed1d0c6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.IGT: failure for intel-gpu-top: Support for client stats (rev4)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: intel-gpu-top: Support for client stats (rev4)
URL : https://patchwork.freedesktop.org/series/71182/
State : failure
== Summary ==
CI Bug Log - changes from IGT_5964_full -> IGTPW_5422_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_5422_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_5422_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5422_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@mock@evict:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-tglb5/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-tglb6/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in IGTPW_5422_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][3] -> [SKIP][4] ([i915#658])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-iclb2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb3/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][5] -> [FAIL][6] ([i915#2842]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-tglb2/igt@gem_exec_fair@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-tglb6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-iclb5/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][9] -> [FAIL][10] ([i915#2842]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-kbl3/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-kbl4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][11] -> [SKIP][12] ([fdo#109271])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-kbl2/igt@gem_exec_fair@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-kbl1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][13] -> [FAIL][14] ([i915#2842]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-glk8/igt@gem_exec_fair@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-glk7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_reloc@basic-many-active@vcs1:
- shard-iclb: NOTRUN -> [FAIL][15] ([i915#2389])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb1/igt@gem_exec_reloc@[email protected]
* igt@gem_exec_schedule@u-fairslice@bcs0:
- shard-iclb: [PASS][16] -> [DMESG-WARN][17] ([i915#2803])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-iclb1/igt@gem_exec_schedule@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb7/igt@gem_exec_schedule@[email protected]
* igt@gem_exec_whisper@basic-normal:
- shard-glk: [PASS][18] -> [DMESG-WARN][19] ([i915#118] / [i915#95])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-glk1/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-glk3/igt@[email protected]
* igt@gem_userptr_blits@coherency-unsync:
- shard-tglb: NOTRUN -> [SKIP][20] ([fdo#110542])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-tglb8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][21] ([fdo#109290])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb4/igt@[email protected]
* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-tglb: NOTRUN -> [SKIP][22] ([fdo#110426] / [i915#1704])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-tglb3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][23] ([fdo#110426] / [i915#1704])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb6/igt@[email protected]
* igt@gen3_mixed_blits:
- shard-kbl: NOTRUN -> [SKIP][24] ([fdo#109271]) +29 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-kbl1/igt@gen3_mixed_blits.html
* igt@kms_color_chamelium@pipe-a-ctm-green-to-red:
- shard-glk: NOTRUN -> [SKIP][25] ([fdo#109271] / [fdo#111827]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-glk5/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-apl8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][27] ([fdo#109284] / [fdo#111827])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb2/igt@[email protected]
* igt@kms_color_chamelium@pipe-d-ctm-0-5:
- shard-tglb: NOTRUN -> [SKIP][28] ([fdo#109284] / [fdo#111827]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-tglb2/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-kbl1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][30] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb3/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [PASS][31] -> [FAIL][32] ([i915#96])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-hsw6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-hsw6/igt@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-hsw: [PASS][33] -> [FAIL][34] ([i915#2370])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-iclb: NOTRUN -> [SKIP][35] ([fdo#109274]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb2/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-kbl: NOTRUN -> [DMESG-WARN][36] ([i915#180])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-kbl2/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-pwrite:
- shard-glk: NOTRUN -> [SKIP][37] ([fdo#109271]) +14 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-glk9/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-pwrite.html
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109280]) +5 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-pwrite.html
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271]) +17 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-apl8/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][40] ([fdo#111825]) +7 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-tglb5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#533])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-apl7/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#533])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-glk8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][43] ([fdo#109278]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb5/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#533])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-kbl2/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#658])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-kbl1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][46] ([i915#2920])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-tglb3/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#658])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-apl2/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#658])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-glk3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][49] ([i915#2920])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb2/igt@[email protected]
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][50] -> [SKIP][51] ([fdo#109441])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-iclb2/igt@kms_psr@psr2_basic.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb5/igt@kms_psr@psr2_basic.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109441])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb7/igt@kms_psr@psr2_sprite_render.html
* igt@nouveau_crc@pipe-d-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][53] ([i915#2530])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109278] / [i915#2530])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb4/igt@[email protected]
* igt@perf@gen8-unprivileged-single-ctx-counters:
- shard-tglb: NOTRUN -> [SKIP][55] ([fdo#109289])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-tglb5/igt@[email protected]
* igt@prime_nv_api@nv_self_import_to_different_fd:
- shard-tglb: NOTRUN -> [SKIP][56] ([fdo#109291])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-tglb1/igt@prime_nv_api@nv_self_import_to_different_fd.html
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109291])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb1/igt@prime_nv_api@nv_self_import_to_different_fd.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][58] ([i915#2846]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-kbl1/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-kbl4/igt@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [FAIL][60] ([i915#2842]) -> [PASS][61] +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-glk1/igt@gem_exec_fair@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-glk8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-tglb: [FAIL][62] ([i915#2842]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-tglb1/igt@gem_exec_fair@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-tglb6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][64] ([i915#2849]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-iclb1/igt@gem_exec_fair@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb3/igt@gem_exec_fair@[email protected]
* igt@gem_vm_create@destroy-race:
- shard-tglb: [TIMEOUT][66] ([i915#2795]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-tglb8/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-tglb1/igt@[email protected]
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-kbl: [INCOMPLETE][68] ([i915#151] / [i915#155]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-kbl1/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-kbl4/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- shard-hsw: [INCOMPLETE][70] ([i915#2782]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-hsw2/igt@i915_selftest@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-hsw6/igt@i915_selftest@[email protected]
* igt@kms_async_flips@test-time-stamp:
- shard-tglb: [FAIL][72] ([i915#2597]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-tglb5/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-tglb6/igt@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][74] ([i915#79]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-glk1/igt@kms_flip@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-glk1/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary:
- shard-kbl: [FAIL][76] ([i915#49]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-kbl3/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-kbl1/igt@[email protected]
- shard-apl: [FAIL][78] ([i915#49]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-apl6/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-apl7/igt@[email protected]
* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [SKIP][80] ([i915#433]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-tglb6/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-tglb3/igt@[email protected]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][82] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-iclb1/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb2/igt@[email protected]
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][84] ([fdo#109441]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-iclb5/igt@kms_psr@psr2_sprite_blt.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][86] ([i915#165] / [i915#295]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-kbl7/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-kbl2/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-iclb: [FAIL][88] ([i915#1542]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-iclb8/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb6/igt@[email protected]
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][90] ([i915#1804] / [i915#2684]) -> [WARN][91] ([i915#2684])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-iclb7/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb5/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area-0:
- shard-iclb: [SKIP][92] ([i915#658]) -> [SKIP][93] ([i915#2920]) +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-iclb1/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb2/igt@[email protected]
* igt@runner@aborted:
- shard-iclb: [FAIL][94] ([i915#2295] / [i915#2724]) -> ([FAIL][95], [FAIL][96]) ([i915#2295] / [i915#2426] / [i915#2724])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5964/shard-iclb3/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb7/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/shard-iclb4/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110426]: https://bugs.freedesktop.org/show_bug.cgi?id=110426
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#1704]: https://gitlab.freedesktop.org/drm/intel/issues/1704
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2795]: https://gitlab.freedesktop.org/drm/intel/issues/2795
[i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
Participating hosts (8 -> 8)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5964 -> IGTPW_5422
CI-20190529: 20190529
CI_DRM_9668: d386242bc14582829f8ccb3845880c5bf1ada76b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5422: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/index.html
IGT_5964: 0949766cb9846d7d55fac9cdf31d3d8e8ed1d0c6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5422/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev