Skip to contentSkip to conversation

staging: vc04_services: bcm2835-camera: Modify return statement.

PATCH In review Vatsala Narang 2 participants 2 messages Apr 27, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: vc04_services: bcm2835-camera: Modify return statement.

Modify return statement and remove the respective assignment.

Issue found by Coccinelle.

---
 drivers/staging/vc04_services/bcm2835-camera/controls.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/staging/vc04_services/bcm2835-camera/controls.c +2 -6
index 2e0a422cdf3e..9841c30450ce 100644
@@ -270,11 +270,9 @@ static int ctrl_set_rotate(struct bm2835_mmal_dev *dev,
 	if (ret < 0)
 		return ret;
 
-	ret = vchiq_mmal_port_parameter_set(dev->instance, &camera->output[2],
+	return vchiq_mmal_port_parameter_set(dev->instance, &camera->output[2],
 					    mmal_ctrl->mmal_id,
 					    &u32_value, sizeof(u32_value));
-
-	return ret;
 }
 
 static int ctrl_set_flip(struct bm2835_mmal_dev *dev,
@@ -313,11 +311,9 @@ static int ctrl_set_flip(struct bm2835_mmal_dev *dev,
 	if (ret < 0)
 		return ret;
 
-	ret = vchiq_mmal_port_parameter_set(dev->instance, &camera->output[2],
+	return vchiq_mmal_port_parameter_set(dev->instance, &camera->output[2],
 					    mmal_ctrl->mmal_id,
 					    &u32_value, sizeof(u32_value));
-
-	return ret;
 }
 
 static int ctrl_set_exposure(struct bm2835_mmal_dev *dev,
Signature · 1 line
2.17.1