Kworld 315U

PATCH In review Franklin Meng 2 participants 3 messages Jan 18, 2010 – Jan 26, 2010 Media (V4L/DVB)

lore

Share & tools

lore

Franklin Meng

author

2010-01-18 07:13 UTC #0 lore raw

PATCH 3/3 Kworld 315U

Patch to bring device out of power saving mode.

Signed-off-by Franklin Meng<[email protected]>

linux/drivers/media/video/em28xx/em28xx-core.c Sun Jan 17 22:54:21 2010 -0800 renamed from linux/drivers/media/video/em28xx/em28xx-core.c Thu Dec 31 19:14:54 2009 -0200 +0 -0

diff -r b6b82258cf5e linux/drivers/media/video/em28xx/em28xx-core.c                   
@@ -1132,6 +1132,7 @@

*/
void em28xx_wake_i2c(struct em28xx *dev)
{
+ v4l2_device_call_all(&dev->v4l2_dev, 0, core, s_power, 1); v4l2_device_call_all(&dev->v4l2_dev, 0, core, reset, 0); v4l2_device_call_all(&dev->v4l2_dev, 0, video, s_routing, INPUT(dev->ctl_input)->vmux, 0, 0);

Mauro Carvalho Chehab

2010-01-25 14:13 UTC #1 lore raw

Franklin Meng wrote:

Also complained about line-wrapping.

Cheers,
Mauro

Quoted 24 lines

Patch to bring device out of power saving mode.

Signed-off-by Franklin Meng<[email protected]>

diff -r b6b82258cf5e linux/drivers/media/video/em28xx/em28xx-core.c

linux/drivers/media/video/em28xx/em28xx-core.c Sun Jan 17 22:54:21 2010 -0800 renamed from linux/drivers/media/video/em28xx/em28xx-core.c Thu Dec 31 19:14:54 2009 -0200 +1 -1

@@ -1132,6 +1132,7 @@                                                                 
  */                                                                                  
 void em28xx_wake_i2c(struct em28xx *dev)                                             
 {                                                                                    
+       v4l2_device_call_all(&dev->v4l2_dev, 0, core,  s_power, 1);                   
        v4l2_device_call_all(&dev->v4l2_dev, 0, core,  reset, 0);                     
        v4l2_device_call_all(&dev->v4l2_dev, 0, video, s_routing,                     
                        INPUT(dev->ctl_input)->vmux, 0, 0);                           
 
 
 
 
 
--

To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Franklin Meng

author

2010-01-26 02:51 UTC #2 lore raw

Do you need me to resubmit the patches as a file attachment?

Thanks,
Franklin Meng

Quoted 81 lines · Mauro Carvalho Chehab

From: Mauro Carvalho Chehab <[email protected]>
Subject: Re: [Patch 3/3] Kworld 315U
To: "Franklin Meng" <[email protected]>
Cc: [email protected], "Douglas Schilling Landgraf" <[email protected]>
Date: Monday, January 25, 2010, 6:13 AM
Franklin Meng wrote:
Also complained about line-wrapping.
Cheers,
Mauro
Quoted 6 lines
Patch to bring device out of power saving mode.
Signed-off-by Franklin Meng<[email protected]>
diff -r b6b82258cf5e
linux/drivers/media/video/em28xx/em28xx-core.c

Quoted 1 line
---
a/linux/drivers/media/video/em28xx/em28xx-core.c
Thu Dec 31 19:14:54 2009 -0200
Quoted 1 line
+++
b/linux/drivers/media/video/em28xx/em28xx-core.c
Sun Jan 17 22:54:21 2010 -0800
Review
Quoted 1 line
(quoted diff) +0 -0
@@ -1132,6 +1132,7 @@       
Review line 1132
Quoted 1 line
(quoted diff) +0 -0
    */         
Review line 1133
Quoted 1 line
(quoted diff) +0 -0
   void em28xx_wake_i2c(struct em28xx *dev) 
Review line 1134
Quoted 1 line
(quoted diff) +0 -0
   {           
Review line 1135
Quoted 1 line
(quoted diff) +1 -0
+   
v4l2_device_call_all(&dev->v4l2_dev,
0, core, s_power, 1);
Quoted 1 line
   v4l2_device_call_all(&dev->v4l2_dev,
0, core, reset, 0);
Quoted 1 line
   v4l2_device_call_all(&dev->v4l2_dev,
0, video, s_routing,
Quoted 1 line

   INPUT(dev->ctl_input)->vmux, 0,
0);
Quoted 7 lines

--
To unsubscribe from this list: send the line
"unsubscribe linux-media" in
Quoted 2 lines
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html