Skip to contentSkip to conversation

clk: clk-qoriq: Replace of_node_put() with __free()

PATCH Applied David Hunter 2 participants 2 messages Sep 18, 2024 – Oct 9, 2024 Common clk

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 clk: clk-qoriq: Replace of_node_put() with __free()

Use __free() to have automatic cleanup instead of calling of_node_put() manually.

Compiled without errors or warnings.

---
The following commit has information on _free(device_node):
9448e55d032d99af8e23487f51a542d51b2f1a48

v3
- Changed subject
v2 - https://lore.kernel.org/all/[email protected]/
- Improved message body
- Use change log to give more information about __free()
v1 - https://lore.kernel.org/all/[email protected]/

---
 drivers/clk/clk-qoriq.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/clk/clk-qoriq.c +2 -4
index 4dcde305944c..a560edeb4b55 100644
@@ -9,6 +9,7 @@
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
 #include <dt-bindings/clock/fsl,qoriq-clockgen.h>
+#include <linux/cleanup.h>
 #include <linux/clk.h>
 #include <linux/clk-provider.h>
 #include <linux/clkdev.h>
@@ -1065,11 +1066,8 @@ static void __init _clockgen_init(struct device_node *np, bool legacy);
 static void __init legacy_init_clockgen(struct device_node *np)
 {
 	if (!clockgen.node) {
-		struct device_node *parent_np;
-
-		parent_np = of_get_parent(np);
+		struct device_node *parent_np __free(device_node) = of_get_parent(np);
 		_clockgen_init(parent_np, true);
-		of_node_put(parent_np);
 	}
 }
 
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw

Quoting David Hunter (2024-09-18 05:39:23)

Quoted 7 lines

Use __free() to have automatic cleanup instead of calling of_node_put() manually.

Compiled without errors or warnings.

---

Applied to clk-next