Skip to contentSkip to conversation

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/542

PATCH In review zzl 2 participants 2 messages Mar 12, 2022 – Mar 14, 2022

lore
Share & tools
lore

zzl

author
#0 lore raw

PATCH 1/1 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/542

---
 hw/audio/intel-hda.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/audio/intel-hda.c +1 -1
index 5f8a878f20..ff32936cfd 100644
@@ -328,7 +328,7 @@ static void intel_hda_corb_run(IntelHDAState *d)
             dprint(d, 2, "%s: corb ring empty\n", __func__);
             return;
         }
-        if (d->rirb_count == d->rirb_cnt) {
+        if (d->rirb_count >= d->rirb_cnt) {
             dprint(d, 2, "%s: rirb count reached\n", __func__);
             return;
         }
Signature · 1 line
2.32.0
#1 lore raw
Quoted 9 lines · zzl
---
  hw/audio/intel-hda.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
hw/audio/intel-hda.c +0 -0
index 5f8a878f20..ff32936cfd 100644

hw/audio/intel-hda.c static void intel_hda_corb_run(IntelHDAState *d) · line 334

Quoted 8 lines
hw/audio/intel-hda.c +1 -1
@@ -328,7 +328,7 @@ static void intel_hda_corb_run(IntelHDAState *d)
              dprint(d, 2, "%s: corb ring empty\n", __func__);
              return;
          }
-        if (d->rirb_count == d->rirb_cnt) {
+        if (d->rirb_count >= d->rirb_cnt) {
              dprint(d, 2, "%s: rirb count reached\n", __func__);
              return;
          }

Hi!

Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html for information how to correclty submit a patch. Especially you need to supply a "Signed-off-by" line, too, and please use a proper subject for the mail and place the "Resolves:" line into the patch description instead.

Apart from that, the bug ticket already links a patch series with a proposed fix ... could you elaborate why this needs a different approach?

Thomas