Skip to contentSkip to conversation

tests/kms_concurrent: Test for maximum number of planes

PATCH In review Mika Kahola 3 participants 5 messages Mar 19, 2020 – Mar 23, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/kms_concurrent: Test for maximum number of planes

In some cases we ran out of bandwidth when executiong a test. An error such as this can be seen on dmesg

"Bandwidth 16632 MB/s exceeds max available 6553 MB/s (7 active planes)"

The patch tests first, how many planes the platform can support with the given resolution. The actual test is then performed by using the calculated maximum number of planes instead of maximum number of planes that the platform supports.

---
 tests/kms_concurrent.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
tests/kms_concurrent.c +9 -6
index 14ca5fab..61137139 100644
@@ -196,20 +196,19 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
 }
 
 static void
-test_plane_position_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
+test_plane_position_with_output(data_t *data, enum pipe pipe, int max_planes,
+				igt_output_t *output)
 {
 	int i;
 	int iterations = opt.iterations < 1 ? 1 : opt.iterations;
 	bool loop_forever = opt.iterations == LOOP_FOREVER ? true : false;
-	int max_planes = data->display.pipes[pipe].n_planes;
 
 	igt_pipe_refresh(&data->display, pipe, true);
 
 	i = 0;
 	while (i < iterations || loop_forever) {
 		prepare_planes(data, pipe, max_planes, output);
-		igt_display_commit2(&data->display, COMMIT_ATOMIC);
-
+		igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
 		i++;
 	}
 }
@@ -242,7 +241,7 @@ get_lowres_mode(data_t *data, const drmModeModeInfo *mode_default,
 	return mode;
 }
 
-static void
+static int
 test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
 {
 	const drmModeModeInfo *mode_hi, *mode_lo;
@@ -294,6 +293,8 @@ test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
 
 		i++;
 	}
+
+	return max_planes;
 }
 
 static void
@@ -301,6 +302,7 @@ run_test(data_t *data, enum pipe pipe, igt_output_t *output)
 {
 	int connected_outs;
 	int n_planes = data->display.pipes[pipe].n_planes;
+	int max_planes = n_planes;
 
 	if (!opt.user_seed)
 		opt.seed = time(NULL);
@@ -311,9 +313,10 @@ run_test(data_t *data, enum pipe pipe, igt_output_t *output)
 			 igt_output_name(output), kmstest_pipe_name(pipe), opt.seed);
 
 		test_init(data, pipe, n_planes, output);
+		max_planes = test_resolution_with_output(data, pipe, output);
 
 		igt_fork(child, 1) {
-			test_plane_position_with_output(data, pipe, output);
+			test_plane_position_with_output(data, pipe, max_planes, output);
 		}
 
 		test_resolution_with_output(data, pipe, output);
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_concurrent: Test for maximum number of planes

== Series Details ==

== Series Details ==

Series: tests/kms_concurrent: Test for maximum number of planes
URL : https://patchwork.freedesktop.org/series/74872/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8159 -> IGTPW_4324
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/index.html

Known issues
------------

Here are the changes found in IGTPW_4324 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@execlists:
- fi-glk-dsi: [PASS][1] -> [INCOMPLETE][2] ([i915#58] / [i915#656] / [k.org#198133])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/fi-glk-dsi/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/fi-glk-dsi/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@gem_contexts:
- fi-skl-lmem: [PASS][3] -> [DMESG-FAIL][4] ([i915#933])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/fi-skl-lmem/igt@i915_selftest@live@gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/fi-skl-lmem/igt@i915_selftest@live@gem_contexts.html

#### Possible fixes ####

* igt@i915_selftest@live@execlists:
- fi-cml-u2: [INCOMPLETE][5] ([i915#283] / [i915#656]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/fi-cml-u2/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/fi-cml-u2/igt@i915_selftest@[email protected]

#### Warnings ####

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-guc: [FAIL][7] ([i915#665] / [i915#704]) -> [SKIP][8] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/fi-kbl-guc/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/fi-kbl-guc/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#283]: https://gitlab.freedesktop.org/drm/intel/issues/283
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656
[i915#665]: https://gitlab.freedesktop.org/drm/intel/issues/665
[i915#704]: https://gitlab.freedesktop.org/drm/intel/issues/704
[i915#933]: https://gitlab.freedesktop.org/drm/intel/issues/933
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133

Participating hosts (43 -> 36)
------------------------------

Additional (1): fi-bwr-2160
Missing (8): fi-kbl-soraka fi-bdw-5557u fi-byt-squawks fi-bsw-cyan fi-kbl-7500u fi-gdg-551 fi-byt-clapper fi-skl-6600u

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5522 -> IGTPW_4324

CI-20190529: 20190529
CI_DRM_8159: 00b2e0f1e7b3ea36379d68855f46a86400935411 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4324: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/index.html
IGT_5522: bd2b01af69c9720d54e68a8702a23e4ff3637746 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_concurrent: Test for maximum number of planes

In reply to Mika Kahola
== Series Details ==

== Series Details ==

Series: tests/kms_concurrent: Test for maximum number of planes
URL : https://patchwork.freedesktop.org/series/74872/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8159_full -> IGTPW_4324_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/index.html

Known issues
------------

Here are the changes found in IGTPW_4324_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_busy@busy-vcs1:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb3/igt@[email protected]

* igt@gem_caching@read-writes:
- shard-hsw: [PASS][3] -> [DMESG-WARN][4] ([fdo#110789] / [i915#478])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-hsw1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-hsw1/igt@[email protected]

* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#110854])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb6/igt@[email protected]

* igt@gem_exec_schedule@implicit-both-bsd1:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276] / [i915#677])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb8/igt@[email protected]

* igt@gem_exec_schedule@implicit-read-write-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([i915#677])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb8/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#112146]) +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb3/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb4/igt@[email protected]

* igt@i915_pm_rpm@gem-evict-pwrite:
- shard-hsw: [PASS][13] -> [SKIP][14] ([fdo#109271]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-hsw7/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-hsw2/igt@[email protected]
- shard-tglb: [PASS][15] -> [SKIP][16] ([i915#1316]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-tglb6/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-tglb2/igt@[email protected]
- shard-iclb: [PASS][17] -> [SKIP][18] ([i915#1316]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb5/igt@[email protected]

* igt@i915_pm_rpm@system-suspend:
- shard-glk: [PASS][19] -> [SKIP][20] ([fdo#109271]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-glk8/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-glk2/igt@[email protected]

* igt@i915_pm_rps@reset:
- shard-iclb: [PASS][21] -> [FAIL][22] ([i915#413])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb4/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb2/igt@[email protected]

* igt@i915_suspend@sysfs-reader:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([i915#180])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-apl7/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-apl1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-pwrite:
- shard-snb: [PASS][25] -> [DMESG-WARN][26] ([i915#478])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-snb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-pwrite.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-snb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-glk: [PASS][27] -> [FAIL][28] ([i915#49])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-glk6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-glk8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
- shard-apl: [PASS][29] -> [FAIL][30] ([i915#49])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-apl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-apl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
- shard-kbl: [PASS][31] -> [FAIL][32] ([i915#49])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html

* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [PASS][33] -> [DMESG-WARN][34] ([i915#180]) +5 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-kbl4/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-kbl2/igt@[email protected]

* igt@kms_psr@psr2_dpms:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb2/igt@kms_psr@psr2_dpms.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb5/igt@kms_psr@psr2_dpms.html

* igt@kms_setmode@basic:
- shard-hsw: [PASS][37] -> [FAIL][38] ([i915#31])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-hsw5/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-hsw4/igt@[email protected]

* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109276]) +20 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb1/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb7/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_isolation@vecs0-s3:
- shard-kbl: [DMESG-WARN][41] ([i915#180]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-kbl2/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-kbl3/igt@[email protected]

* igt@gem_exec_schedule@implicit-write-read-bsd1:
- shard-iclb: [SKIP][43] ([fdo#109276] / [i915#677]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb6/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb2/igt@[email protected]

* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [SKIP][45] ([fdo#112146]) -> [PASS][46] +6 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb4/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb5/igt@[email protected]

* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [SKIP][47] ([i915#677]) -> [PASS][48] +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb4/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb8/igt@[email protected]

* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [SKIP][49] ([fdo#109276]) -> [PASS][50] +11 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb8/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb2/igt@[email protected]

* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-iclb: [FAIL][51] ([i915#644]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb8/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb3/igt@[email protected]

* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-hsw: [DMESG-WARN][53] ([fdo#111870]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-hsw2/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-hsw4/igt@[email protected]

* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [DMESG-WARN][55] ([fdo#111870] / [i915#478]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-snb5/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-snb2/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-modeset:
- shard-kbl: [INCOMPLETE][57] ([i915#151] / [i915#155]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-kbl6/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-kbl1/igt@[email protected]

* igt@i915_pm_rps@waitboost:
- shard-tglb: [FAIL][59] ([i915#413]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-tglb1/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-tglb7/igt@[email protected]

* igt@kms_flip@flip-vs-suspend:
- shard-apl: [DMESG-WARN][61] ([i915#180]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-apl4/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-apl7/igt@[email protected]

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][63] ([fdo#109642] / [fdo#111068]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb6/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb2/igt@[email protected]

* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [SKIP][65] ([fdo#109441]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb6/igt@kms_psr@psr2_primary_blt.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb2/igt@kms_psr@psr2_primary_blt.html

* igt@kms_setmode@basic:
- shard-apl: [FAIL][67] ([i915#31]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-apl1/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-apl1/igt@[email protected]
- shard-glk: [FAIL][69] ([i915#31]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-glk1/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-glk6/igt@[email protected]

* igt@kms_vblank@pipe-a-ts-continuation-modeset-rpm:
- shard-tglb: [SKIP][71] ([fdo#112015]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-tglb1/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-tglb5/igt@[email protected]
- shard-hsw: [SKIP][73] ([fdo#109271]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-hsw6/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-hsw6/igt@[email protected]
- shard-iclb: [SKIP][75] ([fdo#109278]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb2/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb2/igt@[email protected]
- shard-glk: [SKIP][77] ([fdo#109271]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-glk5/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-glk4/igt@[email protected]

* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [SKIP][79] ([fdo#112080]) -> [PASS][80] +13 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb6/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb1/igt@[email protected]

#### Warnings ####

* igt@gem_userptr_blits@dmabuf-unsync:
- shard-hsw: [DMESG-WARN][81] ([fdo#111870]) -> [DMESG-WARN][82] ([fdo#110789] / [fdo#111870])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-hsw4/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-hsw4/igt@[email protected]
- shard-snb: [DMESG-WARN][83] ([fdo#111870] / [i915#478]) -> [DMESG-WARN][84] ([fdo#110789] / [fdo#111870] / [i915#478])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-snb5/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-snb5/igt@[email protected]

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][85] ([i915#588]) -> [SKIP][86] ([i915#658])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-iclb2/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-iclb1/igt@[email protected]

* igt@runner@aborted:
- shard-snb: ([FAIL][87], [FAIL][88], [FAIL][89], [FAIL][90], [FAIL][91], [FAIL][92], [FAIL][93], [FAIL][94]) ([fdo#111870] / [i915#1077] / [i915#1485]) -> ([FAIL][95], [FAIL][96], [FAIL][97], [FAIL][98], [FAIL][99], [FAIL][100], [FAIL][101]) ([fdo#111870] / [i915#1077] / [i915#1485] / [i915#698])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-snb5/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-snb6/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-snb5/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-snb4/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-snb5/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-snb2/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-snb5/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8159/shard-snb2/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-snb2/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-snb2/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-snb6/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-snb5/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-snb6/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-snb2/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/shard-snb6/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112015]: https://bugs.freedesktop.org/show_bug.cgi?id=112015
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#1077]: https://gitlab.freedesktop.org/drm/intel/issues/1077
[i915#1316]: https://gitlab.freedesktop.org/drm/intel/issues/1316
[i915#1485]: https://gitlab.freedesktop.org/drm/intel/issues/1485
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#698]: https://gitlab.freedesktop.org/drm/intel/issues/698

Participating hosts (10 -> 8)
------------------------------

Missing (2): pig-skl-6260u pig-glk-j5005

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5522 -> IGTPW_4324
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_8159: 00b2e0f1e7b3ea36379d68855f46a86400935411 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4324: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/index.html
IGT_5522: bd2b01af69c9720d54e68a8702a23e4ff3637746 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4324/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by on v1 1/1
#3 lore raw
In reply to Mika Kahola
Quoted 72 lines · Mika Kahola

In some cases we ran out of bandwidth when executiong a test. An error such as this can be seen on dmesg

"Bandwidth 16632 MB/s exceeds max available 6553 MB/s (7 active planes)"

The patch tests first, how many planes the platform can support with the given resolution. The actual test is then performed by using the calculated maximum number of planes instead of maximum number of planes that the platform supports.

---
  tests/kms_concurrent.c | 15 +++++++++------
  1 file changed, 9 insertions(+), 6 deletions(-)
tests/kms_concurrent.c +7 -5
index 14ca5fab..61137139 100644
@@ -196,20 +196,19 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
  }
 
  static void
-test_plane_position_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
+test_plane_position_with_output(data_t *data, enum pipe pipe, int max_planes,
+				igt_output_t *output)
  {
  	int i;
  	int iterations = opt.iterations < 1 ? 1 : opt.iterations;
  	bool loop_forever = opt.iterations == LOOP_FOREVER ? true : false;
-	int max_planes = data->display.pipes[pipe].n_planes;
 
  	igt_pipe_refresh(&data->display, pipe, true);
 
  	i = 0;
  	while (i < iterations || loop_forever) {
  		prepare_planes(data, pipe, max_planes, output);
-		igt_display_commit2(&data->display, COMMIT_ATOMIC);
-
+		igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
  		i++;
  	}
  }
@@ -242,7 +241,7 @@ get_lowres_mode(data_t *data, const drmModeModeInfo *mode_default,
  	return mode;
  }
 
-static void
+static int
  test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
  {
  	const drmModeModeInfo *mode_hi, *mode_lo;
@@ -294,6 +293,8 @@ test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
 
  		i++;
  	}
+
+	return max_planes;
  }
 
  static void
@@ -301,6 +302,7 @@ run_test(data_t *data, enum pipe pipe, igt_output_t *output)
  {
  	int connected_outs;
  	int n_planes = data->display.pipes[pipe].n_planes;
+	int max_planes = n_planes;
 
  	if (!opt.user_seed)
  		opt.seed = time(NULL);
@@ -311,9 +313,10 @@ run_test(data_t *data, enum pipe pipe, igt_output_t *output)
  			 igt_output_name(output), kmstest_pipe_name(pipe), opt.seed);

tests/kms_concurrent.c run_test(data_t *data, enum pipe pipe, igt_output_t *output) · line 322

Quoted 10 lines
tests/kms_concurrent.c +2 -1
 
  		test_init(data, pipe, n_planes, output);
+		max_planes = test_resolution_with_output(data, pipe, output);
 
  		igt_fork(child, 1) {
-			test_plane_position_with_output(data, pipe, output);
+			test_plane_position_with_output(data, pipe, max_planes, output);
  		}
 
  		test_resolution_with_output(data, pipe, output);

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author Reviewed-by Juha-Pekka Heikkila
#4 lore raw

Pushed!

Thanks for the review!

Cheers,
Mika

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Juha-Pekka Heikkila
Sent: Thursday, March 19, 2020 6:35 PM
To: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Test for maximum number of planes

Quoted 74 lines · Mika Kahola

In some cases we ran out of bandwidth when executiong a test. An error such as this can be seen on dmesg

"Bandwidth 16632 MB/s exceeds max available 6553 MB/s (7 active planes)"

The patch tests first, how many planes the platform can support with the given resolution. The actual test is then performed by using the calculated maximum number of planes instead of maximum number of planes that the platform supports.

---
  tests/kms_concurrent.c | 15 +++++++++------
  1 file changed, 9 insertions(+), 6 deletions(-)
tests/kms_concurrent.c index renamed from tests/kms_concurrent.c +0 -0

14ca5fab..61137139 100644

tests/kms_concurrent.c +3 -4
@@ -196,20 +196,19 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
  }
 
  static void
-test_plane_position_with_output(data_t *data, enum pipe pipe, 
 igt_output_t *output)
+test_plane_position_with_output(data_t *data, enum pipe pipe, int max_planes,
+				igt_output_t *output)
  {
  	int i;
  	int iterations = opt.iterations < 1 ? 1 : opt.iterations;
  	bool loop_forever = opt.iterations == LOOP_FOREVER ? true : false;
-	int max_planes = data->display.pipes[pipe].n_planes;
 
  	igt_pipe_refresh(&data->display, pipe, true);
 
  	i = 0;
  	while (i < iterations || loop_forever) {
  		prepare_planes(data, pipe, max_planes, output);
-		igt_display_commit2(&data->display, COMMIT_ATOMIC);
-
+		igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
  		i++;
  	}
  }
tests/kms_concurrent.c +1 -1
@@ -242,7 +241,7 @@ get_lowres_mode(data_t *data, const drmModeModeInfo *mode_default,
  	return mode;
  }
 
-static void
+static int
  test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
  {
  	const drmModeModeInfo *mode_hi, *mode_lo; @@ -294,6 +293,8 @@ 

test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)

  		i++;
  	}
tests/kms_concurrent.c +3 -0
+
+	return max_planes;
  }
 
  static void
@@ -301,6 +302,7 @@ run_test(data_t *data, enum pipe pipe, igt_output_t *output)
  {
  	int connected_outs;
  	int n_planes = data->display.pipes[pipe].n_planes;
+	int max_planes = n_planes;
 
  	if (!opt.user_seed)
  		opt.seed = time(NULL);
@@ -311,9 +313,10 @@ run_test(data_t *data, enum pipe pipe, igt_output_t *output)
  			 igt_output_name(output), kmstest_pipe_name(pipe), opt.seed);

tests/kms_concurrent.c run_test(data_t *data, enum pipe pipe, igt_output_t *output) · line 322

Quoted 10 lines
tests/kms_concurrent.c +2 -1
 
  		test_init(data, pipe, n_planes, output);
+		max_planes = test_resolution_with_output(data, pipe, output);
 
  		igt_fork(child, 1) {
-			test_plane_position_with_output(data, pipe, output);
+			test_plane_position_with_output(data, pipe, max_planes, output);
  		}
 
  		test_resolution_with_output(data, pipe, output);

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev