bpf: Make bpf_helper_defs.h c++ friendly
PATCH 1/1 bpf: Make bpf_helper_defs.h c++ friendly
From: Peng Wei <[email protected]>
Compiling C++ BPF programs with existing bpf_helper_defs.h is not possible due to stricter C++ type conversions. C++ complains about (void *) type conversions:
bpf_helper_defs.h:57:67: error: invalid conversion from ‘void*’ to ‘void* (*)(void*, const void*)’ [-fpermissive]
57 | static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1;
| ^~~~~~~~~~
| |
| void*Extend bpf_doc.py to use proper function type instead of void.
Before:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1;
After:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *(*)(void *map, const void *key)) 1;
--- scripts/bpf_doc.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
scripts/bpf_doc.py +6 -1
@@ -827,6 +827,9 @@ COMMANDS print(' *{}{}'.format(' \t' if line else '', line)) print(' */') + fptr_type = '%s%s(*)(' % ( + self.map_type(proto['ret_type']), + ((' ' + proto['ret_star']) if proto['ret_star'] else '')) print('static %s %s(*%s)(' % (self.map_type(proto['ret_type']), proto['ret_star'], proto['name']), end='') comma = ''
@@ -845,8 +848,10 @@ COMMANDS one_arg += '{}'.format(n) comma = ', ' print(one_arg, end='') + fptr_type += one_arg - print(') = (void *) %d;' % helper.enum_val) + fptr_type += ')' + print(') = (%s) %d;' % (fptr_type, helper.enum_val)) print('') ###############################################################################
Signature · 1 line
2.40.0.634.g4ca3ef3211-goog
Quoted 6 lines · Stanislav Fomichev
From: Peng Wei <[email protected]>
Compiling C++ BPF programs with existing
bpf_helper_defs.his not possible due to stricter C++ type conversions. C++ complains about (void *) type conversions:
Quoted 7 lines
bpf_helper_defs.h:57:67: error: invalid conversion from ‘void*’ to ‘void* (*)(void*, const void*)’ [-fpermissive]
57 | static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1; | ^~~~~~~~~~ | | | void*Extend
bpf_doc.pyto use proper function type instead of void.
Could you specify what exactly the compilation command triggering the above error?
Quoted 39 lines
Before:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1;After:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *(*)(void *map, const void *key)) 1;Signed-off-by Peng Wei <[email protected]>Signed-off-by Stanislav Fomichev <[email protected]>--- scripts/bpf_doc.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)scripts/bpf_doc.py +6
-1@@ -827,6 +827,9 @@ COMMANDS print(' *{}{}'.format(' \t' if line else '', line)) print(' */') + fptr_type = '%s%s(*)(' % ( + self.map_type(proto['ret_type']), + ((' ' + proto['ret_star']) if proto['ret_star'] else '')) print('static %s %s(*%s)(' % (self.map_type(proto['ret_type']), proto['ret_star'], proto['name']), end='') comma = ''@@ -845,8 +848,10 @@ COMMANDS one_arg += '{}'.format(n) comma = ', ' print(one_arg, end='') + fptr_type += one_arg - print(') = (void *) %d;' % helper.enum_val) + fptr_type += ')' + print(') = (%s) %d;' % (fptr_type, helper.enum_val)) print('') ###############################################################################
Quoted 16 lines · Yonghong Song
Quoted 12 lines · Stanislav Fomichev
From: Peng Wei <[email protected]>
Compiling C++ BPF programs with existing
bpf_helper_defs.his not possible due to stricter C++ type conversions. C++ complains about (void *) type conversions:bpf_helper_defs.h:57:67: error: invalid conversion from ‘void*’ to ‘void* (*)(void*, const void*)’ [-fpermissive]
57 | static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1; | ^~~~~~~~~~ | | | void*
Quoted 4 lines
Quoted 1 line
Extend
bpf_doc.pyto use proper function type instead of void.Could you specify what exactly the compilation command triggering the above error?
The following does it for me:
clang++ --include linux/types.h ./tools/lib/bpf/bpf_helper_defs.h
Quoted 39 lines
Quoted 39 lines
Before:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1;After:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *(*)(void *map, const void *key)) 1;Signed-off-by Peng Wei <[email protected]>Signed-off-by Stanislav Fomichev <[email protected]>--- scripts/bpf_doc.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)scripts/bpf_doc.py +6
-1@@ -827,6 +827,9 @@ COMMANDS print(' *{}{}'.format(' \t' if line else '', line)) print(' */') + fptr_type = '%s%s(*)(' % ( + self.map_type(proto['ret_type']), + ((' ' + proto['ret_star']) if proto['ret_star'] else '')) print('static %s %s(*%s)(' % (self.map_type(proto['ret_type']), proto['ret_star'], proto['name']), end='') comma = ''@@ -845,8 +848,10 @@ COMMANDS one_arg += '{}'.format(n) comma = ', ' print(one_arg, end='') + fptr_type += one_arg - print(') = (void *) %d;' % helper.enum_val) + fptr_type += ')' + print(') = (%s) %d;' % (fptr_type, helper.enum_val)) print('') ###############################################################################
Quoted 8 lines · Stanislav Fomichev
Quoted 7 lines · Yonghong Song
Quoted 3 lines · Stanislav Fomichev
From: Peng Wei <[email protected]>
Compiling C++ BPF programs with existing
bpf_helper_defs.his not
Just curious, why you want to compile BPF programs with C++? The patch looks good to me. But it would be great to know some reasoning since a lot of stuff, e.g., some CORE related intrinsics, not available for C++.
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
possible due to stricter C++ type conversions. C++ complains about (void *) type conversions:
bpf_helper_defs.h:57:67: error: invalid conversion from ‘void*’ to ‘void* (*)(void*, const void*)’ [-fpermissive]
57 | static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1; | ^~~~~~~~~~ | | | void*
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Extend
bpf_doc.pyto use proper function type instead of void.Could you specify what exactly the compilation command triggering the above error?
The following does it for me:
clang++ --includelinux/types.h./tools/lib/bpf/bpf_helper_defs.h
Thanks. It would be good if you add the above compilation command in the commit message.
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
Before:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1;After:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *(*)(void *map, const void *key)) 1;Signed-off-by Peng Wei <[email protected]>Signed-off-by Stanislav Fomichev <[email protected]>--- scripts/bpf_doc.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)scripts/bpf_doc.py +6
-1@@ -827,6 +827,9 @@ COMMANDS print(' *{}{}'.format(' \t' if line else '', line)) print(' */') + fptr_type = '%s%s(*)(' % ( + self.map_type(proto['ret_type']), + ((' ' + proto['ret_star']) if proto['ret_star'] else '')) print('static %s %s(*%s)(' % (self.map_type(proto['ret_type']), proto['ret_star'], proto['name']), end='') comma = ''@@ -845,8 +848,10 @@ COMMANDS one_arg += '{}'.format(n) comma = ', ' print(one_arg, end='') + fptr_type += one_arg - print(') = (void *) %d;' % helper.enum_val) + fptr_type += ')' + print(') = (%s) %d;' % (fptr_type, helper.enum_val)) print('') ###############################################################################
Quoted 9 lines · Yonghong Song
Quoted 5 lines · Stanislav Fomichev
Quoted 4 lines · Yonghong Song
On 4/24/23 5:01 PM, Stanislav Fomichev wrote:
Quoted 8 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
From: Peng Wei <[email protected]>
Compiling C++ BPF programs with existing
bpf_helper_defs.his notJust curious, why you want to compile BPF programs with C++? The patch looks good to me. But it would be great to know some reasoning since a lot of stuff, e.g., some CORE related intrinsics, not available for C++.
Can you share more? What's not available? Any pointers to the docs maybe?
People here want to try to use c++ to see if templating helps with v4 vs v6 handling.
We have a bunch of copy-paste around this place and would like to see whether c++ could make it a bit more readable.
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
possible due to stricter C++ type conversions. C++ complains about (void *) type conversions:
bpf_helper_defs.h:57:67: error: invalid conversion from ‘void*’ to ‘void* (*)(void*, const void*)’ [-fpermissive]
57 | static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1; | ^~~~~~~~~~ | | | void*Extend
bpf_doc.pyto use proper function type instead of void.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Could you specify what exactly the compilation command triggering the above error?
The following does it for me:
clang++ --includelinux/types.h./tools/lib/bpf/bpf_helper_defs.hThanks. It would be good if you add the above compilation command in the commit message.
Sure, will add.
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
Before:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1;After:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *(*)(void *map, const void *key)) 1;Signed-off-by Peng Wei <[email protected]>Signed-off-by Stanislav Fomichev <[email protected]>--- scripts/bpf_doc.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)scripts/bpf_doc.py +6
-1@@ -827,6 +827,9 @@ COMMANDS print(' *{}{}'.format(' \t' if line else '', line)) print(' */') + fptr_type = '%s%s(*)(' % ( + self.map_type(proto['ret_type']), + ((' ' + proto['ret_star']) if proto['ret_star'] else '')) print('static %s %s(*%s)(' % (self.map_type(proto['ret_type']), proto['ret_star'], proto['name']), end='') comma = ''@@ -845,8 +848,10 @@ COMMANDS one_arg += '{}'.format(n) comma = ', ' print(one_arg, end='') + fptr_type += one_arg - print(') = (void *) %d;' % helper.enum_val) + fptr_type += ')' + print(') = (%s) %d;' % (fptr_type, helper.enum_val)) print('') ###############################################################################
Quoted 12 lines · Stanislav Fomichev
Quoted 11 lines · Yonghong Song
Quoted 7 lines · Stanislav Fomichev
Quoted 6 lines · Yonghong Song
Quoted 2 lines · Stanislav Fomichev
From: Peng Wei <[email protected]>
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Compiling C++ BPF programs with existing
bpf_helper_defs.his notJust curious, why you want to compile BPF programs with C++? The patch looks good to me. But it would be great to know some reasoning since a lot of stuff, e.g., some CORE related intrinsics, not available for C++.
Can you share more? What's not available? Any pointers to the docs maybe?
Sorry, it is an attribute, instead of instrinsics.
The attribute preserve_access_index/btf_type_tag/btf_decl_tag are all C only.
In llvm-project/clang/include/clang/Basic/Attr.td:
def BPFPreserveAccessIndex : InheritableAttr,
TargetSpecificAttr<TargetBPF> { let Spellings = [Clang<"preserve_access_index">]; let Subjects = SubjectList<[Record], ErrorDiag>; let Documentation = [BPFPreserveAccessIndexDocs]; let LangOpts = [COnly];
}
def BTFDeclTag : InheritableAttr {
let Spellings = [Clang<"btf_decl_tag">];
let Args = [StringArgument<"BTFDeclTag">];
let Subjects = SubjectList<[Var, Function, Record, Field, TypedefName],
ErrorDiag>;
let Documentation = [BTFDeclTagDocs];
let LangOpts = [COnly];
}
def BTFTypeTag : TypeAttr {
let Spellings = [Clang<"btf_type_tag">];
let Args = [StringArgument<"BTFTypeTag">];
let Documentation = [BTFTypeTagDocs];
let LangOpts = [COnly];
}
Quoted 69 lines
People here want to try to use c++ to see if templating helps with v4 vs v6 handling.
We have a bunch of copy-paste around this place and would like to see whether c++ could make it a bit more readable.Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
possible due to stricter C++ type conversions. C++ complains about (void *) type conversions:
bpf_helper_defs.h:57:67: error: invalid conversion from ‘void*’ to ‘void* (*)(void*, const void*)’ [-fpermissive]
57 | static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1; | ^~~~~~~~~~ | | | void*Extend
bpf_doc.pyto use proper function type instead of void.Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Could you specify what exactly the compilation command triggering the above error?
The following does it for me:
clang++ --includelinux/types.h./tools/lib/bpf/bpf_helper_defs.hThanks. It would be good if you add the above compilation command in the commit message.
Sure, will add.
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
Before:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1;After:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *(*)(void *map, const void *key)) 1;Signed-off-by Peng Wei <[email protected]>Signed-off-by Stanislav Fomichev <[email protected]>--- scripts/bpf_doc.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)scripts/bpf_doc.py +6
-1@@ -827,6 +827,9 @@ COMMANDS print(' *{}{}'.format(' \t' if line else '', line)) print(' */') + fptr_type = '%s%s(*)(' % ( + self.map_type(proto['ret_type']), + ((' ' + proto['ret_star']) if proto['ret_star'] else '')) print('static %s %s(*%s)(' % (self.map_type(proto['ret_type']), proto['ret_star'], proto['name']), end='') comma = ''@@ -845,8 +848,10 @@ COMMANDS one_arg += '{}'.format(n) comma = ', ' print(one_arg, end='') + fptr_type += one_arg - print(') = (void *) %d;' % helper.enum_val) + fptr_type += ')' + print(') = (%s) %d;' % (fptr_type, helper.enum_val)) print('') ###############################################################################
Quoted 23 lines · Yonghong Song
Quoted 19 lines · Stanislav Fomichev
Quoted 17 lines · Yonghong Song
Quoted 8 lines · Stanislav Fomichev
Quoted 7 lines · Yonghong Song
Quoted 3 lines · Stanislav Fomichev
From: Peng Wei <[email protected]>
Compiling C++ BPF programs with existing
bpf_helper_defs.his notJust curious, why you want to compile BPF programs with C++? The patch looks good to me. But it would be great to know some reasoning since a lot of stuff, e.g., some CORE related intrinsics, not available for C++.
Quoted 6 lines
Quoted 1 line
Can you share more? What's not available? Any pointers to the docs maybe?
Sorry, it is an attribute, instead of instrinsics.
The attribute preserve_access_index/btf_type_tag/btf_decl_tag are all C only.
Interesting, thanks! I don't think we use btf_type_tag/btf_decl_tag in the program we want to try c++, but losing preserve_access_index might be unfortunate :-( But we'll see..
Btw, any reason these are explicitly opted out from c++? Doesn't seem like there is anything c-specific in them?
The c++ we are talking about here is mostly "c with classes + templates"; no polymorphism / inheritance.
Quoted 97 lines
In llvm-project/clang/include/clang/Basic/Attr.td:
def BPFPreserveAccessIndex : InheritableAttr,
TargetSpecificAttr<TargetBPF> { let Spellings = [Clang<"preserve_access_index">]; let Subjects = SubjectList<[Record], ErrorDiag>; let Documentation = [BPFPreserveAccessIndexDocs]; let LangOpts = [COnly]; }def BTFDeclTag : InheritableAttr { let Spellings = [Clang<"btf_decl_tag">]; let Args = [StringArgument<"BTFDeclTag">]; let Subjects = SubjectList<[Var, Function, Record, Field, TypedefName], ErrorDiag>; let Documentation = [BTFDeclTagDocs]; let LangOpts = [COnly]; }def BTFTypeTag : TypeAttr { let Spellings = [Clang<"btf_type_tag">]; let Args = [StringArgument<"BTFTypeTag">]; let Documentation = [BTFTypeTagDocs]; let LangOpts = [COnly]; }Quoted 69 lines
People here want to try to use c++ to see if templating helps with v4 vs v6 handling.
We have a bunch of copy-paste around this place and would like to see whether c++ could make it a bit more readable.Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
possible due to stricter C++ type conversions. C++ complains about (void *) type conversions:
bpf_helper_defs.h:57:67: error: invalid conversion from ‘void*’ to ‘void* (*)(void*, const void*)’ [-fpermissive]
57 | static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1; | ^~~~~~~~~~ | | | void*Extend
bpf_doc.pyto use proper function type instead of void.Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Could you specify what exactly the compilation command triggering the above error?
The following does it for me:
clang++ --includelinux/types.h./tools/lib/bpf/bpf_helper_defs.hThanks. It would be good if you add the above compilation command in the commit message.
Sure, will add.
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
Before:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1;After:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *(*)(void *map, const void *key)) 1;Signed-off-by Peng Wei <[email protected]>Signed-off-by Stanislav Fomichev <[email protected]>--- scripts/bpf_doc.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)scripts/bpf_doc.py +6
-1@@ -827,6 +827,9 @@ COMMANDS print(' *{}{}'.format(' \t' if line else '', line)) print(' */') + fptr_type = '%s%s(*)(' % ( + self.map_type(proto['ret_type']), + ((' ' + proto['ret_star']) if proto['ret_star'] else '')) print('static %s %s(*%s)(' % (self.map_type(proto['ret_type']), proto['ret_star'], proto['name']), end='') comma = ''@@ -845,8 +848,10 @@ COMMANDS one_arg += '{}'.format(n) comma = ', ' print(one_arg, end='') + fptr_type += one_arg - print(') = (void *) %d;' % helper.enum_val) + fptr_type += ')' + print(') = (%s) %d;' % (fptr_type, helper.enum_val)) print('') ###############################################################################
Quoted 28 lines · Stanislav Fomichev
Quoted 27 lines · Yonghong Song
Quoted 12 lines · Stanislav Fomichev
Quoted 11 lines · Yonghong Song
Quoted 7 lines · Stanislav Fomichev
Quoted 6 lines · Yonghong Song
Quoted 2 lines · Stanislav Fomichev
From: Peng Wei <[email protected]>
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Compiling C++ BPF programs with existing
bpf_helper_defs.his notJust curious, why you want to compile BPF programs with C++? The patch looks good to me. But it would be great to know some reasoning since a lot of stuff, e.g., some CORE related intrinsics, not available for C++.
Can you share more? What's not available? Any pointers to the docs maybe?
Sorry, it is an attribute, instead of instrinsics.
Quoted 8 lines
Quoted 2 lines
The attribute preserve_access_index/btf_type_tag/btf_decl_tag are all C only.
Interesting, thanks! I don't think we use btf_type_tag/btf_decl_tag in the program we want to try c++, but losing
preserve_access_indexmight be unfortunate :-( But we'll see..
Btw, any reason these are explicitly opted out from c++? Doesn't seem like there is anything c-specific in them?
Initial use case is C only. If we say to support C++, we will need to add attribute processing codes in various other places (member functions, templates, other c++ constructs, etc.) to convert these attributes to proper debuginfo. There are no use cases for this, so we didn't do it in the first place.
Quoted 100 lines
The c++ we are talking about here is mostly "c with classes + templates"; no polymorphism / inheritance.
Quoted 97 lines
In llvm-project/clang/include/clang/Basic/Attr.td:
def BPFPreserveAccessIndex : InheritableAttr,
TargetSpecificAttr<TargetBPF> { let Spellings = [Clang<"preserve_access_index">]; let Subjects = SubjectList<[Record], ErrorDiag>; let Documentation = [BPFPreserveAccessIndexDocs]; let LangOpts = [COnly]; }def BTFDeclTag : InheritableAttr { let Spellings = [Clang<"btf_decl_tag">]; let Args = [StringArgument<"BTFDeclTag">]; let Subjects = SubjectList<[Var, Function, Record, Field, TypedefName], ErrorDiag>; let Documentation = [BTFDeclTagDocs]; let LangOpts = [COnly]; }def BTFTypeTag : TypeAttr { let Spellings = [Clang<"btf_type_tag">]; let Args = [StringArgument<"BTFTypeTag">]; let Documentation = [BTFTypeTagDocs]; let LangOpts = [COnly]; }Quoted 69 lines
People here want to try to use c++ to see if templating helps with v4 vs v6 handling.
We have a bunch of copy-paste around this place and would like to see whether c++ could make it a bit more readable.Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
possible due to stricter C++ type conversions. C++ complains about (void *) type conversions:
bpf_helper_defs.h:57:67: error: invalid conversion from ‘void*’ to ‘void* (*)(void*, const void*)’ [-fpermissive]
57 | static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1; | ^~~~~~~~~~ | | | void*Extend
bpf_doc.pyto use proper function type instead of void.Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Could you specify what exactly the compilation command triggering the above error?
The following does it for me:
clang++ --includelinux/types.h./tools/lib/bpf/bpf_helper_defs.hThanks. It would be good if you add the above compilation command in the commit message.
Sure, will add.
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
Before:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1;After:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *(*)(void *map, const void *key)) 1;Signed-off-by Peng Wei <[email protected]>Signed-off-by Stanislav Fomichev <[email protected]>--- scripts/bpf_doc.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)scripts/bpf_doc.py +6
-1@@ -827,6 +827,9 @@ COMMANDS print(' *{}{}'.format(' \t' if line else '', line)) print(' */') + fptr_type = '%s%s(*)(' % ( + self.map_type(proto['ret_type']), + ((' ' + proto['ret_star']) if proto['ret_star'] else '')) print('static %s %s(*%s)(' % (self.map_type(proto['ret_type']), proto['ret_star'], proto['name']), end='') comma = ''@@ -845,8 +848,10 @@ COMMANDS one_arg += '{}'.format(n) comma = ', ' print(one_arg, end='') + fptr_type += one_arg - print(') = (void *) %d;' % helper.enum_val) + fptr_type += ')' + print(') = (%s) %d;' % (fptr_type, helper.enum_val)) print('') ###############################################################################
Quoted 41 lines · Yonghong Song
Quoted 28 lines · Stanislav Fomichev
Quoted 27 lines · Yonghong Song
Quoted 12 lines · Stanislav Fomichev
Quoted 11 lines · Yonghong Song
Quoted 7 lines · Stanislav Fomichev
Quoted 6 lines · Yonghong Song
Quoted 2 lines · Stanislav Fomichev
From: Peng Wei <[email protected]>
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Compiling C++ BPF programs with existing
bpf_helper_defs.his notJust curious, why you want to compile BPF programs with C++? The patch looks good to me. But it would be great to know some reasoning since a lot of stuff, e.g., some CORE related intrinsics, not available for C++.
Can you share more? What's not available? Any pointers to the docs maybe?
Sorry, it is an attribute, instead of instrinsics.
Quoted 8 lines
Quoted 2 lines
The attribute preserve_access_index/btf_type_tag/btf_decl_tag are all C only.
Interesting, thanks! I don't think we use btf_type_tag/btf_decl_tag in the program we want to try c++, but losing
preserve_access_indexmight be unfortunate :-( But we'll see..
Btw, any reason these are explicitly opted out from c++? Doesn't seem like there is anything c-specific in them?
Quoted 5 lines
Initial use case is C only. If we say to support C++, we will need to add attribute processing codes in various other places (member functions, templates, other c++ constructs, etc.) to convert these attributes to proper debuginfo. There are no use cases for this, so we didn't do it in the first place.
I see. In this case, let me respin the patch as is with the clang++ command to reproduce.
We'll experiment with our program internally to see whether these are the showstoppers.
Quoted 100 lines
Quoted 100 lines
The c++ we are talking about here is mostly "c with classes + templates"; no polymorphism / inheritance.
Quoted 97 lines
In llvm-project/clang/include/clang/Basic/Attr.td:
def BPFPreserveAccessIndex : InheritableAttr,
TargetSpecificAttr<TargetBPF> { let Spellings = [Clang<"preserve_access_index">]; let Subjects = SubjectList<[Record], ErrorDiag>; let Documentation = [BPFPreserveAccessIndexDocs]; let LangOpts = [COnly]; }def BTFDeclTag : InheritableAttr { let Spellings = [Clang<"btf_decl_tag">]; let Args = [StringArgument<"BTFDeclTag">]; let Subjects = SubjectList<[Var, Function, Record, Field, TypedefName], ErrorDiag>; let Documentation = [BTFDeclTagDocs]; let LangOpts = [COnly]; }def BTFTypeTag : TypeAttr { let Spellings = [Clang<"btf_type_tag">]; let Args = [StringArgument<"BTFTypeTag">]; let Documentation = [BTFTypeTagDocs]; let LangOpts = [COnly]; }Quoted 69 lines
People here want to try to use c++ to see if templating helps with v4 vs v6 handling.
We have a bunch of copy-paste around this place and would like to see whether c++ could make it a bit more readable.Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
possible due to stricter C++ type conversions. C++ complains about (void *) type conversions:
bpf_helper_defs.h:57:67: error: invalid conversion from ‘void*’ to ‘void* (*)(void*, const void*)’ [-fpermissive]
57 | static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1; | ^~~~~~~~~~ | | | void*Extend
bpf_doc.pyto use proper function type instead of void.Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Could you specify what exactly the compilation command triggering the above error?
The following does it for me:
clang++ --includelinux/types.h./tools/lib/bpf/bpf_helper_defs.hThanks. It would be good if you add the above compilation command in the commit message.
Sure, will add.
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
Before:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *) 1;After:
static void *(*bpf_map_lookup_elem)(void *map, const void *key) = (void *(*)(void *map, const void *key)) 1;Signed-off-by Peng Wei <[email protected]>Signed-off-by Stanislav Fomichev <[email protected]>--- scripts/bpf_doc.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)scripts/bpf_doc.py +6
-1@@ -827,6 +827,9 @@ COMMANDS print(' *{}{}'.format(' \t' if line else '', line)) print(' */') + fptr_type = '%s%s(*)(' % ( + self.map_type(proto['ret_type']), + ((' ' + proto['ret_star']) if proto['ret_star'] else '')) print('static %s %s(*%s)(' % (self.map_type(proto['ret_type']), proto['ret_star'], proto['name']), end='') comma = ''@@ -845,8 +848,10 @@ COMMANDS one_arg += '{}'.format(n) comma = ', ' print(one_arg, end='') + fptr_type += one_arg - print(') = (void *) %d;' % helper.enum_val) + fptr_type += ')' + print(') = (%s) %d;' % (fptr_type, helper.enum_val)) print('') ###############################################################################