Skip to contentSkip to conversation

makedumpfile: support -F option on xen

PATCH In review Akio Takebe 2 participants 2 messages Jan 29, 2008 – Jan 30, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 makedumpfile: support -F option on xen

Hi,

makdumpfile doesn't support -F option on xen.
The following patch support it.

Best Regards,

Akio Takebe

makedumpfile.c renamed from makedumpfile.c.orig +10 -0
@@ -5803,12 +5803,22 @@ handle_xen()
 	if (!create_dump_bitmap_xen())
 		goto out;
 
+	if (info->flag_flatten) {
+		if (!write_start_flat_header())
+			goto out;
+	}
+
 	if (!write_elf_header())
 		goto out;
 
 	if (!write_elf_pages())
 		goto out;
 
+	if (info->flag_flatten) {
+		if (!write_end_flat_header())
+			goto out;
+	}
+
 	if (!close_files_for_creating_dumpfile())
 		goto out;
 

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#1 lore raw

Hi Takebe-san,

Thank you for the patch.
I confirmed that your patch is right on x86_64 xen machine. I will merge your patch into the next release.

Thanks
Ken'ichi Ohmichi

Quoted 27 lines · Akio Takebe

Hi,

makdumpfile doesn't support -F option on xen.
The following patch support it.

Best Regards,

Akio Takebe

makedumpfile.c renamed from makedumpfile.c.orig +5 -0
@@ -5803,12 +5803,22 @@ handle_xen()
 	if (!create_dump_bitmap_xen())
 		goto out;
 
+	if (info->flag_flatten) {
+		if (!write_start_flat_header())
+			goto out;
+	}
+
 	if (!write_elf_header())
 		goto out;
 
 	if (!write_elf_pages())

makedumpfile.c handle_xen() · line 5824

Quoted 10 lines
makedumpfile.c renamed from makedumpfile.c.orig +5 -0
 		goto out;
 
+	if (info->flag_flatten) {
+		if (!write_end_flat_header())
+			goto out;
+	}
+
 	if (!close_files_for_creating_dumpfile())
 		goto out;
 

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec