Skip to contentSkip to conversation

media: qcom: venus: add callback parameter names

PATCH In review Hungyu Lin 3 participants 3 messages Jun 4 – Jun 8

Subsystems (4)
lore
Share & tools
lore

Hungyu Lin

author
#0 lore raw

PATCH 1/1 media: qcom: venus: add callback parameter names

Naming the callback parameters improves readability and resolves checkpatch warnings about unnamed function pointer arguments.

No functional change intended.

---
 drivers/media/platform/qcom/venus/hfi_msgs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/venus/hfi_msgs.c +1 -1
index 47b99d5b5af7..5c2025c5acc7 100644
@@ -690,7 +690,7 @@ struct hfi_done_handler {
 	u32 pkt;
 	u32 pkt_sz;
 	u32 pkt_sz2;
-	void (*done)(struct venus_core *, struct venus_inst *, void *);
+	void (*done)(struct venus_core *core, struct venus_inst *inst, void *packet);
 	bool is_sys_pkt;
 };
 
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Hungyu Lin

Naming the callback parameters improves readability and resolves checkpatch warnings about unnamed function pointer arguments.

No functional change intended.

---
 drivers/media/platform/qcom/venus/hfi_msgs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 2 lines
With best wishes
Dmitry
Reviewed-by on v1 1/1
#2 lore raw
In reply to Hungyu Lin
Quoted 15 lines · Hungyu Lin

Naming the callback parameters improves readability and resolves checkpatch warnings about unnamed function pointer arguments.

No functional change intended.

---
 drivers/media/platform/qcom/venus/hfi_msgs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/venus/hfi_msgs.c +0 -0
index 47b99d5b5af7..5c2025c5acc7 100644

drivers/media/platform/qcom/venus/hfi_msgs.c struct hfi_done_handler { · line 696

Quoted 8 lines
drivers/media/platform/qcom/venus/hfi_msgs.c +1 -1
@@ -690,7 +690,7 @@ struct hfi_done_handler {
 	u32 pkt;
 	u32 pkt_sz;
 	u32 pkt_sz2;
-	void (*done)(struct venus_core *, struct venus_inst *, void *);
+	void (*done)(struct venus_core *core, struct venus_inst *inst, void *packet);
 	bool is_sys_pkt;
 };