Skip to contentSkip to conversation

sim: cgen: add remainder functions (needed for OR1K lf.rem.[sd])

PATCH Superseded Doug Evans 1 participant 1 message Oct 9, 2017

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore

Doug Evans

author
#0 lore raw

PATCH v5 1/6 sim: cgen: add remainder functions (needed for OR1K lf.rem.[sd])

Quoted 7 lines · Stafford Horne
Quoted 4 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+    else if (n.class == sim_fpu_class_number
+	&& n.normal_exp <= (NR_FRAC_GUARD)) /* If not too large round.  */

This line should be aligned with the opening parenthesis (well, one char to the right).

Right, that does move the comment out of the 80 char range, but just the ending '*/'. I hope thats ok.

A common thing to do is put the comment on the preceding line.

E.g.,

    else if (n.class == sim_fpu_class_number
             /* If not too large round.  */
             && n.normal_exp <= (NR_FRAC_GUARD))

[appropriately tabbed of course]