Skip to contentSkip to conversation

KVM: VMX: replace "fall through" with "return true" to indicate different case

PATCH linmiaohe 1 participant 1 message Feb 19, 2020 KVM

lore
Share & tools
lore

linmiaohe

author
#0 lore raw
Quoted 11 lines · Sean Christopherson

Review static bool rmode_exception(struct kvm_vcpu *vcpu, int vec) · line 4498

Quoted 8 lines · linmiaohe

From: Miaohe Lin <[email protected]>

(quoted diff) +1 -1
@@ -4495,7 +4495,7 @@ static bool rmode_exception(struct kvm_vcpu *vcpu, int vec)
 		if (vcpu->guest_debug &
 			(KVM_GUESTDBG_SINGLESTEP | KVM_GUESTDBG_USE_HW_BP))
 			return false;
-		/* fall through */
+		return true;

I prefer the current code, i.e. the fall through. This code is already burdened with a fall through, from #BP->#DB, and IMO the fall through makes it more obvious that the vcpu->guest_debug checks are corner cases, while everything else is handled by common logic.

Yeh, it looks better this way. But from a different perspective, "return turn" here indicates #BP and #DB need do vcpu->guest_debug checks, while others not. Thanks. :)

Quoted 4 lines
Quoted 4 lines
(quoted diff) +0 -0
 	case DE_VECTOR:
 	case OF_VECTOR:
 	case BR_VECTOR: