wifi: rtw88: fix typo rtw8822cu_probe
Ping-Ke Shih
maintainerPATCH 1/1 wifi: rtw88: fix typo rtw8822cu_probe
From: Po-Hao Huang <[email protected]>
The probe function of 8822cu is misplaced to 8822bu, so we fix it.
--- drivers/net/wireless/realtek/rtw88/rtw8822cu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/realtek/rtw88/rtw8822cu.c +2 -2
@@ -25,7 +25,7 @@ static const struct usb_device_id rtw_8822cu_id_table[] = { };MODULE_DEVICE_TABLE (usb, rtw_8822cu_id_table); -static int rtw8822bu_probe (struct usb_interface *intf, +static int rtw8822cu_probe (struct usb_interface *intf,const struct usb_device_id *id) {return rtw_usb_probe (intf, id);
@@ -34,7 +34,7 @@ static int rtw8822bu_probe(struct usb_interface *intf,static struct usb_driver rtw_8822cu_driver = { .name ="rtw_8822cu" , .id_table = rtw_8822cu_id_table, - .probe = rtw8822bu_probe, + .probe = rtw8822cu_probe, .disconnect = rtw_usb_disconnect, };module_usb_driver (rtw_8822cu_driver);
Signature · 1 line
2.25.1
Quoted 7 lines · Ping-Ke Shih
From: Po-Hao Huang <[email protected]>
The probe function of 8822cu is misplaced to 8822bu, so we fix it.
Fixes 07cef03b8d44 ("wifi: rtw88: Add rtw8822cu chipset support")Signed-off-by Po-Hao Huang <[email protected]>Signed-off-by Ping-Ke Shih <[email protected]>
I guess this is just a cosmetic change and does not cause any changes in functionality? I can add that to the commit log.
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Ping-Ke Shih
maintainerQuoted 13 lines
-----Original Message-----
From: Kalle Valo <[email protected]>
Sent: Friday, August 25, 2023 2:47 PM
To: Ping-Ke Shih <[email protected]>
Cc: Bernie Huang <[email protected]>; [email protected]
Subject: Re: [PATCH] wifi: rtw88: fix typortw8822cu_probeQuoted 2 lines · Ping-Ke Shih
From: Po-Hao Huang <[email protected]>
Quoted 9 lines
Quoted 5 lines
The probe function of 8822cu is misplaced to 8822bu, so we fix it.
Fixes 07cef03b8d44 ("wifi: rtw88: Add rtw8822cu chipset support")Signed-off-by Po-Hao Huang <[email protected]>Signed-off-by Ping-Ke Shih <[email protected]>I guess this is just a cosmetic change and does not cause any changes in functionality? I can add that to the commit log.
Yes, it doesn't change anything. If Fixes tag is not suitable, please also remove it.
Thank you.
Ping-ke
Quoted 17 lines · Ping-Ke Shih
Quoted 17 lines
-----Original Message-----
From: Kalle Valo <[email protected]>
Sent: Friday, August 25, 2023 2:47 PM
To: Ping-Ke Shih <[email protected]>
Cc: Bernie Huang <[email protected]>; [email protected]
Subject: Re: [PATCH] wifi: rtw88: fix typortw8822cu_probeQuoted 7 lines · Ping-Ke Shih
From: Po-Hao Huang <[email protected]>
The probe function of 8822cu is misplaced to 8822bu, so we fix it.
Fixes 07cef03b8d44 ("wifi: rtw88: Add rtw8822cu chipset support")Signed-off-by Po-Hao Huang <[email protected]>Signed-off-by Ping-Ke Shih <[email protected]>
Quoted 5 lines
Quoted 2 lines
I guess this is just a cosmetic change and does not cause any changes in functionality? I can add that to the commit log.
Yes, it doesn't change anything. If Fixes tag is not suitable, please also remove it.
Good point, as this is not fixing any functionality in opinion there should not be a Fixes tag. I'll also remove that.
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 7 lines · Ping-Ke Shih
From: Po-Hao Huang <[email protected]>
The probe function of 8822cu is misplaced to 8822bu, so we fix it. Just cosmetics, no changes in functionality.
Signed-off-by Po-Hao Huang <[email protected]>Signed-off-by Ping-Ke Shih <[email protected]>
Patch applied to wireless-next.git, thanks.
497840a1fc5c wifi: rtw88: fix typo rtw8822cu_probe
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches