Skip to contentSkip to conversation

net/bnxt: supress warnings

PATCH In review Stephen Hemminger 5 participants 7 messages Mar 14, 2019 – Mar 15, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

cover net/bnxt: supress warnings

Silence messages that are not errors.

Stephen Hemminger (2):
net/bnxt: silence iova warnings
net/bnxt: suppress supprious error log

 drivers/net/bnxt/bnxt_ethdev.c | 6 ++----
 drivers/net/bnxt/bnxt_rxq.c    | 3 ++-
 2 files changed, 4 insertions(+), 5 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/2 net/bnxt: silence iova warnings

When using bnxt on bare-metal with vfio-pci, the driver logs an unnecessary warning. Hardware works fine, message is not urgent. Change it to INFO level.

Fixes 62196f4e0941 ("mem: rename address mapping function to IOVA")
---
 drivers/net/bnxt/bnxt_ethdev.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/net/bnxt/bnxt_ethdev.c +2 -4
index 189527207f9a..bdc6a1267a52 100644
@@ -3242,10 +3242,8 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)
 		memset(mz->addr, 0, mz->len);
 		mz_phys_addr = mz->iova;
 		if ((unsigned long)mz->addr == mz_phys_addr) {
-			PMD_DRV_LOG(WARNING,
-				"Memzone physical address same as virtual.\n");
-			PMD_DRV_LOG(WARNING,
-				"Using rte_mem_virt2iova()\n");
+			PMD_DRV_LOG(INFO,
+				"Memzone physical address same as virtual using rte_mem_virt2iova()\n");
 			mz_phys_addr = rte_mem_virt2iova(mz->addr);
 			if (mz_phys_addr == 0) {
 				PMD_DRV_LOG(ERR,
Signature · 1 line
2.17.1
#3 lore raw

Re: [PATCH 1/2] net/bnxt: silence iova warnings

Quoted 13 lines · Rami Rosen

Stephen Hemminger ‏<[email protected]>:

Quoted 8 lines

When using bnxt on bare-metal with vfio-pci, the driver logs an unnecessary warning. Hardware works fine, message is not urgent. Change it to INFO level.

Fixes 62196f4e0941 ("mem: rename address mapping function to IOVA")

---

#4 lore raw

PATCH 2/2 net/bnxt: suppress supprious error log

In reply to Stephen Hemminger

The driver multiple rxq allocation logs a message at error level but it really is a debug message.

Fixes 51fafb89a9a0 ("net/bnxt: get rid of ff pools and use VNIC info array")
---
 drivers/net/bnxt/bnxt_rxq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/bnxt/bnxt_rxq.c +2 -1
index 5345d3938311..17e2909a7e5c 100644
@@ -100,7 +100,8 @@ int bnxt_mq_rx_configure(struct bnxt *bp)
 		}
 	}
 	nb_q_per_grp = bp->rx_cp_nr_rings / pools;
-	PMD_DRV_LOG(ERR, "pools = %u nb_q_per_grp = %u\n", pools, nb_q_per_grp);
+	PMD_DRV_LOG(DEBUG, "pools = %u nb_q_per_grp = %u\n",
+		    pools, nb_q_per_grp);
 	start_grp_id = 0;
 	end_grp_id = nb_q_per_grp;
 
Signature · 1 line
2.17.1
Acked-by on v1 2/2
#5 lore raw

Re: [PATCH 2/2] net/bnxt: suppress supprious error log

Quoted 25 lines · Stephen Hemminger

The driver multiple rxq allocation logs a message at error level but it really is a debug message.

Fixes 51fafb89a9a0 ("net/bnxt: get rid of ff pools and use VNIC info array")
---
 drivers/net/bnxt/bnxt_rxq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/bnxt/bnxt_rxq.c +2 -2
index 5345d3938311..17e2909a7e5c 100644
@@ -100,7 +100,8 @@ int bnxt_mq_rx_configure(struct bnxt *bp)
                }
        }
        nb_q_per_grp = bp->rx_cp_nr_rings / pools;
-       PMD_DRV_LOG(ERR, "pools = %u nb_q_per_grp = %u\n", pools, nb_q_per_grp);
+       PMD_DRV_LOG(DEBUG, "pools = %u nb_q_per_grp = %u\n",
+                   pools, nb_q_per_grp);
        start_grp_id = 0;
        end_grp_id = nb_q_per_grp;
 
--
Quoted 2 lines

2.17.1

#6 lore raw
In reply to Stephen Hemminger
Quoted 5 lines · Stephen Hemminger

Silence messages that are not errors.

Stephen Hemminger (2):
net/bnxt: silence iova warnings
net/bnxt: suppress supprious error log

Series applied to dpdk-next-net/master, thanks.