Skip to contentSkip to conversation

dsa: lan9303: Correct stat name

PATCH Applied Jerry Ray 3 participants 3 messages Nov 28, 2022 – Nov 29, 2022

Subsystems (3)
lore
Share & tools
lore

Jerry Ray

author
#0 lore raw

PATCH 1/1 dsa: lan9303: Correct stat name

Fixes a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303")

This patch changes the reported ethtool statistics for the lan9303 family of parts covered by this driver.

The TxUnderRun statistic label is renamed to RxShort to accurately reflect what stat the device is reporting. I did not reorder the statistics as that might cause problems with existing user code that are expecting the stats at a certain offset.

---
 drivers/net/dsa/lan9303-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/dsa/lan9303-core.c +1 -1
index 438e46af03e9..80f07bd20593 100644
@@ -961,7 +961,7 @@ static const struct lan9303_mib_desc lan9303_mib[] = {
 	{ .offset = LAN9303_MAC_TX_BRDCST_CNT_0, .name = "TxBroad", },
 	{ .offset = LAN9303_MAC_TX_PAUSE_CNT_0, .name = "TxPause", },
 	{ .offset = LAN9303_MAC_TX_MULCST_CNT_0, .name = "TxMulti", },
-	{ .offset = LAN9303_MAC_RX_UNDSZE_CNT_0, .name = "TxUnderRun", },
+	{ .offset = LAN9303_MAC_RX_UNDSZE_CNT_0, .name = "RxShort", },
 	{ .offset = LAN9303_MAC_TX_64_CNT_0, .name = "Tx64Byte", },
 	{ .offset = LAN9303_MAC_TX_127_CNT_0, .name = "Tx128Byte", },
 	{ .offset = LAN9303_MAC_TX_255_CNT_0, .name = "Tx256Byte", },
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Jerry Ray
Fixes a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303")

The Fixes: tag is supposed to come above your Signed-off-by, I don't know if the maintainers will fix that up manually or not, but in any case:

Quoted 27 lines

This patch changes the reported ethtool statistics for the lan9303 family of parts covered by this driver.

The TxUnderRun statistic label is renamed to RxShort to accurately reflect what stat the device is reporting. I did not reorder the statistics as that might cause problems with existing user code that are expecting the stats at a certain offset.

---
  drivers/net/dsa/lan9303-core.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/dsa/lan9303-core.c +1 -1
index 438e46af03e9..80f07bd20593 100644
@@ -961,7 +961,7 @@ static const struct lan9303_mib_desc lan9303_mib[] = {
  	{ .offset = LAN9303_MAC_TX_BRDCST_CNT_0, .name = "TxBroad", },
  	{ .offset = LAN9303_MAC_TX_PAUSE_CNT_0, .name = "TxPause", },
  	{ .offset = LAN9303_MAC_TX_MULCST_CNT_0, .name = "TxMulti", },
-	{ .offset = LAN9303_MAC_RX_UNDSZE_CNT_0, .name = "TxUnderRun", },
+	{ .offset = LAN9303_MAC_RX_UNDSZE_CNT_0, .name = "RxShort", },
  	{ .offset = LAN9303_MAC_TX_64_CNT_0, .name = "Tx64Byte", },
  	{ .offset = LAN9303_MAC_TX_127_CNT_0, .name = "Tx128Byte", },
  	{ .offset = LAN9303_MAC_TX_255_CNT_0, .name = "Tx256Byte", },
Signature · 1 line
Florian
#2 lore raw
In reply to Jerry Ray
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 11 lines · On Mon, 28 Nov 2022 13:35:59 -0600 you wrote:
Fixes a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303")

This patch changes the reported ethtool statistics for the lan9303 family of parts covered by this driver.

The TxUnderRun statistic label is renamed to RxShort to accurately reflect what stat the device is reporting. I did not reorder the statistics as that might cause problems with existing user code that are expecting the stats at a certain offset.

[...]

Here is the summary with links:
- [net] dsa: lan9303: Correct stat name

    https://git.kernel.org/netdev/net/c/39f59bca275d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html